[jira] [Commented] (PARQUET-1688) [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7

2019-11-08 Thread Francois Saint-Jacques (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970398#comment-16970398
 ] 

Francois Saint-Jacques commented on PARQUET-1688:
-

Which begs the question, can ARROW committer merge such issues?

> [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7
> -
>
> Key: PARQUET-1688
> URL: https://issues.apache.org/jira/browse/PARQUET-1688
> Project: Parquet
>  Issue Type: Improvement
>  Components: parquet-cpp
>Reporter: Kouhei Sutou
>Assignee: Gawain BOLTON
>Priority: Major
>  Labels: pull-request-available
> Fix For: cpp-1.6.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> cc [~gawain_bolton]
> This is caused since PARQUET-1678 is merged.
> It seems that g++ 4.8.5 on CentOS 7 doesn't have the default implementation 
> of {{operator=() noexcept}}:
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=2562=logs=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b=5469=5484=1=1
> {noformat}
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:31:0,
>  from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:61:17:
>  error: function 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)'
>StreamReader& operator=(StreamReader&&) noexcept = default;
>  ^
> make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/stream_reader.cc.o] 
> Error 1
> make[2]: *** Waiting for unfinished jobs
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PARQUET-1688) [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7

2019-11-08 Thread Francois Saint-Jacques (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970138#comment-16970138
 ] 

Francois Saint-Jacques commented on PARQUET-1688:
-

[~wesm] can you assign to Gawain and resolve the issue? I don't have the JIRA 
privileges.

> [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7
> -
>
> Key: PARQUET-1688
> URL: https://issues.apache.org/jira/browse/PARQUET-1688
> Project: Parquet
>  Issue Type: Improvement
>  Components: parquet-cpp
>Reporter: Kouhei Sutou
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> cc [~gawain_bolton]
> This is caused since PARQUET-1678 is merged.
> It seems that g++ 4.8.5 on CentOS 7 doesn't have the default implementation 
> of {{operator=() noexcept}}:
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=2562=logs=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b=5469=5484=1=1
> {noformat}
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:31:0,
>  from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:61:17:
>  error: function 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)'
>StreamReader& operator=(StreamReader&&) noexcept = default;
>  ^
> make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/stream_reader.cc.o] 
> Error 1
> make[2]: *** Waiting for unfinished jobs
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PARQUET-1688) [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7

2019-11-07 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969737#comment-16969737
 ] 

Wes McKinney commented on PARQUET-1688:
---

in PARQUET. I'll close ARROW-7088

> [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7
> -
>
> Key: PARQUET-1688
> URL: https://issues.apache.org/jira/browse/PARQUET-1688
> Project: Parquet
>  Issue Type: Improvement
>  Components: parquet-cpp
>Reporter: Kouhei Sutou
>Priority: Major
>
> cc [~gawain_bolton]
> This is caused since PARQUET-1678 is merged.
> It seems that g++ 4.8.5 on CentOS 7 doesn't have the default implementation 
> of {{operator=() noexcept}}:
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=2562=logs=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b=5469=5484=1=1
> {noformat}
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:31:0,
>  from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:61:17:
>  error: function 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)'
>StreamReader& operator=(StreamReader&&) noexcept = default;
>  ^
> make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/stream_reader.cc.o] 
> Error 1
> make[2]: *** Waiting for unfinished jobs
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PARQUET-1688) [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7

2019-11-07 Thread Wes McKinney (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969731#comment-16969731
 ] 

Wes McKinney commented on PARQUET-1688:
---

I think this duplicates ARROW-7088

> [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7
> -
>
> Key: PARQUET-1688
> URL: https://issues.apache.org/jira/browse/PARQUET-1688
> Project: Parquet
>  Issue Type: Improvement
>  Components: parquet-cpp
>Reporter: Kouhei Sutou
>Priority: Major
>
> cc [~gawain_bolton]
> This is caused since PARQUET-1678 is merged.
> It seems that g++ 4.8.5 on CentOS 7 doesn't have the default implementation 
> of {{operator=() noexcept}}:
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=2562=logs=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b=5469=5484=1=1
> {noformat}
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:31:0,
>  from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:61:17:
>  error: function 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)'
>StreamReader& operator=(StreamReader&&) noexcept = default;
>  ^
> make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/stream_reader.cc.o] 
> Error 1
> make[2]: *** Waiting for unfinished jobs
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (PARQUET-1688) [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7

2019-11-07 Thread Kouhei Sutou (Jira)


[ 
https://issues.apache.org/jira/browse/PARQUET-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969734#comment-16969734
 ] 

Kouhei Sutou commented on PARQUET-1688:
---

Oh, sorry. I missed it.

Should we track this in ARROW- or PARQUET-?

> [C++] StreamWriter/StreamReader can't be built with g++ 4.8.5 on CentOS 7
> -
>
> Key: PARQUET-1688
> URL: https://issues.apache.org/jira/browse/PARQUET-1688
> Project: Parquet
>  Issue Type: Improvement
>  Components: parquet-cpp
>Reporter: Kouhei Sutou
>Priority: Major
>
> cc [~gawain_bolton]
> This is caused since PARQUET-1678 is merged.
> It seems that g++ 4.8.5 on CentOS 7 doesn't have the default implementation 
> of {{operator=() noexcept}}:
> https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=2562=logs=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb=5b4cc83a-7bb0-5664-5bb1-588f7e4dc05b=5469=5484=1=1
> {noformat}
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:31:0,
>  from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_reader.h:61:17:
>  error: function 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamReader& 
> parquet::StreamReader::operator=(parquet::StreamReader&&)'
>StreamReader& operator=(StreamReader&&) noexcept = default;
>  ^
> make[2]: *** [src/parquet/CMakeFiles/parquet_objlib.dir/stream_reader.cc.o] 
> Error 1
> make[2]: *** Waiting for unfinished jobs
> In file included from 
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.cc:18:0:
> /root/rpmbuild/BUILD/apache-arrow-0.15.0.dev227/cpp/src/parquet/stream_writer.h:67:17:
>  error: function 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)' defaulted on its 
> first declaration with an exception-specification that differs from the 
> implicit declaration 'parquet::StreamWriter& 
> parquet::StreamWriter::operator=(parquet::StreamWriter&&)'
>StreamWriter& operator=(StreamWriter&&) noexcept = default;
>  ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)