Jenkins build is back to normal : PDFBox-Trunk-jdk11 #114

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-4341) [Patch] PNGConverter: PNG bytes to PDImageXObject converter

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4341:

Attachment: (was: 010054.png)

> [Patch] PNGConverter: PNG bytes to PDImageXObject converter
> ---
>
> Key: PDFBOX-4341
> URL: https://issues.apache.org/jira/browse/PDFBOX-4341
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Writing
>Affects Versions: 2.0.12
>Reporter: Emmeran Seehuber
>Priority: Minor
> Attachments: 001229.png, 001230.png, 008528.png, 014431.png, 
> 016289.png, 017012.png, 017030.png, 017063.png, 017084.png, 
> pngconvert_testimg.zip, pngconvert_v1.patch, pngconvert_v2.patch
>
>
> The attached patch implements a PNG bytes to PDImageXObject converter. It 
> tries to create a PDImageXObject from the chunks of a PNG image, without 
> recompressing it. This allows to use programs like pngcrush and friends to 
> embedded optimal compressed images. It’s also way faster than recompressing 
> the image.
> The class PNGConverter does this in three steps:
>  - Parsing the PNG chunk structure from the byte array
>  - Validating all relevant data chunks (i.e. checking the CRC). Chunks which 
> are not needed (e.g. text chunks) are not validated.
>  - Constructing a PDImageXObject from the chunks
> When at any of this steps an error occurs or the converter detects that it is 
> not possible to map the image, it will bail out and return null. In this case 
> the image has to be embedded the „normal“ way by reading it using ImageIO and 
> compressing it again.
> Only this PNG image types can be converted (at least theoretically) without 
> recompressing the image data:
>  - Grayscale
>  - Truecolor (i.e. RGB 8-Bit/16-Bit)
>  - Indexed
> As soon as transparency is used it gets difficult:
>  - Grayscale with alpha / truecolor with alpha: The alpha channel is saved in 
> the image data stream, as they are stored as (Gray,Alpha) or 
> (Red,Green,Blue,Alpha) tuples. You have to separate the alpha information for 
> the SMASK-Image. At this moment you can just read and recompress it using the 
> LosslessFactory.
>  - Indexed with alpha. Alpha and color tables are separate in the PNG, so 
> this should be possible to build a grayscale SMASK from the image data (which 
> are just the table indices) and the alpha table. Tried that, but Acrobat 
> Reader does not like indexed SMASKs… One could just build a grayscale SMASK 
> using the alpha table and the decompressed image index data. This would at 
> least save some space, as the optimized indexed image data is still used.
> With the current patch only truecolor without alpha images work correctly. 
> The other tests for grayscale and indexed fail. (You must place the zipped 
> images in the resources folder were png.png resides to run the testdrivers; 
> This images are „original“ work done by me using Gimp, Krita and ImageOptim 
> (on macOS) to build the different png image types.)
> Notes for the current patch:
>  - The grayscale images have the wrong gamma curve. I tried using the 
> ColorSpace.CS_GRAY ICC profile and the image seems now only „slightly“ off 
> (i.e. pixel value FFD6D6D6 vs FFD7D7D7). As soon as a gAMA chunk is given the 
> image is tagged with a CalGray profile, but the colors are way more off then.
>  - The cHRM (chroma) chunk is read and *should* work, as I used the formula’s 
> from the PDF spec to convert the cRHM values to the CalRGB whitepoint and 
> matrix. I have not yet tested this, as I have no test image with cHRM at the 
> moment. Note: Matrix(COSArray) and Matrix.toCOSArray() are fine for geometric 
> matrices. But this methods are wrong for any other kind of matrix (i.e. color 
> transform matrices), as they only store/restore 6 values of the 3x3 matrix. I 
> deprecated PDCalRGB.setMatrix(Matrix) because of this, as this was never 
> working and can not work as long as the Matrix class is for geometric use 
> cases only. This should also be documented on the Matrix class, that it is 
> not general purpose. I added a PDCalRGB.setMatrix(COSArray) method to allow 
> to set the matrix.
>  - The indexed image displays fine in Acrobat Reader, but the test driver 
> fails as PDImageXObject.getImage() returns a complete black (everything 0) 
> image. Strange, I suspect some error in the PDFBox image decoding.
>  - If an image is tagged with sRGB, the builtin Java sRGB ICC profile is 
> attached. Theoretically you can use a CalRGB colorspace, but using a ICC 
> color profile is likely faster (at least in PDFBox) and more „standard“.
> You can also look at this patch on GitHub 
> [https://github.com/apache/pdfbox/compare/2.0...rototor:2.0-png-from-bytes-encoder?expand=1]
>  if you like.
> It would be nice if someone could give me some hints with the colorspace 
> probl

[jira] [Commented] (PDFBOX-4341) [Patch] PNGConverter: PNG bytes to PDImageXObject converter

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663154#comment-16663154
 ] 

Tilman Hausherr commented on PDFBOX-4341:
-

I let it run overnight... in almost all cases the size was larger with the new 
converter. But there are not many files.

I did not go very far (file 017). The weird problem is that I always get 
"java.io.EOFException: Unexpected end of ZLIB input stream" when downloading 
the files, for almost each file after a long time. This wasn't that way years 
ago when I downloaded all files and kept only the pdf files.

> [Patch] PNGConverter: PNG bytes to PDImageXObject converter
> ---
>
> Key: PDFBOX-4341
> URL: https://issues.apache.org/jira/browse/PDFBOX-4341
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Writing
>Affects Versions: 2.0.12
>Reporter: Emmeran Seehuber
>Priority: Minor
> Attachments: 001229.png, 001230.png, 008528.png, 010054.png, 
> 014431.png, 016289.png, 017012.png, 017030.png, 017063.png, 017084.png, 
> pngconvert_testimg.zip, pngconvert_v1.patch, pngconvert_v2.patch
>
>
> The attached patch implements a PNG bytes to PDImageXObject converter. It 
> tries to create a PDImageXObject from the chunks of a PNG image, without 
> recompressing it. This allows to use programs like pngcrush and friends to 
> embedded optimal compressed images. It’s also way faster than recompressing 
> the image.
> The class PNGConverter does this in three steps:
>  - Parsing the PNG chunk structure from the byte array
>  - Validating all relevant data chunks (i.e. checking the CRC). Chunks which 
> are not needed (e.g. text chunks) are not validated.
>  - Constructing a PDImageXObject from the chunks
> When at any of this steps an error occurs or the converter detects that it is 
> not possible to map the image, it will bail out and return null. In this case 
> the image has to be embedded the „normal“ way by reading it using ImageIO and 
> compressing it again.
> Only this PNG image types can be converted (at least theoretically) without 
> recompressing the image data:
>  - Grayscale
>  - Truecolor (i.e. RGB 8-Bit/16-Bit)
>  - Indexed
> As soon as transparency is used it gets difficult:
>  - Grayscale with alpha / truecolor with alpha: The alpha channel is saved in 
> the image data stream, as they are stored as (Gray,Alpha) or 
> (Red,Green,Blue,Alpha) tuples. You have to separate the alpha information for 
> the SMASK-Image. At this moment you can just read and recompress it using the 
> LosslessFactory.
>  - Indexed with alpha. Alpha and color tables are separate in the PNG, so 
> this should be possible to build a grayscale SMASK from the image data (which 
> are just the table indices) and the alpha table. Tried that, but Acrobat 
> Reader does not like indexed SMASKs… One could just build a grayscale SMASK 
> using the alpha table and the decompressed image index data. This would at 
> least save some space, as the optimized indexed image data is still used.
> With the current patch only truecolor without alpha images work correctly. 
> The other tests for grayscale and indexed fail. (You must place the zipped 
> images in the resources folder were png.png resides to run the testdrivers; 
> This images are „original“ work done by me using Gimp, Krita and ImageOptim 
> (on macOS) to build the different png image types.)
> Notes for the current patch:
>  - The grayscale images have the wrong gamma curve. I tried using the 
> ColorSpace.CS_GRAY ICC profile and the image seems now only „slightly“ off 
> (i.e. pixel value FFD6D6D6 vs FFD7D7D7). As soon as a gAMA chunk is given the 
> image is tagged with a CalGray profile, but the colors are way more off then.
>  - The cHRM (chroma) chunk is read and *should* work, as I used the formula’s 
> from the PDF spec to convert the cRHM values to the CalRGB whitepoint and 
> matrix. I have not yet tested this, as I have no test image with cHRM at the 
> moment. Note: Matrix(COSArray) and Matrix.toCOSArray() are fine for geometric 
> matrices. But this methods are wrong for any other kind of matrix (i.e. color 
> transform matrices), as they only store/restore 6 values of the 3x3 matrix. I 
> deprecated PDCalRGB.setMatrix(Matrix) because of this, as this was never 
> working and can not work as long as the Matrix class is for geometric use 
> cases only. This should also be documented on the Matrix class, that it is 
> not general purpose. I added a PDCalRGB.setMatrix(COSArray) method to allow 
> to set the matrix.
>  - The indexed image displays fine in Acrobat Reader, but the test driver 
> fails as PDImageXObject.getImage() returns a complete black (everything 0) 
> image. Strange, I suspect some error in the PDFBox image decoding.
>  - If an image is 

[jira] [Updated] (PDFBOX-4341) [Patch] PNGConverter: PNG bytes to PDImageXObject converter

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4341:

Attachment: 017063.png
017030.png
017012.png
016289.png
014431.png
010054.png
008528.png
017084.png

> [Patch] PNGConverter: PNG bytes to PDImageXObject converter
> ---
>
> Key: PDFBOX-4341
> URL: https://issues.apache.org/jira/browse/PDFBOX-4341
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Writing
>Affects Versions: 2.0.12
>Reporter: Emmeran Seehuber
>Priority: Minor
> Attachments: 001229.png, 001230.png, 008528.png, 010054.png, 
> 014431.png, 016289.png, 017012.png, 017030.png, 017063.png, 017084.png, 
> pngconvert_testimg.zip, pngconvert_v1.patch, pngconvert_v2.patch
>
>
> The attached patch implements a PNG bytes to PDImageXObject converter. It 
> tries to create a PDImageXObject from the chunks of a PNG image, without 
> recompressing it. This allows to use programs like pngcrush and friends to 
> embedded optimal compressed images. It’s also way faster than recompressing 
> the image.
> The class PNGConverter does this in three steps:
>  - Parsing the PNG chunk structure from the byte array
>  - Validating all relevant data chunks (i.e. checking the CRC). Chunks which 
> are not needed (e.g. text chunks) are not validated.
>  - Constructing a PDImageXObject from the chunks
> When at any of this steps an error occurs or the converter detects that it is 
> not possible to map the image, it will bail out and return null. In this case 
> the image has to be embedded the „normal“ way by reading it using ImageIO and 
> compressing it again.
> Only this PNG image types can be converted (at least theoretically) without 
> recompressing the image data:
>  - Grayscale
>  - Truecolor (i.e. RGB 8-Bit/16-Bit)
>  - Indexed
> As soon as transparency is used it gets difficult:
>  - Grayscale with alpha / truecolor with alpha: The alpha channel is saved in 
> the image data stream, as they are stored as (Gray,Alpha) or 
> (Red,Green,Blue,Alpha) tuples. You have to separate the alpha information for 
> the SMASK-Image. At this moment you can just read and recompress it using the 
> LosslessFactory.
>  - Indexed with alpha. Alpha and color tables are separate in the PNG, so 
> this should be possible to build a grayscale SMASK from the image data (which 
> are just the table indices) and the alpha table. Tried that, but Acrobat 
> Reader does not like indexed SMASKs… One could just build a grayscale SMASK 
> using the alpha table and the decompressed image index data. This would at 
> least save some space, as the optimized indexed image data is still used.
> With the current patch only truecolor without alpha images work correctly. 
> The other tests for grayscale and indexed fail. (You must place the zipped 
> images in the resources folder were png.png resides to run the testdrivers; 
> This images are „original“ work done by me using Gimp, Krita and ImageOptim 
> (on macOS) to build the different png image types.)
> Notes for the current patch:
>  - The grayscale images have the wrong gamma curve. I tried using the 
> ColorSpace.CS_GRAY ICC profile and the image seems now only „slightly“ off 
> (i.e. pixel value FFD6D6D6 vs FFD7D7D7). As soon as a gAMA chunk is given the 
> image is tagged with a CalGray profile, but the colors are way more off then.
>  - The cHRM (chroma) chunk is read and *should* work, as I used the formula’s 
> from the PDF spec to convert the cRHM values to the CalRGB whitepoint and 
> matrix. I have not yet tested this, as I have no test image with cHRM at the 
> moment. Note: Matrix(COSArray) and Matrix.toCOSArray() are fine for geometric 
> matrices. But this methods are wrong for any other kind of matrix (i.e. color 
> transform matrices), as they only store/restore 6 values of the 3x3 matrix. I 
> deprecated PDCalRGB.setMatrix(Matrix) because of this, as this was never 
> working and can not work as long as the Matrix class is for geometric use 
> cases only. This should also be documented on the Matrix class, that it is 
> not general purpose. I added a PDCalRGB.setMatrix(COSArray) method to allow 
> to set the matrix.
>  - The indexed image displays fine in Acrobat Reader, but the test driver 
> fails as PDImageXObject.getImage() returns a complete black (everything 0) 
> image. Strange, I suspect some error in the PDFBox image decoding.
>  - If an image is tagged with sRGB, the builtin Java sRGB ICC profile is 
> attached. Theoretically you can use a CalRGB colorspace, but using a ICC 
> color profile is likely faster (at least in PDFBox) and more „standard“.
> You can also look at this patch on GitHub 
> [h

Build failed in Jenkins: PDFBox-Trunk-jdk11 #113

[Apache Jenkins Server]

See 

--
[...truncated 6.26 KB...]
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:937)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:864)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at 
hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused: hudson.remoting.ProxyException: java.io.IOException
at 
hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:216)
at 
hudson.scm.subversion.WorkspaceUpdater$UpdateTask.delegateTo(WorkspaceUpdater.java:168)
at 
hudson.scm.SubversionSCM$CheckOutTask.perform(SubversionSCM.java:1041)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:1017)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:990)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2918)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@52ea58e3:ubuntu-eu2
at hudson.FilePath.act(FilePath.java:1043)
at hudson.FilePath.act(FilePath.java:1025)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:937)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:864)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
Cleaning up 
ERROR: Failed to update http://svn.apache.org/repos/asf/pdfbox/trunk
org.tmatesoft.svn.core.SVNException: svn: E155032: The pristine text with 
checksum '$sha1$0d8a658d1ecd3fa00dd8f46d24a9d2fdef18f3e4' was found in the DB 
but not on disk
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:70)
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:57)
at 
org.tmatesoft.svn.core.internal.wc17.db.SvnWcDbPristines.checkPristine(SvnWcDbPristines.java:159)
at 
org.tmatesoft.svn.core.internal.wc17.db.SvnWcDbPristines.getPristinePath(SvnWcDbPristines.java:184)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb.getPristinePath(SVNWCDb.java:1724)
at 
org.tmatesoft.svn.core.internal.wc17.SVNWCContext.isTextModified(SVNWCContext.java:754)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.assembleStatus(SVNStatusEditor17.java:356)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.sendStatusStructure(SVNStatusEditor17.java:216)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.getDirStatus(SVNStatusEditor17.java:742)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.walkStatus(SVNStatusEditor17.java:665)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgGetStatus.run(SvnNgGetStatus.java:132)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgGetStatus.run(SvnNgGetStatus.java:27)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgOperationRunner.run(SvnNgOperationRunner.java:20)
at 
org.tmatesoft.svn.core.internal.wc2.SvnOperati

Build failed in Jenkins: PDFBox-Trunk-jdk11 #112

[Apache Jenkins Server]

See 

--
[...truncated 8.34 KB...]
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:937)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:864)
at hudson.scm.SCM.checkout(SCM.java:504)
at 
hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at 
jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at 
hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at 
hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Caused: java.io.IOException
at 
hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:216)
at 
hudson.scm.subversion.WorkspaceUpdater$UpdateTask.delegateTo(WorkspaceUpdater.java:168)
at 
hudson.scm.SubversionSCM$CheckOutTask.perform(SubversionSCM.java:1041)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:1017)
at hudson.scm.SubversionSCM$CheckOutTask.invoke(SubversionSCM.java:990)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2918)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:748)
Caused: java.io.IOException: remote file operation failed: 
 at 
hudson.remoting.Channel@52ea58e3:ubuntu-eu2
at hudson.FilePath.act(FilePath.java:1043)
at hudson.FilePath.act(FilePath.java:1025)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:937)
at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:864)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1794)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:543)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
Retrying after 10 seconds
Cleaning up 
ERROR: Failed to update http://svn.apache.org/repos/asf/pdfbox/trunk
org.tmatesoft.svn.core.SVNException: svn: E155032: The pristine text with 
checksum '$sha1$0d8a658d1ecd3fa00dd8f46d24a9d2fdef18f3e4' was found in the DB 
but not on disk
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:70)
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:57)
at 
org.tmatesoft.svn.core.internal.wc17.db.SvnWcDbPristines.checkPristine(SvnWcDbPristines.java:159)
at 
org.tmatesoft.svn.core.internal.wc17.db.SvnWcDbPristines.getPristinePath(SvnWcDbPristines.java:184)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb.getPristinePath(SVNWCDb.java:1724)
at 
org.tmatesoft.svn.core.internal.wc17.SVNWCContext.isTextModified(SVNWCContext.java:754)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.assembleStatus(SVNStatusEditor17.java:356)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.sendStatusStructure(SVNStatusEditor17.java:216)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.getDirStatus(SVNStatusEditor17.java:742)
at 
org.tmatesoft.svn.core.internal.wc17.SVNStatusEditor17.walkStatus(SVNStatusEditor17.java:665)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgGetStatus.run(SvnNgGetStatus.java:132)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgGetStatus.run(SvnNgGetStatus.java:27)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgOperationRunner.run(SvnNgOperationRunner.java:20)
at 
org.tmatesoft.svn.core.internal.wc2.SvnOperationRunner.run(SvnOperationRunner.

[jira] [Updated] (PDFBOX-4359) Bad sizing of signature field inside rotated page

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4359:

Description: 
>From Patrick Herber in the user mailing list:
{quote}I have some problems with the sizing of a signature field inside a 
rotated document page (90
 degrees).
 If instead of specifying the zoom factor (as in the CreateVisibleSignature 
example) I specify
 the desired height and width of the signature, the resulting image has 
completely wrong dimensions:
{code:java}
visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
{code}
If the page is not rotated or if I remove the call to adjustForRotation() then 
the image is
 correctly displayed (in case of rotated document of course rotated but with 
the correct proportions).
{quote}
The problem is that {{adjustForRotation()}} is hard-coded for 200 x 100 size 
(zoomed at 50%).

  was:
>From Patrick Herber in the user mailing list:
{quote}
I have some problems with the sizing of a signature field inside a rotated 
document page (90
degrees).
If instead of specifying the zoom factor (as in the CreateVisibleSignature 
example) I specify
the desired height and width of the signature, the resulting image has 
completely wrong dimensions:
{code}
visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
{code}

If the page is not rotated or if I remove the call to adjustForRotation() then 
the image is
correctly displayed (in case of rotated document of course rotated but with the 
correct proportions).
{quote}
The problem is that \{{adjustForRotation()}} is hard-coded for 200 x 100 size.


> Bad sizing of signature field inside rotated page
> -
>
> Key: PDFBOX-4359
> URL: https://issues.apache.org/jira/browse/PDFBOX-4359
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.12
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.13, 3.0.0 PDFBox
>
>
> From Patrick Herber in the user mailing list:
> {quote}I have some problems with the sizing of a signature field inside a 
> rotated document page (90
>  degrees).
>  If instead of specifying the zoom factor (as in the CreateVisibleSignature 
> example) I specify
>  the desired height and width of the signature, the resulting image has 
> completely wrong dimensions:
> {code:java}
> visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
> {code}
> If the page is not rotated or if I remove the call to adjustForRotation() 
> then the image is
>  correctly displayed (in case of rotated document of course rotated but with 
> the correct proportions).
> {quote}
> The problem is that {{adjustForRotation()}} is hard-coded for 200 x 100 size 
> (zoomed at 50%).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Resolved] (PDFBOX-4359) Bad sizing of signature field inside rotated page

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr resolved PDFBOX-4359.
-
Resolution: Fixed

> Bad sizing of signature field inside rotated page
> -
>
> Key: PDFBOX-4359
> URL: https://issues.apache.org/jira/browse/PDFBOX-4359
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.12
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.13, 3.0.0 PDFBox
>
>
> From Patrick Herber in the user mailing list:
> {quote}
> I have some problems with the sizing of a signature field inside a rotated 
> document page (90
> degrees).
> If instead of specifying the zoom factor (as in the CreateVisibleSignature 
> example) I specify
> the desired height and width of the signature, the resulting image has 
> completely wrong dimensions:
> {code}
> visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
> {code}
> If the page is not rotated or if I remove the call to adjustForRotation() 
> then the image is
> correctly displayed (in case of rotated document of course rotated but with 
> the correct proportions).
> {quote}
> The problem is that \{{adjustForRotation()}} is hard-coded for 200 x 100 size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4359) Bad sizing of signature field inside rotated page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662732#comment-16662732
 ] 

ASF subversion and git services commented on PDFBOX-4359:
-

Commit 1844787 from til...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1844787 ]

PDFBOX-4359: don't use hard coded dimensions but use image dimensions for 
affine transform

> Bad sizing of signature field inside rotated page
> -
>
> Key: PDFBOX-4359
> URL: https://issues.apache.org/jira/browse/PDFBOX-4359
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.12
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.13, 3.0.0 PDFBox
>
>
> From Patrick Herber in the user mailing list:
> {quote}
> I have some problems with the sizing of a signature field inside a rotated 
> document page (90
> degrees).
> If instead of specifying the zoom factor (as in the CreateVisibleSignature 
> example) I specify
> the desired height and width of the signature, the resulting image has 
> completely wrong dimensions:
> {code}
> visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
> {code}
> If the page is not rotated or if I remove the call to adjustForRotation() 
> then the image is
> correctly displayed (in case of rotated document of course rotated but with 
> the correct proportions).
> {quote}
> The problem is that \{{adjustForRotation()}} is hard-coded for 200 x 100 size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4359) Bad sizing of signature field inside rotated page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662731#comment-16662731
 ] 

ASF subversion and git services commented on PDFBOX-4359:
-

Commit 1844786 from til...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1844786 ]

PDFBOX-4359: don't use hard coded dimensions but use image dimensions for 
affine transform

> Bad sizing of signature field inside rotated page
> -
>
> Key: PDFBOX-4359
> URL: https://issues.apache.org/jira/browse/PDFBOX-4359
> Project: PDFBox
>  Issue Type: Bug
>  Components: Signing
>Affects Versions: 2.0.12
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.13, 3.0.0 PDFBox
>
>
> From Patrick Herber in the user mailing list:
> {quote}
> I have some problems with the sizing of a signature field inside a rotated 
> document page (90
> degrees).
> If instead of specifying the zoom factor (as in the CreateVisibleSignature 
> example) I specify
> the desired height and width of the signature, the resulting image has 
> completely wrong dimensions:
> {code}
> visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
> {code}
> If the page is not rotated or if I remove the call to adjustForRotation() 
> then the image is
> correctly displayed (in case of rotated document of course rotated but with 
> the correct proportions).
> {quote}
> The problem is that \{{adjustForRotation()}} is hard-coded for 200 x 100 size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Created] (PDFBOX-4359) Bad sizing of signature field inside rotated page

[Tilman Hausherr (JIRA)]

Tilman Hausherr created PDFBOX-4359:
---

 Summary: Bad sizing of signature field inside rotated page
 Key: PDFBOX-4359
 URL: https://issues.apache.org/jira/browse/PDFBOX-4359
 Project: PDFBox
  Issue Type: Bug
  Components: Signing
Affects Versions: 2.0.12
Reporter: Tilman Hausherr
Assignee: Tilman Hausherr
 Fix For: 2.0.13, 3.0.0 PDFBox


>From Patrick Herber in the user mailing list:
{quote}
I have some problems with the sizing of a signature field inside a rotated 
document page (90
degrees).
If instead of specifying the zoom factor (as in the CreateVisibleSignature 
example) I specify
the desired height and width of the signature, the resulting image has 
completely wrong dimensions:
{code}
visibleSignDesigner.xAxis(x).yAxis(y).height(height).width(width).adjustForRotation();
{code}

If the page is not rotated or if I remove the call to adjustForRotation() then 
the image is
correctly displayed (in case of rotated document of course rotated but with the 
correct proportions).
{quote}
The problem is that \{{adjustForRotation()}} is hard-coded for 200 x 100 size.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-4341) [Patch] PNGConverter: PNG bytes to PDImageXObject converter

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4341:

Attachment: 001230.png
001229.png

> [Patch] PNGConverter: PNG bytes to PDImageXObject converter
> ---
>
> Key: PDFBOX-4341
> URL: https://issues.apache.org/jira/browse/PDFBOX-4341
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Writing
>Affects Versions: 2.0.12
>Reporter: Emmeran Seehuber
>Priority: Minor
> Attachments: 001229.png, 001230.png, pngconvert_testimg.zip, 
> pngconvert_v1.patch, pngconvert_v2.patch
>
>
> The attached patch implements a PNG bytes to PDImageXObject converter. It 
> tries to create a PDImageXObject from the chunks of a PNG image, without 
> recompressing it. This allows to use programs like pngcrush and friends to 
> embedded optimal compressed images. It’s also way faster than recompressing 
> the image.
> The class PNGConverter does this in three steps:
>  - Parsing the PNG chunk structure from the byte array
>  - Validating all relevant data chunks (i.e. checking the CRC). Chunks which 
> are not needed (e.g. text chunks) are not validated.
>  - Constructing a PDImageXObject from the chunks
> When at any of this steps an error occurs or the converter detects that it is 
> not possible to map the image, it will bail out and return null. In this case 
> the image has to be embedded the „normal“ way by reading it using ImageIO and 
> compressing it again.
> Only this PNG image types can be converted (at least theoretically) without 
> recompressing the image data:
>  - Grayscale
>  - Truecolor (i.e. RGB 8-Bit/16-Bit)
>  - Indexed
> As soon as transparency is used it gets difficult:
>  - Grayscale with alpha / truecolor with alpha: The alpha channel is saved in 
> the image data stream, as they are stored as (Gray,Alpha) or 
> (Red,Green,Blue,Alpha) tuples. You have to separate the alpha information for 
> the SMASK-Image. At this moment you can just read and recompress it using the 
> LosslessFactory.
>  - Indexed with alpha. Alpha and color tables are separate in the PNG, so 
> this should be possible to build a grayscale SMASK from the image data (which 
> are just the table indices) and the alpha table. Tried that, but Acrobat 
> Reader does not like indexed SMASKs… One could just build a grayscale SMASK 
> using the alpha table and the decompressed image index data. This would at 
> least save some space, as the optimized indexed image data is still used.
> With the current patch only truecolor without alpha images work correctly. 
> The other tests for grayscale and indexed fail. (You must place the zipped 
> images in the resources folder were png.png resides to run the testdrivers; 
> This images are „original“ work done by me using Gimp, Krita and ImageOptim 
> (on macOS) to build the different png image types.)
> Notes for the current patch:
>  - The grayscale images have the wrong gamma curve. I tried using the 
> ColorSpace.CS_GRAY ICC profile and the image seems now only „slightly“ off 
> (i.e. pixel value FFD6D6D6 vs FFD7D7D7). As soon as a gAMA chunk is given the 
> image is tagged with a CalGray profile, but the colors are way more off then.
>  - The cHRM (chroma) chunk is read and *should* work, as I used the formula’s 
> from the PDF spec to convert the cRHM values to the CalRGB whitepoint and 
> matrix. I have not yet tested this, as I have no test image with cHRM at the 
> moment. Note: Matrix(COSArray) and Matrix.toCOSArray() are fine for geometric 
> matrices. But this methods are wrong for any other kind of matrix (i.e. color 
> transform matrices), as they only store/restore 6 values of the 3x3 matrix. I 
> deprecated PDCalRGB.setMatrix(Matrix) because of this, as this was never 
> working and can not work as long as the Matrix class is for geometric use 
> cases only. This should also be documented on the Matrix class, that it is 
> not general purpose. I added a PDCalRGB.setMatrix(COSArray) method to allow 
> to set the matrix.
>  - The indexed image displays fine in Acrobat Reader, but the test driver 
> fails as PDImageXObject.getImage() returns a complete black (everything 0) 
> image. Strange, I suspect some error in the PDFBox image decoding.
>  - If an image is tagged with sRGB, the builtin Java sRGB ICC profile is 
> attached. Theoretically you can use a CalRGB colorspace, but using a ICC 
> color profile is likely faster (at least in PDFBox) and more „standard“.
> You can also look at this patch on GitHub 
> [https://github.com/apache/pdfbox/compare/2.0...rototor:2.0-png-from-bytes-encoder?expand=1]
>  if you like.
> It would be nice if someone could give me some hints with the colorspace 
> problems. I will try to reread the specs again, maybe I have missed 
> somet

[jira] [Commented] (PDFBOX-4341) [Patch] PNGConverter: PNG bytes to PDImageXObject converter

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662703#comment-16662703
 ] 

Tilman Hausherr commented on PDFBOX-4341:
-

Yes these. I've tried to do my own test but for some reason the download 
doesn't really work. I only managed to hit two files... these were larger with 
the new converter.

 

> [Patch] PNGConverter: PNG bytes to PDImageXObject converter
> ---
>
> Key: PDFBOX-4341
> URL: https://issues.apache.org/jira/browse/PDFBOX-4341
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Writing
>Affects Versions: 2.0.12
>Reporter: Emmeran Seehuber
>Priority: Minor
> Attachments: 001229.png, 001230.png, pngconvert_testimg.zip, 
> pngconvert_v1.patch, pngconvert_v2.patch
>
>
> The attached patch implements a PNG bytes to PDImageXObject converter. It 
> tries to create a PDImageXObject from the chunks of a PNG image, without 
> recompressing it. This allows to use programs like pngcrush and friends to 
> embedded optimal compressed images. It’s also way faster than recompressing 
> the image.
> The class PNGConverter does this in three steps:
>  - Parsing the PNG chunk structure from the byte array
>  - Validating all relevant data chunks (i.e. checking the CRC). Chunks which 
> are not needed (e.g. text chunks) are not validated.
>  - Constructing a PDImageXObject from the chunks
> When at any of this steps an error occurs or the converter detects that it is 
> not possible to map the image, it will bail out and return null. In this case 
> the image has to be embedded the „normal“ way by reading it using ImageIO and 
> compressing it again.
> Only this PNG image types can be converted (at least theoretically) without 
> recompressing the image data:
>  - Grayscale
>  - Truecolor (i.e. RGB 8-Bit/16-Bit)
>  - Indexed
> As soon as transparency is used it gets difficult:
>  - Grayscale with alpha / truecolor with alpha: The alpha channel is saved in 
> the image data stream, as they are stored as (Gray,Alpha) or 
> (Red,Green,Blue,Alpha) tuples. You have to separate the alpha information for 
> the SMASK-Image. At this moment you can just read and recompress it using the 
> LosslessFactory.
>  - Indexed with alpha. Alpha and color tables are separate in the PNG, so 
> this should be possible to build a grayscale SMASK from the image data (which 
> are just the table indices) and the alpha table. Tried that, but Acrobat 
> Reader does not like indexed SMASKs… One could just build a grayscale SMASK 
> using the alpha table and the decompressed image index data. This would at 
> least save some space, as the optimized indexed image data is still used.
> With the current patch only truecolor without alpha images work correctly. 
> The other tests for grayscale and indexed fail. (You must place the zipped 
> images in the resources folder were png.png resides to run the testdrivers; 
> This images are „original“ work done by me using Gimp, Krita and ImageOptim 
> (on macOS) to build the different png image types.)
> Notes for the current patch:
>  - The grayscale images have the wrong gamma curve. I tried using the 
> ColorSpace.CS_GRAY ICC profile and the image seems now only „slightly“ off 
> (i.e. pixel value FFD6D6D6 vs FFD7D7D7). As soon as a gAMA chunk is given the 
> image is tagged with a CalGray profile, but the colors are way more off then.
>  - The cHRM (chroma) chunk is read and *should* work, as I used the formula’s 
> from the PDF spec to convert the cRHM values to the CalRGB whitepoint and 
> matrix. I have not yet tested this, as I have no test image with cHRM at the 
> moment. Note: Matrix(COSArray) and Matrix.toCOSArray() are fine for geometric 
> matrices. But this methods are wrong for any other kind of matrix (i.e. color 
> transform matrices), as they only store/restore 6 values of the 3x3 matrix. I 
> deprecated PDCalRGB.setMatrix(Matrix) because of this, as this was never 
> working and can not work as long as the Matrix class is for geometric use 
> cases only. This should also be documented on the Matrix class, that it is 
> not general purpose. I added a PDCalRGB.setMatrix(COSArray) method to allow 
> to set the matrix.
>  - The indexed image displays fine in Acrobat Reader, but the test driver 
> fails as PDImageXObject.getImage() returns a complete black (everything 0) 
> image. Strange, I suspect some error in the PDFBox image decoding.
>  - If an image is tagged with sRGB, the builtin Java sRGB ICC profile is 
> attached. Theoretically you can use a CalRGB colorspace, but using a ICC 
> color profile is likely faster (at least in PDFBox) and more „standard“.
> You can also look at this patch on GitHub 
> [https://github.com/apache/pdfbox/compare/2.0...rototor:2.0-png-from-bytes-encoder?

Jenkins build is back to stable : PDFBox-2.0.x #1220

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to stable : PDFBox-2.0.x » Apache PDFBox #1220

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox-2.0.x » Apache PDFBox application #1219

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox-2.0.x » Apache PDFBox #1219

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is unstable: PDFBox-2.0.x #1219

[Apache Jenkins Server]

See 


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4312:

Comment: was deleted

(was: Your last comment did not contain any text.)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662581#comment-16662581
 ] 

Tilman Hausherr edited comment on PDFBOX-4312 at 10/24/18 5:26 PM:
---

It's what I explained in September, that signing will only work if you 
calculate the signature from the input stream at the time sign() is called. 
What you are doing is to calculate the signature at an earlier time, when the 
PDF doesn't exist in its signed form. The signature covers both the original 
PDF and the incremental save part, except the signature itself.
 
To insert the signature and the byterange at the proper place you need to write 
some code yourself, as explained by me on October 22 in the long comment.


was (Author: tilman):
It's what I explained in September, that it will only work if you calculate the 
signature from the input stream at the time sign() is called. What you are 
doing is to calculate the signature at an earlier time, when the PDF doesn't 
exist in its signed form. The signature covers both the original PDF and the 
incremental save part, except the signature itself.
 
To insert the signature and the byterange at the proper place you need to write 
some code yourself, as explained by me on October 22 in the long comment.

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[Tilman Hausherr (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662581#comment-16662581
 ] 

Tilman Hausherr commented on PDFBOX-4312:
-

It's what I explained in September, that it will only work if you calculate the 
signature from the input stream at the time sign() is called. What you are 
doing is to calculate the signature at an earlier time, when the PDF doesn't 
exist in its signed form. The signature covers both the original PDF and the 
incremental save part, except the signature itself.
 
To insert the signature and the byterange at the proper place you need to write 
some code yourself, as explained by me on October 22 in the long comment.

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4312:

Attachment: (was: 
testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[Tilman Hausherr (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-4312:

Attachment: (was: 
testingSignature-signed-SaveIncremental-2param-good.pdf)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: The same error i am seeing after the improved code . signed by unknown 
please see the attached file.

 

 

 

 )

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: My signature  is getting inserted at the end of the pdf . so i think my 
signature is getting invalid. any way to control the insertion of the signature 
at the proper offset  of the byte range array.

 )

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: [^testingSigned_Final.pdf])

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: Signature is getting inserted when i returned it from sign method. But 
still there is signed by unknown instead of name of the person signing the 
document.  any update code is posted upward.

thanks in advance

 

 )

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: I tried it manually but it does not work with notepad++. You said to use 
pdfbox 2.0.12 but the dll is not available  for pdfbox 2.0.12 then how it will 
work in. Net any other way. Thanks. )

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: the pdf is same as above attached.)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: please find attached PDF  for reference. instead of signed by unknown i 
want to show signed by name of the person signing that document.  !Screenshot 
(30).png!)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: On Tue 23 Oct, 2018, 12:45 AM Tilman Hausherr (JIRA), 

)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: can u suggest how to write the tool in .net c++ because i am not familiar 
with the c++. is there any other  way ? dll for pdfbox 2.0.12 id not available 
then how can i use pdfbox 2.0.12 that work properly for incremental updates. 
thanks in advance.)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: I have tried it but its not working the output is pos = 0 any other way 
to insert the signature at proper offset of the byte range array.)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Issue Comment Deleted] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

bal updated PDFBOX-4312:

Comment: was deleted

(was: please see the attached signed pdf i want to show only one name please 
suggest some solution on priority

 

!Screenshot (31).png!)

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662087#comment-16662087
 ] 

bal commented on PDFBOX-4312:
-

please delete the upper two uploaded pdf file . i am not able to do it. 

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4312) Signature is not getting inserted into 00000 area

[bal (JIRA)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661963#comment-16661963
 ] 

bal commented on PDFBOX-4312:
-

public byte[] sign(InputStream @is)
 {
    InputStream ipstream = @is;

     byte[] pdf = null;

 

     pdf = docSigDict["doc"];

    return pdf;
 }

whats looks wrong in sign method i am just calculating signature bytes from 
response and returning it from sign method. Is there any way to insert the 
signature at proper byte range offset so that my signature gets valid. thanks.

 

> Signature is not getting inserted into 0 area
> -
>
> Key: PDFBOX-4312
> URL: https://issues.apache.org/jira/browse/PDFBOX-4312
> Project: PDFBox
>  Issue Type: Bug
>  Components: .NET, PDModel, Signing
>Affects Versions: 1.8.9, 1.8.15
>Reporter: bal
>Priority: Major
> Fix For: 1.8.17
>
> Attachments: 
> testingSignature-signed-SaveIncremental-1param-bad-cutoff.pdf, 
> testingSignature-signed-SaveIncremental-2param-good.pdf
>
>
> Hi ,
> I want to sign pdf using signature in pkcs 7 format . I am converting pkcs 7 
> signature to byte array using Convert.FromBase64String method in .net . I am 
> passing this byte array to sign method in signature interface which gets 
> called after calling saveincremental. My byte array is inserting proper but 
> the name of which signature is not shown when i open pdf. May be my byte 
> conversion may not proper or something else i am doing wrong. please let me 
> know.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Build failed in Jenkins: PDFBox-2.0.x » Apache PDFBox application #1218

[Apache Jenkins Server]

See 


--
[...truncated 6.09 KB...]
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
pdfbox-app ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.22.1:test (default-test) @ pdfbox-app ---
[INFO] Skipping execution of surefire because it has already been run for this 
configuration
[JENKINS] Recording test results
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.17:check (check-java-version) @ 
pdfbox-app ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.0
[INFO] 
[INFO] --- maven-site-plugin:3.7:attach-descriptor (attach-descriptor) @ 
pdfbox-app ---
[INFO] Skipping because packaging 'bundle' is not pom.
[INFO] 
[INFO] >>> maven-source-plugin:3.0.1:jar (attach-sources) > generate-sources @ 
pdfbox-app >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
pdfbox-app ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (default) @ pdfbox-app ---
[WARNING] Failed to getClass for org.apache.maven.plugins.source.SourceJarMojo
[INFO] 
[INFO] <<< maven-source-plugin:3.0.1:jar (attach-sources) < generate-sources @ 
pdfbox-app <<<
[INFO] 
[INFO] 
[INFO] --- maven-source-plugin:3.0.1:jar (attach-sources) @ pdfbox-app ---
[INFO] Skipping source per configuration.
[WARNING] Failed to getClass for org.apache.felix.bundleplugin.BundlePlugin
[INFO] 
[INFO] <<< maven-bundle-plugin:2.5.4:bundle (default-bundle) < package @ 
pdfbox-app <<<
[INFO] 
[INFO] 
[INFO] --- maven-bundle-plugin:2.5.4:bundle (default-bundle) @ pdfbox-app ---
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Unused 
Private-Package instructions, no such package(s) on the class path: [!*]
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Export 
org.apache.pdfbox.io,  has 1,  private references [org.apache.commons.logging], 
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Export 
org.apache.pdfbox.pdmodel,  has 1,  private references 
[org.apache.fontbox.ttf], 
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Export 
org.apache.pdfbox.pdmodel.common,  has 1,  private references 
[org.apache.fontbox.util], 
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Export 
org.apache.pdfbox.pdmodel.font,  has 7,  private references 
[org.apache.fontbox.cff, org.apache.fontbox.afm, org.apache.fontbox, 
org.apache.fontbox.ttf, org.apache.fontbox.type1, org.apache.fontbox.cmap, 
org.apache.fontbox.util], 
[WARNING] Bundle org.apache.pdfbox:pdfbox-app:bundle:2.0.13-SNAPSHOT : Export 
org.apache.pdfbox.pdmodel.font.encoding,  has 2,  private references 
[org.apache.fontbox.encoding, org.apache.fontbox.afm], 
[INFO] 
[INFO] --- maven-site-plugin:3.7:attach-descriptor (attach-descriptor) @ 
pdfbox-app ---
[INFO] Skipping because packaging 'bundle' is not pom.
[INFO] 
[INFO] >>> maven-source-plugin:3.0.1:jar (attach-sources) > generate-sources @ 
pdfbox-app >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
pdfbox-app ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (default) @ pdfbox-app ---
[WARNING] Failed to getClass for org.apache.maven.plugins.source.SourceJarMojo
[INFO] 
[INFO] <<< maven-source-plugin:3.0.1:jar (attach-sources) < generate-sources @ 
pdfbox-app <<<
[INFO] 
[INFO] 
[INFO] --- maven-source-plugin:3.0.1:jar (attach-sources) @ pdfbox-app ---
[INFO] Skipping source per configuration.
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (default) @ pdfbox-app ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: release.properties
[INFO] 3 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 1 licenses.
[INFO] 
[INFO] --- dependency-check-maven:3.3.2:check (default) @ pdfbox-app ---
[INFO] Central analyzer disabled
[INFO] Checking for updates
[INFO] Skipping NVD check since last check was within 4 hours.
[INFO] Skipping RetireJS update since last update was within 24 hours.
[INFO] Check for updates complete (5 ms)
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (0 seconds)
[INFO] Skipping CPE Analysis for npm
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression 

Build failed in Jenkins: PDFBox-2.0.x #1218

[Apache Jenkins Server]

See 


Changes:

[tilman] PDFBOX-4071: use new convenience method

--
[...truncated 977.96 KB...]
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: release.properties
[INFO] 3 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 1 licenses.
[INFO] 
[INFO] --- dependency-check-maven:3.3.2:check (default) @ pdfbox-app ---
[INFO] Central analyzer disabled
[INFO] Checking for updates
[INFO] Skipping NVD check since last check was within 4 hours.
[INFO] Skipping RetireJS update since last update was within 24 hours.
[INFO] Check for updates complete (5 ms)
[INFO] Analysis Started
[INFO] Finished Archive Analyzer (0 seconds)
[INFO] Finished File Name Analyzer (0 seconds)
[INFO] Finished Jar Analyzer (0 seconds)
[INFO] Finished Dependency Merging Analyzer (0 seconds)
[INFO] Finished Version Filter Analyzer (0 seconds)
[INFO] Finished Hint Analyzer (0 seconds)
[INFO] Created CPE Index (0 seconds)
[INFO] Skipping CPE Analysis for npm
[INFO] Finished CPE Analyzer (0 seconds)
[INFO] Finished False Positive Analyzer (0 seconds)
[INFO] Finished NVD CVE Analyzer (0 seconds)
[INFO] Finished Vulnerability Suppression Analyzer (0 seconds)
[INFO] Finished Dependency Bundling Analyzer (0 seconds)
[INFO] Analysis Complete (1 seconds)
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ pdfbox-app ---
[INFO] Installing 

 to 

[INFO] Installing 
 to 

[INFO] 
[INFO] >>> maven-bundle-plugin:2.5.4:install (default-install) > install @ 
pdfbox-app >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
pdfbox-app ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (default) @ pdfbox-app ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ pdfbox-app ---
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ 
pdfbox-app ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.6.0:compile (default-compile) @ pdfbox-app 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ 
pdfbox-app ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.6.0:testCompile (default-testCompile) @ 
pdfbox-app ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.22.1:test (default-test) @ pdfbox-app ---
[INFO] Skipping execution of surefire because it has already been run for this 
configuration
[JENKINS] Recording test results
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.17:check (check-java-version) @ 
pdfbox-app ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.0
[INFO] 
[INFO] >>> maven-bundle-plugin:2.5.4:bundle (default-bundle) > package @ 
pdfbox-app >>>
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ 
pdfbox-app ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (default) @ pdfbox-app ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ pdfbox-app ---
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:resources (default-resources) @ 
pdfbox-app ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.6.0:compile (default-compile) @ pdfbox-app 
---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-resources-plugin:3.0.2:testResources (default-testResources) @ 
pdfbox-app ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO]