[GitHub] [pdfbox] IntraCherche edited a comment on pull request #93: Updated comment when rendered image is too large

[GitBox]

IntraCherche edited a comment on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-752859592


   Because the code checks `if ((long) widthPx * (long) heightPx > 
Integer.MAX_VALUE)` and `widthPx` and `heightPx` are defined as
   
   `int widthPx = (int) Math.max(Math.floor(widthPt * scale), 1);`
   ` int heightPx = (int) Math.max(Math.floor(heightPt * scale), 1);`
   
   But then the error message uses `widthPt` and `heightPt` (not `widthPx` and 
`heightPx` as in the if check). So if you rewrite the the if check (just to 
understand) with `widthPt` and `heightPt` instead of `widthPx` and `heightPx`, 
you get :
   `widthPx * heightPx = widthPt * scale * heightPt * scale` which in turn 
yields to `widthPt * heightPt * scale * scale ` or `widthPt * heightPt * scale 
^ 2` which is the proposed update.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[GitHub] [pdfbox] IntraCherche commented on pull request #93: Updated comment when rendered image is too large

[GitBox]

IntraCherche commented on pull request #93:
URL: https://github.com/apache/pdfbox/pull/93#issuecomment-752859592


   Because the code checks `if ((long) widthPx * (long) heightPx > 
Integer.MAX_VALUE)` and `widthPx` and `heightPx` are defined as
   
   `int widthPx = (int) Math.max(Math.floor(widthPt * scale), 1);
int heightPx = (int) Math.max(Math.floor(heightPt * scale), 1);`
   
   But then the error message uses `widthPt` and `heightPt` (not `widthPx` and 
`heightPx` as in the if check). So if you rewrite the the if check (just to 
understand) with `widthPt` and `heightPt` instead of `widthPx` and `heightPx`, 
you get :
   `widthPx * heightPx = widthPt * scale * heightPt * scale` which in turn 
yields to `widthPt * heightPt * scale * scale ` or `widthPt * heightPt * scale 
^ 2` which is the proposed update.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Jira]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256752#comment-17256752
 ] 

Andreas Lehmkühler commented on PDFBOX-2602:


I don't really have a preference as I don't use PDFBox very often that way. But 
I guess the new ones are easier to memorize as one don't have to care about 
case sensitivity, everything is just lower case

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256662#comment-17256662
 ] 

Tilman Hausherr commented on PDFBOX-2602:
-

I'd prefer the old names but if others (Andreas?) prefer the new ones, I can 
easily change it locally so that I can keep my habits.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256593#comment-17256593
 ] 

Maruan Sahyoun commented on PDFBOX-2602:


shall we keep the new ones or go back to the old ones?

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to stable : PDFBox » PDFBox-2.0.x #193

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to stable : PDFBox » PDFBox-2.0.x » Apache PDFBox examples #193

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256581#comment-17256581
 ] 

Tilman Hausherr commented on PDFBOX-2602:
-

Yeah I agree with that.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256577#comment-17256577
 ] 

Maruan Sahyoun commented on PDFBOX-2602:


Adding an alias is possible but it will show up in the usage section. IMHO 
that's not nice.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is still unstable: PDFBox » PDFBox-2.0.x » Apache PDFBox examples #192

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is still unstable: PDFBox » PDFBox-2.0.x #192

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Replace jaxb date DatatypeConverter with java.time

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256554#comment-17256554
 ] 

ASF subversion and git services commented on PDFBOX-5061:
-

Commit 1884943 from Maruan Sahyoun in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884943 ]

PDFBOX-5061: remove jaxb dependency

> Replace jaxb date DatatypeConverter with java.time
> --
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Replace jaxb date DatatypeConverter with java.time

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256556#comment-17256556
 ] 

Maruan Sahyoun commented on PDFBOX-5061:


Should be done here - let me know if there are further changes. Potentially we 
can simplify DateConverter but I'll leave it as is for now.

> Replace jaxb date DatatypeConverter with java.time
> --
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[GitHub] [pdfbox] asfgit closed pull request #101: PDFBOX-5061 Replace javax.xml.bind by jakarta.xml.bind

[GitBox]

asfgit closed pull request #101:
URL: https://github.com/apache/pdfbox/pull/101


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Replace jaxb date DatatypeConverter with java.time

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256555#comment-17256555
 ] 

ASF subversion and git services commented on PDFBOX-5061:
-

Commit 1884944 from Maruan Sahyoun in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884944 ]

PDFBOX-5061: remove jaxb dependency; closes #101

> Replace jaxb date DatatypeConverter with java.time
> --
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox » PDFBox-2.0.x #191

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build became unstable: PDFBox » PDFBox-2.0.x » Apache PDFBox examples #191

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256538#comment-17256538
 ] 

Tilman Hausherr commented on PDFBOX-2602:
-

Yes, so that I can still use "PDFDebugger", "PDFSplit", "ExtractImages" etc.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-2602) Enhance command line tools

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256519#comment-17256519
 ] 

Tilman Hausherr edited comment on PDFBOX-2602 at 12/30/20, 1:51 PM:


Can we keep the old command names as a "secret" possibility? My problem is that 
when I answer support requests that require a test from the command line, I 
usually test with 3.0 first, and if that one works, I try the same with 2.0. So 
now I would have to remember both command name sets.


was (Author: tilman):
Can we keep the old command names as a "secret" possibility? My problem is that 
when I answer support requests that require a test from the command line, I 
usually test with 3.0 first, and if that one works, I try the same with 2.0. So 
now I would have to remember both.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Resolved] (PDFBOX-4321) PDDocument.save(OutputStream) shouldn't close the output stream

[Jira]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler resolved PDFBOX-4321.

Resolution: Fixed

COSWriter doesn't implement the Cloaseable interface and PDDocument.save() 
doesn't close the given Outputstream anymore 

> PDDocument.save(OutputStream) shouldn't close the output stream
> ---
>
> Key: PDFBOX-4321
> URL: https://issues.apache.org/jira/browse/PDFBOX-4321
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.11, 3.0.0 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> As mentioned by [~haraldk76] in PDFBOX-4241, 
> {{PDDocument.save(OutputStream)}} shouldn't close the output stream, this is 
> poor design.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4321) PDDocument.save(OutputStream) shouldn't close the output stream

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256534#comment-17256534
 ] 

ASF subversion and git services commented on PDFBOX-4321:
-

Commit 1884942 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884942 ]

PDFBOX-4321: adjust test

> PDDocument.save(OutputStream) shouldn't close the output stream
> ---
>
> Key: PDFBOX-4321
> URL: https://issues.apache.org/jira/browse/PDFBOX-4321
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.11, 3.0.0 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> As mentioned by [~haraldk76] in PDFBOX-4241, 
> {{PDDocument.save(OutputStream)}} shouldn't close the output stream, this is 
> poor design.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4321) PDDocument.save(OutputStream) shouldn't close the output stream

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256532#comment-17256532
 ] 

ASF subversion and git services commented on PDFBOX-4321:
-

Commit 1884941 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884941 ]

PDFBOX-4321: don't close given output stream after saving a pdf

> PDDocument.save(OutputStream) shouldn't close the output stream
> ---
>
> Key: PDFBOX-4321
> URL: https://issues.apache.org/jira/browse/PDFBOX-4321
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.11, 3.0.0 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> As mentioned by [~haraldk76] in PDFBOX-4241, 
> {{PDDocument.save(OutputStream)}} shouldn't close the output stream, this is 
> poor design.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256524#comment-17256524
 ] 

ASF subversion and git services commented on PDFBOX-4892:
-

Commit 1884939 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1884939 ]

PDFBOX-4892: improve logging

> Improve code quality (4)
> 
>
> Key: PDFBOX-4892
> URL: https://issues.apache.org/jira/browse/PDFBOX-4892
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.20
>Reporter: Tilman Hausherr
>Priority: Minor
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], 
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-4071, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4892) Improve code quality (4)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256525#comment-17256525
 ] 

ASF subversion and git services commented on PDFBOX-4892:
-

Commit 1884940 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884940 ]

PDFBOX-4892: improve logging

> Improve code quality (4)
> 
>
> Key: PDFBOX-4892
> URL: https://issues.apache.org/jira/browse/PDFBOX-4892
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.20
>Reporter: Tilman Hausherr
>Priority: Minor
>
> This is a longterm issue for the task to improve code quality, by using the 
> [SonarQube report|https://sonarcloud.io/project/issues?id=pdfbox-reactor], 
> hints in different IDEs, the FindBugs tool and other code quality tools.
> This is a follow-up of PDFBOX-4071, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256522#comment-17256522
 ] 

Maruan Sahyoun commented on PDFBOX-2602:


[~tilman] the old names are still valid for the individual tools. So you'd also 
like to have them in the pdfbox app?

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Replace jaxb date DatatypeConverter with java.time

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256521#comment-17256521
 ] 

ASF subversion and git services commented on PDFBOX-5061:
-

Commit 1884938 from Maruan Sahyoun in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884938 ]

PDFBOX-5061: replace jaxb parsing with time zone string

> Replace jaxb date DatatypeConverter with java.time
> --
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256519#comment-17256519
 ] 

Tilman Hausherr commented on PDFBOX-2602:
-

Can we keep the old command names as a "secret" possibility? My problem is that 
when I answer support requests that require a test from the command line, I 
usually test with 3.0 first, and if that one works, I try the same with 2.0. So 
now I would have to remember both.

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Assigned] (PDFBOX-4321) PDDocument.save(OutputStream) shouldn't close the output stream

[Jira]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-4321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Lehmkühler reassigned PDFBOX-4321:
--

Assignee: Andreas Lehmkühler

> PDDocument.save(OutputStream) shouldn't close the output stream
> ---
>
> Key: PDFBOX-4321
> URL: https://issues.apache.org/jira/browse/PDFBOX-4321
> Project: PDFBox
>  Issue Type: Bug
>  Components: PDModel
>Affects Versions: 2.0.11, 3.0.0 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
>
> As mentioned by [~haraldk76] in PDFBOX-4241, 
> {{PDDocument.save(OutputStream)}} shouldn't close the output stream, this is 
> poor design.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[GitHub] [pdfbox] msahyoun commented on pull request #101: PDFBOX-5061 Replace javax.xml.bind by jakarta.xml.bind

[GitBox]

msahyoun commented on pull request #101:
URL: https://github.com/apache/pdfbox/pull/101#issuecomment-752510319


   @koppor we are looking to replace with java.time instead of the suggested 
jakarta.xml component.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4952) PDF compression - object stream creation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256493#comment-17256493
 ] 

ASF subversion and git services commented on PDFBOX-4952:
-

Commit 1884936 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884936 ]

PDFBOX-4952: remove unneeded object set

> PDF compression - object stream creation
> 
>
> Key: PDFBOX-4952
> URL: https://issues.apache.org/jira/browse/PDFBOX-4952
> Project: PDFBox
>  Issue Type: New Feature
>  Components: PDModel
>Affects Versions: 2.0.21
>Reporter: Christian Appl
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
> Attachments: image-2020-09-07-09-47-30-172.png, 
> image-2020-09-07-10-05-15-631.png
>
>
> I implemented a basic starting point to realize a PDF compression based on 
> PDFBox 2.0.22-SNAPSHOT
> I want to use this ticket, to ask if you would be interested in such a 
> feature and whether you would be interested to merge it into PDFBox.
> This is sort of a POC, only implementing some very basic functionality, that 
> surely must and could be extended further and it does only implement some 
> very basic and simplistic Unit Tests.
>  However it is able to reduce the size of resulting documents, and creates 
> objectstreams as defined in the PDF reference manual.
> *What it currently does:*
>  It provides the bundling and compression of objects to objectstreams -and 
> further applies simple content compression to a small selection of contents-.
> -To realize content compression, it provides a simple interface and abstract 
> class for "ContentCompressor"s which search a document for specific content, 
> that could be compressed and do compress that contents.-
> -Currently two content compressors exist:-
>  -_ImageCompressor_-
>  -Searches for simple images, that could be compressed using DCT.-
> -_UnencodedStreamCompressor_-
>  -Searches the document for yet unencoded streams and applies a Flate 
> compression where necessary.-
> -Both compressors can be parameterized using a centralized 
> "CompressParameters" instance which is passed to a new "saveCompressed" 
> method of PDDocument.-
> The compression is based on, modifies and is realized by a set of extensions 
> for the "COSWriter" class. Basically it organizes objects, that are passed to 
> the COSWriter in objectStreams -and applies content optimization where 
> necessary and possible-.
> Currently this does support encryption, but does not support linearization of 
> the compressed documents.
> *Caveat:*
>  If this feature is interesting to you, then I would not expect you to simply 
> merge this fork into 2.0.22. I am expecting that you would like to have some 
> details and concepts changed and am ready to implement changes that would be 
> required for this to work to your liking.
> *POC:*
>  4 resulting documents can be found in "target/test-output/compression" when 
> "COSDocumentCompressionTest" is run.
> *The Pull request can be found on Github at:*
>  [https://github.com/apache/pdfbox/pull/86]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-5061) Replace jaxb date DatatypeConverter with java.time

[Maruan Sahyoun (Jira)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maruan Sahyoun updated PDFBOX-5061:
---
Summary: Replace jaxb date DatatypeConverter with java.time  (was: Migrate 
to jakarta APIs)

> Replace jaxb date DatatypeConverter with java.time
> --
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256492#comment-17256492
 ] 

Maruan Sahyoun commented on PDFBOX-5061:


I've added an initial test which is using java.time instead of jaxb to ensure 
that the tests still work i.e. java.time parses to the same value as jaxb. Will 
work of these tests. Ideally we can also get rid of most of DateConverter but 
the initial goal is to remove jaxb first.

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256488#comment-17256488
 ] 

ASF subversion and git services commented on PDFBOX-5061:
-

Commit 1884935 from Maruan Sahyoun in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884935 ]

PDFBOX-5061: add initial test using java.time

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5062) IllegalBlockSizeException when loading the file

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256474#comment-17256474
 ] 

Tilman Hausherr commented on PDFBOX-5062:
-

Your PDF is corrupted or malformed.

The log output shows a warning before the exception:
{noformat}
 Warning  [COSParser] The end of the stream doesn't point to the correct 
offset, using workaround to read the stream, stream start position: 125739, 
length: 7088, expected end position: 132827
 Error  [SecurityHandler] IOException thrown when decrypting object 2 0 obj
{noformat}
The second line is new, it's just for clarification of the exception you 
already know. However it allows to tell that it happens in the _same_ stream 
that has the bad length. You can use an editor like NOTEPAD++ to see what's at 
these offsets.

> IllegalBlockSizeException when loading the file
> ---
>
> Key: PDFBOX-5062
> URL: https://issues.apache.org/jira/browse/PDFBOX-5062
> Project: PDFBox
>  Issue Type: Bug
>  Components: Crypto, PDModel
>Affects Versions: 2.0.22
>Reporter: Zubair Uddin Farooqui
>Priority: Major
> Attachments: Medical services-1 (dup-keywords) (1).pdf
>
>
> Getting _IllegalBlockSizeException_ when loading the file 
> *Code:*
> {code:java}
> PDDocument pdDoc = PDDocument.load(file);{code}
> *Exception:*
> {code:java}
> java.io.IOException: javax.crypto.IllegalBlockSizeException: Input length 
> must be multiple of 16 when decrypting with padded cipherjava.io.IOException: 
> javax.crypto.IllegalBlockSizeException: Input length must be multiple of 16 
> when decrypting with padded cipher at 
> org.apache.pdfbox.pdmodel.encryption.SecurityHandler.encryptDataAESother(SecurityHandler.java:315)
>  at 
> org.apache.pdfbox.pdmodel.encryption.SecurityHandler.encryptData(SecurityHandler.java:201)
>  at 
> org.apache.pdfbox.pdmodel.encryption.SecurityHandler.decryptStream(SecurityHandler.java:510)
>  at org.apache.pdfbox.pdfparser.COSParser.parseFileObject(COSParser.java:929) 
> at 
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:886)
>  at 
> org.apache.pdfbox.pdfparser.COSParser.parseObjectDynamically(COSParser.java:806)
>  at 
> org.apache.pdfbox.pdfparser.COSParser.parseDictObjects(COSParser.java:766) at 
> org.apache.pdfbox.pdfparser.PDFParser.initialParse(PDFParser.java:187) at 
> org.apache.pdfbox.pdfparser.PDFParser.parse(PDFParser.java:226) at 
> org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1099) at 
> org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1082) at 
> org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:1041) at 
> org.apache.pdfbox.pdmodel.PDDocument.load(PDDocument.java:989)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-4952) PDF compression - object stream creation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-4952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256465#comment-17256465
 ] 

ASF subversion and git services commented on PDFBOX-4952:
-

Commit 1884934 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884934 ]

PDFBOX-4952: remove unneeded object pool

> PDF compression - object stream creation
> 
>
> Key: PDFBOX-4952
> URL: https://issues.apache.org/jira/browse/PDFBOX-4952
> Project: PDFBox
>  Issue Type: New Feature
>  Components: PDModel
>Affects Versions: 2.0.21
>Reporter: Christian Appl
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.0 PDFBox
>
> Attachments: image-2020-09-07-09-47-30-172.png, 
> image-2020-09-07-10-05-15-631.png
>
>
> I implemented a basic starting point to realize a PDF compression based on 
> PDFBox 2.0.22-SNAPSHOT
> I want to use this ticket, to ask if you would be interested in such a 
> feature and whether you would be interested to merge it into PDFBox.
> This is sort of a POC, only implementing some very basic functionality, that 
> surely must and could be extended further and it does only implement some 
> very basic and simplistic Unit Tests.
>  However it is able to reduce the size of resulting documents, and creates 
> objectstreams as defined in the PDF reference manual.
> *What it currently does:*
>  It provides the bundling and compression of objects to objectstreams -and 
> further applies simple content compression to a small selection of contents-.
> -To realize content compression, it provides a simple interface and abstract 
> class for "ContentCompressor"s which search a document for specific content, 
> that could be compressed and do compress that contents.-
> -Currently two content compressors exist:-
>  -_ImageCompressor_-
>  -Searches for simple images, that could be compressed using DCT.-
> -_UnencodedStreamCompressor_-
>  -Searches the document for yet unencoded streams and applies a Flate 
> compression where necessary.-
> -Both compressors can be parameterized using a centralized 
> "CompressParameters" instance which is passed to a new "saveCompressed" 
> method of PDDocument.-
> The compression is based on, modifies and is realized by a set of extensions 
> for the "COSWriter" class. Basically it organizes objects, that are passed to 
> the COSWriter in objectStreams -and applies content optimization where 
> necessary and possible-.
> Currently this does support encryption, but does not support linearization of 
> the compressed documents.
> *Caveat:*
>  If this feature is interesting to you, then I would not expect you to simply 
> merge this fork into 2.0.22. I am expecting that you would like to have some 
> details and concepts changed and am ready to implement changes that would be 
> required for this to work to your liking.
> *POC:*
>  4 resulting documents can be found in "target/test-output/compression" when 
> "COSDocumentCompressionTest" is run.
> *The Pull request can be found on Github at:*
>  [https://github.com/apache/pdfbox/pull/86]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Assigned] (PDFBOX-5061) Migrate to jakarta APIs

[Maruan Sahyoun (Jira)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maruan Sahyoun reassigned PDFBOX-5061:
--

Assignee: Maruan Sahyoun

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256446#comment-17256446
 ] 

Maruan Sahyoun commented on PDFBOX-5061:


I knew I shouldn't have mentioned that :)

Will do.

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Jira]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256441#comment-17256441
 ] 

Andreas Lehmkühler commented on PDFBOX-5061:


[~msahyoun] Please go ahead, so that we can rid of that dependency before 
releasing 3.0.0 :D

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Comment Edited] (PDFBOX-5061) Migrate to jakarta APIs

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256433#comment-17256433
 ] 

Tilman Hausherr edited comment on PDFBOX-5061 at 12/30/20, 10:28 AM:
-

That would of course be better because it wouldn't grow our code.

I removed the 2.0.23 target because replacing DatatypeConverter still leaves us 
with the dependency on javax.activation in newer jdks and we can't get rid of 
that because it's in the API.


was (Author: tilman):
That's of course be even better because it wouldn't grow our code.

I removed the 2.0.23 target because replacing DatatypeConverter still leaves us 
with the dependency on javax.activation in newer jdks and we can't get rid of 
that because it's in the API.

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256433#comment-17256433
 ] 

Tilman Hausherr commented on PDFBOX-5061:
-

That's of course be even better because it wouldn't grow our code.

I removed the 2.0.23 target because replacing DatatypeConverter still leaves us 
with the dependency on javax.activation in newer jdks and we can't get rid of 
that because it's in the API.

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Updated] (PDFBOX-5061) Migrate to jakarta APIs

[Tilman Hausherr (Jira)]

 [ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tilman Hausherr updated PDFBOX-5061:

Fix Version/s: (was: 2.0.23)

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-2602) Enhance command line tools

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-2602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256423#comment-17256423
 ] 

ASF subversion and git services commented on PDFBOX-2602:
-

Commit 1884933 from Maruan Sahyoun in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1884933 ]

PDFBOX-2602: move single line description to header

> Enhance command line tools
> --
>
> Key: PDFBOX-2602
> URL: https://issues.apache.org/jira/browse/PDFBOX-2602
> Project: PDFBox
>  Issue Type: Bug
>  Components: Utilities
>Affects Versions: 1.8.8, 2.0.0
>Reporter: Maruan Sahyoun
>Assignee: Maruan Sahyoun
>Priority: Minor
> Fix For: 3.0.0 PDFBox
>
>
> The command line tools shall be enhanced to have the same behavior across all 
> tools.
> From the discussion on the dev mailing list
> - add an -h option to print the usage
> - print the usage to System.err and use an exit code of 1 if there was an 
> invalid command line parameter
> - print messages on exceptions to System.err
> - rethrow the exception so java can handle it if it will terminate afterwards 
> anyway
> - use an exit code of 1if rethrowing doesn't make sense
> Additional input:
> https://clig.dev/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-3330) Enhance and update PDFBox website & documentation

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256413#comment-17256413
 ] 

ASF subversion and git services commented on PDFBOX-3330:
-

Commit 3e46a42aa2ab0b2aa67e4793f84708624bed3ce4 in pdfbox-docs's branch 
refs/heads/master from Maruan Sahyoun
[ https://gitbox.apache.org/repos/asf?p=pdfbox-docs.git;h=3e46a42 ]

PDFBOX-3330: add colon to sample commit message to encourage usage; closes #4


> Enhance and update PDFBox website & documentation
> -
>
> Key: PDFBOX-3330
> URL: https://issues.apache.org/jira/browse/PDFBOX-3330
> Project: PDFBox
>  Issue Type: Task
>  Components: Documentation
>Reporter: Maruan Sahyoun
>Priority: Major
> Attachments: Bildschirmfoto von »2018-03-14 22-59-10«.png, 
> Bildschirmfoto von »2018-03-14 22-59-21«.png, PDFBox.Logo-0.1.0.png, 
> pdfbox-topbar.pdf, screenshot-1.png, toolbox.svg, topbar.png
>
>
> General purpose ticket to track enhancements to the website and documentation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[GitHub] [pdfbox-docs] asfgit closed pull request #4: Add missing colon to README.md

[GitBox]

asfgit closed pull request #4:
URL: https://github.com/apache/pdfbox-docs/pull/4


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Maruan Sahyoun (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256407#comment-17256407
 ] 

Maruan Sahyoun commented on PDFBOX-5061:


I did some prototyping using java.time for 3.0.0 - works well so IMHO we should 
use that instead of an added dependency.

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 2.0.23, 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5061) Migrate to jakarta APIs

[Jira]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256390#comment-17256390
 ] 

Andreas Lehmkühler commented on PDFBOX-5061:


Ah, I see. I'm thinking about migrating the code to use {{java.time.*}}. In 
this case {{java.time.format.DateTimeFormatter.parse(CharSequence)}} should do 
the trick

> Migrate to jakarta APIs
> ---
>
> Key: PDFBOX-5061
> URL: https://issues.apache.org/jira/browse/PDFBOX-5061
> Project: PDFBox
>  Issue Type: Task
>Reporter: Oliver Kopp
>Priority: Minor
> Fix For: 2.0.23, 3.0.0 PDFBox
>
> Attachments: screenshot-1.png
>
>
> {{javax.}}-dependencies have been superseeded by jakarta dependencies.
> To be able to use Apache PDFBox in Java projects using newer JDKs, it would 
> be feasable to use the new jakarta dependencies. I think, only 
> jakarta.xml.bind is affected. [https://eclipse-ee4j.github.io/jaxb-ri/]
> See also https://issues.apache.org/jira/browse/SHIRO-750



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org