Re: [PR] Improve performance of FileSystemFontProvider.scanFonts() [pdfbox]

[via GitHub]

bogdiuk commented on PR #189:
URL: https://github.com/apache/pdfbox/pull/189#issuecomment-2175628732

   Force-pushed the new implementation, based on 3.0 branch (rev 
5c4a09a5c0574c1701151202ede2be1857610a36). Also I edited the 1st post to 
reflect changes
   
   Performance numbers: first number is a re-run (font files are cached by the 
OS), second is a cold run
   
   Windows (296 fonts):
   - 2.9s..4.0s - `3.0` branch
   - 0.8s..1.9s - `performance-scanfonts` branch
   - 0.3s..0.6s - `performance-scanfonts` +"pdfbox.fontcache.skipchecksums"
   
   macOS (792 fonts):
   - 2.2..3.6s - `3.0` branch
   - 0.4..0.5s - `performance-scanfonts` branch
   - 0.16s..0.2s `performance-scanfonts` +"pdfbox.fontcache.skipchecksums"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855850#comment-17855850
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918403 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918403 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855849#comment-17855849
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918402 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918402 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

[Tilman Hausherr (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855852#comment-17855852
 ] 

Tilman Hausherr commented on PDFBOX-5842:
-

Thanks, yes, good observation.

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855851#comment-17855851
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918404 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918404 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Re: [PR] Improve performance of FileSystemFontProvider.scanFonts() [pdfbox]

[via GitHub]

bogdiuk commented on PR #189:
URL: https://github.com/apache/pdfbox/pull/189#issuecomment-2175740993

   Reasoning behind using a separate class `LoadOnlyHeaders` instead of 
extracting information directly from `TrueTypeFont`:
   * easier to debug - single place to put breakpoints
   * easier to refactor:
 * for example, simple "Find All Usages" can reveal that `setSomething()` 
is not used
 * the alternative is having `boolean isLoadOnlyHeaders` in `TTFParser`, 
`CFFParser` and `TrueTypeFont`: it would be harder to collect usages of all 3
   * in the future, parsing some tables can be skipped completely, only setting 
respective fields of `LoadOnlyHeaders`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-3.0.x » Apache PDFBox #374

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org

Jenkins build is back to normal : PDFBox » PDFBox-3.0.x #374

[Apache Jenkins Server]

See 



-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org