[jira] [Commented] (PDFBOX-5481) Add module-info to the project

2024-07-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868563#comment-17868563
 ] 

ASF subversion and git services commented on PDFBOX-5481:
-

Commit 1919511 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919511 ]

PDFBOX-5481: wrap indirect objects whenever they are added directly to a 
COSDictionary or COSArray

> Add module-info to the project
> --
>
> Key: PDFBOX-5481
> URL: https://issues.apache.org/jira/browse/PDFBOX-5481
> Project: PDFBox
>  Issue Type: Wish
>Reporter: Thiago Henrique Hupner
>Priority: Minor
>
> It would be great to provide module-info to the jars to allow simplified use 
> with JLink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5481) Add module-info to the project

2024-07-25 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17868562#comment-17868562
 ] 

ASF subversion and git services commented on PDFBOX-5481:
-

Commit 1919510 from le...@apache.org in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919510 ]

PDFBOX-5481: wrap indirect objects whenever they are added directly to a 
COSDictionary or COSArray

> Add module-info to the project
> --
>
> Key: PDFBOX-5481
> URL: https://issues.apache.org/jira/browse/PDFBOX-5481
> Project: PDFBox
>  Issue Type: Wish
>Reporter: Thiago Henrique Hupner
>Priority: Minor
>
> It would be great to provide module-info to the jars to allow simplified use 
> with JLink



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867321#comment-17867321
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919370 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919370 ]

PDFBOX-5851: set color and colorspace before setting the path, as suggested by 
Michael Klink

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf, screenshot-1.png
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867322#comment-17867322
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919371 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919371 ]

PDFBOX-5851: set color and colorspace before setting the path, as suggested by 
Michael Klink

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf, screenshot-1.png
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867320#comment-17867320
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919369 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919369 ]

PDFBOX-5851: set color and colorspace before setting the path, as suggested by 
Michael Klink

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf, screenshot-1.png
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867305#comment-17867305
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919367 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919367 ]

PDFBOX-5851: set an invalid color when Pattern colorspace is missing

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867304#comment-17867304
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919366 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919366 ]

PDFBOX-5851: set an invalid color when Pattern colorspace is missing

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5851) When this PDF is rendered with the "f" Operator, a black screen appears.

2024-07-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17867306#comment-17867306
 ] 

ASF subversion and git services commented on PDFBOX-5851:
-

Commit 1919368 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919368 ]

PDFBOX-5851: set an invalid color when Pattern colorspace is missing

> When this PDF is rendered with the "f" Operator, a black screen appears.
> 
>
> Key: PDFBOX-5851
> URL: https://issues.apache.org/jira/browse/PDFBOX-5851
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: Pattern
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-07-19-16-58-35-439.png, 
> image-2024-07-19-16-58-57-515.png, image-2024-07-19-17-41-18-618.png, 
> image2-scratch_unc.pdf, image2.pdf
>
>
> [^image2.pdf]
> !image-2024-07-19-16-58-35-439.png|width=345,height=187!
> !image-2024-07-19-16-58-57-515.png|width=214,height=277!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5789) Remove release subproject

2024-07-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17866926#comment-17866926
 ] 

ASF subversion and git services commented on PDFBOX-5789:
-

Commit 1919341 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919341 ]

PDFBOX-5789: restore 2.0.30 release configuration

> Remove release subproject
> -
>
> Key: PDFBOX-5789
> URL: https://issues.apache.org/jira/browse/PDFBOX-5789
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.30, 3.0.2 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> PDFBOX-5699 introduce the new subproject "release" in order to fix some issue 
> with the SCM-URL. 
> In the hindsight it turns out to be an issue. The release project doesn't 
> include any source code and therefore is excluded from the source zip. But as 
> it is still a part of the project itself, it leads to a broken build if 
> someone uses the zip to do so.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1782#comment-1782
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919306 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919306 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1781#comment-1781
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919305 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919305 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1780#comment-1780
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919304 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919304 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17866658#comment-17866658
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 7572d876b4b8c7133c9fed39f1ac02d90d985451 in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=7572d87 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5789) Remove release subproject

2024-07-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17865571#comment-17865571
 ] 

ASF subversion and git services commented on PDFBOX-5789:
-

Commit 1919175 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919175 ]

PDFBOX-5789: fix release process

> Remove release subproject
> -
>
> Key: PDFBOX-5789
> URL: https://issues.apache.org/jira/browse/PDFBOX-5789
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.30, 3.0.2 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> PDFBOX-5699 introduce the new subproject "release" in order to fix some issue 
> with the SCM-URL. 
> In the hindsight it turns out to be an issue. The release project doesn't 
> include any source code and therefore is excluded from the source zip. But as 
> it is still a part of the project itself, it leads to a broken build if 
> someone uses the zip to do so.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5850) Add fix MNG-8180

2024-07-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17865566#comment-17865566
 ] 

ASF subversion and git services commented on PDFBOX-5850:
-

Commit 1919172 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919172 ]

PDFBOX-5850: add circumvention for MNG 8180 Maven bug, by Tamas Cservenak

> Add fix MNG-8180
> 
>
> Key: PDFBOX-5850
> URL: https://issues.apache.org/jira/browse/PDFBOX-5850
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Minor
> Fix For: 3.0.3 PDFBox, 4.0.0
>
>
> See MNG-8180, especially the remark at the end.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5850) Add fix MNG-8180

2024-07-12 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17865567#comment-17865567
 ] 

ASF subversion and git services commented on PDFBOX-5850:
-

Commit 1919173 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919173 ]

PDFBOX-5850: add circumvention for MNG 8180 Maven bug, by Tamas Cservenak

> Add fix MNG-8180
> 
>
> Key: PDFBOX-5850
> URL: https://issues.apache.org/jira/browse/PDFBOX-5850
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Minor
> Fix For: 3.0.3 PDFBox, 4.0.0
>
>
> See MNG-8180, especially the remark at the end.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5808) Add support for GSUB Lookup Type 3

2024-07-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17864700#comment-17864700
 ] 

ASF subversion and git services commented on PDFBOX-5808:
-

Commit 1919098 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919098 ]

PDFBOX-5808: add logging

> Add support for GSUB Lookup Type 3
> --
>
> Key: PDFBOX-5808
> URL: https://issues.apache.org/jira/browse/PDFBOX-5808
> Project: PDFBox
>  Issue Type: New Feature
>  Components: FontBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Fabrice Calafat
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: gsub
> Fix For: 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-04-30-14-06-16-298.png, screenshot-1.png, 
> screenshot-2.png, screenshot-3.png, screenshot-4.png, screenshot-5.png
>
>
> Add support for the lookup type 3, Alternate Substitution when handling GSUB:
> [https://learn.microsoft.com/en-us/typography/opentype/spec/gsub#AS]
> The first available substitution glyph can be used (as done in other 
> libraries)
>  
> Also, the current implementation of CompoundCharacterTokenizer doesn't 
> account for collision in ligatures
> For example, if a font supports ligatures for _att_ and {_}en{_}, the current 
> implementation will not tokenize properly for the word _attention._ This is 
> because the regex implementation doesn't allow for a proper split
>  
> I'll open a proposed implementation for the above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5808) Add support for GSUB Lookup Type 3

2024-07-10 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17864699#comment-17864699
 ] 

ASF subversion and git services commented on PDFBOX-5808:
-

Commit 1919097 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919097 ]

PDFBOX-5808: add logging

> Add support for GSUB Lookup Type 3
> --
>
> Key: PDFBOX-5808
> URL: https://issues.apache.org/jira/browse/PDFBOX-5808
> Project: PDFBox
>  Issue Type: New Feature
>  Components: FontBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Fabrice Calafat
>Assignee: Tilman Hausherr
>Priority: Major
>  Labels: gsub
> Fix For: 3.0.3 PDFBox, 4.0.0
>
> Attachments: image-2024-04-30-14-06-16-298.png, screenshot-1.png, 
> screenshot-2.png, screenshot-3.png, screenshot-4.png, screenshot-5.png
>
>
> Add support for the lookup type 3, Alternate Substitution when handling GSUB:
> [https://learn.microsoft.com/en-us/typography/opentype/spec/gsub#AS]
> The first available substitution glyph can be used (as done in other 
> libraries)
>  
> Also, the current implementation of CompoundCharacterTokenizer doesn't 
> account for collision in ligatures
> For example, if a font supports ligatures for _att_ and {_}en{_}, the current 
> implementation will not tokenize properly for the word _attention._ This is 
> because the regex implementation doesn't allow for a proper split
>  
> I'll open a proposed implementation for the above



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5789) Remove release subproject

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17864013#comment-17864013
 ] 

ASF subversion and git services commented on PDFBOX-5789:
-

Commit 1919053 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919053 ]

PDFBOX-5789: move phase of ant task to deploy

> Remove release subproject
> -
>
> Key: PDFBOX-5789
> URL: https://issues.apache.org/jira/browse/PDFBOX-5789
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.30, 3.0.2 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> PDFBOX-5699 introduce the new subproject "release" in order to fix some issue 
> with the SCM-URL. 
> In the hindsight it turns out to be an issue. The release project doesn't 
> include any source code and therefore is excluded from the source zip. But as 
> it is still a part of the project itself, it leads to a broken build if 
> someone uses the zip to do so.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5789) Remove release subproject

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863881#comment-17863881
 ] 

ASF subversion and git services commented on PDFBOX-5789:
-

Commit 1919041 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919041 ]

PDFBOX-5789: adjust path for release build

> Remove release subproject
> -
>
> Key: PDFBOX-5789
> URL: https://issues.apache.org/jira/browse/PDFBOX-5789
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.30, 3.0.2 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> PDFBOX-5699 introduce the new subproject "release" in order to fix some issue 
> with the SCM-URL. 
> In the hindsight it turns out to be an issue. The release project doesn't 
> include any source code and therefore is excluded from the source zip. But as 
> it is still a part of the project itself, it leads to a broken build if 
> someone uses the zip to do so.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5789) Remove release subproject

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863873#comment-17863873
 ] 

ASF subversion and git services commented on PDFBOX-5789:
-

Commit 1919032 from le...@apache.org in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919032 ]

PDFBOX-5789: remove release subproject

> Remove release subproject
> -
>
> Key: PDFBOX-5789
> URL: https://issues.apache.org/jira/browse/PDFBOX-5789
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 2.0.30, 3.0.2 PDFBox, 4.0.0
>Reporter: Andreas Lehmkühler
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> PDFBOX-5699 introduce the new subproject "release" in order to fix some issue 
> with the SCM-URL. 
> In the hindsight it turns out to be an issue. The release project doesn't 
> include any source code and therefore is excluded from the source zip. But as 
> it is still a part of the project itself, it leads to a broken build if 
> someone uses the zip to do so.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863760#comment-17863760
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 9fc2565315df666b0f2da18a7dafbbf959806836 in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=9fc2565 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863730#comment-17863730
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919013 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1919013 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863729#comment-17863729
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919012 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1919012 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863728#comment-17863728
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1919011 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1919011 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863571#comment-17863571
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918990 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918990 ]

PDFBOX-5660: use convenience methods

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863570#comment-17863570
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918989 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918989 ]

PDFBOX-5660: use convenience method

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-07 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863569#comment-17863569
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918988 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918988 ]

PDFBOX-5660: use convenience method

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863224#comment-17863224
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918932 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918932 ]

PDFBOX-5660: update maven enforcer configuration

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863132#comment-17863132
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918925 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918925 ]

PDFBOX-5660: improve javadoc

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863130#comment-17863130
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918923 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918923 ]

PDFBOX-5660: improve javadoc

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863131#comment-17863131
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918924 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918924 ]

PDFBOX-5660: improve javadoc

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17863115#comment-17863115
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918921 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918921 ]

PDFBOX-5660: update animal sniffer plugin, commons logging

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5848) Infinite loop processing PDF

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862968#comment-17862968
 ] 

ASF subversion and git services commented on PDFBOX-5848:
-

Commit 1918905 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918905 ]

PDFBOX-5848: remove /Parent entry for widgets because it can lead to orphan 
pages

> Infinite loop processing PDF
> 
>
> Key: PDFBOX-5848
> URL: https://issues.apache.org/jira/browse/PDFBOX-5848
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 3.0.2 PDFBox
>Reporter: Joan Fisbein
>Priority: Major
> Attachments: cbc0018b-5659-4ae3-9887-0e0a2d9a62a7.pdf, 
> screenshot-1.png
>
>
> I use PDFBox to split hundreds of PDFs per day, generally, everything works 
> flawlessly but I just received a PDF that generates an infinite loop when I 
> try to split it.
>  
> I used this Java code to reproduce it using PDFBox 3.0.2 (haven't tried other 
> versions):
> {code:java}
> private static void splitPdf(File fileToSplit) {
>   try (PDDocument document = Loader.loadPDF(fileToSplit)) {
> int documentPages = document.getNumberOfPages();
> Splitter splitter = new Splitter();
> List Pages = splitter.split(document);
> Iterator iterator = Pages.listIterator();
> while (iterator.hasNext()) {
>   PDDocument pd = iterator.next();
>   pd.save(fileToSplit.getName() + "-" + Pages.indexOf(pd) + ".pdf");
>   pd.close();
> }
>   } catch (IOException e) {
> throw new RuntimeException(e);
>   }
> } {code}
> The PDF file is attached to the issue



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5848) Infinite loop processing PDF

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862967#comment-17862967
 ] 

ASF subversion and git services commented on PDFBOX-5848:
-

Commit 1918904 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918904 ]

PDFBOX-5848: remove /Parent entry for widgets because it can lead to orphan 
pages

> Infinite loop processing PDF
> 
>
> Key: PDFBOX-5848
> URL: https://issues.apache.org/jira/browse/PDFBOX-5848
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 3.0.2 PDFBox
>Reporter: Joan Fisbein
>Priority: Major
> Attachments: cbc0018b-5659-4ae3-9887-0e0a2d9a62a7.pdf, 
> screenshot-1.png
>
>
> I use PDFBox to split hundreds of PDFs per day, generally, everything works 
> flawlessly but I just received a PDF that generates an infinite loop when I 
> try to split it.
>  
> I used this Java code to reproduce it using PDFBox 3.0.2 (haven't tried other 
> versions):
> {code:java}
> private static void splitPdf(File fileToSplit) {
>   try (PDDocument document = Loader.loadPDF(fileToSplit)) {
> int documentPages = document.getNumberOfPages();
> Splitter splitter = new Splitter();
> List Pages = splitter.split(document);
> Iterator iterator = Pages.listIterator();
> while (iterator.hasNext()) {
>   PDDocument pd = iterator.next();
>   pd.save(fileToSplit.getName() + "-" + Pages.indexOf(pd) + ".pdf");
>   pd.close();
> }
>   } catch (IOException e) {
> throw new RuntimeException(e);
>   }
> } {code}
> The PDF file is attached to the issue



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5848) Infinite loop processing PDF

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862966#comment-17862966
 ] 

ASF subversion and git services commented on PDFBOX-5848:
-

Commit 1918903 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918903 ]

PDFBOX-5848: remove /Parent entry for widgets because it can lead to orphan 
pages

> Infinite loop processing PDF
> 
>
> Key: PDFBOX-5848
> URL: https://issues.apache.org/jira/browse/PDFBOX-5848
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 3.0.2 PDFBox
>Reporter: Joan Fisbein
>Priority: Major
> Attachments: cbc0018b-5659-4ae3-9887-0e0a2d9a62a7.pdf, 
> screenshot-1.png
>
>
> I use PDFBox to split hundreds of PDFs per day, generally, everything works 
> flawlessly but I just received a PDF that generates an infinite loop when I 
> try to split it.
>  
> I used this Java code to reproduce it using PDFBox 3.0.2 (haven't tried other 
> versions):
> {code:java}
> private static void splitPdf(File fileToSplit) {
>   try (PDDocument document = Loader.loadPDF(fileToSplit)) {
> int documentPages = document.getNumberOfPages();
> Splitter splitter = new Splitter();
> List Pages = splitter.split(document);
> Iterator iterator = Pages.listIterator();
> while (iterator.hasNext()) {
>   PDDocument pd = iterator.next();
>   pd.save(fileToSplit.getName() + "-" + Pages.indexOf(pd) + ".pdf");
>   pd.close();
> }
>   } catch (IOException e) {
> throw new RuntimeException(e);
>   }
> } {code}
> The PDF file is attached to the issue



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862959#comment-17862959
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918900 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918900 ]

PDFBOX-5660: remove unneeded cast

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862960#comment-17862960
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918901 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918901 ]

PDFBOX-5660: remove unneeded cast

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-04 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862961#comment-17862961
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918902 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918902 ]

PDFBOX-5660: remove unneeded cast

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862920#comment-17862920
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918897 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918897 ]

PDFBOX-5660: fix compiler warning

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862919#comment-17862919
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918896 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918896 ]

PDFBOX-5660: fix compiler warning

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862676#comment-17862676
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit aa0bed934f3c370969aee0126f7836a91fd5e3eb in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=aa0bed9 ]

PDFBOX-5660: update owasp plugin

PDFBOX-5660: update owasp plugin

PDFBOX-5660: update owasp plugin

PDFBOX-5660: update owasp plugin


> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862652#comment-17862652
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918866 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918866 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862651#comment-17862651
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918865 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918865 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862650#comment-17862650
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918864 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918864 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862649#comment-17862649
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit b6ce7d70cc0a5c49246bae9c17db146d3c37ef5c in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=b6ce7d7 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862646#comment-17862646
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 5eb794c23ddad2c0d337635cffa1abcd243c52d0 in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=5eb794c ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862445#comment-17862445
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918844 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918844 ]

PDFBOX-5660: fix logging exception parameter type

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862437#comment-17862437
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918837 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918837 ]

PDFBOX-5660: fix logging exception parameter type

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862433#comment-17862433
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918836 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918836 ]

PDFBOX-5660: fix logging exception parameter type

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862424#comment-17862424
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918830 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918830 ]

PDFBOX-5660: fix logging exception parameter type

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17862422#comment-17862422
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918829 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918829 ]

PDFBOX-5660: fix logging exception parameter type

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861207#comment-17861207
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 7abf9d837f551b7dc133c1c57e5277b573a75dde in pdfbox-jbig2's branch 
refs/heads/master from Tilman Hausherr
[ https://gitbox.apache.org/repos/asf?p=pdfbox-jbig2.git;h=7abf9d8 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5847) Improve performance of FileSystemFontProvider.scanFonts()

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861177#comment-17861177
 ] 

ASF subversion and git services commented on PDFBOX-5847:
-

Commit 1918786 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918786 ]

PDFBOX-5847: fix log message

> Improve performance of FileSystemFontProvider.scanFonts()
> -
>
> Key: PDFBOX-5847
> URL: https://issues.apache.org/jira/browse/PDFBOX-5847
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Major
>
> PR by Mykola Bohdiuk which introduces an "only headers" mode for the font 
> parsers where each table reads as little information as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5847) Improve performance of FileSystemFontProvider.scanFonts()

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861174#comment-17861174
 ] 

ASF subversion and git services commented on PDFBOX-5847:
-

Commit 1918783 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918783 ]

PDFBOX-5847: fix log message

> Improve performance of FileSystemFontProvider.scanFonts()
> -
>
> Key: PDFBOX-5847
> URL: https://issues.apache.org/jira/browse/PDFBOX-5847
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Major
>
> PR by Mykola Bohdiuk which introduces an "only headers" mode for the font 
> parsers where each table reads as little information as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5847) Improve performance of FileSystemFontProvider.scanFonts()

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861175#comment-17861175
 ] 

ASF subversion and git services commented on PDFBOX-5847:
-

Commit 1918784 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918784 ]

PDFBOX-5847: fix log message

> Improve performance of FileSystemFontProvider.scanFonts()
> -
>
> Key: PDFBOX-5847
> URL: https://issues.apache.org/jira/browse/PDFBOX-5847
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Major
>
> PR by Mykola Bohdiuk which introduces an "only headers" mode for the font 
> parsers where each table reads as little information as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861170#comment-17861170
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918781 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918781 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861169#comment-17861169
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918780 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918780 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861150#comment-17861150
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918779 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918779 ]

PDFBOX-5660: update owasp plugin

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5847) Improve performance of FileSystemFontProvider.scanFonts()

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1786#comment-1786
 ] 

ASF subversion and git services commented on PDFBOX-5847:
-

Commit 1918774 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918774 ]

PDFBOX-5847: Improve performance of FileSystemFontProvider.scanFonts() by 
introducing an "only headers" mode for the font parsers where each table reads 
as little information as possible, by Mykola Bohdiuk

> Improve performance of FileSystemFontProvider.scanFonts()
> -
>
> Key: PDFBOX-5847
> URL: https://issues.apache.org/jira/browse/PDFBOX-5847
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Major
>
> PR by Mykola Bohdiuk which introduces an "only headers" mode for the font 
> parsers where each table reads as little information as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5847) Improve performance of FileSystemFontProvider.scanFonts()

2024-07-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17861110#comment-17861110
 ] 

ASF subversion and git services commented on PDFBOX-5847:
-

Commit 1918773 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918773 ]

PDFBOX-5847: Improve performance of FileSystemFontProvider.scanFonts() by 
introducing an "only headers" mode for the font parsers where each table reads 
as little information as possible, by Mykola Bohdiuk

> Improve performance of FileSystemFontProvider.scanFonts()
> -
>
> Key: PDFBOX-5847
> URL: https://issues.apache.org/jira/browse/PDFBOX-5847
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Priority: Major
>
> PR by Mykola Bohdiuk which introduces an "only headers" mode for the font 
> parsers where each table reads as little information as possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-06-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860693#comment-17860693
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918722 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918722 ]

PDFBOX-5660: update junit

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-06-27 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17860694#comment-17860694
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918723 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918723 ]

PDFBOX-5660: update junit

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5660) Improve code quality (5)

2024-06-19 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17856367#comment-17856367
 ] 

ASF subversion and git services commented on PDFBOX-5660:
-

Commit 1918465 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918465 ]

PDFBOX-5660: simplify

> Improve code quality (5)
> 
>
> Key: PDFBOX-5660
> URL: https://issues.apache.org/jira/browse/PDFBOX-5660
> Project: PDFBox
>  Issue Type: Improvement
>Reporter: Tilman Hausherr
>Priority: Minor
> Attachments: AnnotationSample.Standard.pdf, 
> DRY_refactoring_Typ2CharStringParser.patch, 
> Removed_the_readFully_method_in_the_PfbParser_class_and_replaced__with_calling_readAllByte.patch,
>  
> Simplify_list_and_map_operations,_use_known_size_when_creating_StringBuilder.patch,
>  Simplify_string_conversion_in_PDFHighlighter.patch, 
> Update_string_handling_and_regex_in_several_classes.patch, 
> avoid_multiple_unboxing.patch, code_cleanup.patch, 
> do_not_create_temporary_File_instance.patch, 
> extract_common_code,_move_toUpperCase()_out_of_loop.patch, 
> fix_HTML_error_in_Javadoc.patch, fix_javadoc_problems.patch, 
> introduce_COSArray_of(float___)_to_make_the_code_more_concise_and_avoid_creating_and_copyi.patch,
>  introduce_StringUtil_class_for_reusable_functionality.patch, 
> introduce_constants_COSFLOAT_ZERO_and_COSFloat_ONE_to_avoid_creating_unnecessary_instances.patch,
>  make_inner_class_static.patch, refactor_isEndOfName.patch, 
> remove_code_duplication_in_Type2CharStringParser.patch, 
> remove_obsolete_class_NullOutputStream.patch, 
> remove_unnecessary_calls_to_toString()_String_valueOf().patch, 
> replace_System_getProperty()_calls.patch, screenshot-1.png, 
> simplify_hashCode()_and_equals(),_test_name_first_because_Map_equals()_is_expensive.patch,
>  simplify_stream_operations.patch, use_Map_ofEntries().patch, 
> use_Math_min()_to_make_code_more_readable.patch, use_Objects_equals().patch, 
> use_String_isEmpty()_Collection_isEmpty()_instead_of_checking_length_size.patch,
>  use_String_join().patch, use_switch_for_readability.patch, 
> use_try-with-resources_(since_Java_9_the_variable_declaration_in_the_try_is_not_necessary_.patch
>
>
> This is a longterm issue for the task to improve code quality, by using the 
> SonarQube report, hints in different IDEs, the FindBugs tool and other code 
> quality tools.
> This is a follow-up of PDFBOX-4892, which was getting too long.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855851#comment-17855851
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918404 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918404 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855849#comment-17855849
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918402 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918402 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-18 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855850#comment-17855850
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918403 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918403 ]

PDFBOX-5842: avoid 0 scales, as suggested by Timo Boehme

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5841) First split result document misses metadata after split

2024-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855697#comment-17855697
 ] 

ASF subversion and git services commented on PDFBOX-5841:
-

Commit 1918392 from le...@apache.org in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918392 ]

PDFBOX-5841: copy COSObject instead of PDMetadata to avoid a malformed result

> First split result document misses metadata after split
> ---
>
> Key: PDFBOX-5841
> URL: https://issues.apache.org/jira/browse/PDFBOX-5841
> Project: PDFBox
>  Issue Type: Bug
>  Components: Writing
>Affects Versions: 3.0.3 PDFBox, 4.0.0
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.3 PDFBox, 4.0.0
>
> Attachments: splitresult1.pdf, splitresult2.pdf
>
>
> This happens with the test file of PDFBOX-5840 and can also be reproduced 
> with the command line utility: the first split result file doesn't have the 
> metadata.
> Alternatively it can be reproduced programmatically by adding this code below 
> {{assertEquals(5, pageTree.indexOf(pd5.getPage()));}} in 
> {code:java}
> assertNotNull(dstDoc.getDocumentCatalog().getMetadata());
> ByteArrayOutputStream baos = new ByteArrayOutputStream();
> dstDoc.save(baos);
> PDDocument reloadedDoc = Loader.loadPDF(baos.toByteArray());
> assertNotNull(reloadedDoc.getDocumentCatalog().getMetadata());
> reloadedDoc.close();
> {code}
> I believe this is another writing problem, because the metadata exists, but 
> gets lost during the first save, not during a second one (not part of the 
> test code). It is expected to be object 116. It doesn't happen with 2.0. 
> Attached: two saved files by splitting so that the entire file is the result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5841) First split result document misses metadata after split

2024-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855694#comment-17855694
 ] 

ASF subversion and git services commented on PDFBOX-5841:
-

Commit 1918391 from le...@apache.org in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918391 ]

PDFBOX-5841: copy COSObject instead of PDMetadata to avoid a malformed result

> First split result document misses metadata after split
> ---
>
> Key: PDFBOX-5841
> URL: https://issues.apache.org/jira/browse/PDFBOX-5841
> Project: PDFBox
>  Issue Type: Bug
>  Components: Writing
>Affects Versions: 3.0.3 PDFBox, 4.0.0
>Reporter: Tilman Hausherr
>Assignee: Andreas Lehmkühler
>Priority: Major
> Fix For: 3.0.3 PDFBox, 4.0.0
>
> Attachments: splitresult1.pdf, splitresult2.pdf
>
>
> This happens with the test file of PDFBOX-5840 and can also be reproduced 
> with the command line utility: the first split result file doesn't have the 
> metadata.
> Alternatively it can be reproduced programmatically by adding this code below 
> {{assertEquals(5, pageTree.indexOf(pd5.getPage()));}} in 
> {code:java}
> assertNotNull(dstDoc.getDocumentCatalog().getMetadata());
> ByteArrayOutputStream baos = new ByteArrayOutputStream();
> dstDoc.save(baos);
> PDDocument reloadedDoc = Loader.loadPDF(baos.toByteArray());
> assertNotNull(reloadedDoc.getDocumentCatalog().getMetadata());
> reloadedDoc.close();
> {code}
> I believe this is another writing problem, because the metadata exists, but 
> gets lost during the first save, not during a second one (not part of the 
> test code). It is expected to be object 116. It doesn't happen with 2.0. 
> Attached: two saved files by splitting so that the entire file is the result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855638#comment-17855638
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918388 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918388 ]

PDFBOX-5842: avoid 0 parameter to getScaledInstance()

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855639#comment-17855639
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918389 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918389 ]

PDFBOX-5842: avoid 0 parameter to getScaledInstance()

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5842) IllegalArgumentException: Width (26) and height (0) must be non-zero

2024-06-17 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855637#comment-17855637
 ] 

ASF subversion and git services commented on PDFBOX-5842:
-

Commit 1918387 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918387 ]

PDFBOX-5842: avoid 0 parameter to getScaledInstance()

> IllegalArgumentException: Width (26) and height (0) must be non-zero
> 
>
> Key: PDFBOX-5842
> URL: https://issues.apache.org/jira/browse/PDFBOX-5842
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
>
> reported by Patrycja Zaremba in the users mailing list
> https://lists.apache.org/thread/xnwcyhq2c16d9xfgqwgjs70k9qb1w8tp
> {quote}When the page which I try to convert have any element which is png with
> only 1px height (28x1, 54x1 etc.) it is scaled down to 0 and I got this{quote}
> IllegalArgumentException: Width (26) and height (0) must be non-zero
> org.apache.pdfbox.rendering.PageDrawer.drawImage(PageDrawer.java:1281)
> 
> org.apache.pdfbox.contentstream.operator.graphics.DrawObject.process(DrawObject.java:74)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5840) When splitting, keep named page destinations that are part of target document(s)

2024-06-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855210#comment-17855210
 ] 

ASF subversion and git services commented on PDFBOX-5840:
-

Commit 1918352 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918352 ]

PDFBOX-5840: fix imports

> When splitting, keep named page destinations that are part of target 
> document(s)
> 
>
> Key: PDFBOX-5840
> URL: https://issues.apache.org/jira/browse/PDFBOX-5840
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 410609.pdf, named-dest-handling abandoned code.txt
>
>
> Keep named destinations. The current code just ignores them. I wrote some 40 
> lines that would create a name tree in the destination document, but this 
> didn't work because the destination name gets modified when retrieved as a 
> string. So I just keep the actual destination and forget the name, which is a 
> single code line. It's a new document anyway and the average user expectation 
> is that the links "just work".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-2941) Improve PDFDebugger (2)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855176#comment-17855176
 ] 

ASF subversion and git services commented on PDFBOX-2941:
-

Commit 1918348 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918348 ]

PDFBOX-2941: add "/S:" for better visibility of actions

> Improve PDFDebugger (2)
> ---
>
> Key: PDFBOX-2941
> URL: https://issues.apache.org/jira/browse/PDFBOX-2941
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
> Attachments: gs-bugzilla694570.pdf, keep_zoom.diff, osx-tabs.png, 
> pdfdebugger-screenshot-reverted.png, pdfdebugger-screenshot-trunc.png, 
> screenshot_debugger_new.png, screenshot_debugger_not_aligned.png, 
> screenshot_debugger_old.png, screenshot_w7_fontsize.png, 
> separate_filter_choice_from_text_hex_views.diff, sonar_qube_resolve.diff, 
> sonar_qube_resolve_25_08.diff
>
>
> This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came 
> up in GSoC2015, ideas that were not implemented due to lack of time, and new 
> ideas.
> *Viewing*
>  - refactor PDFDebugger.java
>  - ✓ render glyphs of fonts
>  - ✓ refactor StreamPane to share stream filtering among Text view and hex 
> view
>  - ✓ password dialog when hitting protected PDF
>  - show "pretty" XML
>  - display filtered streams even if the unfiltered stream is corrupt 
> (PDFBOX-2976)
>  - ✓ display the "caused by" part exception stack trace (nested exceptions)
>  - ✓ keep zoom
>  - ✓ integrate DrawPrintTextLocations into rendering
>  - integrate area text extraction with a mouse-created rectangle that shows 
> the coordinates in a status line
>  - ✓ show permission flags of {{Encrypt/P}} entry
>  - ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 
> in PDF spec
>  - ✓ show page labels additional to page number (see file from TIKA-2121 as 
> example)
>  - ✓ "reopen" menu item (useful when editing an existing PDF to create a 
> reduced PDF)
>  - choose zoom automatically so that PDF page can be seen in full
> *Editing*
>  - save modified PDFs
>  - editing in hex viewer
>  - remove nodes (e.g. elements from a COSDictionary)
>  - delete array or dictionary elements
>  - load content streams
>  - edit & keep content streams



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-2941) Improve PDFDebugger (2)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855175#comment-17855175
 ] 

ASF subversion and git services commented on PDFBOX-2941:
-

Commit 1918347 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918347 ]

PDFBOX-2941: add "/S:" for better visibility of actions

> Improve PDFDebugger (2)
> ---
>
> Key: PDFBOX-2941
> URL: https://issues.apache.org/jira/browse/PDFBOX-2941
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
> Attachments: gs-bugzilla694570.pdf, keep_zoom.diff, osx-tabs.png, 
> pdfdebugger-screenshot-reverted.png, pdfdebugger-screenshot-trunc.png, 
> screenshot_debugger_new.png, screenshot_debugger_not_aligned.png, 
> screenshot_debugger_old.png, screenshot_w7_fontsize.png, 
> separate_filter_choice_from_text_hex_views.diff, sonar_qube_resolve.diff, 
> sonar_qube_resolve_25_08.diff
>
>
> This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came 
> up in GSoC2015, ideas that were not implemented due to lack of time, and new 
> ideas.
> *Viewing*
>  - refactor PDFDebugger.java
>  - ✓ render glyphs of fonts
>  - ✓ refactor StreamPane to share stream filtering among Text view and hex 
> view
>  - ✓ password dialog when hitting protected PDF
>  - show "pretty" XML
>  - display filtered streams even if the unfiltered stream is corrupt 
> (PDFBOX-2976)
>  - ✓ display the "caused by" part exception stack trace (nested exceptions)
>  - ✓ keep zoom
>  - ✓ integrate DrawPrintTextLocations into rendering
>  - integrate area text extraction with a mouse-created rectangle that shows 
> the coordinates in a status line
>  - ✓ show permission flags of {{Encrypt/P}} entry
>  - ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 
> in PDF spec
>  - ✓ show page labels additional to page number (see file from TIKA-2121 as 
> example)
>  - ✓ "reopen" menu item (useful when editing an existing PDF to create a 
> reduced PDF)
>  - choose zoom automatically so that PDF page can be seen in full
> *Editing*
>  - save modified PDFs
>  - editing in hex viewer
>  - remove nodes (e.g. elements from a COSDictionary)
>  - delete array or dictionary elements
>  - load content streams
>  - edit & keep content streams



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-2941) Improve PDFDebugger (2)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855174#comment-17855174
 ] 

ASF subversion and git services commented on PDFBOX-2941:
-

Commit 1918346 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918346 ]

PDFBOX-2941: add "/S:" for better visibility of actions

> Improve PDFDebugger (2)
> ---
>
> Key: PDFBOX-2941
> URL: https://issues.apache.org/jira/browse/PDFBOX-2941
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
> Attachments: gs-bugzilla694570.pdf, keep_zoom.diff, osx-tabs.png, 
> pdfdebugger-screenshot-reverted.png, pdfdebugger-screenshot-trunc.png, 
> screenshot_debugger_new.png, screenshot_debugger_not_aligned.png, 
> screenshot_debugger_old.png, screenshot_w7_fontsize.png, 
> separate_filter_choice_from_text_hex_views.diff, sonar_qube_resolve.diff, 
> sonar_qube_resolve_25_08.diff
>
>
> This is a follow-up issue to PDFBOX-2530 to implement extra ideas that came 
> up in GSoC2015, ideas that were not implemented due to lack of time, and new 
> ideas.
> *Viewing*
>  - refactor PDFDebugger.java
>  - ✓ render glyphs of fonts
>  - ✓ refactor StreamPane to share stream filtering among Text view and hex 
> view
>  - ✓ password dialog when hitting protected PDF
>  - show "pretty" XML
>  - display filtered streams even if the unfiltered stream is corrupt 
> (PDFBOX-2976)
>  - ✓ display the "caused by" part exception stack trace (nested exceptions)
>  - ✓ keep zoom
>  - ✓ integrate DrawPrintTextLocations into rendering
>  - integrate area text extraction with a mouse-created rectangle that shows 
> the coordinates in a status line
>  - ✓ show permission flags of {{Encrypt/P}} entry
>  - ✓ show signature flags of {{Root/AcroForm/SigFlags}} entry, see Table 219 
> in PDF spec
>  - ✓ show page labels additional to page number (see file from TIKA-2121 as 
> example)
>  - ✓ "reopen" menu item (useful when editing an existing PDF to create a 
> reduced PDF)
>  - choose zoom automatically so that PDF page can be seen in full
> *Editing*
>  - save modified PDFs
>  - editing in hex viewer
>  - remove nodes (e.g. elements from a COSDictionary)
>  - delete array or dictionary elements
>  - load content streams
>  - edit & keep content streams



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855083#comment-17855083
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918340 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918340 ]

PDFBOX-5835: add test with reduced file

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
> "  

[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855081#comment-17855081
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918338 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918338 ]

PDFBOX-5835: add test with reduced file

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
> "  \n" +

[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855082#comment-17855082
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918339 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918339 ]

PDFBOX-5835: add test with reduced file

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
> "  

[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855070#comment-17855070
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918336 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918336 ]

PDFBOX-5835: detect namespace declaration at two more places

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
>  

[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855071#comment-17855071
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918337 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918337 ]

PDFBOX-5835: detect namespace declaration at two more places

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
>   

[jira] [Commented] (PDFBOX-5835) DomXmpParser - IllegalArgumentException: prefix cannot be "null" when creating a QName

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855069#comment-17855069
 ] 

ASF subversion and git services commented on PDFBOX-5835:
-

Commit 1918335 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918335 ]

PDFBOX-5835: detect namespace declaration at two more places

> DomXmpParser - IllegalArgumentException: prefix cannot be "null" when 
> creating a QName
> --
>
> Key: PDFBOX-5835
> URL: https://issues.apache.org/jira/browse/PDFBOX-5835
> Project: PDFBox
>  Issue Type: Bug
>  Components: XmpBox
>Affects Versions: 3.0.2 PDFBox
>Reporter: Oliver Schmidtmer
>Priority: Major
>
> I've got a PDF from, where parsing the metadata fails with an 
> IllegalArgumentException
> {code:java}
> java.lang.IllegalArgumentException: prefix cannot be "null" when creating a 
> QName
>   at java.xml/javax.xml.namespace.QName.(QName.java:192)
>   at org.apache.xmpbox.xml.DomHelper.getQName(DomHelper.java:99)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseChildrenAsProperties(DomXmpParser.java:306)
>   at 
> org.apache.xmpbox.xml.DomXmpParser.parseDescriptionRoot(DomXmpParser.java:250)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:201)
>   at org.apache.xmpbox.xml.DomXmpParser.parse(DomXmpParser.java:112)
> {code}
> This can be reproduced with a simple test, using the extracted metadata:
> {code:java}
> @Test
> void testDomXmpParser() throws XmpParsingException
> {
> // taken from file test-landscape2.pdf
> String xmpmeta = " standalone=\"no\"?>\n" +
> " id=\"W5M0MpCehiHzreSzNTczkc9d\"?> x:xmptk=\"FIS/xee\">\n" +
> "  xmlns:rdf=\"http://www.w3.org/1999/02/22-rdf-syntax-ns#\;>\n" +
> "  xmlns:pdfaid=\"http://www.aiim.org/pdfa/ns/id/\;>\n" +
> "   3\n" +
> "   A\n" +
> "  \n" +
> "   xmlns:pdfaExtension=\"http://www.aiim.org/pdfa/ns/extension/\; 
> xmlns:pdfaField=\"http://www.aiim.org/pdfa/ns/field#\; 
> xmlns:pdfaProperty=\"http://www.aiim.org/pdfa/ns/property#\; 
> xmlns:pdfaSchema=\"http://www.aiim.org/pdfa/ns/schema#\; 
> xmlns:pdfaType=\"http://www.aiim.org/pdfa/ns/type#\; rdf:about=\"\"/>\n" +
> "  \n" +
> "xmlns=\"http://www.aiim.org/pdfa/ns/extension/\;>\n" +
> "\n" +
> " \n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>ZUGFeRD PDFA Extension 
> Schema\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>urn:ferd:pdfa:CrossIndustryDocument:invoice:1p0#\n"
>  +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>zf\n" +
> "   xmlns=\"http://www.aiim.org/pdfa/ns/schema#\;>\n" +
> "   \n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentFileName\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>name of the embedded XML 
> invoice file\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>DocumentType\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>INVOICE\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Version\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The actual version of the 
> ZUGFeRD data\n" +
> "\n" +
> "\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>ConformanceLevel\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>Text\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>external\n" +
> "  xmlns=\"http://www.aiim.org/pdfa/ns/property#\;>The conformance level of the 
> ZUGFeRD data\n" +
> "\n" +
> "   \n" +
>   

[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855060#comment-17855060
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918330 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918330 ]

PDFBOX-5839: Sonar fix

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855061#comment-17855061
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918331 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918331 ]

PDFBOX-5839: Sonar fix

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855059#comment-17855059
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918329 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918329 ]

PDFBOX-5839: Sonar fix

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Assignee: Tilman Hausherr
>Priority: Major
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5840) When splitting, keep named page destinations that are part of target document(s)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855050#comment-17855050
 ] 

ASF subversion and git services commented on PDFBOX-5840:
-

Commit 1918327 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918327 ]

PDFBOX-5840: keep and transform named page destinations that are part of target 
document

> When splitting, keep named page destinations that are part of target 
> document(s)
> 
>
> Key: PDFBOX-5840
> URL: https://issues.apache.org/jira/browse/PDFBOX-5840
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 410609.pdf, named-dest-handling abandoned code.txt
>
>
> Keep named destinations. The current code just ignores them. I wrote some 40 
> lines that would create a name tree in the destination document, but this 
> didn't work because the destination name gets modified when retrieved as a 
> string. So I just keep the actual destination and forget the name, which is a 
> single code line. It's a new document anyway and the average user expectation 
> is that the links "just work".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5840) When splitting, keep named page destinations that are part of target document(s)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855051#comment-17855051
 ] 

ASF subversion and git services commented on PDFBOX-5840:
-

Commit 1918328 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918328 ]

PDFBOX-5840: keep and transform named page destinations that are part of target 
document

> When splitting, keep named page destinations that are part of target 
> document(s)
> 
>
> Key: PDFBOX-5840
> URL: https://issues.apache.org/jira/browse/PDFBOX-5840
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 410609.pdf, named-dest-handling abandoned code.txt
>
>
> Keep named destinations. The current code just ignores them. I wrote some 40 
> lines that would create a name tree in the destination document, but this 
> didn't work because the destination name gets modified when retrieved as a 
> string. So I just keep the actual destination and forget the name, which is a 
> single code line. It's a new document anyway and the average user expectation 
> is that the links "just work".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5840) When splitting, keep named page destinations that are part of target document(s)

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855049#comment-17855049
 ] 

ASF subversion and git services commented on PDFBOX-5840:
-

Commit 1918326 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918326 ]

PDFBOX-5840: keep and transform named page destinations that are part of target 
document

> When splitting, keep named page destinations that are part of target 
> document(s)
> 
>
> Key: PDFBOX-5840
> URL: https://issues.apache.org/jira/browse/PDFBOX-5840
> Project: PDFBox
>  Issue Type: Improvement
>  Components: Utilities
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
> Fix For: 2.0.32, 3.0.3 PDFBox, 4.0.0
>
> Attachments: 410609.pdf, named-dest-handling abandoned code.txt
>
>
> Keep named destinations. The current code just ignores them. I wrote some 40 
> lines that would create a name tree in the destination document, but this 
> didn't work because the destination name gets modified when retrieved as a 
> string. So I just keep the actual destination and forget the name, which is a 
> single code line. It's a new document anyway and the average user expectation 
> is that the links "just work".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854989#comment-17854989
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918318 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918318 ]

PDFBOX-5839: avoid NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854987#comment-17854987
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918316 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918316 ]

PDFBOX-5839: avoid NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854988#comment-17854988
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918317 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918317 ]

PDFBOX-5839: avoid NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png, 
> image-2024-06-14-16-35-39-381.png, image-2024-06-14-16-39-47-557.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854970#comment-17854970
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918311 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918311 ]

PDFBOX-5839: avoid ClassCastException and NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854971#comment-17854971
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918312 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918312 ]

PDFBOX-5839: avoid ClassCastException and NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5839) ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to org.apache.pdfbox.cos.COSDictionary

2024-06-14 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854972#comment-17854972
 ] 

ASF subversion and git services commented on PDFBOX-5839:
-

Commit 1918313 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918313 ]

PDFBOX-5839: avoid ClassCastException and NPE

> ClassCastException: org.apache.pdfbox.cos.COSNull cannot be cast to 
> org.apache.pdfbox.cos.COSDictionary
> ---
>
> Key: PDFBOX-5839
> URL: https://issues.apache.org/jira/browse/PDFBOX-5839
> Project: PDFBox
>  Issue Type: Bug
>  Components: Rendering
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: liu
>Priority: Major
> Attachments: 1.pdf, 2.pdf, image-2024-06-14-15-36-01-099.png
>
>
> [^1.pdf][^2.pdf]
> ^!image-2024-06-14-15-36-01-099.png|width=395,height=214!^
> When rendering 1.pdf and 2.pdf, there will be a ClassCastException problem.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-3117) Left margin cut off when printing

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854746#comment-17854746
 ] 

ASF subversion and git services commented on PDFBOX-3117:
-

Commit 1918294 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918294 ]

PDFBOX-3117: avoid negative translation value when centering

> Left margin cut off when printing
> -
>
> Key: PDFBOX-3117
> URL: https://issues.apache.org/jira/browse/PDFBOX-3117
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.10, 1.8.11, 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
>  Labels: print, printing
> Attachments: PDFBOX-3117-1468001565.pdf, PDFBOX-3117.pdf
>
>
> This is about the margin problem when printing that was mentioned on the user 
> mailing list. What I know at this time:
> - media box is (0 0 233.29 3600)
> - used fonts: Times-Roman and ArialUnicodeMS not embedded
> Effect happens with a real printer, but not when printing to PDF or to XPS.
> First todo is to create such a file in the hope of getting the effect because 
> the file can't be shared.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-3117) Left margin cut off when printing

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854745#comment-17854745
 ] 

ASF subversion and git services commented on PDFBOX-3117:
-

Commit 1918293 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918293 ]

PDFBOX-3117: avoid negative translation value when centering

> Left margin cut off when printing
> -
>
> Key: PDFBOX-3117
> URL: https://issues.apache.org/jira/browse/PDFBOX-3117
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.10, 1.8.11, 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
>  Labels: print, printing
> Attachments: PDFBOX-3117-1468001565.pdf, PDFBOX-3117.pdf
>
>
> This is about the margin problem when printing that was mentioned on the user 
> mailing list. What I know at this time:
> - media box is (0 0 233.29 3600)
> - used fonts: Times-Roman and ArialUnicodeMS not embedded
> Effect happens with a real printer, but not when printing to PDF or to XPS.
> First todo is to create such a file in the hope of getting the effect because 
> the file can't be shared.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-3117) Left margin cut off when printing

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-3117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854747#comment-17854747
 ] 

ASF subversion and git services commented on PDFBOX-3117:
-

Commit 1918295 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918295 ]

PDFBOX-3117: avoid negative translation value when centering

> Left margin cut off when printing
> -
>
> Key: PDFBOX-3117
> URL: https://issues.apache.org/jira/browse/PDFBOX-3117
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.10, 1.8.11, 2.0.0
>Reporter: Tilman Hausherr
>Priority: Major
>  Labels: print, printing
> Attachments: PDFBOX-3117-1468001565.pdf, PDFBOX-3117.pdf
>
>
> This is about the margin problem when printing that was mentioned on the user 
> mailing list. What I know at this time:
> - media box is (0 0 233.29 3600)
> - used fonts: Times-Roman and ArialUnicodeMS not embedded
> Effect happens with a real printer, but not when printing to PDF or to XPS.
> First todo is to create such a file in the hope of getting the effect because 
> the file can't be shared.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5837) Add center constructor parameter to PDFPageable and to pdfbox-app

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854699#comment-17854699
 ] 

ASF subversion and git services commented on PDFBOX-5837:
-

Commit 1918291 from Tilman Hausherr in branch 'pdfbox/branches/3.0'
[ https://svn.apache.org/r1918291 ]

PDFBOX-5837: add noCenter option

> Add center constructor parameter to PDFPageable and to pdfbox-app
> -
>
> Key: PDFBOX-5837
> URL: https://issues.apache.org/jira/browse/PDFBOX-5837
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
>  Labels: print, printing
> Fix For: 2.0.32, 3.0.3 PDFBox
>
>
> Add optional {{center}} parameter to telescopic {{PDFPageable}} constructor 
> and pass it to {{PDFPrintable}}, and add the parameter to the comment line 
> class. This may also help with the printing of landscape labels, see also
> https://lists.apache.org/thread/oqpzf93onp3ytvgjh4hvkcdty4y4tbd3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5837) Add center constructor parameter to PDFPageable and to pdfbox-app

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854700#comment-17854700
 ] 

ASF subversion and git services commented on PDFBOX-5837:
-

Commit 1918292 from Tilman Hausherr in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1918292 ]

PDFBOX-5837: add noCenter option

> Add center constructor parameter to PDFPageable and to pdfbox-app
> -
>
> Key: PDFBOX-5837
> URL: https://issues.apache.org/jira/browse/PDFBOX-5837
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
>  Labels: print, printing
> Fix For: 2.0.32, 3.0.3 PDFBox
>
>
> Add optional {{center}} parameter to telescopic {{PDFPageable}} constructor 
> and pass it to {{PDFPrintable}}, and add the parameter to the comment line 
> class. This may also help with the printing of landscape labels, see also
> https://lists.apache.org/thread/oqpzf93onp3ytvgjh4hvkcdty4y4tbd3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



[jira] [Commented] (PDFBOX-5837) Add center constructor parameter to PDFPageable and to pdfbox-app

2024-06-13 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/PDFBOX-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854698#comment-17854698
 ] 

ASF subversion and git services commented on PDFBOX-5837:
-

Commit 1918290 from Tilman Hausherr in branch 'pdfbox/branches/2.0'
[ https://svn.apache.org/r1918290 ]

PDFBOX-5837: add noCenter option

> Add center constructor parameter to PDFPageable and to pdfbox-app
> -
>
> Key: PDFBOX-5837
> URL: https://issues.apache.org/jira/browse/PDFBOX-5837
> Project: PDFBox
>  Issue Type: Improvement
>Affects Versions: 2.0.31, 3.0.2 PDFBox
>Reporter: Tilman Hausherr
>Assignee: Tilman Hausherr
>Priority: Minor
>  Labels: print, printing
> Fix For: 2.0.32, 3.0.3 PDFBox
>
>
> Add optional {{center}} parameter to telescopic {{PDFPageable}} constructor 
> and pass it to {{PDFPrintable}}, and add the parameter to the comment line 
> class. This may also help with the printing of landscape labels, see also
> https://lists.apache.org/thread/oqpzf93onp3ytvgjh4hvkcdty4y4tbd3



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org



  1   2   3   4   5   6   7   8   9   10   >