[jira] [Commented] (PDFBOX-2054) Remove System.out.println()

2014-05-03 Thread Tilman Hausherr (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988749#comment-13988749
 ] 

Tilman Hausherr commented on PDFBOX-2054:
-

Committed a second round in rev 1592251 for the trunk and rev 1592252 for the 
1.8 branch.

> Remove System.out.println()
> ---
>
> Key: PDFBOX-2054
> URL: https://issues.apache.org/jira/browse/PDFBOX-2054
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>Reporter: Hong-Thai Nguyen
>Assignee: Tilman Hausherr
>Priority: Minor
>
> For example at GlyfSimpleDescript.java
> {code}
> ...
> catch (ArrayIndexOutOfBoundsException e)
> {
> System.out.println("error: array index out of bounds");
> }
> {code}
> and also 'printStackTrace' like in PageDrawer.java:
> {code}
> ...
> catch( IOException io )
> {
> io.printStackTrace();
> }
> {code}
> Should forward exception or keep silence.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PDFBOX-2054) Remove System.out.println()

2014-05-02 Thread Tilman Hausherr (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988598#comment-13988598
 ] 

Tilman Hausherr commented on PDFBOX-2054:
-

Committed a first round in rev 1592153 for the trunk and rev 1592155 for the 
1.8 branch.

> Remove System.out.println()
> ---
>
> Key: PDFBOX-2054
> URL: https://issues.apache.org/jira/browse/PDFBOX-2054
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>Reporter: Hong-Thai Nguyen
>Assignee: Tilman Hausherr
>Priority: Minor
>
> For example at GlyfSimpleDescript.java
> {code}
> ...
> catch (ArrayIndexOutOfBoundsException e)
> {
> System.out.println("error: array index out of bounds");
> }
> {code}
> and also 'printStackTrace' like in PageDrawer.java:
> {code}
> ...
> catch( IOException io )
> {
> io.printStackTrace();
> }
> {code}
> Should forward exception or keep silence.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PDFBOX-2054) Remove System.out.println()

2014-05-02 Thread Tilman Hausherr (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988311#comment-13988311
 ] 

Tilman Hausherr commented on PDFBOX-2054:
-

You can use 
{noformat}
  {code}
   ...
  {code}
{noformat}
for such text, but I got your point. I will replace these (and maybe others) 
with calls to the logging system.

> Remove System.out.println()
> ---
>
> Key: PDFBOX-2054
> URL: https://issues.apache.org/jira/browse/PDFBOX-2054
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>Reporter: Hong-Thai Nguyen
>Assignee: Tilman Hausherr
>Priority: Minor
>
> For example at GlyfSimpleDescript.java
> {code}
> ...
> catch (ArrayIndexOutOfBoundsException e)
> {
> System.out.println("error: array index out of bounds");
> }
> {code}
> and also 'printStackTrace' like in PageDrawer.java:
> {code}
> ...
> catch( IOException io )
> {
> io.printStackTrace();
> }
> {code}
> Should forward exception or keep silence.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PDFBOX-2054) Remove System.out.println()

2014-05-02 Thread Hong-Thai Nguyen (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987830#comment-13987830
 ] 

Hong-Thai Nguyen commented on PDFBOX-2054:
--

Yes, we use PDFbox via Tika in many connectors. We direct out & err separately 
in logs files, and log4j in other file with something like this:
java -Dlog4j.configuration=file:log4j.properties -cp CP_PATH runClass  
^>%LOG_FOLDER%\out.txt 2^>%LOG_FOLDER%\err.txt

Normally, we expect that all log must be group in log4j (with configuration on 
logger, level ...), out.txt and err.txt are reserved for something else.

Otherwise, printStackTrace() & out.println() mentions nothing about date/time 
and more less controllable.


> Remove System.out.println()
> ---
>
> Key: PDFBOX-2054
> URL: https://issues.apache.org/jira/browse/PDFBOX-2054
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>Reporter: Hong-Thai Nguyen
>Priority: Minor
>
> For example at GlyfSimpleDescript.java
> {code}
> ...
> catch (ArrayIndexOutOfBoundsException e)
> {
> System.out.println("error: array index out of bounds");
> }
> {code}
> and also 'printStackTrace' like in PageDrawer.java:
> {code}
> ...
> catch( IOException io )
> {
> io.printStackTrace();
> }
> {code}
> Should forward exception or keep silence.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PDFBOX-2054) Remove System.out.println()

2014-05-02 Thread Tilman Hausherr (JIRA) 

[ 
https://issues.apache.org/jira/browse/PDFBOX-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987819#comment-13987819
 ] 

Tilman Hausherr commented on PDFBOX-2054:
-

Do you have a file or an application that produces this exception? I will 
remove the println and replace it with logging (which can be kept silent), but 
at this time I would not yet change the handling by rethrowing the exception.

> Remove System.out.println()
> ---
>
> Key: PDFBOX-2054
> URL: https://issues.apache.org/jira/browse/PDFBOX-2054
> Project: PDFBox
>  Issue Type: Bug
>Affects Versions: 1.8.4, 1.8.5, 1.8.6, 2.0.0
>Reporter: Hong-Thai Nguyen
>Priority: Minor
>
> For example at GlyfSimpleDescript.java
> {code}
> ...
> catch (ArrayIndexOutOfBoundsException e)
> {
> System.out.println("error: array index out of bounds");
> }
> {code}
> and also 'printStackTrace' like in PageDrawer.java:
> {code}
> ...
> catch( IOException io )
> {
> io.printStackTrace();
> }
> {code}
> Should forward exception or keep silence.



--
This message was sent by Atlassian JIRA
(v6.2#6252)