[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[ https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726653#comment-16726653 ] Andreas Lehmkühler commented on PDFBOX-3184: [~gau...@ainosoft.com] There is no new conclusion. My last comment is nearly 3 years old and it was fixed at the same time, see the SVN comment just above my last one. Saying that IMHO there isn't any reason for reopening this ticket or better creating a new new one. > Throwing in PDType1Font.encode for chars above 255 is wrong. > > > Key: PDFBOX-3184 > URL: https://issues.apache.org/jira/browse/PDFBOX-3184 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.0 >Reporter: Maaartinus >Assignee: Andreas Lehmkühler >Priority: Major > Fix For: 2.0.0 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Chars like `'\u2019'` can be handled by the code following the test, so > throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See > [http://stackoverflow.com/a/34598915/581205] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[ https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726645#comment-16726645 ] Debasish commented on PDFBOX-3184: -- [~lehmi] shoul this issue be reopened in light of your new conclusion ? > Throwing in PDType1Font.encode for chars above 255 is wrong. > > > Key: PDFBOX-3184 > URL: https://issues.apache.org/jira/browse/PDFBOX-3184 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.0 >Reporter: Maaartinus >Assignee: Andreas Lehmkühler >Priority: Major > Fix For: 2.0.0 > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Chars like `'\u2019'` can be handled by the code following the test, so > throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See > [http://stackoverflow.com/a/34598915/581205] -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[
https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090661#comment-15090661
]
Andreas Lehmkühler commented on PDFBOX-3184:
I've doublechecked the given use case and came to the conclusion that the range
check is wrong.
We were comparing apples and oranges. PDFont#encode expects unicode code points
and the range check valid for encoding specific codes (in this case
WinAnsiEncoding). This works for a lot of character but not for all
{quote}
"bullet" maps to \u+2022 (unicode) and \u+0095 (WinAnsiEncoding)
{quote}
Furthermore the first test isn't necessary at all as a second one follows. The
codepoint is tranfered to a name using GlyphList and if the name isn't valid
for the given encoding an IllegalArgumentExcpetion is thrown.
> Throwing in PDType1Font.encode for chars above 255 is wrong.
>
>
> Key: PDFBOX-3184
> URL: https://issues.apache.org/jira/browse/PDFBOX-3184
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
>Affects Versions: 2.0.0
>Reporter: Maaartinus
>Assignee: Andreas Lehmkühler
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Chars like `'\u2019'` can be handled by the code following the test, so
> throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See
> [http://stackoverflow.com/a/34598915/581205]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[ https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090658#comment-15090658 ] ASF subversion and git services commented on PDFBOX-3184: - Commit 1723858 from [~lehmi] in branch 'pdfbox/trunk' [ https://svn.apache.org/r1723858 ] PDFBOX-3184: remove wrong range check > Throwing in PDType1Font.encode for chars above 255 is wrong. > > > Key: PDFBOX-3184 > URL: https://issues.apache.org/jira/browse/PDFBOX-3184 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.0 >Reporter: Maaartinus >Assignee: Andreas Lehmkühler > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Chars like `'\u2019'` can be handled by the code following the test, so > throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See > [http://stackoverflow.com/a/34598915/581205] -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[
https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085732#comment-15085732
]
Andreas Lehmkühler commented on PDFBOX-3184:
You are using one of the 14 standard fonts and their encoding is limited to 8
bit codes
{quote}
Can't encode U+2019 in font Helvetica. Type 1 fonts only support 8-bit code
points
{quote}
You have to follow the WinAnsiEncoding as described in the PDF spec. Use U+0092
instead of U+2019 and everything should work fine.
Alternatively you can embbed a font using PDType0Font, which supports unicode
encoding (as long as the used fonts supports the characters you are using)
> Throwing in PDType1Font.encode for chars above 255 is wrong.
>
>
> Key: PDFBOX-3184
> URL: https://issues.apache.org/jira/browse/PDFBOX-3184
> Project: PDFBox
> Issue Type: Bug
> Components: PDModel
>Affects Versions: 2.0.0
>Reporter: Maaartinus
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Chars like `'\u2019'` can be handled by the code following the test, so
> throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See
> [http://stackoverflow.com/a/34598915/581205]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org
For additional commands, e-mail: dev-h...@pdfbox.apache.org
[jira] [Commented] (PDFBOX-3184) Throwing in PDType1Font.encode for chars above 255 is wrong.
[ https://issues.apache.org/jira/browse/PDFBOX-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085778#comment-15085778 ] Maaartinus commented on PDFBOX-3184: So you're saying it's not a bug? I'm a real n00b here, feel free to close this issue if you're sure it works correctly. > Throwing in PDType1Font.encode for chars above 255 is wrong. > > > Key: PDFBOX-3184 > URL: https://issues.apache.org/jira/browse/PDFBOX-3184 > Project: PDFBox > Issue Type: Bug > Components: PDModel >Affects Versions: 2.0.0 >Reporter: Maaartinus > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Chars like `'\u2019'` can be handled by the code following the test, so > throwing in `PDType1Font.encode` whenever `unicode > 0xff` is wrong. See > [http://stackoverflow.com/a/34598915/581205] -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@pdfbox.apache.org For additional commands, e-mail: dev-h...@pdfbox.apache.org
