[jira] [Commented] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164161#comment-16164161 ] Hudson commented on PHOENIX-4205: - SUCCESS: Integrated in Jenkins build Phoenix-master #1793 (See [https://builds.apache.org/job/Phoenix-master/1793/]) PHOENIX-4205 Modify OutOfOrderMutationsIT to not use CURRENT_SCN (jamestaylor: rev 33b12c789e5c24cbf4d711006e4b8c41e9393a78) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/OutOfOrderMutationsIT.java > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Test >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4205.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164162#comment-16164162 ] Hudson commented on PHOENIX-4169: - SUCCESS: Integrated in Jenkins build Phoenix-master #1793 (See [https://builds.apache.org/job/Phoenix-master/1793/]) PHOENIX-4169 Explicitly cap timeout for index disable RPC on compaction (jamestaylor: rev 2e5986a76aa171a62b342a46cc984a00a3a36746) * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/Indexer.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.0.98.v4.patch, > PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch, > PHOENIX-4169.master.v3.patch, PHOENIX-4169.master.v4.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4185) Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164163#comment-16164163 ] Hudson commented on PHOENIX-4185: - SUCCESS: Integrated in Jenkins build Phoenix-master #1793 (See [https://builds.apache.org/job/Phoenix-master/1793/]) PHOENIX-4185 Rewrite tests to disable DDL and DML for PercentileIT.java (jamestaylor: rev 586cdab9f82661a40fa12be881b6adfed034b09c) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java * (edit) .gitignore * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java > Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN > > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Fix For: 4.12.0 > > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3111) Possible Deadlock/delay while building index, upsert select, delete rows at server
[
https://issues.apache.org/jira/browse/PHOENIX-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164130#comment-16164130
]
Lars Hofhansl commented on PHOENIX-3111:
Warming up the discussion on this old issue.
What prevents a steady stream of write with local index updates or constant
stream of UPSERT SELECT from delaying a region split forever?
Perhaps I am overly cautious. Just that starving out a necessary split possibly
forever can be ... bad.
> Possible Deadlock/delay while building index, upsert select, delete rows at
> server
> --
>
> Key: PHOENIX-3111
> URL: https://issues.apache.org/jira/browse/PHOENIX-3111
> Project: Phoenix
> Issue Type: Bug
>Reporter: Sergio Peleato
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Fix For: 4.8.0
>
> Attachments: PHOENIX-3111_addendum.patch, PHOENIX-3111.patch,
> PHOENIX-3111_v2.patch
>
>
> There is a possible deadlock while building local index or running upsert
> select, delete at server. The situation might happen in this case.
> In the above queries we scan mutations from table and write back to same
> table in that case there is a chance of memstore might reach the threshold of
> blocking memstore size then RegionTooBusyException might be thrown back to
> client and queries might retry scanning.
> Let's suppose if we take a local index build index case we first scan from
> the data table and prepare index mutations and write back to same table.
> So there is chance of memstore full as well in that case we try to flush the
> region. But if the split happen in between then split might be waiting for
> write lock on the region to close and flush wait for readlock because the
> write lock in the queue until the local index build completed. Local index
> build won't complete because we are not allowed to write until there is
> flush. This might not be complete deadlock situation but the queries might
> take lot of time to complete in this cases.
> {noformat}
> "regionserver//192.168.0.53:16201-splits-1469165876186" #269 prio=5
> os_prio=31 tid=0x7f7fb2050800 nid=0x1c033 waiting on condition
> [0x000139b68000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0006ede72550> (a
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
> at
> java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:943)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1422)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1370)
> - locked <0x0006ede69d00> (a java.lang.Object)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.stepsBeforePONR(SplitTransactionImpl.java:394)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.createDaughters(SplitTransactionImpl.java:278)
> at
> org.apache.hadoop.hbase.regionserver.SplitTransactionImpl.execute(SplitTransactionImpl.java:561)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.doSplitting(SplitRequest.java:82)
> at
> org.apache.hadoop.hbase.regionserver.SplitRequest.run(SplitRequest.java:154)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
>Locked ownable synchronizers:
> - <0x0006ee132098> (a
> java.util.concurrent.ThreadPoolExecutor$Worker)
> {noformat}
> {noformat}
> "MemStoreFlusher.0" #170 prio=5 os_prio=31 tid=0x7f7fb6842000 nid=0x19303
> waiting on condition [0x0001388e9000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0x0006ede72550> (a
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
> at
>
[jira] [Commented] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164049#comment-16164049 ] Hudson commented on PHOENIX-4201: - SUCCESS: Integrated in Jenkins build Phoenix-master #1792 (See [https://builds.apache.org/job/Phoenix-master/1792/]) PHOENIX-4201 Addendum to clear cache in deleteMetadata (samarth: rev b53de204104bbd0262ed8fd7e0341f147698f1f1) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201_addendum.patch, PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164050#comment-16164050 ] Hudson commented on PHOENIX-4191: - SUCCESS: Integrated in Jenkins build Phoenix-master #1792 (See [https://builds.apache.org/job/Phoenix-master/1792/]) PHOENIX-4191 Categorize uncategorized integration tests (elserj: rev d9ac3f109b86d70a3ec8f5e82175f03343be10d0) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolIT.java * (edit) phoenix-hive/src/it/java/org/apache/phoenix/hive/BaseHivePhoenixStoreIT.java * (add) phoenix-core/src/test/java/org/apache/hadoop/hbase/regionserver/wal/ReadWriteKeyValuesWithCodecTest.java * (delete) phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/ReadWriteKeyValuesWithCodecIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablePermissionsIT.java * (edit) phoenix-hive/src/it/java/org/apache/phoenix/hive/HivePhoenixStoreIT.java > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch, > PHOENIX-4191.003.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[
https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163980#comment-16163980
]
Hadoop QA commented on PHOENIX-4169:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886739/PHOENIX-4169.master.v4.patch
against master branch at commit b53de204104bbd0262ed8fd7e0341f147698f1f1.
ATTACHMENT ID: 12886739
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+logger.info("Major compaction running
while index on table is disabled. Clearing index disable timestamp: " +
tableName);
+ PhoenixConnection conn =
QueryUtil.getConnectionOnServer(compactionConfig).unwrap(PhoenixConnection.class);
+ LOG.info("Major compaction running while
index on table is disabled. Clearing index disable timestamp: " +
fullTableName);
+public static final String METADATA_WRITE_RETRIES_NUMBER =
"phoenix.metadata.rpc.retries.number";
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1431//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1431//console
This message is automatically generated.
> Explicitly cap timeout for index disable RPC on compaction
> --
>
> Key: PHOENIX-4169
> URL: https://issues.apache.org/jira/browse/PHOENIX-4169
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.12.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Critical
> Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch,
> PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.0.98.v4.patch,
> PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch,
> PHOENIX-4169.master.v3.patch, PHOENIX-4169.master.v4.patch
>
>
> In PHOENIX-3953 we're marking the mutable global index as disabled with an
> index_disable_timestamp of 0 from the compaction hook.This is a potentially a
> server-server RPC, and HConnectionManager#setServerSideHConnectionRetries
> makes it such that the HBase client config on the server side has 10 times
> the number of retries, lasting hours.
> To avoid a hung coprocessor hook, we should explicitly cap the number of
> retries here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor resolved PHOENIX-4205. --- Resolution: Fixed > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Test >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4205.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4205: -- Issue Type: Test (was: Bug) > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Test >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4205.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4185: -- Summary: Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN (was: Convert ) > Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN > > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Fix For: 4.12.0 > > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4185: -- Fix Version/s: 4.12.0 > Convert PercentileIT and ProductMetricsIT to not use CURRENT_SCN > > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Fix For: 4.12.0 > > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) Convert
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4185: -- Summary: Convert (was: converting tests for disable DDL/DML for 4.12) > Convert > > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Fix For: 4.12.0 > > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4185: -- Description: converting tests for disable DDL/DML for 4.12. Disallow customized SCN timestamp assignment ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java was: converting tests for disable DDL/DML for 4.12. Disallow customized SCN timestamp assignment ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java > converting tests for disable DDL/DML for 4.12 > - > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[
https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163905#comment-16163905
]
Hadoop QA commented on PHOENIX-4185:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886721/PHOENIX-4185-v1.patch
against master branch at commit 790e8d4d2b84a0e234609b2d8420e3ff398f0dee.
ATTACHMENT ID: 12886721
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+String query = "SELECT PERCENTILE_DISC(0.9) WITHIN GROUP (ORDER BY
A_INTEGER ASC) FROM " + tableName;
+String query = "SELECT PERCENTILE_DISC(0.9) WITHIN GROUP (ORDER BY
A_INTEGER DESC) FROM " + tableName;
+private static void initTableValues(String tablename, String tenantId,
byte[][] splits) throws Exception {
+protected static void initTableValues(String tablename, Connection conn,
String tenantId) throws Exception {
+private static void initDateTableValues(String tablename, String tenantId,
byte[][] splits, Date startDate) throws Exception {
+private static void initDateTableValues(String tablename, String tenantId,
byte[][] splits, Date startDate, double dateIncrement) throws Exception {
+private static void initDateTableValues(String tablename, Connection conn,
String tenantId, Date startDate, double dateIncrement) throws Exception {
+String query = "SELECT count(1), feature f FROM "+tablename+" WHERE
organization_id=? AND \"DATE\" >= to_date(?) AND \"DATE\" <= to_date(?) GROUP
BY f";
+String query = "SELECT \"DATE\" FROM "+tablename+" WHERE
organization_id=? AND unique_users >= 30 AND transactions >= 300 AND
cpu_utilization > 2 AND db_utilization > 0.5 AND io_time = 4000";
+String query = "SELECT \"DATE\" FROM "+tablename+" WHERE
organization_id=? AND (transactions = 1 OR unset_column = 5 OR io_time =
4000)";
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.activemq.artemis.tests.integration.client.LargeMessageTest.testDLAOnExpiry(LargeMessageTest.java:730)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1430//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1430//console
This message is automatically generated.
> converting tests for disable DDL/DML for 4.12
> -
>
> Key: PHOENIX-4185
> URL: https://issues.apache.org/jira/browse/PHOENIX-4185
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.12.0
>Reporter: Ethan Wang
>Assignee: Ethan Wang
> Attachments: PHOENIX-4185-v1.patch
>
>
> converting tests for disable DDL/DML for 4.12. Disallow customized SCN
> timestamp assignment
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163893#comment-16163893 ] James Taylor commented on PHOENIX-4169: --- +1. Thanks, [~vincentpoon]. > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.0.98.v4.patch, > PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch, > PHOENIX-4169.master.v3.patch, PHOENIX-4169.master.v4.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163891#comment-16163891 ] Samarth Jain commented on PHOENIX-4205: --- +1, looks good > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4205.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163889#comment-16163889 ] Hudson commented on PHOENIX-4201: - SUCCESS: Integrated in Jenkins build Phoenix-master #1791 (See [https://builds.apache.org/job/Phoenix-master/1791/]) PHOENIX-4201 Remove usage of SCN from QueryDatabaseMetadataIT (samarth: rev 790e8d4d2b84a0e234609b2d8420e3ff398f0dee) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201_addendum.patch, PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4205: -- Attachment: PHOENIX-4205.patch Please review, [~samarthjain]. I've removed the unit tests for out of order mutations since that can no longer happen, but kept the ones where the timestamp is the same. I'm not sure that can happen either, but we can leave the tests there for now. > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4205.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4205: -- Fix Version/s: 4.12.0 > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > Fix For: 4.12.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
James Taylor created PHOENIX-4205: - Summary: Modify OutOfOrderMutationsIT to not use CURRENT_SCN Key: PHOENIX-4205 URL: https://issues.apache.org/jira/browse/PHOENIX-4205 Project: Phoenix Issue Type: Bug Reporter: James Taylor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (PHOENIX-4205) Modify OutOfOrderMutationsIT to not use CURRENT_SCN
[ https://issues.apache.org/jira/browse/PHOENIX-4205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor reassigned PHOENIX-4205: - Assignee: James Taylor > Modify OutOfOrderMutationsIT to not use CURRENT_SCN > --- > > Key: PHOENIX-4205 > URL: https://issues.apache.org/jira/browse/PHOENIX-4205 > Project: Phoenix > Issue Type: Bug >Reporter: James Taylor >Assignee: James Taylor > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163873#comment-16163873 ] James Taylor commented on PHOENIX-4204: --- +1. Thanks, [~mujtabachohan]! > Modify SequenceBulkAllocationIT.java to not use currentSCN > -- > > Key: PHOENIX-4204 > URL: https://issues.apache.org/jira/browse/PHOENIX-4204 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan >Assignee: Mujtaba Chohan > Attachments: PHOENIX-4204.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan updated PHOENIX-4204: Attachment: PHOENIX-4204.patch > Modify SequenceBulkAllocationIT.java to not use currentSCN > -- > > Key: PHOENIX-4204 > URL: https://issues.apache.org/jira/browse/PHOENIX-4204 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan > Attachments: PHOENIX-4204.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan reassigned PHOENIX-4204: --- Assignee: Mujtaba Chohan > Modify SequenceBulkAllocationIT.java to not use currentSCN > -- > > Key: PHOENIX-4204 > URL: https://issues.apache.org/jira/browse/PHOENIX-4204 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan >Assignee: Mujtaba Chohan > Attachments: PHOENIX-4204.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4204) Modify SequenceBulkAllocationIT.java to not use currentSCN
Mujtaba Chohan created PHOENIX-4204: --- Summary: Modify SequenceBulkAllocationIT.java to not use currentSCN Key: PHOENIX-4204 URL: https://issues.apache.org/jira/browse/PHOENIX-4204 Project: Phoenix Issue Type: Test Reporter: Mujtaba Chohan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4203) GuidePost cache should be a singleton
Samarth Jain created PHOENIX-4203: - Summary: GuidePost cache should be a singleton Key: PHOENIX-4203 URL: https://issues.apache.org/jira/browse/PHOENIX-4203 Project: Phoenix Issue Type: Bug Reporter: Samarth Jain Currently, there is a guide post cache for every instance of ConnectionQueryServicesImpl. If a user has multiple connection profiles, then we will end up having one instance of guide post cache per such profile. This is not optimal since guide post cache is meant to be shared across the Phoenix JDBC driver. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4203) GuidePost cache should be a singleton
[ https://issues.apache.org/jira/browse/PHOENIX-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4203: -- Description: Currently, there is a guide post cache for every instance of ConnectionQueryServicesImpl. If a user has multiple connection profiles, then we will end up having one instance of guide post cache per such profile. This is a bit wasteful since guide post cache is meant to be shared across the Phoenix JDBC driver. (was: Currently, there is a guide post cache for every instance of ConnectionQueryServicesImpl. If a user has multiple connection profiles, then we will end up having one instance of guide post cache per such profile. This is not optimal since guide post cache is meant to be shared across the Phoenix JDBC driver.) > GuidePost cache should be a singleton > - > > Key: PHOENIX-4203 > URL: https://issues.apache.org/jira/browse/PHOENIX-4203 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain > > Currently, there is a guide post cache for every instance of > ConnectionQueryServicesImpl. If a user has multiple connection profiles, then > we will end up having one instance of guide post cache per such profile. This > is a bit wasteful since guide post cache is meant to be shared across the > Phoenix JDBC driver. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables
[ https://issues.apache.org/jira/browse/PHOENIX-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163805#comment-16163805 ] Thomas D'Silva commented on PHOENIX-4198: - If a user has read access to a base table, will they be able to create a view? Or will the user need CREATE access on the namespace? Any thoughts on if we should be doing something similar for SequenceRegionObserver, currently users need write access to SYSTEM.SEQUENCE in order to use sequences. > Remove the need for users to have access to the Phoenix SYSTEM tables to > create tables > -- > > Key: PHOENIX-4198 > URL: https://issues.apache.org/jira/browse/PHOENIX-4198 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Labels: namespaces > Fix For: 4.12.0 > > Attachments: PHOENIX-4198.patch > > > Problem statement:- > A user who doesn't have access to a table should also not be able to modify > Phoenix Metadata. Currently, every user required to have a write permission > to SYSTEM tables which is a security concern as they can > create/alter/drop/corrupt meta data of any other table without proper access > to the corresponding physical tables. > [~devaraj] recommended a solution as below. > 1. A coprocessor endpoint would be implemented and all write accesses to the > catalog table would have to necessarily go through that. The 'hbase' user > would own that table. Today, there is MetaDataEndpointImpl that's run on the > RS where the catalog is hosted, and that could be enhanced to serve the > purpose we need. > 2. The regionserver hosting the catalog table would do the needful for all > catalog updates - creating the mutations as needed, that is. > 3. The coprocessor endpoint could use Ranger to do necessary authorization > checks before updating the catalog table. So for example, if a user doesn't > have authorization to create a table in a certain namespace, or update the > schema, etc., it can reject such requests outright. Only after successful > validations, does it perform the operations (physical operations to do with > creating the table, and updating the catalog table with the necessary > mutations). > 4. In essence, the code that implements dealing with DDLs, would be hosted in > the catalog table endpoint. The client code would be really thin, and it > would just invoke the endpoint with the necessary info. The additional thing > that needs to be done in the endpoint is the validation of authorization to > prevent unauthorized users from making changes to someone else's > tables/schemas/etc. For example, one should be able to create a view on a > table if he has read access on the base table. That mutation on the catalog > table would be permitted. For changing the schema (adding a new column for > example), the said user would need write permission on the table... etc etc. > Thanks [~elserj] for the write-up. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4202) Clear client side cache in ConnectionQueryServicesImpl#clearCache()
[ https://issues.apache.org/jira/browse/PHOENIX-4202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4202: -- Attachment: PHOENIX-4202.patch [~jamestaylor], please review. > Clear client side cache in ConnectionQueryServicesImpl#clearCache() > --- > > Key: PHOENIX-4202 > URL: https://issues.apache.org/jira/browse/PHOENIX-4202 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4202.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163783#comment-16163783 ] James Taylor commented on PHOENIX-4191: --- +1. Thanks, [~elserj]. > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch, > PHOENIX-4191.003.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4169: -- Attachment: PHOENIX-4169.master.v4.patch PHOENIX-4169.0.98.v4.patch [~jamestaylor] updated patch with Indexer changes as well. I created a separate config with separate timeouts because writes to update the index state should have longer timeouts than normal index updates (which are shorter). > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.0.98.v4.patch, > PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch, > PHOENIX-4169.master.v3.patch, PHOENIX-4169.master.v4.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated PHOENIX-4191: Attachment: PHOENIX-4191.003.patch .003 Removes the warbucks-plugin use and just categorizes the offending tests. > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch, > PHOENIX-4191.003.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163775#comment-16163775 ] Josh Elser commented on PHOENIX-4191: - Alright, fair enough. Let me try to turn this around quickly. > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
[
https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163773#comment-16163773
]
Josh Elser commented on PHOENIX-3757:
-
[~tdsilva], it's fallen off my immediate radar. Feel free to snipe it if you
have the cycles :)
> System mutex table not being created in SYSTEM namespace when namespace
> mapping is enabled
> --
>
> Key: PHOENIX-3757
> URL: https://issues.apache.org/jira/browse/PHOENIX-3757
> Project: Phoenix
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Labels: namespaces
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3757.001.patch, PHOENIX-3757.002.patch
>
>
> Noticed this issue while writing a test for PHOENIX-3756:
> The SYSTEM.MUTEX table is always created in the default namespace, even when
> {{phoenix.schema.isNamespaceMappingEnabled=true}}. At a glance, it looks like
> the logic for the other system tables isn't applied to the mutex table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (PHOENIX-4202) Clear client side cache in ConnectionQueryServicesImpl#clearCache()
Samarth Jain created PHOENIX-4202: - Summary: Clear client side cache in ConnectionQueryServicesImpl#clearCache() Key: PHOENIX-4202 URL: https://issues.apache.org/jira/browse/PHOENIX-4202 Project: Phoenix Issue Type: Bug Reporter: Samarth Jain Assignee: Samarth Jain -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[
https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163764#comment-16163764
]
James Taylor commented on PHOENIX-4201:
---
One more thing is I don't see the client-side cache being cleared from
ConnectionQueryServicesImpl.clearCache(). I think it probably should be. You
can do that with this code snippet:
{code}
this.latestMetaData = newEmptyMetaData();
{code}
> Remove usage of SCN from QueryDatabaseMetadataIT
>
>
> Key: PHOENIX-4201
> URL: https://issues.apache.org/jira/browse/PHOENIX-4201
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4201_addendum.patch, PHOENIX-4201.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled
[
https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163755#comment-16163755
]
Thomas D'Silva commented on PHOENIX-3757:
-
[~elserj]
Are you still working on this?
> System mutex table not being created in SYSTEM namespace when namespace
> mapping is enabled
> --
>
> Key: PHOENIX-3757
> URL: https://issues.apache.org/jira/browse/PHOENIX-3757
> Project: Phoenix
> Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Labels: namespaces
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3757.001.patch, PHOENIX-3757.002.patch
>
>
> Noticed this issue while writing a test for PHOENIX-3756:
> The SYSTEM.MUTEX table is always created in the default namespace, even when
> {{phoenix.schema.isNamespaceMappingEnabled=true}}. At a glance, it looks like
> the logic for the other system tables isn't applied to the mutex table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[
https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163751#comment-16163751
]
James Taylor commented on PHOENIX-4201:
---
Thanks for fixing, [~samarthjain]. FYI, an empty string is null in Phoenix, so
a clause such as {{TABLE_SCHEM = ''}} will never match anything (since null =
is always false). So this query could simply be:
{code}
DELETE FROM SYSTEM.CATALOG WHERE TABLE_SCHEM IS NULL OR TABLE_SCHEM != 'SYSTEM'
{code}
> Remove usage of SCN from QueryDatabaseMetadataIT
>
>
> Key: PHOENIX-4201
> URL: https://issues.apache.org/jira/browse/PHOENIX-4201
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4201_addendum.patch, PHOENIX-4201.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[
https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163744#comment-16163744
]
Hadoop QA commented on PHOENIX-4169:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886678/PHOENIX-4169.master.v2.patch
against master branch at commit 1d4025a57daedeebb64ef735b1055ebc9c6b2131.
ATTACHMENT ID: 12886678
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+Configuration clonedConfig =
PropertiesUtil.cloneConfig(e.getEnvironment().getConfiguration());
+
e.getEnvironment().getConfiguration().getInt(QueryServices.NUM_RETRIES_FOR_SCHEMA_UPDATE_CHECK,
+logger.info("Major compaction running
while index on table is disabled. Clearing index disable timestamp: " +
tableName);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MetaDataEndPointIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DeleteIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.iterate.PhoenixQueryTimeoutIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RenewLeaseIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CountDistinctApproximateHyperLogLogIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpperLowerFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.HashJoinLocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexToolForPartialBuildWithNamespaceEnabledIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CountDistinctCompressionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.GetSetByteBitFunctionEnd2EndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RegexpReplaceFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MapReduceIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.StddevIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DecodeFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpdateCacheAcrossDifferentClientsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PowerFunctionEnd2EndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ArithmeticQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ReadIsolationLevelIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.VariableLengthPKIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.util.IndexScrutinyIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DisableLocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OnDuplicateKeyIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.hadoop.hbase.regionserver.wal.WALRecoveryRegionPostOpenIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryTimeoutIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.SaltedIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CbrtFunctionEnd2EndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.RegexpSplitFunctionIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.LnLogFunctionEnd2EndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SpillableGroupByIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UserDefinedFunctionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ExplainPlanWithStatsDisabledIT
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163730#comment-16163730 ] James Taylor commented on PHOENIX-4191: --- I'd go with the simple fix for 4.12 and then ping the dev list to discuss what JDK folks are on. The hanging unit test on JDK 8 may have been fixed recently. > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163693#comment-16163693 ] Josh Elser commented on PHOENIX-4191: - bq. We're still on JDK 7 here, so I don't think that plugin will help us. Yes, and no. The plugin just requires a JDK8 installation; we can still have the compiler source/target set to 7 and use this plugin. The current downside is just when developers haven't yet installed a JDK8 compiler, the check wouldn't run for those folks which isn't a big deal. I'd assume the large majority of developers are still using JDK8 to build JDK7 targeted code (at least I've been doing that for some time). Does that make sense/alleviate concern? The only rub is that I do have to use a JDK7 installation when building the 0.98 branch. There's some issue with HBase 0.98 which results in a unit test hanging if you try to use JDK8 (even with the Java7 target). Even then, not a big concern since catching an IT in master will result in a change to all branches. bq. How about just adding an annotation to the test classes where it's missing? Wouldn't that be a simpler solution, especially for 4.12? Yup, that's always a path forward, regardless of the above outcome. > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4201: -- Attachment: PHOENIX-4201_addendum.patch Addendum to address review comments. > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201_addendum.patch, PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4191) Not all ITs being run
[ https://issues.apache.org/jira/browse/PHOENIX-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163665#comment-16163665 ] James Taylor commented on PHOENIX-4191: --- [~elserj] - thanks for following up on this. We're still on JDK 7 here, so I don't think that plugin will help us. How about just adding an annotation to the test classes where it's missing? Wouldn't that be a simpler solution, especially for 4.12? > Not all ITs being run > - > > Key: PHOENIX-4191 > URL: https://issues.apache.org/jira/browse/PHOENIX-4191 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Blocker > Fix For: 4.12.0 > > Attachments: PHOENIX-4191.001.patch, PHOENIX-4191.002.patch > > > Noticed that not all of the ITs are getting run, specifically > SystemTablePermissionsIT. > It seems like we have the build set up to require that all ITs fall into a > specific bucket of categories. Those not in one of those categories are > ignored. > Marked as blocker as we've had regressions around security in this part of > the code before. Must make sure this test is running before a release happens. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[
https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163663#comment-16163663
]
James Taylor commented on PHOENIX-4201:
---
[~samarthjain] - it'd be best to clear the client side and server side cache
after deleting the metadata here, as soon we'll rely on the cache sometimes
when we service these metadata API calls.
{code}
+@Before
+// We need to clean up phoenix metadata to ensure tests don't step on each
other
+public void deleteMetadata() throws Exception {
+try (Connection conn = DriverManager.getConnection(getUrl())) {
+String delete =
+"DELETE FROM SYSTEM.CATALOG WHERE TABLE_SCHEM IS NULL OR
TABLE_SCHEM = '' OR TABLE_SCHEM != 'SYSTEM'";
+conn.createStatement().executeUpdate(delete);
+conn.commit();
+delete = "DELETE FROM \"SYSTEM\".\"SEQUENCE\"";
+conn.createStatement().executeUpdate(delete);
+conn.commit();
+}
+}
{code}
> Remove usage of SCN from QueryDatabaseMetadataIT
>
>
> Key: PHOENIX-4201
> URL: https://issues.apache.org/jira/browse/PHOENIX-4201
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4201.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4188) Disable DTD parsing on Pherf XML documents
[ https://issues.apache.org/jira/browse/PHOENIX-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163655#comment-16163655 ] Hudson commented on PHOENIX-4188: - SUCCESS: Integrated in Jenkins build Phoenix-master #1790 (See [https://builds.apache.org/job/Phoenix-master/1790/]) PHOENIX-4188 Disable inline-DTDs in Pherf XML records (elserj: rev 4ee35057c6a63c347f959361338b517d4f5b38c4) * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/impl/XMLResultHandler.java * (add) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/XMLConfigParserTest.java * (edit) phoenix-pherf/pom.xml * (add) phoenix-pherf/src/test/resources/malicious_results_with_dtd.xml * (edit) phoenix-pherf/config/scenario/user_defined_scenario.xml * (add) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/result/impl/XMLResultHandlerTest.java * (add) phoenix-pherf/src/test/resources/scenario/malicious_scenario_with_dtd.xml * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/ConfigurationParserTest.java > Disable DTD parsing on Pherf XML documents > -- > > Key: PHOENIX-4188 > URL: https://issues.apache.org/jira/browse/PHOENIX-4188 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 4.12.0 > > Attachments: PHOENIX-4188.001.patch, PHOENIX-4188.002.patch > > > A security scan dinged Phoenix for an external entities attack on the XML > files that Pherf creates. > We can easily work around it by disabling the inline doctype definition in > the XML parser we use. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Wang updated PHOENIX-4185: Attachment: (was: PHOENIX-4185.patch) > converting tests for disable DDL/DML for 4.12 > - > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Wang updated PHOENIX-4185: Attachment: PHOENIX-4185-v1.patch > converting tests for disable DDL/DML for 4.12 > - > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Attachments: PHOENIX-4185-v1.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4201: -- Attachment: (was: PHOENIX-4201.patch) > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4201: -- Attachment: PHOENIX-4201.patch > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
Samarth Jain created PHOENIX-4201: - Summary: Remove usage of SCN from QueryDatabaseMetadataIT Key: PHOENIX-4201 URL: https://issues.apache.org/jira/browse/PHOENIX-4201 Project: Phoenix Issue Type: Bug Reporter: Samarth Jain Assignee: Samarth Jain -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4201) Remove usage of SCN from QueryDatabaseMetadataIT
[ https://issues.apache.org/jira/browse/PHOENIX-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4201: -- Attachment: PHOENIX-4201.patch > Remove usage of SCN from QueryDatabaseMetadataIT > > > Key: PHOENIX-4201 > URL: https://issues.apache.org/jira/browse/PHOENIX-4201 > Project: Phoenix > Issue Type: Bug >Reporter: Samarth Jain >Assignee: Samarth Jain > Attachments: PHOENIX-4201.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163625#comment-16163625 ] James Taylor commented on PHOENIX-4185: --- Thanks, [~aertoria] - looks good. Do these tests still pass? If so, I'll commit shortly. > converting tests for disable DDL/DML for 4.12 > - > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Attachments: PHOENIX-4185.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[
https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163614#comment-16163614
]
Hadoop QA commented on PHOENIX-4185:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886717/PHOENIX-4185.patch
against master branch at commit 4ee35057c6a63c347f959361338b517d4f5b38c4.
ATTACHMENT ID: 12886717
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev patch that doesn't require tests.
{color:red}-1 javac{color}. The patch appears to cause mvn compile goal to
fail .
Compilation errors resume:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-clean-plugin:2.5:clean (default-clean) on
project phoenix-core: Failed to clean project: Failed to delete
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-core/target
-> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :phoenix-core
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1429//console
This message is automatically generated.
> converting tests for disable DDL/DML for 4.12
> -
>
> Key: PHOENIX-4185
> URL: https://issues.apache.org/jira/browse/PHOENIX-4185
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.12.0
>Reporter: Ethan Wang
>Assignee: Ethan Wang
> Attachments: PHOENIX-4185.patch
>
>
> converting tests for disable DDL/DML for 4.12. Disallow customized SCN
> timestamp assignment
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java
> ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PHOENIX-4185) converting tests for disable DDL/DML for 4.12
[ https://issues.apache.org/jira/browse/PHOENIX-4185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Wang updated PHOENIX-4185: Attachment: PHOENIX-4185.patch > converting tests for disable DDL/DML for 4.12 > - > > Key: PHOENIX-4185 > URL: https://issues.apache.org/jira/browse/PHOENIX-4185 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Ethan Wang >Assignee: Ethan Wang > Attachments: PHOENIX-4185.patch > > > converting tests for disable DDL/DML for 4.12. Disallow customized SCN > timestamp assignment > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/PercentileIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/ProductMetricsIT.java > ./phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4200) QualifierFilter from HBase to be implemented
Priyansh Saxena created PHOENIX-4200: Summary: QualifierFilter from HBase to be implemented Key: PHOENIX-4200 URL: https://issues.apache.org/jira/browse/PHOENIX-4200 Project: Phoenix Issue Type: Improvement Affects Versions: 4.11.0, 4.10.0, 4.9.0 Reporter: Priyansh Saxena Fix For: 5.0 Currently, it is not possible to filter columns from a table using an SQL-like query in Phoenix. This impairs the use of Phoenix as an SQL layer over HBase where wide column-family approach is being used and/or the column-names are dynamic. Need to determine how to handle and display dynamic column-names. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4199) Modify SequenceIT.java to not use CurrentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163428#comment-16163428 ] James Taylor commented on PHOENIX-4199: --- +1. Thanks, [~mujtabachohan]! Meant to mention that you need to generate unique sequence names too, but looks like you already figured that out. > Modify SequenceIT.java to not use CurrentSCN > > > Key: PHOENIX-4199 > URL: https://issues.apache.org/jira/browse/PHOENIX-4199 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan >Assignee: Mujtaba Chohan > Attachments: PHOENIX-4199.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163417#comment-16163417 ] James Taylor commented on PHOENIX-4169: --- [~vincentpoon] - there's also an Indexer.postCompact() hook that does a cross RS call. Will this one be ok as we're already modifying the Configuration associated with Indexer? > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.master.patch, > PHOENIX-4169.master.v2.patch, PHOENIX-4169.master.v3.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[
https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163400#comment-16163400
]
Hadoop QA commented on PHOENIX-4169:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12886686/PHOENIX-4169.0.98.v3.patch
against master branch at commit 1d4025a57daedeebb64ef735b1055ebc9c6b2131.
ATTACHMENT ID: 12886686
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1428//console
This message is automatically generated.
> Explicitly cap timeout for index disable RPC on compaction
> --
>
> Key: PHOENIX-4169
> URL: https://issues.apache.org/jira/browse/PHOENIX-4169
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.12.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Critical
> Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch,
> PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.master.patch,
> PHOENIX-4169.master.v2.patch, PHOENIX-4169.master.v3.patch
>
>
> In PHOENIX-3953 we're marking the mutable global index as disabled with an
> index_disable_timestamp of 0 from the compaction hook.This is a potentially a
> server-server RPC, and HConnectionManager#setServerSideHConnectionRetries
> makes it such that the HBase client config on the server side has 10 times
> the number of retries, lasting hours.
> To avoid a hung coprocessor hook, we should explicitly cap the number of
> retries here.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4169: -- Attachment: PHOENIX-4169.0.98.v3.patch PHOENIX-4169.master.v3.patch [~samarthjain] Thanks, updated the patch with your suggestion > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.0.98.v3.patch, PHOENIX-4169.master.patch, > PHOENIX-4169.master.v2.patch, PHOENIX-4169.master.v3.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4199) Modify SequenceIT.java to not use CurrentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan updated PHOENIX-4199: Attachment: PHOENIX-4199.patch > Modify SequenceIT.java to not use CurrentSCN > > > Key: PHOENIX-4199 > URL: https://issues.apache.org/jira/browse/PHOENIX-4199 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan > Attachments: PHOENIX-4199.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (PHOENIX-4199) Modify SequenceIT.java to not use CurrentSCN
[ https://issues.apache.org/jira/browse/PHOENIX-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan reassigned PHOENIX-4199: --- Assignee: Mujtaba Chohan > Modify SequenceIT.java to not use CurrentSCN > > > Key: PHOENIX-4199 > URL: https://issues.apache.org/jira/browse/PHOENIX-4199 > Project: Phoenix > Issue Type: Test >Reporter: Mujtaba Chohan >Assignee: Mujtaba Chohan > Attachments: PHOENIX-4199.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4199) Modify SequenceIT.java to not use CurrentSCN
Mujtaba Chohan created PHOENIX-4199: --- Summary: Modify SequenceIT.java to not use CurrentSCN Key: PHOENIX-4199 URL: https://issues.apache.org/jira/browse/PHOENIX-4199 Project: Phoenix Issue Type: Test Reporter: Mujtaba Chohan -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163341#comment-16163341 ] Samarth Jain commented on PHOENIX-4169: --- [~vincentpoon] - it would be slightly more performant if you can have the clonedConfig as a member variable (maybe named as compactionConfig?), instead. There is a cost to doing a deep clone of the configuration object. You can initialize the member variable in start() like we do for upsertSelectConfig. > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (PHOENIX-4169) Explicitly cap timeout for index disable RPC on compaction
[ https://issues.apache.org/jira/browse/PHOENIX-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vincent Poon updated PHOENIX-4169: -- Attachment: PHOENIX-4169.master.v2.patch PHOENIX-4169.0.98.v2.patch added a log line for when the index disable timestamp is cleared > Explicitly cap timeout for index disable RPC on compaction > -- > > Key: PHOENIX-4169 > URL: https://issues.apache.org/jira/browse/PHOENIX-4169 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.12.0 >Reporter: Vincent Poon >Assignee: Vincent Poon >Priority: Critical > Attachments: PHOENIX-4169.0.98.patch, PHOENIX-4169.0.98.v2.patch, > PHOENIX-4169.master.patch, PHOENIX-4169.master.v2.patch > > > In PHOENIX-3953 we're marking the mutable global index as disabled with an > index_disable_timestamp of 0 from the compaction hook.This is a potentially a > server-server RPC, and HConnectionManager#setServerSideHConnectionRetries > makes it such that the HBase client config on the server side has 10 times > the number of retries, lasting hours. > To avoid a hung coprocessor hook, we should explicitly cap the number of > retries here. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4188) Disable DTD parsing on Pherf XML documents
[ https://issues.apache.org/jira/browse/PHOENIX-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163318#comment-16163318 ] Josh Elser commented on PHOENIX-4188: - Thanks boss. Pushing now. > Disable DTD parsing on Pherf XML documents > -- > > Key: PHOENIX-4188 > URL: https://issues.apache.org/jira/browse/PHOENIX-4188 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 4.12.0 > > Attachments: PHOENIX-4188.001.patch, PHOENIX-4188.002.patch > > > A security scan dinged Phoenix for an external entities attack on the XML > files that Pherf creates. > We can easily work around it by disabling the inline doctype definition in > the XML parser we use. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4188) Disable DTD parsing on Pherf XML documents
[ https://issues.apache.org/jira/browse/PHOENIX-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163316#comment-16163316 ] Mujtaba Chohan commented on PHOENIX-4188: - +1. Thanks [~elserj] > Disable DTD parsing on Pherf XML documents > -- > > Key: PHOENIX-4188 > URL: https://issues.apache.org/jira/browse/PHOENIX-4188 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 4.12.0 > > Attachments: PHOENIX-4188.001.patch, PHOENIX-4188.002.patch > > > A security scan dinged Phoenix for an external entities attack on the XML > files that Pherf creates. > We can easily work around it by disabling the inline doctype definition in > the XML parser we use. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4188) Disable DTD parsing on Pherf XML documents
[ https://issues.apache.org/jira/browse/PHOENIX-4188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163090#comment-16163090 ] Josh Elser commented on PHOENIX-4188: - Any feedback, [~mujtabachohan]? ;) I think it's ready to go in. > Disable DTD parsing on Pherf XML documents > -- > > Key: PHOENIX-4188 > URL: https://issues.apache.org/jira/browse/PHOENIX-4188 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 4.12.0 > > Attachments: PHOENIX-4188.001.patch, PHOENIX-4188.002.patch > > > A security scan dinged Phoenix for an external entities attack on the XML > files that Pherf creates. > We can easily work around it by disabling the inline doctype definition in > the XML parser we use. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2079) databaseMetaData.getIndexInfo is not giving proper index names
[ https://issues.apache.org/jira/browse/PHOENIX-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163086#comment-16163086 ] Josh Elser commented on PHOENIX-2079: - [~suraj786], are you saying that you are seeing this situation with Phoenix-4.3.0? Have you tried using a recent release such as Phoenix-4.11.0? If you would like someone to volunteer their time to investigate this further, having some clear steps that could be followed is always helpful (e.g. example SQL commands you ran, what output you got, and what you expected to see instead). > databaseMetaData.getIndexInfo is not giving proper index names > -- > > Key: PHOENIX-2079 > URL: https://issues.apache.org/jira/browse/PHOENIX-2079 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.3.0 > Environment: Hbase 98.9 > Hadoop 2 >Reporter: suraj misra > Labels: verify > Fix For: 4.12.0 > > > Hi, > databaseMetaData.getIndexInfo method is giving wrong index names for primary > keys. > For example suppose we have a table having one primary key column and other > column on which index is created then above API giving wrong index name for > primary key column. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables
[
https://issues.apache.org/jira/browse/PHOENIX-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163061#comment-16163061
]
Josh Elser commented on PHOENIX-4198:
-
Thanks for working on this one, Ankit. This has definitely been a repeated ask
I've seen come across my "desk".
Make sure to add a JUnit Category annotation to {{TableDDLPermissionsIT}}
otherwise you'll run into PHOENIX-4191. Does it make sense to consolidate that
test with {{SystemTablePermissionsIT}}?
{{mutateRowsWithLocks(...)}} seems a little weird -- when we're doing the new
code-path, we don't explicitly grab any locks whereas I'd assume that does
happen in the other codepath. Is that OK?
Looks OK at a high-level to me, but I should bring it down and play with it
locally too :)
FYI [~jamestaylor]
> Remove the need for users to have access to the Phoenix SYSTEM tables to
> create tables
> --
>
> Key: PHOENIX-4198
> URL: https://issues.apache.org/jira/browse/PHOENIX-4198
> Project: Phoenix
> Issue Type: Bug
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4198.patch
>
>
> Problem statement:-
> A user who doesn't have access to a table should also not be able to modify
> Phoenix Metadata. Currently, every user required to have a write permission
> to SYSTEM tables which is a security concern as they can
> create/alter/drop/corrupt meta data of any other table without proper access
> to the corresponding physical tables.
> [~devaraj] recommended a solution as below.
> 1. A coprocessor endpoint would be implemented and all write accesses to the
> catalog table would have to necessarily go through that. The 'hbase' user
> would own that table. Today, there is MetaDataEndpointImpl that's run on the
> RS where the catalog is hosted, and that could be enhanced to serve the
> purpose we need.
> 2. The regionserver hosting the catalog table would do the needful for all
> catalog updates - creating the mutations as needed, that is.
> 3. The coprocessor endpoint could use Ranger to do necessary authorization
> checks before updating the catalog table. So for example, if a user doesn't
> have authorization to create a table in a certain namespace, or update the
> schema, etc., it can reject such requests outright. Only after successful
> validations, does it perform the operations (physical operations to do with
> creating the table, and updating the catalog table with the necessary
> mutations).
> 4. In essence, the code that implements dealing with DDLs, would be hosted in
> the catalog table endpoint. The client code would be really thin, and it
> would just invoke the endpoint with the necessary info. The additional thing
> that needs to be done in the endpoint is the validation of authorization to
> prevent unauthorized users from making changes to someone else's
> tables/schemas/etc. For example, one should be able to create a view on a
> table if he has read access on the base table. That mutation on the catalog
> table would be permitted. For changing the schema (adding a new column for
> example), the said user would need write permission on the table... etc etc.
> Thanks [~elserj] for the write-up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables
[ https://issues.apache.org/jira/browse/PHOENIX-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-4198: --- Attachment: PHOENIX-4198.patch > Remove the need for users to have access to the Phoenix SYSTEM tables to > create tables > -- > > Key: PHOENIX-4198 > URL: https://issues.apache.org/jira/browse/PHOENIX-4198 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.12.0 > > Attachments: PHOENIX-4198.patch > > > Problem statement:- > A user who doesn't have access to a table should also not be able to modify > Phoenix Metadata. Currently, every user required to have a write permission > to SYSTEM tables which is a security concern as they can > create/alter/drop/corrupt meta data of any other table without proper access > to the corresponding physical tables. > [~devaraj] recommended a solution as below. > 1. A coprocessor endpoint would be implemented and all write accesses to the > catalog table would have to necessarily go through that. The 'hbase' user > would own that table. Today, there is MetaDataEndpointImpl that's run on the > RS where the catalog is hosted, and that could be enhanced to serve the > purpose we need. > 2. The regionserver hosting the catalog table would do the needful for all > catalog updates - creating the mutations as needed, that is. > 3. The coprocessor endpoint could use Ranger to do necessary authorization > checks before updating the catalog table. So for example, if a user doesn't > have authorization to create a table in a certain namespace, or update the > schema, etc., it can reject such requests outright. Only after successful > validations, does it perform the operations (physical operations to do with > creating the table, and updating the catalog table with the necessary > mutations). > 4. In essence, the code that implements dealing with DDLs, would be hosted in > the catalog table endpoint. The client code would be really thin, and it > would just invoke the endpoint with the necessary info. The additional thing > that needs to be done in the endpoint is the validation of authorization to > prevent unauthorized users from making changes to someone else's > tables/schemas/etc. For example, one should be able to create a view on a > table if he has read access on the base table. That mutation on the catalog > table would be permitted. For changing the schema (adding a new column for > example), the said user would need write permission on the table... etc etc. > Thanks [~elserj] for the write-up. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables
[ https://issues.apache.org/jira/browse/PHOENIX-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163001#comment-16163001 ] Ankit Singhal commented on PHOENIX-4198: PFA, a wip patch for the same. Currently, Create table/index/view * A user who has a CREATE access on schema/namespace can create table/view/index. We also need read access to the data table for view and index but not sure which API (common in Ranger/native authorization) we can use. [~elserj]/[~apurtell] any idea? Drop table/index/view * A user who has CREATE access on physical/data table can drop table/index/view. Same we need write access to the physical table, not sure which API I can use? Alter(Add/drop column,properties) table/index/view * A user who has CREATE access on physical/data table can alter table/index/view. Create/drop schema * A user who has GLOBAL ADMIN access can create and drop the schema. > Remove the need for users to have access to the Phoenix SYSTEM tables to > create tables > -- > > Key: PHOENIX-4198 > URL: https://issues.apache.org/jira/browse/PHOENIX-4198 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal > Fix For: 4.12.0 > > > Problem statement:- > A user who doesn't have access to a table should also not be able to modify > Phoenix Metadata. Currently, every user required to have a write permission > to SYSTEM tables which is a security concern as they can > create/alter/drop/corrupt meta data of any other table without proper access > to the corresponding physical tables. > [~devaraj] recommended a solution as below. > 1. A coprocessor endpoint would be implemented and all write accesses to the > catalog table would have to necessarily go through that. The 'hbase' user > would own that table. Today, there is MetaDataEndpointImpl that's run on the > RS where the catalog is hosted, and that could be enhanced to serve the > purpose we need. > 2. The regionserver hosting the catalog table would do the needful for all > catalog updates - creating the mutations as needed, that is. > 3. The coprocessor endpoint could use Ranger to do necessary authorization > checks before updating the catalog table. So for example, if a user doesn't > have authorization to create a table in a certain namespace, or update the > schema, etc., it can reject such requests outright. Only after successful > validations, does it perform the operations (physical operations to do with > creating the table, and updating the catalog table with the necessary > mutations). > 4. In essence, the code that implements dealing with DDLs, would be hosted in > the catalog table endpoint. The client code would be really thin, and it > would just invoke the endpoint with the necessary info. The additional thing > that needs to be done in the endpoint is the validation of authorization to > prevent unauthorized users from making changes to someone else's > tables/schemas/etc. For example, one should be able to create a view on a > table if he has read access on the base table. That mutation on the catalog > table would be permitted. For changing the schema (adding a new column for > example), the said user would need write permission on the table... etc etc. > Thanks [~elserj] for the write-up. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables
Ankit Singhal created PHOENIX-4198: -- Summary: Remove the need for users to have access to the Phoenix SYSTEM tables to create tables Key: PHOENIX-4198 URL: https://issues.apache.org/jira/browse/PHOENIX-4198 Project: Phoenix Issue Type: Bug Reporter: Ankit Singhal Assignee: Ankit Singhal Fix For: 4.12.0 Problem statement:- A user who doesn't have access to a table should also not be able to modify Phoenix Metadata. Currently, every user required to have a write permission to SYSTEM tables which is a security concern as they can create/alter/drop/corrupt meta data of any other table without proper access to the corresponding physical tables. [~devaraj] recommended a solution as below. 1. A coprocessor endpoint would be implemented and all write accesses to the catalog table would have to necessarily go through that. The 'hbase' user would own that table. Today, there is MetaDataEndpointImpl that's run on the RS where the catalog is hosted, and that could be enhanced to serve the purpose we need. 2. The regionserver hosting the catalog table would do the needful for all catalog updates - creating the mutations as needed, that is. 3. The coprocessor endpoint could use Ranger to do necessary authorization checks before updating the catalog table. So for example, if a user doesn't have authorization to create a table in a certain namespace, or update the schema, etc., it can reject such requests outright. Only after successful validations, does it perform the operations (physical operations to do with creating the table, and updating the catalog table with the necessary mutations). 4. In essence, the code that implements dealing with DDLs, would be hosted in the catalog table endpoint. The client code would be really thin, and it would just invoke the endpoint with the necessary info. The additional thing that needs to be done in the endpoint is the validation of authorization to prevent unauthorized users from making changes to someone else's tables/schemas/etc. For example, one should be able to create a view on a table if he has read access on the base table. That mutation on the catalog table would be permitted. For changing the schema (adding a new column for example), the said user would need write permission on the table... etc etc. Thanks [~elserj] for the write-up. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-4182) DatabaseMetaData.getTables throws exception when getting SEQUENCE information
[ https://issues.apache.org/jira/browse/PHOENIX-4182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162566#comment-16162566 ] suraj misra commented on PHOENIX-4182: -- Thank you James for your quick response. Is 4.12.0 release date finalized? > DatabaseMetaData.getTables throws exception when getting SEQUENCE information > - > > Key: PHOENIX-4182 > URL: https://issues.apache.org/jira/browse/PHOENIX-4182 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.11.0 > Environment: Hbase 1.2 environment >Reporter: suraj misra >Assignee: James Taylor > Fix For: 4.12.0 > > Attachments: PHOENIX-4182.patch > > > It is throwing exception only in case of using SEQUENCE. For TABLE, INDEX and > SYSTEM_TABLES , It is working fine. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2079) databaseMetaData.getIndexInfo is not giving proper index names
[ https://issues.apache.org/jira/browse/PHOENIX-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162549#comment-16162549 ] suraj misra commented on PHOENIX-2079: -- Please let me know it needs further information. Could this be done in 4.12.0 release. > databaseMetaData.getIndexInfo is not giving proper index names > -- > > Key: PHOENIX-2079 > URL: https://issues.apache.org/jira/browse/PHOENIX-2079 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.3.0 > Environment: Hbase 98.9 > Hadoop 2 >Reporter: suraj misra > Labels: verify > Fix For: 4.12.0 > > > Hi, > databaseMetaData.getIndexInfo method is giving wrong index names for primary > keys. > For example suppose we have a table having one primary key column and other > column on which index is created then above API giving wrong index name for > primary key column. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
