[jira] [Updated] (PHOENIX-4743) ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if failed

2019-08-24 Thread Sandeep Pal (Jira) 


 [ 
https://issues.apache.org/jira/browse/PHOENIX-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandeep Pal updated PHOENIX-4743:
-
Attachment: PHOENIX-4743.v3.patch

> ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if 
> failed
> --
>
> Key: PHOENIX-4743
> URL: https://issues.apache.org/jira/browse/PHOENIX-4743
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Chinmay Kulkarni
>Assignee: Sandeep Pal
>Priority: Major
>  Labels: phoenix-hardening
> Attachments: PHOENIX-4743.patch, PHOENIX-4743.v1.patch, 
> PHOENIX-4743.v3.patch
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you issue an "ALTER TABLE" for a global index to add a column, Phoenix 
> throws a SQLException, but the HBase metadata for the global index table is 
> still modified.
> Steps to reproduce:
>  * Create the base data table: 
> {code:java}
> create table if not exists z_base_table (id INTEGER not null primary key, 
> host VARCHAR(10), flag boolean);{code}
>  * Create a global index on top of this table: 
> {code:java}
> create index global_z_index on z_base_table(HOST);{code}
>  * Add a column to the global index table:
> {code:java}
> alter table global_z_index add cf1.age INTEGER;{code}
> This will throw an exception in Phoenix, but HBase metadata for the global 
> index table is still modified. Stack trace:
> {noformat}
> Error: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop 
> column referenced by VIEW columnName=GLOBAL_Z_INDEX (state=42M01,code=1010)
>  java.sql.SQLException: ERROR 1010 (42M01): Not allowed to mutate table. 
> Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX
>  at 
> org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:494)
>  at 
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:150)
>  at 
> org.apache.phoenix.schema.MetaDataClient.processMutationResult(MetaDataClient.java:3049)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3503)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3210)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1432)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
>  at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1825)
>  at sqlline.Commands.execute(Commands.java:822)
>  at sqlline.Commands.sql(Commands.java:732)
>  at sqlline.SqlLine.dispatch(SqlLine.java:813)
>  at sqlline.SqlLine.begin(SqlLine.java:686)
>  at sqlline.SqlLine.start(SqlLine.java:398)
>  at sqlline.SqlLine.main(SqlLine.java:291{noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (PHOENIX-4743) ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if failed

2019-08-24 Thread Sandeep Pal (Jira) 


 [ 
https://issues.apache.org/jira/browse/PHOENIX-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandeep Pal updated PHOENIX-4743:
-
Attachment: (was: PHOENIX-4743.v2.patch)

> ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if 
> failed
> --
>
> Key: PHOENIX-4743
> URL: https://issues.apache.org/jira/browse/PHOENIX-4743
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Chinmay Kulkarni
>Assignee: Sandeep Pal
>Priority: Major
>  Labels: phoenix-hardening
> Attachments: PHOENIX-4743.patch, PHOENIX-4743.v1.patch
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you issue an "ALTER TABLE" for a global index to add a column, Phoenix 
> throws a SQLException, but the HBase metadata for the global index table is 
> still modified.
> Steps to reproduce:
>  * Create the base data table: 
> {code:java}
> create table if not exists z_base_table (id INTEGER not null primary key, 
> host VARCHAR(10), flag boolean);{code}
>  * Create a global index on top of this table: 
> {code:java}
> create index global_z_index on z_base_table(HOST);{code}
>  * Add a column to the global index table:
> {code:java}
> alter table global_z_index add cf1.age INTEGER;{code}
> This will throw an exception in Phoenix, but HBase metadata for the global 
> index table is still modified. Stack trace:
> {noformat}
> Error: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop 
> column referenced by VIEW columnName=GLOBAL_Z_INDEX (state=42M01,code=1010)
>  java.sql.SQLException: ERROR 1010 (42M01): Not allowed to mutate table. 
> Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX
>  at 
> org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:494)
>  at 
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:150)
>  at 
> org.apache.phoenix.schema.MetaDataClient.processMutationResult(MetaDataClient.java:3049)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3503)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3210)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1432)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
>  at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1825)
>  at sqlline.Commands.execute(Commands.java:822)
>  at sqlline.Commands.sql(Commands.java:732)
>  at sqlline.SqlLine.dispatch(SqlLine.java:813)
>  at sqlline.SqlLine.begin(SqlLine.java:686)
>  at sqlline.SqlLine.start(SqlLine.java:398)
>  at sqlline.SqlLine.main(SqlLine.java:291{noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

[jira] [Updated] (PHOENIX-4743) ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if failed

2019-08-24 Thread Sandeep Pal (Jira) 


 [ 
https://issues.apache.org/jira/browse/PHOENIX-4743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sandeep Pal updated PHOENIX-4743:
-
Attachment: PHOENIX-4743.v2.patch

> ALTER TABLE ADD COLUMN for global index should not modify HBase metadata if 
> failed
> --
>
> Key: PHOENIX-4743
> URL: https://issues.apache.org/jira/browse/PHOENIX-4743
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Chinmay Kulkarni
>Assignee: Sandeep Pal
>Priority: Major
>  Labels: phoenix-hardening
> Attachments: PHOENIX-4743.patch, PHOENIX-4743.v1.patch, 
> PHOENIX-4743.v2.patch
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> When you issue an "ALTER TABLE" for a global index to add a column, Phoenix 
> throws a SQLException, but the HBase metadata for the global index table is 
> still modified.
> Steps to reproduce:
>  * Create the base data table: 
> {code:java}
> create table if not exists z_base_table (id INTEGER not null primary key, 
> host VARCHAR(10), flag boolean);{code}
>  * Create a global index on top of this table: 
> {code:java}
> create index global_z_index on z_base_table(HOST);{code}
>  * Add a column to the global index table:
> {code:java}
> alter table global_z_index add cf1.age INTEGER;{code}
> This will throw an exception in Phoenix, but HBase metadata for the global 
> index table is still modified. Stack trace:
> {noformat}
> Error: ERROR 1010 (42M01): Not allowed to mutate table. Cannot add/drop 
> column referenced by VIEW columnName=GLOBAL_Z_INDEX (state=42M01,code=1010)
>  java.sql.SQLException: ERROR 1010 (42M01): Not allowed to mutate table. 
> Cannot add/drop column referenced by VIEW columnName=GLOBAL_Z_INDEX
>  at 
> org.apache.phoenix.exception.SQLExceptionCode$Factory$1.newException(SQLExceptionCode.java:494)
>  at 
> org.apache.phoenix.exception.SQLExceptionInfo.buildException(SQLExceptionInfo.java:150)
>  at 
> org.apache.phoenix.schema.MetaDataClient.processMutationResult(MetaDataClient.java:3049)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3503)
>  at 
> org.apache.phoenix.schema.MetaDataClient.addColumn(MetaDataClient.java:3210)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement$ExecutableAddColumnStatement$1.execute(PhoenixStatement.java:1432)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:408)
>  at org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:391)
>  at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:390)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:378)
>  at 
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:1825)
>  at sqlline.Commands.execute(Commands.java:822)
>  at sqlline.Commands.sql(Commands.java:732)
>  at sqlline.SqlLine.dispatch(SqlLine.java:813)
>  at sqlline.SqlLine.begin(SqlLine.java:686)
>  at sqlline.SqlLine.start(SqlLine.java:398)
>  at sqlline.SqlLine.main(SqlLine.java:291{noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)