[jira] [Resolved] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-19 Thread Istvan Toth (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth resolved PHOENIX-6193.
--
Resolution: Fixed

I could not reproduce the Yetus warnings, it seems that Yetus was confused by 
leftover files after patching.

> PHOENIX-6151 slows down shading 
> 
>
> Key: PHOENIX-6193
> URL: https://issues.apache.org/jira/browse/PHOENIX-6193
> Project: Phoenix
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Critical
> Fix For: 5.1.0, 4.16.0
>
>
> PHOENIX-6151 increases shading time by ~400%, which is a disproportional 
> share of the total build time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-19 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated PHOENIX-6124:
--
Attachment: PHOENIX-6124.4.x.000.patch

> Block adding/dropping a column on a parent view for clients <4.15 and for 
> clients that have phoenix.allow.system.catalog.rollback=true
> --
>
> Key: PHOENIX-6124
> URL: https://issues.apache.org/jira/browse/PHOENIX-6124
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Viraj Jasani
>Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6124.4.x.000.patch, PHOENIX-6124.4.x.000.patch
>
>
> For pre-4.15 clients, we have to block adding/dropping a column to a table if 
> it has child views since we can’t do any checkAndPut distributed locking (see 
> [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]).
>  
> However, this is only prevented if the parent is a table and not if the 
> parent is a view. We should extend [the 
> condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591]
>  to also cover views since conflicting mutations on its children can also 
> lead to inconsistencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-19 Thread Istvan Toth (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth reopened PHOENIX-6193:
--

Yetus finds RAT and Javadocs problems

> PHOENIX-6151 slows down shading 
> 
>
> Key: PHOENIX-6193
> URL: https://issues.apache.org/jira/browse/PHOENIX-6193
> Project: Phoenix
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Critical
> Fix For: 5.1.0, 4.16.0
>
>
> PHOENIX-6151 increases shading time by ~400%, which is a disproportional 
> share of the total build time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6189:
---
Fix Version/s: 4.16.0
   5.1.0

> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name 
> instead of actual value 
> 
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Trivial
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6189.4x.patch
>
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains 
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6172:
---
Attachment: PHOENIX-6172.4.x.v2.patch

> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script 
> ---
>
> Key: PHOENIX-6172
> URL: https://issues.apache.org/jira/browse/PHOENIX-6172
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6172.4.x.patch, PHOENIX-6172.4.x.v2.patch, 
> PHOENIX-6172.master.patch, PHOENIX-6172.master.v1.patch, 
> PHOENIX-6172.master.v2.patch
>
>
> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script by using HBase put. Making sure the HBase row ts reflects the 4.16 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6172:
---
Attachment: PHOENIX-6172.master.v2.patch

> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script 
> ---
>
> Key: PHOENIX-6172
> URL: https://issues.apache.org/jira/browse/PHOENIX-6172
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6172.4.x.patch, PHOENIX-6172.master.patch, 
> PHOENIX-6172.master.v1.patch, PHOENIX-6172.master.v2.patch
>
>
> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script by using HBase put. Making sure the HBase row ts reflects the 4.16 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6189:
---
Attachment: (was: PHOENIX-6189.4x.patch)

> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name 
> instead of actual value 
> 
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Trivial
> Attachments: PHOENIX-6189.4x.patch
>
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains 
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6189:
---
Attachment: PHOENIX-6189.4x.patch

> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name 
> instead of actual value 
> 
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Trivial
> Attachments: PHOENIX-6189.4x.patch
>
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains 
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-19 Thread Chinmay Kulkarni (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chinmay Kulkarni updated PHOENIX-6142:
--
Attachment: PHOENIX-6142.master.v1.patch

> Make DDL operations resilient to orphan parent->child linking rows in 
> SYSTEM.CHILD_LINK
> ---
>
> Key: PHOENIX-6142
> URL: https://issues.apache.org/jira/browse/PHOENIX-6142
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6142-4.x-v1.patch, PHOENIX-6142.4.x.v2.patch, 
> PHOENIX-6142.4.x.v3.patch, PHOENIX-6142.4.x.v4.patch, 
> PHOENIX-6142.master.v1.patch
>
>
> We are targeting PHOENIX-6141 for 4.17. Until we have it, we should aim at 
> making DDL operations resilient to orphan parent->child linking rows. DDL 
> operations identified which can fail due to orphan rows are:
>  # Any ALTER TABLE ADD/DROP/SET calls on the base table T will fail if there 
> are orphan links from T to some already dropped view. This happens because 
> the call to 
> [MetaDataEndpointImpl.findAllChildViews()|https://github.com/apache/phoenix/blob/fece8e69b9c03c80db7a0801d99e5de31fe15ffa/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2142]
>  from 
> [MetaDataEndpointImpl.mutateColumn()|https://github.com/apache/phoenix/blob/fece8e69b9c03c80db7a0801d99e5de31fe15ffa/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2592]
>  fails with a TableNotFoundException.
>  # Any DROP TABLE/VIEW call without CASCADE will fail even though there are 
> actually no child views since the orphan rows wrongly indicate that there are 
> child views.
>  # During the upgrade path for UpgradeUtil.syncUpdateCacheFreqAllIndexes(), 
> we will just ignore any orphan views (for ex, see 
> [this|https://github.com/apache/phoenix/blob/fece8e69b9c03c80db7a0801d99e5de31fe15ffa/phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java#L1368-L1374]),
>  but the call to UpgradeUtil.upgradeTable() will fail with a 
> TableNotFoundException for each orphan view.
> # During a CREATE TABLE/VIEW, we try to drop any views from the previous life 
> of that table/view, however we might end up dropping a legitimate view (with 
> the same name) which is on another table/view because of this.
> Before dropping any views that we see from a parent->child link, we need to 
> ensure that the view is in fact a child view of the same table/view we think 
> it is an orphan of.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (PHOENIX-6193) PHOENIX-6151 slows down shading

2020-10-19 Thread Istvan Toth (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth resolved PHOENIX-6193.
--
Fix Version/s: 4.16.0
   5.1.0
   Resolution: Fixed

Committed to master and 4.x

Thanks for ideas and reviews [~larsh] and [~elserj]

> PHOENIX-6151 slows down shading 
> 
>
> Key: PHOENIX-6193
> URL: https://issues.apache.org/jira/browse/PHOENIX-6193
> Project: Phoenix
>  Issue Type: Bug
>  Components: core
>Affects Versions: 5.1.0, 4.16.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Critical
> Fix For: 5.1.0, 4.16.0
>
>
> PHOENIX-6151 increases shading time by ~400%, which is a disproportional 
> share of the total build time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6172:
---
Attachment: PHOENIX-6172.master.v1.patch

> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script 
> ---
>
> Key: PHOENIX-6172
> URL: https://issues.apache.org/jira/browse/PHOENIX-6172
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6172.4.x.patch, PHOENIX-6172.master.patch, 
> PHOENIX-6172.master.v1.patch
>
>
> Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade 
> script by using HBase put. Making sure the HBase row ts reflects the 4.16 
> version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6189) DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name instead of actual value

2020-10-19 Thread Xinyi Yan (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xinyi Yan updated PHOENIX-6189:
---
Attachment: PHOENIX-6189.4x.patch

> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name 
> instead of actual value 
> 
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.14.3
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Trivial
> Attachments: PHOENIX-6189.4x.patch
>
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains 
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6125) Make sure SYSTEM.TASK does not split

2020-10-19 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated PHOENIX-6125:
--
Attachment: PHOENIX-6125.4.x.000.patch

> Make sure SYSTEM.TASK does not split
> 
>
> Key: PHOENIX-6125
> URL: https://issues.apache.org/jira/browse/PHOENIX-6125
> Project: Phoenix
>  Issue Type: Improvement
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6125.4.x.000.patch
>
>
> To avoid problems such as 
> [PHOENIX-5945|https://issues.apache.org/jira/browse/PHOENIX-5945] we can just 
> prevent SYSTEM.TASK from splitting. 
> Currently we only store relatively rare tasks inside SYSTEM.TASK and so we 
> should probably be safe to assume that it only spans a single region. Note 
> that we will also have to handle changing the split policy during the upgrade 
> path for 4.15 operators.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-19 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated PHOENIX-6124:
--
Attachment: (was: PHOENIX-6124.master.000.patch)

> Block adding/dropping a column on a parent view for clients <4.15 and for 
> clients that have phoenix.allow.system.catalog.rollback=true
> --
>
> Key: PHOENIX-6124
> URL: https://issues.apache.org/jira/browse/PHOENIX-6124
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Viraj Jasani
>Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6124.4.x.000.patch
>
>
> For pre-4.15 clients, we have to block adding/dropping a column to a table if 
> it has child views since we can’t do any checkAndPut distributed locking (see 
> [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]).
>  
> However, this is only prevented if the parent is a table and not if the 
> parent is a view. We should extend [the 
> condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591]
>  to also cover views since conflicting mutations on its children can also 
> lead to inconsistencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-19 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani updated PHOENIX-6124:
--
Attachment: PHOENIX-6124.4.x.000.patch

> Block adding/dropping a column on a parent view for clients <4.15 and for 
> clients that have phoenix.allow.system.catalog.rollback=true
> --
>
> Key: PHOENIX-6124
> URL: https://issues.apache.org/jira/browse/PHOENIX-6124
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Viraj Jasani
>Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6124.4.x.000.patch
>
>
> For pre-4.15 clients, we have to block adding/dropping a column to a table if 
> it has child views since we can’t do any checkAndPut distributed locking (see 
> [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]).
>  
> However, this is only prevented if the parent is a table and not if the 
> parent is a view. We should extend [the 
> condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591]
>  to also cover views since conflicting mutations on its children can also 
> lead to inconsistencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (PHOENIX-6196) Update phoenix.mutate.maxSizeBytes to accept long values

2020-10-19 Thread Ankit Singhal (Jira)
Ankit Singhal created PHOENIX-6196:
--

 Summary: Update phoenix.mutate.maxSizeBytes to accept long values
 Key: PHOENIX-6196
 URL: https://issues.apache.org/jira/browse/PHOENIX-6196
 Project: Phoenix
  Issue Type: Task
Reporter: Ankit Singhal
Assignee: Ankit Singhal


Currently, the config "phoenix.mutate.maxSizeBytes" accepts value in Int, so a 
user can only provide up to 2GB but there are some scenarios like UPSERT SELECT 
from temp table with large rows, where the user may want to set more value to 
it when auto-commit is off. 

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (PHOENIX-6195) Should not import com.google.guava directly

2020-10-19 Thread Istvan Toth (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth resolved PHOENIX-6195.
--
Fix Version/s: 5.1.0
   Resolution: Fixed

Committed to master.

Thanks for the fix [~vjasani].

> Should not import com.google.guava directly
> ---
>
> Key: PHOENIX-6195
> URL: https://issues.apache.org/jira/browse/PHOENIX-6195
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Viraj Jasani
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 5.1.0
>
>
> phoenix-core is broken due to direct imports of com.google.guava 
> (PHOENIX-6181) instead of importing phoenix thirdparty:
> {code:java}
> [WARNING] Used undeclared dependencies found:
> [WARNING]com.google.guava:guava:jar:11.0.2:compile
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Phoenix Hbase 2.3.0 compatibility .. SUCCESS [ 28.384 
> s]
> [INFO] Phoenix Hbase 2.2.1 compatibility .. SUCCESS [  2.402 
> s]
> [INFO] Phoenix Hbase 2.1.6 compatibility .. SUCCESS [  2.816 
> s]
> [INFO] Apache Phoenix 5.1.0-SNAPSHOT .. SUCCESS [  1.407 
> s]
> [INFO] Phoenix Core ... FAILURE [ 43.982 
> s]
> [INFO] Phoenix - Pherf  SKIPPED
> [INFO] Phoenix Client . SKIPPED
> [INFO] Phoenix Server . SKIPPED
> [INFO] Phoenix - Tracing Web Application .. SKIPPED
> [INFO] Phoenix Assembly ... SKIPPED
> [INFO] phoenix-tools 5.1.0-SNAPSHOT ... SKIPPED
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 01:19 min
> [INFO] Finished at: 2020-10-19T16:54:06+05:30
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.1:analyze-only 
> (enforce-dependencies) on project phoenix-core: Dependency problems found -> 
> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR] 
> [ERROR] After correcting the problems, you can resume the build with the 
> command
> [ERROR]   mvn  -rf :phoenix-core
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (PHOENIX-6195) Should not import com.google.guava directly

2020-10-19 Thread Viraj Jasani (Jira)
Viraj Jasani created PHOENIX-6195:
-

 Summary: Should not import com.google.guava directly
 Key: PHOENIX-6195
 URL: https://issues.apache.org/jira/browse/PHOENIX-6195
 Project: Phoenix
  Issue Type: Bug
Reporter: Viraj Jasani
Assignee: Viraj Jasani


phoenix-core is broken due to direct imports of com.google.guava (PHOENIX-6181) 
instead of importing phoenix thirdparty:
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]com.google.guava:guava:jar:11.0.2:compile
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Phoenix Hbase 2.3.0 compatibility .. SUCCESS [ 28.384 s]
[INFO] Phoenix Hbase 2.2.1 compatibility .. SUCCESS [  2.402 s]
[INFO] Phoenix Hbase 2.1.6 compatibility .. SUCCESS [  2.816 s]
[INFO] Apache Phoenix 5.1.0-SNAPSHOT .. SUCCESS [  1.407 s]
[INFO] Phoenix Core ... FAILURE [ 43.982 s]
[INFO] Phoenix - Pherf  SKIPPED
[INFO] Phoenix Client . SKIPPED
[INFO] Phoenix Server . SKIPPED
[INFO] Phoenix - Tracing Web Application .. SKIPPED
[INFO] Phoenix Assembly ... SKIPPED
[INFO] phoenix-tools 5.1.0-SNAPSHOT ... SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 01:19 min
[INFO] Finished at: 2020-10-19T16:54:06+05:30
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.1:analyze-only 
(enforce-dependencies) on project phoenix-core: Dependency problems found -> 
[Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :phoenix-core
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (PHOENIX-6083) View index creation does a checkAndPut on an incorrect row key

2020-10-19 Thread Richard Antal (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Richard Antal reassigned PHOENIX-6083:
--

Assignee: Richard Antal

> View index creation does a checkAndPut on an incorrect row key
> --
>
> Key: PHOENIX-6083
> URL: https://issues.apache.org/jira/browse/PHOENIX-6083
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Richard Antal
>Priority: Critical
>  Labels: phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: image-2020-08-18-11-09-35-080.png, 
> image-2020-08-18-11-09-53-816.png
>
>
> When creating a view index, we "lock" on the indexed and included columns by 
> doing a checkAndPut on the cell: 
> (, ,  the indexed/included column>)
> This is done to prevent another client from concurrently dropping any of the 
> indexed/included columns. This however, is not working as expected since the 
> indexed column naming convention is different (:) 
> rather than just . 
> Thus, concurrent dropping of the column is not prevented and this leads to 
> failure in view index creation with either an NPE or IllegalArgumentException.
> !image-2020-08-18-11-09-35-080.png!
> !image-2020-08-18-11-09-53-816.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (PHOENIX-6192) UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific connection to resolve tenant views

2020-10-19 Thread Viraj Jasani (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viraj Jasani reassigned PHOENIX-6192:
-

Assignee: Viraj Jasani

> UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific 
> connection to resolve tenant views
> ---
>
> Key: PHOENIX-6192
> URL: https://issues.apache.org/jira/browse/PHOENIX-6192
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Viraj Jasani
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> In UpgradeUtil.synchUpdateCacheFreqAllIndexes(), we try to retrieve all child 
> views of each table to make all the view index UPDATE_CACHE_FREQUENCY 
> property values in sync with the view.
> Here however, when iterating over the parent->child link results, we don't 
> use a tenant-specific connection to retrieve a tenant view leading to the 
> PTable resolution failing (see 
> [this|https://github.com/apache/phoenix/blob/264310bd1e6c14996c3cfb11557fc66a012cb01b/phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java#L1369])



--
This message was sent by Atlassian Jira
(v8.3.4#803005)