[jira] [Resolved] (PHOENIX-4378) Unable to set KEEP_DELETED_CELLS to true on RS scanner
[ https://issues.apache.org/jira/browse/PHOENIX-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal resolved PHOENIX-4378. Resolution: Duplicate > Unable to set KEEP_DELETED_CELLS to true on RS scanner > -- > > Key: PHOENIX-4378 > URL: https://issues.apache.org/jira/browse/PHOENIX-4378 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Blocker > Labels: HBase-2.0 > Fix For: 5.1.0 > > > [~jamestaylor], > It seems we may need to fix PHOENIX-4277 differently for HBase 2.0 as we can > only update TTL and maxVersions now in preStoreScannerOpen and cannot return > a new StoreScanner with updated scanInfo. > for reference: > [1]https://issues.apache.org/jira/browse/PHOENIX-4318?focusedCommentId=16249943&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16249943 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (PHOENIX-4378) Unable to set KEEP_DELETED_CELLS to true on RS scanner
[ https://issues.apache.org/jira/browse/PHOENIX-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal reopened PHOENIX-4378: > Unable to set KEEP_DELETED_CELLS to true on RS scanner > -- > > Key: PHOENIX-4378 > URL: https://issues.apache.org/jira/browse/PHOENIX-4378 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Blocker > Labels: HBase-2.0 > Fix For: 5.1.0 > > > [~jamestaylor], > It seems we may need to fix PHOENIX-4277 differently for HBase 2.0 as we can > only update TTL and maxVersions now in preStoreScannerOpen and cannot return > a new StoreScanner with updated scanInfo. > for reference: > [1]https://issues.apache.org/jira/browse/PHOENIX-4318?focusedCommentId=16249943&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16249943 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (PHOENIX-4378) Unable to set KEEP_DELETED_CELLS to true on RS scanner
[ https://issues.apache.org/jira/browse/PHOENIX-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal resolved PHOENIX-4378. Resolution: Fixed > Unable to set KEEP_DELETED_CELLS to true on RS scanner > -- > > Key: PHOENIX-4378 > URL: https://issues.apache.org/jira/browse/PHOENIX-4378 > Project: Phoenix > Issue Type: Bug >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Blocker > Labels: HBase-2.0 > Fix For: 5.1.0 > > > [~jamestaylor], > It seems we may need to fix PHOENIX-4277 differently for HBase 2.0 as we can > only update TTL and maxVersions now in preStoreScannerOpen and cannot return > a new StoreScanner with updated scanInfo. > for reference: > [1]https://issues.apache.org/jira/browse/PHOENIX-4318?focusedCommentId=16249943&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16249943 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-5955) OrphanViewToolIT is flapping
[ https://issues.apache.org/jira/browse/PHOENIX-5955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinyi Yan updated PHOENIX-5955: --- Fix Version/s: 5.1.0 > OrphanViewToolIT is flapping > > > Key: PHOENIX-5955 > URL: https://issues.apache.org/jira/browse/PHOENIX-5955 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Xinyi Yan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5955.4x.patch > > > In several Jenkins runs over the past few days, we've been getting failures > from the OrphanViewToolIT suite, which I believe had been well-behaved until > recently. > {code:java} > 17:40:24 [ERROR] OrphanViewToolIT.testDeleteBaseTableRows:279 > 17:40:24 [ERROR] OrphanViewToolIT.testDeleteBaseTableRows:279 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteChildParentLinkRows:402->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteChildParentLinkRows:402->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteChildViewRows:315->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteChildViewRows:315->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteGrandchildViewRows:344->verifyOrphanFileLineCounts:256->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteGrandchildViewRows:344->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteParentChildLinkRows:374->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeleteParentChildLinkRows:374->verifyOrphanFileLineCounts:255->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeletePhysicalTableLinks:429->verifyLineCount:209 > 17:40:24 [ERROR] > OrphanViewToolIT.testDeletePhysicalTableLinks:424->verifyCountQuery:218 > 17:40:24 [ERROR] > LocalImmutableNonTxIndexIT>BaseIndexIT.testCreateIndexAfterUpsertStarted:2 > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6212) Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs when splitting is disabled
[ https://issues.apache.org/jira/browse/PHOENIX-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chinmay Kulkarni updated PHOENIX-6212: -- Description: We should fix [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65] so that it ensures that splitting SYSTEM.CATALOG fails if either phoenix.allow.system.catalog.rollback=true and/or phoenix.system.catalog.splittable=false Currently this test is not really ensuring that a split fails (see [this comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for more details) was: We should fix [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65] so that it ensures that splitting SYSTEM.CATALOG fails if either phoenix.allow.system.catalog.rollback=true and/or phoenix.system.catalog.splittable=false Currently this test is not really ensuring that a split goes through (see [this comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for more details) > Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs > when splitting is disabled > --- > > Key: PHOENIX-6212 > URL: https://issues.apache.org/jira/browse/PHOENIX-6212 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 5.1.0, 4.16.0 > > > We should fix > [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65] > so that it ensures that splitting SYSTEM.CATALOG fails if either > phoenix.allow.system.catalog.rollback=true and/or > phoenix.system.catalog.splittable=false > Currently this test is not really ensuring that a split fails (see [this > comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for > more details) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6218) Rows deleted count for client side deletes is incorrect for immutable tables with indexes
[ https://issues.apache.org/jira/browse/PHOENIX-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tanuj Khurana updated PHOENIX-6218: --- Summary: Rows deleted count for client side deletes is incorrect for immutable tables with indexes (was: Rows deleted count is incorrect for immutable tables with indexes) > Rows deleted count for client side deletes is incorrect for immutable tables > with indexes > - > > Key: PHOENIX-6218 > URL: https://issues.apache.org/jira/browse/PHOENIX-6218 > Project: Phoenix > Issue Type: Bug >Reporter: Tanuj Khurana >Assignee: Tanuj Khurana >Priority: Major > > For immutable tables if the best query plan for delete uses the data table > and it has an index, the rows deleted count reported is #(rows > updated)/#(tables updated) where # of rows updated only includes data table > rows but the number of tables includes data + index. This reduces the row > count than the actual rows deleted count. > The same problem can also happen if the best query plan uses the index table > and there are more than one index present on the data table. In this case the > rows updated will include both data table and the index table (one used by > the query plan) but because there are other indexes also present the #(tables > updated) will be more and we will get an inaccurate result. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-6218) Rows deleted count is incorrect for immutable tables with indexes
Tanuj Khurana created PHOENIX-6218: -- Summary: Rows deleted count is incorrect for immutable tables with indexes Key: PHOENIX-6218 URL: https://issues.apache.org/jira/browse/PHOENIX-6218 Project: Phoenix Issue Type: Bug Reporter: Tanuj Khurana Assignee: Tanuj Khurana For immutable tables if the best query plan for delete uses the data table and it has an index, the rows deleted count reported is #(rows updated)/#(tables updated) where # of rows updated only includes data table rows but the number of tables includes data + index. This reduces the row count than the actual rows deleted count. The same problem can also happen if the best query plan uses the index table and there are more than one index present on the data table. In this case the rows updated will include both data table and the index table (one used by the query plan) but because there are other indexes also present the #(tables updated) will be more and we will get an inaccurate result. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PHOENIX-6217) WHERE statement that combines values from different column families (that runs on index on a table with SINGLE_CELL_ARRAY_WITH_OFFSETS) doesn't return correct results
Gokcen Iskender created PHOENIX-6217: Summary: WHERE statement that combines values from different column families (that runs on index on a table with SINGLE_CELL_ARRAY_WITH_OFFSETS) doesn't return correct results Key: PHOENIX-6217 URL: https://issues.apache.org/jira/browse/PHOENIX-6217 Project: Phoenix Issue Type: Bug Reporter: Gokcen Iskender CREATE IMMUTABLE TABLE S.TBL_N01( varchar_pk VARCHAR NOT NULL, char_pk CHAR(10) NOT NULL, int_pk INTEGER NOT NULL, long_pk BIGINT NOT NULL, decimal_pk DECIMAL(31, 10) NOT NULL, date_pk DATE NOT NULL, a.varchar_col1 VARCHAR, a.char_col1 CHAR(10), a.int_col1 INTEGER, a.long_col1 BIGINT, a.decimal_col1 DECIMAL(31, 10), a.date1 DATE, b.varchar_col2 VARCHAR, b.char_col2 CHAR(10), b.int_col2 INTEGER, b.long_col2 BIGINT, b.decimal_col2 DECIMAL(31, 10), b.date2 DATE CONSTRAINT pk PRIMARY KEY (varchar_pk, char_pk, int_pk, long_pk DESC, decimal_pk, date_pk)) IMMUTABLE_STORAGE_SCHEME=SINGLE_CELL_ARRAY_WITH_OFFSETS,COLUMN_ENCODED_BYTES=2 CREATE INDEX IF NOT EXISTS IND_N02 ON S.TBL_N01 (long_pk, varchar_pk) INCLUDE (long_col1, long_col2) IMMUTABLE_STORAGE_SCHEME=SINGLE_CELL_ARRAY_WITH_OFFSETS,COLUMN_ENCODED_BYTES=2 String selectFromIndex = "SELECT long_pk, varchar_pk, long_col1, long_col2 FROM " + fullTableName + " where a.long_col1=2 and b.long_col2=3"; rs = conn.createStatement().executeQuery("EXPLAIN " + selectFromIndex); assertTrue(QueryUtil.getExplainPlan(rs).contains(indexName)); rs = conn.createStatement().executeQuery(selectFromIndex); assertTrue(rs.next()); This test fails since the result set is empty. The same query that runs with /*+ NO_INDEX */ hint, returns results -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6155) Prevent doing direct upserts into SYSTEM.TASK from the client
[ https://issues.apache.org/jira/browse/PHOENIX-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-6155: -- Fix Version/s: (was: 4.17.0) (was: 4.16.1) 4.16.0 > Prevent doing direct upserts into SYSTEM.TASK from the client > - > > Key: PHOENIX-6155 > URL: https://issues.apache.org/jira/browse/PHOENIX-6155 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Viraj Jasani >Priority: Major > Fix For: 5.1.0, 4.16.0 > > > In environments with namespace-mapping enabled, we will have to grant write > access to clients in order to make direct upserts into SYSTEM.TASK. Currently > we add a task from the client-side > [here|https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java#L4654]. > In order to implement other Jiras like > [PHOENIX-6154|https://issues.apache.org/jira/browse/PHOENIX-6154] we also may > need to interact with the SYSTEM.TASK table from the client-side. > Instead of doing direct upserts into this table, we should add an endpoint on > SYSTEM.TASK and clients should interact with that. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEPHRA-313) Remove support for ancient HBase releases
[ https://issues.apache.org/jira/browse/TEPHRA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229332#comment-17229332 ] Istvan Toth commented on TEPHRA-313: 1.3 for the 4.x branch. > Remove support for ancient HBase releases > - > > Key: TEPHRA-313 > URL: https://issues.apache.org/jira/browse/TEPHRA-313 > Project: Phoenix Tephra > Issue Type: Improvement >Affects Versions: 0.16.0 >Reporter: Istvan Toth >Assignee: Poorna Chandra >Priority: Major > > Tephra supports positively ancient HBase versions, that are unlikely to be > relevant by now. > Choose a cutoff point, and remove support for all versions older than that. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TEPHRA-313) Remove support for ancient HBase releases
[ https://issues.apache.org/jira/browse/TEPHRA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229325#comment-17229325 ] Andreas Neumann commented on TEPHRA-313: I remember last time we discussed this, we could not do it because Phoenix supports some older versions of HBase. What is the oldest HBase version Phoenix supports now? > Remove support for ancient HBase releases > - > > Key: TEPHRA-313 > URL: https://issues.apache.org/jira/browse/TEPHRA-313 > Project: Phoenix Tephra > Issue Type: Improvement >Affects Versions: 0.16.0 >Reporter: Istvan Toth >Assignee: Poorna Chandra >Priority: Major > > Tephra supports positively ancient HBase versions, that are unlikely to be > relevant by now. > Choose a cutoff point, and remove support for all versions older than that. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (PHOENIX-5472) Typos in the docs description
[ https://issues.apache.org/jira/browse/PHOENIX-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth resolved PHOENIX-5472. -- Fix Version/s: 4.16.0 5.1.0 Resolution: Fixed Backported to 4.x > Typos in the docs description > - > > Key: PHOENIX-5472 > URL: https://issues.apache.org/jira/browse/PHOENIX-5472 > Project: Phoenix > Issue Type: Bug >Reporter: dengziming >Priority: Minor > Fix For: 5.1.0, 4.16.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > some typos to be fixed, for example : > 'a Hbase' change into 'an Hbase' > 'a Htable' change into 'an Htable' > 'a HFile' change into 'an HFile' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (TEPHRA-301) Support HBase 1.5.x
[ https://issues.apache.org/jira/browse/TEPHRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth resolved TEPHRA-301. Resolution: Fixed Changed issue type > Support HBase 1.5.x > --- > > Key: TEPHRA-301 > URL: https://issues.apache.org/jira/browse/TEPHRA-301 > Project: Phoenix Tephra > Issue Type: New Feature >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 0.16.0 > > Attachments: 301-full-v2.txt, 301-full.txt, 301.txt > > > I have a half-baked patch to support HBase 1.5. > Going to post it here soon. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEPHRA-307) Support Hbase 2.3
[ https://issues.apache.org/jira/browse/TEPHRA-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated TEPHRA-307: --- Issue Type: New Feature (was: Improvement) > Support Hbase 2.3 > - > > Key: TEPHRA-307 > URL: https://issues.apache.org/jira/browse/TEPHRA-307 > Project: Phoenix Tephra > Issue Type: New Feature >Affects Versions: 0.15.0-incubating >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 0.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEPHRA-301) Support HBase 1.5.x
[ https://issues.apache.org/jira/browse/TEPHRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated TEPHRA-301: --- Issue Type: New Feature (was: Bug) > Support HBase 1.5.x > --- > > Key: TEPHRA-301 > URL: https://issues.apache.org/jira/browse/TEPHRA-301 > Project: Phoenix Tephra > Issue Type: New Feature >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 0.16.0 > > Attachments: 301-full-v2.txt, 301-full.txt, 301.txt > > > I have a half-baked patch to support HBase 1.5. > Going to post it here soon. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (TEPHRA-309) Add HBase 1.6 compatibility
[ https://issues.apache.org/jira/browse/TEPHRA-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated TEPHRA-309: --- Issue Type: New Feature (was: Task) > Add HBase 1.6 compatibility > --- > > Key: TEPHRA-309 > URL: https://issues.apache.org/jira/browse/TEPHRA-309 > Project: Phoenix Tephra > Issue Type: New Feature >Affects Versions: 0.15.0-incubating >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Blocker > Fix For: 0.16.0 > > > We have added support for HBase 1.6 in Phoenix, but not in Tephra. > While this is not detected by the Phoenix test suite due to the simplified > Tephra implementation it uses with minicluster, this means that Phoenix 4.x > on HBase 1.6 cannot use Tephra on a real cluster. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (TEPHRA-301) Support HBase 1.5.x
[ https://issues.apache.org/jira/browse/TEPHRA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth reopened TEPHRA-301: > Support HBase 1.5.x > --- > > Key: TEPHRA-301 > URL: https://issues.apache.org/jira/browse/TEPHRA-301 > Project: Phoenix Tephra > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 0.16.0 > > Attachments: 301-full-v2.txt, 301-full.txt, 301.txt > > > I have a half-baked patch to support HBase 1.5. > Going to post it here soon. -- This message was sent by Atlassian Jira (v8.3.4#803005)