[jira] [Assigned] (PHOENIX-7111) Metrics for server-side metadata cache

2023-11-16 Thread Stephen Yuan Jiang (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Yuan Jiang reassigned PHOENIX-7111:
---

Assignee: Palash Chauhan

> Metrics for server-side metadata cache
> --
>
> Key: PHOENIX-7111
> URL: https://issues.apache.org/jira/browse/PHOENIX-7111
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: Palash Chauhan
>Assignee: Palash Chauhan
>Priority: Major
>
> Add metrics for monitoring the new metadata caching design. 
>  # Time taken to invalidate cache on all region servers during a DDL operation
>  # Number of failed DDL operations due to failure in cache invalidation
>  # Number of validateLastDDLTimestamp requests per region-server
>  # Cache hits/misses per region-server when validating timestamps



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (PHOENIX-7111) Metrics for server-side metadata cache

2023-11-16 Thread Stephen Yuan Jiang (Jira)


 [ 
https://issues.apache.org/jira/browse/PHOENIX-7111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Yuan Jiang updated PHOENIX-7111:

Summary: Metrics for server-side metadata cache  (was: Metrics for metadata 
cache redesign)

> Metrics for server-side metadata cache
> --
>
> Key: PHOENIX-7111
> URL: https://issues.apache.org/jira/browse/PHOENIX-7111
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: Palash Chauhan
>Priority: Major
>
> Add metrics for monitoring the new metadata caching design. 
>  # Time taken to invalidate cache on all region servers during a DDL operation
>  # Number of failed DDL operations due to failure in cache invalidation
>  # Number of validateLastDDLTimestamp requests per region-server
>  # Cache hits/misses per region-server when validating timestamps



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (PHOENIX-7113) Create a feature flag for invoking MDEI#invalidateServerMetadataCache

2023-11-16 Thread Rushabh Shah (Jira)
Rushabh Shah created PHOENIX-7113:
-

 Summary: Create a feature flag for invoking 
MDEI#invalidateServerMetadataCache
 Key: PHOENIX-7113
 URL: https://issues.apache.org/jira/browse/PHOENIX-7113
 Project: Phoenix
  Issue Type: Sub-task
Reporter: Rushabh Shah


During schema changes, we invoke 
PhoenixRegionServerEndpoint#invalidateServerMetadataCache on all regionservers 
to invalidate cache for the table which is undergoing schema changes.
To handle incompatibilitues during upgrade, we check if 
PhoenixRegionServerEndpoint coproc is loaded or not. If it is not loaded on 
SYSCAT regionserver, then we don't invalidate the cache but if it is loaded on 
SYSCAT regionserver then we call this coproc method on all regionservers. But 
it is possible that during upgrade if we upgrade the system regionservers first 
then PhoenixRegionServerEndpoint is loaded on SYSCAT RS but not loaded on other 
regionservers. This can cause failures during upgrade. 
To avoid this, lets create a new conf property and once all the reginservers 
are upgraded then set that to true.

{code}
String value = conf.get(REGIONSERVER_COPROCESSOR_CONF_KEY);
if (value == null
|| 
!value.contains(PhoenixRegionServerEndpoint.class.getName())) {
// PhoenixRegionServerEndpoint is not loaded. We don't have to 
invalidate the cache.
LOGGER.info("Skip invalidating server metadata cache since 
PhoenixRegionServerEndpoint"
+ " is not loaded");
return;
}
{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OMID-240) Transactional visibility is broken

2023-11-16 Thread Rajeshbabu Chintaguntla (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786871#comment-17786871
 ] 

Rajeshbabu Chintaguntla edited comment on OMID-240 at 11/16/23 5:41 PM:


This issue happening with Inmemory timestamp and commit tables. With HBase 
timestamp and commit tables not able to reproduce this even after 100s 
attempts. Now checking why it's happening with Inmemory tables with additional 
logging.


was (Author: rajeshbabu):
This issue happening with Inmemory timestamp and commit tables. With HBase 
timestamp and commit tables not able to reproduce this even ran 100s of times. 
Now checking why it's happening with Inmemory tables with additional logging.

> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml, 
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
>  > create table test(x float primary key, y float) DISABLE_WAL=true, 
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>  
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0        |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884   |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145   |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OMID-240) Transactional visibility is broken

2023-11-16 Thread Rajeshbabu Chintaguntla (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786871#comment-17786871
 ] 

Rajeshbabu Chintaguntla edited comment on OMID-240 at 11/16/23 5:36 PM:


This issue happening with Inmemory timestamp and commit tables. With HBase 
timestamp and commit tables not able to reproduce this even ran 100s of times. 
Now checking why it's happening with Inmemory tables with additional logging.


was (Author: rajeshbabu):
This issue happening with Inmemory timestamp and commit tables used. With HBase 
timestamp and commit table not able to reproduce this.

> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml, 
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
>  > create table test(x float primary key, y float) DISABLE_WAL=true, 
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>  
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0        |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884   |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145   |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OMID-240) Transactional visibility is broken

2023-11-16 Thread Rajeshbabu Chintaguntla (Jira)


[ 
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786871#comment-17786871
 ] 

Rajeshbabu Chintaguntla commented on OMID-240:
--

This issue happening with Inmemory timestamp and commit tables used. With HBase 
timestamp and commit table not able to reproduce this.

> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
>  Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml, 
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
>  > create table test(x float primary key, y float) DISABLE_WAL=true, 
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>  
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0        |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884   |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145   |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148   |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)