[GitHub] [phoenix-tephra] stoty commented on a change in pull request #103: Tephra 309
stoty commented on a change in pull request #103:
URL: https://github.com/apache/phoenix-tephra/pull/103#discussion_r468333157
##
File path: tephra-hbase-compat-1.4-base/pom.xml
##
@@ -0,0 +1,221 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+org.apache.tephra
+tephra
+0.16.0-incubating-SNAPSHOT
+
+ 4.0.0
+
+ tephra-hbase-compat-1.4-base
+ Apache Tephra HBase 1.4 Compatibility Base
+
+ pom
+
+tephra-hbase-compat-1.4
+tephra-hbase-compat-1.5
+tephra-hbase-compat-1.6
+
+
+
+2.7.4
+
+
+
+
+ org.apache.tephra
+ tephra-api
+ ${project.version}
+
+
+ org.apache.tephra
+ tephra-core
+ ${project.version}
+
+
+ org.apache.hbase
+ hbase
+
+
+
+
+ org.apache.hbase
+ hbase-common
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-client
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-protocol
+ ${hbase14.version}
+ provided
+
+
+ org.apache.hbase
+ hbase-server
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+
+
+ org.apache.tephra
+ tephra-core
+ ${project.version}
+ test-jar
+ test
+
+
+ junit
+ junit
+
+
+ org.slf4j
+ log4j-over-slf4j
+
+
+ org.slf4j
+ jcl-over-slf4j
+
+
+ org.apache.hbase
+ hbase-server
+ ${hbase14.version}
+ test-jar
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-metrics-api
+ ${hbase14.version}
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-metrics
+ ${hbase14.version}
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-testing-util
+ ${hbase14.version}
+ test
+
+
+ asm
+ asm
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+
+
+
+
+
+ org.codehaus.mojo
+ build-helper-maven-plugin
+ 3.0.0
+
+
+ add-source
+ generate-sources
+
+add-source
+
+
+
+ ${project.parent.basedir}/src/main/java
+
+
+
+
+ add-test-source
+ generate-sources
+
+add-test-source
+
+
+
+ ${project.parent.basedir}/src/test/java
+
+
+
+
+
Review comment:
This section copies the common java source files from -common to the
version specific sub-sub-projects that have no source files at all. See the
`` element. The same approach is used in all the -common based
compatibility modules that share the java code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [phoenix-tephra] stoty commented on a change in pull request #103: Tephra 309
stoty commented on a change in pull request #103:
URL: https://github.com/apache/phoenix-tephra/pull/103#discussion_r468333157
##
File path: tephra-hbase-compat-1.4-base/pom.xml
##
@@ -0,0 +1,221 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+org.apache.tephra
+tephra
+0.16.0-incubating-SNAPSHOT
+
+ 4.0.0
+
+ tephra-hbase-compat-1.4-base
+ Apache Tephra HBase 1.4 Compatibility Base
+
+ pom
+
+tephra-hbase-compat-1.4
+tephra-hbase-compat-1.5
+tephra-hbase-compat-1.6
+
+
+
+2.7.4
+
+
+
+
+ org.apache.tephra
+ tephra-api
+ ${project.version}
+
+
+ org.apache.tephra
+ tephra-core
+ ${project.version}
+
+
+ org.apache.hbase
+ hbase
+
+
+
+
+ org.apache.hbase
+ hbase-common
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-client
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-protocol
+ ${hbase14.version}
+ provided
+
+
+ org.apache.hbase
+ hbase-server
+ ${hbase14.version}
+ provided
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+
+
+ org.apache.tephra
+ tephra-core
+ ${project.version}
+ test-jar
+ test
+
+
+ junit
+ junit
+
+
+ org.slf4j
+ log4j-over-slf4j
+
+
+ org.slf4j
+ jcl-over-slf4j
+
+
+ org.apache.hbase
+ hbase-server
+ ${hbase14.version}
+ test-jar
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-metrics-api
+ ${hbase14.version}
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-metrics
+ ${hbase14.version}
+ test
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+ org.apache.hbase
+ hbase-testing-util
+ ${hbase14.version}
+ test
+
+
+ asm
+ asm
+
+
+ org.slf4j
+ slf4j-log4j12
+
+
+
+
+
+
+
+
+
+ org.codehaus.mojo
+ build-helper-maven-plugin
+ 3.0.0
+
+
+ add-source
+ generate-sources
+
+add-source
+
+
+
+ ${project.parent.basedir}/src/main/java
+
+
+
+
+ add-test-source
+ generate-sources
+
+add-test-source
+
+
+
+ ${project.parent.basedir}/src/test/java
+
+
+
+
+
Review comment:
This section copies the common java source files from -common to the
version specific sub-sub-projects that have no source files at all. See the
element. The same approach is used in all the -common based
compatibility modules that share the java code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
