[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-28 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531179#comment-15531179
 ] 

James Taylor commented on PHOENIX-3201:
---

[~an...@apache.org] - there's a bunch of scalar date functions. See all of the 
ones derived from DateScalarFunction. None of these consider the 
phoenix.query.dateFormatTimeZone as far as I know. Please file a separate JIRA 
if you think they should. What does the SQL spec say?

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch, PHOENIX-3201_4.x-HBase-0.98.patch, 
> PHOENIX-3201_4.x-HBase-1.1.patch, PHOENIX-3201_master.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-02 Thread Ankit Singhal (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15458542#comment-15458542
 ] 

Ankit Singhal commented on PHOENIX-3201:


[~jamestaylor]/[~samarthjain], This can be follow up in different JIRA(may be 
under PHOENIX-3220)  but don't these functions( DAYOFWEEK, DAYOFYEAR and 
DAYFORMONTH ) should also adhere timezone 
property(phoenix.query.dateFormatTimeZone) like TO_DATE and other function do.



> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch, PHOENIX-3201_4.x-HBase-0.98.patch, 
> PHOENIX-3201_4.x-HBase-1.1.patch, PHOENIX-3201_master.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-01 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456705#comment-15456705
 ] 

Hadoop QA commented on PHOENIX-3201:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12826709/PHOENIX-3201_4.x-HBase-0.98.patch
  against 4.x-HBase-0.98 branch at commit 
06d37e534d1e07e8206eaefb82dd7bf3f50455b0.
  ATTACHMENT ID: 12826709

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/551//console

This message is automatically generated.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch, PHOENIX-3201_4.x-HBase-0.98.patch, 
> PHOENIX-3201_4.x-HBase-1.1.patch, PHOENIX-3201_master.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-01 Thread prakul agarwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456680#comment-15456680
 ] 

prakul agarwal commented on PHOENIX-3201:
-

[~samarthjain] Have attached the patches for the said branch.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch, PHOENIX-3201_4.x-HBase-0.98.patch, 
> PHOENIX-3201_4.x-HBase-1.1.patch, PHOENIX-3201_master.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-01 Thread Samarth Jain (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456145#comment-15456145
 ] 

Samarth Jain commented on PHOENIX-3201:
---

Ah, that is correct. Prakul, do upload the patches for the 4.x and master 
branches then. Make sure to use random table names in the tests you added.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-01 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456136#comment-15456136
 ] 

James Taylor commented on PHOENIX-3201:
---

[~samarthjain] - we can't put this into 4.8 branches as it doesn't meet our 
patch release criteria. Just 4.x and master for 4.9.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-09-01 Thread Samarth Jain (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456129#comment-15456129
 ] 

Samarth Jain commented on PHOENIX-3201:
---

[~prakul] - can you upload separate patches for the 4.8-* and 4.x-* branches. 
The 4.x* branches have DataTimeIT extending BaseHBaseManagedTimeTableReuseIT 
where as 4.8* don't. 

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-29 Thread prakul agarwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447199#comment-15447199
 ] 

prakul agarwal commented on PHOENIX-3201:
-

[~jamestaylor] Submitted a rebased patch.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-29 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446801#comment-15446801
 ] 

James Taylor commented on PHOENIX-3201:
---

[~prakul] - can you give [~samarthjain] a rebased patch please?

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437822#comment-15437822
 ] 

James Taylor commented on PHOENIX-3201:
---

Thanks for the tip, [~samarthjain]. Would be good to update the contributing.md 
page with this info.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread Samarth Jain (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437817#comment-15437817
 ] 

Samarth Jain commented on PHOENIX-3201:
---

{code}
git format-patch --stdout origin > PHOENIX-3201.patch
{code}

doesn't work for me always. Try this instead (after committing changes to your 
local branch, that is) :

{code}
git format-patch --stdout HEAD^ > PHOENIX-3201.patch
{code}

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437804#comment-15437804
 ] 

James Taylor commented on PHOENIX-3201:
---

Still not getting a test run, [~prakul]. Make sure you patch is rebased onto 
latest and make it against master. If you run this command after committing 
your change locally, you should get what you need to attach here:
{code}
git format-patch --stdout origin > PHOENIX-3201.patch
{code}

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437516#comment-15437516
 ] 

Hadoop QA commented on PHOENIX-3201:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12825516/PHOENIX-3201.patch
  against master branch at commit 9cc77c8104245a138a62ba251e926e14a74d8c11.
  ATTACHMENT ID: 12825516

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/536//console

This message is automatically generated.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437434#comment-15437434
 ] 

James Taylor commented on PHOENIX-3201:
---

Thanks for the pull - FYI, you'll need to attach 
https://patch-diff.githubusercontent.com/raw/apache/phoenix/pull/197.patch as 
an attachment here to get a test run in.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread prakul agarwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437431#comment-15437431
 ] 

prakul agarwal commented on PHOENIX-3201:
-

Raising a pull request on github (as git format-patch... is generating a 
weirdly big patch)
https://github.com/apache/phoenix/pull/197

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437422#comment-15437422
 ] 

ASF GitHub Bot commented on PHOENIX-3201:
-

GitHub user prakul opened a pull request:

https://github.com/apache/phoenix/pull/197

PHOENIX-3201 Implement DAYOFWEEK and DAYOFYEAR built-in functions



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prakul/phoenix phoe-3201

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/phoenix/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit cfd4c17563b332d91eb679b92a826ef22aa6bcdd
Author: prakul 
Date:   2016-08-25T18:32:48Z

PHOENIX-3201 Implement DAYOFWEEK and DAYOFYEAR built-in functions




> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-25 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15437309#comment-15437309
 ] 

Hadoop QA commented on PHOENIX-3201:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12825504/PHOENIX-3201.patch
  against master branch at commit 9cc77c8104245a138a62ba251e926e14a74d8c11.
  ATTACHMENT ID: 12825504

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/535//console

This message is automatically generated.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3201.patch
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (PHOENIX-3201) Implement DAYOFWEEK and DAYOFYEAR built-in functions

2016-08-23 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-3201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434028#comment-15434028
 ] 

James Taylor commented on PHOENIX-3201:
---

Take a look at PHOENIX-1846 for a guide.

> Implement DAYOFWEEK and DAYOFYEAR built-in functions
> 
>
> Key: PHOENIX-3201
> URL: https://issues.apache.org/jira/browse/PHOENIX-3201
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>Assignee: prakul agarwal
>  Labels: newbie
> Fix For: 4.9.0
>
>
> DAYOFWEEK() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005645
> DAYOFYEAR() as documented here: 
> https://docs.oracle.com/cd/B19188_01/doc/B15917/sqfunc.htm#i1005676



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)