[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-28 Thread Francis Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531229#comment-15531229
 ] 

Francis Chuang commented on PHOENIX-3259:
-

 [~jamestaylor], replacing guava 12 with guava 13 worked! Thanks for the work 
around!

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-27 Thread Francis Chuang (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528453#comment-15528453
 ] 

Francis Chuang commented on PHOENIX-3259:
-

Are there any workarounds for this in the meantime?

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-10 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480408#comment-15480408
 ] 

Josh Elser commented on PHOENIX-3259:
-

Even better! I'll hold off on trying to put something together then :). Happy 
to help.

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-10 Thread James Taylor (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480391#comment-15480391
 ] 

James Taylor commented on PHOENIX-3259:
---

Totally understand, [~elserj]. I think we can hold off on this as the Tephra 
folks have committed to get rid of the guava 13 dependency in a release soon 
(TEPHRA-181). Thanks for the input, though!

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-10 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15480379#comment-15480379
 ] 

Josh Elser commented on PHOENIX-3259:
-

bq. I'm not sure I'm fully recovered to take on ripping through all of the 
dependencies this fat-jar will be bundling and updating L again.. Let me see 
how the day goes.

I was thinking about this some more this morning. I don't think this would be 
bringing in more dependencies than are already included in the binary tarball. 
This might not require a herculean effort..

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-09 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477578#comment-15477578
 ] 

Josh Elser commented on PHOENIX-3259:
-

bq. Any bandwidth/interest in this one?

If it were only packaging, I'd say yes. I'm not sure I'm fully recovered to 
take on ripping through all of the dependencies this fat-jar will be bundling 
and updating L again.. Let me see how the day goes.

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-09 Thread James Taylor (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477541#comment-15477541
 ] 

James Taylor commented on PHOENIX-3259:
---

I see - makes sense. Any bandwidth/interest in this one?

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-09 Thread Josh Elser (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477527#comment-15477527
 ] 

Josh Elser commented on PHOENIX-3259:
-

bq. would this be difficult? Changes mainly to phoenix-assembly/pom.xml? Does 
it sound like the right approach, or is there a better approach?

I would recommend creating the fat-jar in a new module. Leave the 
phoenix-assembly module just for creating the tarball. Maven works best when 
you create one artifact per module. The shade-plugin, by default, will replace 
the "default' artifact that is created with the one it creates (e.g. with a 
module "phoenix-transaction-manager", 
phoenix-transaction-manager-4.9.0-HBase-1.2-SNAPSHOT.jar would be the fat-jar), 
and then the phoenix-assembly component descriptors can be updated to just 
bring in that new jar to the tarball by the normal groupId:artifactId method.

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PHOENIX-3259) Create fat jar for transaction manager

2016-09-09 Thread James Taylor (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477505#comment-15477505
 ] 

James Taylor commented on PHOENIX-3259:
---

[~elserj] - would this be difficult? Changes mainly to 
phoenix-assembly/pom.xml? Does it sound like the right approach, or is there a 
better approach?

> Create fat jar for transaction manager
> --
>
> Key: PHOENIX-3259
> URL: https://issues.apache.org/jira/browse/PHOENIX-3259
> Project: Phoenix
>  Issue Type: Bug
>Reporter: James Taylor
>
> Due to the incompatible guava version in HBase (12 instead of 13), the 
> transaction manager will not work by just pointing it to the HBase lib dir. A 
> reasonable alternative would be for Phoenix to build another fat jar 
> specifically for the transaction manager which includes all necessary 
> dependencies (namely guava 13). Then the bin/tephra script (we should rename 
> that to tephra.sh perhaps?) would simply need to have this jar on the 
> classpath.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)