[jira] [Commented] (PHOENIX-3672) Change tests extending BaseQueryIT to use unique table names

2017-02-15 Thread Samarth Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868295#comment-15868295
 ] 

Samarth Jain commented on PHOENIX-3672:
---

Thanks for the reviews.

> Change tests extending BaseQueryIT to use unique table names
> 
>
> Key: PHOENIX-3672
> URL: https://issues.apache.org/jira/browse/PHOENIX-3672
> Project: Phoenix
>  Issue Type: Task
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3672.patch
>
>
> This is important for making sure we have good coverage for column encoding 
> and any new features we will add.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (PHOENIX-3672) Change tests extending BaseQueryIT to use unique table names

2017-02-14 Thread James Taylor (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867226#comment-15867226
 ] 

James Taylor commented on PHOENIX-3672:
---

+1. Thanks for converting these!

> Change tests extending BaseQueryIT to use unique table names
> 
>
> Key: PHOENIX-3672
> URL: https://issues.apache.org/jira/browse/PHOENIX-3672
> Project: Phoenix
>  Issue Type: Task
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3672.patch
>
>
> This is important for making sure we have good coverage for column encoding 
> and any new features we will add.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (PHOENIX-3672) Change tests extending BaseQueryIT to use unique table names

2017-02-14 Thread Thomas D'Silva (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866929#comment-15866929
 ] 

Thomas D'Silva commented on PHOENIX-3672:
-

+1

> Change tests extending BaseQueryIT to use unique table names
> 
>
> Key: PHOENIX-3672
> URL: https://issues.apache.org/jira/browse/PHOENIX-3672
> Project: Phoenix
>  Issue Type: Task
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3672.patch
>
>
> This is important for making sure we have good coverage for column encoding 
> and any new features we will add.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (PHOENIX-3672) Change tests extending BaseQueryIT to use unique table names

2017-02-14 Thread Samarth Jain (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866927#comment-15866927
 ] 

Samarth Jain commented on PHOENIX-3672:
---

I am going to go ahead push this patch to the encodecolumns2 branch for now. 
Will amend or revert if needed.

> Change tests extending BaseQueryIT to use unique table names
> 
>
> Key: PHOENIX-3672
> URL: https://issues.apache.org/jira/browse/PHOENIX-3672
> Project: Phoenix
>  Issue Type: Task
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-3672.patch
>
>
> This is important for making sure we have good coverage for column encoding 
> and any new features we will add.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)