[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925600#comment-15925600
]
Maryann Xue commented on PHOENIX-3727:
--
Update: Synced master branch on my local copy and fixed all compilation bugs
after merge, but hitting some issues now. There has been some big changes on
both sides, and some of them are not bugs but just ref changes. I'm fixing one
bug now.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905830#comment-15905830
]
Maryann Xue commented on PHOENIX-3727:
--
Thank you, [~rajeshbabu] for committing this! Was going to run your script and
get a full test result and then sync from master branch right after that. But
right now I am stuck. One of the hanging tests depended on the fix of
CALCITE-1688, so I had to make a local build of Calcite before I could run the
tests, but it turned out that 'mvn install' had probably been broken on Calcite
master branch. I just asked in the dev list and hope I'll be able to resolve
that soon.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904447#comment-15904447
]
Rajeshbabu Chintaguntla commented on PHOENIX-3727:
--
I will add tests [~jamestaylor]. [~maryannxue] Can you please sync up calcite
branch with master.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904001#comment-15904001
]
Hudson commented on PHOENIX-3727:
-
SUCCESS: Integrated in Jenkins build Phoenix-master #1585 (See
[https://builds.apache.org/job/Phoenix-master/1585/])
PHOENIX-3727 Upserts into salted table are failing in Phoenix-Calcite (samarth:
rev 66a152a94d94aeb1c13f5e0baab413d6d9577d3a)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903652#comment-15903652
]
James Taylor commented on PHOENIX-3727:
---
Would it be possible to file a JIRA to add the test (and add the test if it's
easy)? I don't want to hold up the new RC, though.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903648#comment-15903648
]
Rajeshbabu Chintaguntla commented on PHOENIX-3727:
--
[~samarthjain] There are no tests for that case but there's is the bug.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (PHOENIX-3727) Upserts into salted table are failing in Phoenix-Calcite
[
https://issues.apache.org/jira/browse/PHOENIX-3727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903593#comment-15903593
]
Rajeshbabu Chintaguntla commented on PHOENIX-3727:
--
[~jamestaylor] [~samarthjain] My patch at PHOENIX-3351 added a regression that
pkvalue of salted byte is replaced by multi tenant value or view index id when
upsert select happen at client. This patch fixes that. Would be better to have
ti 4.10.0.
> Upserts into salted table are failing in Phoenix-Calcite
>
>
> Key: PHOENIX-3727
> URL: https://issues.apache.org/jira/browse/PHOENIX-3727
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
> Labels: calcite
> Fix For: 4.10.0
>
> Attachments: PHOENIX-3727.patch
>
>
> {noformat}
> testMutableTableIndexMaintanenceSaltedSalted(org.apache.phoenix.end2end.index.SaltedIndexIT)
> Time elapsed: 4.607 sec <<< ERROR!
> java.sql.SQLException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 2
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanence(SaltedIndexIT.java:123)
> at
> org.apache.phoenix.end2end.index.SaltedIndexIT.testMutableTableIndexMaintanenceSaltedSalted(SaltedIndexIT.java:74)
> {noformat}
> This is because for salted tables we are changing column indexes within
> UpsertCompiler#upsertSelect so with preparedStatements we increment
> columnindexes by 1 so at some point of time we get
> ArrayIndexOutOfBoundsException.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
