[jira] [Commented] (PHOENIX-3980) Wrap iterator returned by BaseQueryPlan so that it always closes dependencies
[ https://issues.apache.org/jira/browse/PHOENIX-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16067204#comment-16067204 ] Hudson commented on PHOENIX-3980: - FAILURE: Integrated in Jenkins build Phoenix-master #1669 (See [https://builds.apache.org/job/Phoenix-master/1669/]) PHOENIX-3980 Wrap iterator returned by BaseQueryPlan so that it always (thomas: rev 21d648a9282579a6f1d03b9c97df120a1355dbaf) * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java > Wrap iterator returned by BaseQueryPlan so that it always closes dependencies > - > > Key: PHOENIX-3980 > URL: https://issues.apache.org/jira/browse/PHOENIX-3980 > Project: Phoenix > Issue Type: Bug >Reporter: Thomas D'Silva >Assignee: Thomas D'Silva > Fix For: 4.12.0, 4.11.1 > > Attachments: PHOENIX-3980.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3980) Wrap iterator returned by BaseQueryPlan so that it always closes dependencies
[ https://issues.apache.org/jira/browse/PHOENIX-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065938#comment-16065938 ] Samarth Jain commented on PHOENIX-3980: --- Looks good, [~tdsilva]. +1. I think we should commit this to the 4.11 branches too. > Wrap iterator returned by BaseQueryPlan so that it always closes dependencies > - > > Key: PHOENIX-3980 > URL: https://issues.apache.org/jira/browse/PHOENIX-3980 > Project: Phoenix > Issue Type: Bug >Reporter: Thomas D'Silva >Assignee: Thomas D'Silva > Fix For: 4.12.0 > > Attachments: PHOENIX-3980.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-3980) Wrap iterator returned by BaseQueryPlan so that it always closes dependencies
[
https://issues.apache.org/jira/browse/PHOENIX-3980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065930#comment-16065930
]
Hadoop QA commented on PHOENIX-3980:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12874798/PHOENIX-3980.patch
against master branch at commit 3c68a87ef80d1443d2abfaa8e485a00f9780adbc.
ATTACHMENT ID: 12874798
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
50 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.MutableQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CreateTableIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1138//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1138//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1138//console
This message is automatically generated.
> Wrap iterator returned by BaseQueryPlan so that it always closes dependencies
> -
>
> Key: PHOENIX-3980
> URL: https://issues.apache.org/jira/browse/PHOENIX-3980
> Project: Phoenix
> Issue Type: Bug
>Reporter: Thomas D'Silva
>Assignee: Thomas D'Silva
> Fix For: 4.12.0
>
> Attachments: PHOENIX-3980.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
