[jira] [Commented] (PHOENIX-4294) Allow scalar function to declare that it's not thread safe

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209815#comment-16209815
 ] 

Hudson commented on PHOENIX-4294:
-

SUCCESS: Integrated in Jenkins build Phoenix-master #1842 (See 
[https://builds.apache.org/job/Phoenix-master/1842/])
PHOENIX-4294 Allow scalar function to declare that it's not thread safe 
(jtaylor: rev ccc44386e05fd7191cd498c8e35b4bb96df2eef7)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/function/ScalarFunction.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/expression/visitor/CloneExpressionVisitor.java


> Allow scalar function to declare that it's not thread safe
> --
>
> Key: PHOENIX-4294
> URL: https://issues.apache.org/jira/browse/PHOENIX-4294
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.13.0, 4.12.1
>
> Attachments: PHOENIX-4294.patch
>
>
> We have our CloneExpressionVisitor which determines when an expression 
> subtree needs to be cloned. For ease of use and clarity, we should have a new 
> method on ScalarFunction that may be overridden to determine when the 
> function is cloned versus not cloned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (PHOENIX-4294) Allow scalar function to declare that it's not thread safe

[Thomas D'Silva (JIRA)]

[ 
https://issues.apache.org/jira/browse/PHOENIX-4294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208774#comment-16208774
 ] 

Thomas D'Silva commented on PHOENIX-4294:
-

+1

> Allow scalar function to declare that it's not thread safe
> --
>
> Key: PHOENIX-4294
> URL: https://issues.apache.org/jira/browse/PHOENIX-4294
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: James Taylor
>Assignee: James Taylor
> Fix For: 4.12.1
>
> Attachments: PHOENIX-4294.patch
>
>
> We have our CloneExpressionVisitor which determines when an expression 
> subtree needs to be cloned. For ease of use and clarity, we should have a new 
> method on ScalarFunction that may be overridden to determine when the 
> function is cloned versus not cloned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)