[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-23 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487911#comment-16487911
 ] 

Hudson commented on PHOENIX-4726:
-

FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1885 (See 
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/1885/])
PHOENIX-4726 save index build timestamp -- for SYNC case only (vincentpoon: rev 
78594437e89fdb06f02cb29405193ef827596c49)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
Revert "PHOENIX-4726 save index build timestamp -- for SYNC case only" 
(vincentpoon: rev b539466bcc19232b7bc3eaff367d11b3f64f0228)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
PHOENIX-4726 save sync index build start timestamp (vincentpoon: rev 
1966edb1986a387580e0d06bd819b52ae9378ea1)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java


> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475332#comment-16475332
 ] 

Hudson commented on PHOENIX-4726:
-

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1891 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1891/])
Revert "PHOENIX-4726 save index build timestamp -- for SYNC case only" 
(vincentpoon: rev 816ef5d4075339c3ad45d881c9e8fc7e7d19f470)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
PHOENIX-4726 save sync index build start timestamp (vincentpoon: rev 
75e8f70babec637ef417644c6c36557e23332a95)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java


> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475144#comment-16475144
 ] 

Hudson commented on PHOENIX-4726:
-

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1890 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1890/])
PHOENIX-4726 save index build timestamp -- for SYNC case only (vincentpoon: rev 
1907f74a61542d993245e9a9849dc2d9b148f6e1)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java


> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474791#comment-16474791
 ] 

Hudson commented on PHOENIX-4726:
-

ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #131 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/131/])
Revert "PHOENIX-4726 save index build timestamp -- for SYNC case only" 
(vincentpoon: rev 09d0b3a5fd2bffd5dc9a54a84b71e92686fecea7)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
PHOENIX-4726 save sync index build start timestamp (vincentpoon: rev 
d175c646562c7b3e5e944a81cab38157dc385915)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java


> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-14 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474487#comment-16474487
 ] 

Hudson commented on PHOENIX-4726:
-

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #130 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/130/])
PHOENIX-4726 save index build timestamp -- for SYNC case only (vincentpoon: rev 
7ebba49d000bb221a8de45e70b4c0afb3b9355a3)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java


> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472825#comment-16472825
 ] 

Xu Cang commented on PHOENIX-4726:
--

uploaded new patch. It addressed Vincent's comment.

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.4.patch, PHOENIX-4726.patch.1, 
> PHOENIX-4726.patch.2, PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472667#comment-16472667
 ] 

Xu Cang commented on PHOENIX-4726:
--

"Never mind - I see now you're using a dynamic column. Is that the way we want 
it to be? "


– Xu:  Yes, we had 2 similar timestamps already as dynamic columns. 

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472668#comment-16472668
 ] 

Xu Cang commented on PHOENIX-4726:
--

"[~xucang] Can you use EnvironmentEdgeManager.currentTimeMillis() instead of 
System.currentTimeMillis() ?

Thanks!"

 

--Xu: will do.

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472531#comment-16472531
 ] 

Vincent Poon commented on PHOENIX-4726:
---

Sure, will do

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472527#comment-16472527
 ] 

James Taylor commented on PHOENIX-4726:
---

FYI, we're getting ready to roll the next RC for 4.14. Would you mind checking 
this in, [~vincentpoon] (assuming it's a good one to have in there)?

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472525#comment-16472525
 ] 

James Taylor commented on PHOENIX-4726:
---

Never mind - I see now you're using a dynamic column. Is that the way we want 
it to be? 

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472523#comment-16472523
 ] 

Vincent Poon commented on PHOENIX-4726:
---

[~jamestaylor] this is a dynamic column - is it still required to do 
addColumnIfNotExists for that ?

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472518#comment-16472518
 ] 

James Taylor commented on PHOENIX-4726:
---

[~xucang]. Thanks for the patch. You need to handle the upgrade path too. 
That's what handles the incremental schema changes to SYSTEM.CATALOG when you 
upgrade to a new minor release. See 
ConnectionQueryServicesImpl.upgradeSystemCatalogIfRequired(). You'll need to 
add another addColumnIfNotExists call here:
{code:java}
        if (currentServerSideTableTimeStamp < 
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0) {

            metaConnection = addColumnsIfNotExists(

              metaConnection,

              PhoenixDatabaseMetaData.SYSTEM_CATALOG,

              MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_14_0,

              PhoenixDatabaseMetaData.TRANSACTION_PROVIDER + " "

                + PTinyint.INSTANCE.getSqlTypeName());{code}

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472481#comment-16472481
 ] 

Vincent Poon commented on PHOENIX-4726:
---

[~xucang] Can you use EnvironmentEdgeManager.currentTimeMillis() instead of 
System.currentTimeMillis() ?

Thanks!

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-11 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472474#comment-16472474
 ] 

Vincent Poon commented on PHOENIX-4726:
---

+1 [~xucang] , thanks for the patch

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-10 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471250#comment-16471250
 ] 

Xu Cang commented on PHOENIX-4726:
--

[~tdsilva]

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Assignee: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-09 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469519#comment-16469519
 ] 

Xu Cang commented on PHOENIX-4726:
--

[~vincentpoon] thanks. I changed it in patch3.

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2, 
> PHOENIX-4726.patch.3
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-08 Thread Vincent Poon (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468196#comment-16468196
 ] 

Vincent Poon commented on PHOENIX-4726:
---

I think we can call it "INDEX_CREATED_DATE", or even just "CREATED_DATE" to 
keep with the existing naming convention.  This is the base case, and async 
differentiates with prepending ASYNC_

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1, PHOENIX-4726.patch.2
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-07 Thread Xu Cang (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466493#comment-16466493
 ] 

Xu Cang commented on PHOENIX-4726:
--

uploaded a patch.

Testing step:
 # create a table. upsert some data.
 # Create a sync index. (not async way)
 # check the 'SYNC_INDEX_CREATED_DATE' value

Testing oupput as below,

0: jdbc:phoenix:> select TABLE_SCHEM, 
TABLE_NAME,COLUMN_NAME,SYNC_INDEX_CREATED_DATE from 
SYSTEM.CATALOG(SYNC_INDEX_CREATED_DATE DATE) where SYNC_INDEX_CREATED_DATE is 
not NULL;
+--+-+--+--+
| TABLE_SCHEM  | TABLE_NAME  | COLUMN_NAME  | SYNC_INDEX_CREATED_DATE  |
+--+-+--+--+
|  | MY_IDX2 |  | 2018-05-07 21:08:38.780  |
|  | MY_TABLE    |  | 2018-05-07 21:01:55.806  |
|  | MY_TABLE2   |  | 2018-05-07 21:02:38.250  |
| SYSTEM   | CATALOG |  | 2018-05-07 20:55:42.008  |
| SYSTEM   | FUNCTION    |  | 2018-05-07 20:55:47.547  |
| SYSTEM   | SEQUENCE    |  | 2018-05-07 20:55:44.635  |
| SYSTEM   | STATS   |  | 2018-05-07 20:55:45.939  |
+--+-+--+--+
7 rows selected (0.105 seconds)
0: jdbc:phoenix:>

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Priority: Minor
> Attachments: PHOENIX-4726.patch.1
>
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (PHOENIX-4726) save index build timestamp -- for SYNC case only.

2018-05-07 Thread James Taylor (JIRA) 

[ 
https://issues.apache.org/jira/browse/PHOENIX-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466378#comment-16466378
 ] 

James Taylor commented on PHOENIX-4726:
---

One way you can get a timestamp is by looking at the cell timestamp of the 
INDEX_STATE column (i.e. column qualifier) on the index table header row in 
SYSTEM.CATALOG.

> save index build timestamp -- for SYNC case only.
> -
>
> Key: PHOENIX-4726
> URL: https://issues.apache.org/jira/browse/PHOENIX-4726
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Xu Cang
>Priority: Minor
>
> save index build timestamp, similar to ASYNC_REBUILD_TIMESTAMP,  or 
> ASYNC_CREATED_DATE
> ("SYNC_INDEX_CREATED_DATE" is my proposed name for SYNC case.)
>  
> Check IndexUtil.java for related code.
> The reason this can be useful is: We saw a case index state stuck in 'b' for 
> quite some long time. And without a timestamp to indicate where it started, 
> it's hard to tell if this is a legit running task or stuck...
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)