[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515381#comment-16515381
]
Hudson commented on PHOENIX-4786:
-
ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #1895 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/1895/])
PHOENIX-4786 Reduce log level to debug when logging new aggregate row
(rajeshbabu: rev 6acdae0ff1a63980f40fe1b794d40ab949cc423d)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514670#comment-16514670
]
Hudson commented on PHOENIX-4786:
-
ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1917 (See
[https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1917/])
PHOENIX-4786 Reduce log level to debug when logging new aggregate row
(rajeshbabu: rev 175fe3fae0577fdc769c8ffbada9a3c2e2d6fb91)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514622#comment-16514622
]
Hudson commented on PHOENIX-4786:
-
ABORTED: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #156 (See
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/156/])
PHOENIX-4786 Reduce log level to debug when logging new aggregate row
(rajeshbabu: rev a0ef6613dfde647ac9b680744b4628dd2423c33f)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514457#comment-16514457
]
Geoffrey Jacoby commented on PHOENIX-4786:
--
+1, thanks [~rajeshbabu]
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514445#comment-16514445
]
Rajeshbabu Chintaguntla commented on PHOENIX-4786:
--
Removed logging keyvalues in the attached patch. Will commit it.
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch, PHOENIX-4786_v2.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514205#comment-16514205
]
Rajeshbabu Chintaguntla commented on PHOENIX-4786:
--
bq.Could this be either put in TRACE, or with a flag to turn off completely?
Some organizations forbid any customer data in logs for compliance reasons.
Agree. I can remove it.
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514173#comment-16514173
]
Geoffrey Jacoby commented on PHOENIX-4786:
--
Could this be either put in TRACE, or with a flag to turn off completely? Some
organizations forbid any customer data in logs for compliance reasons.
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PHOENIX-4786) Reduce log level to debug when logging new aggregate row key found and added results for scan ordered queries
[
https://issues.apache.org/jira/browse/PHOENIX-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16514169#comment-16514169
]
Rajeshbabu Chintaguntla commented on PHOENIX-4786:
--
Trivial patch.
> Reduce log level to debug when logging new aggregate row key found and added
> results for scan ordered queries
> -
>
> Key: PHOENIX-4786
> URL: https://issues.apache.org/jira/browse/PHOENIX-4786
> Project: Phoenix
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Fix For: 5.0.0, 4.15.0
>
> Attachments: PHOENIX-4786.patch
>
>
> Currently we are logging key value when the new aggregate row found for scan
> ordered queries which is info log. This is going to add lot of overhead to
> the queries because sometimes we may write almost all the rows into log.
> {noformat}
> results.add(keyValue);
> if (logger.isInfoEnabled()) {
> logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> + keyValue
> + ",for current key "
> + Bytes.toStringBinary(currentKey.get(),
> currentKey.getOffset(),
> currentKey.getLength()) + ", aggregated
> values: "
> + Arrays.asList(rowAggregators),
> ScanUtil.getCustomAnnotations(scan)));
> }
> {noformat}
> {noformat}
> [root@ctr-e138-1518143905142-358323-01-10 hbase]# grep "Adding new
> aggregate row: "
> hbase-hbase-regionserver-ctr-e138-1518143905142-358323-01-10.log.* | wc -l
> 19082854
> {noformat}
> It's changed recently as part of PHOENIX-4742 so better to make it debug only.
> {noformat}
> -if (logger.isDebugEnabled()) {
> -logger.debug(LogUtil.addCustomAnnotations("Adding
> new aggregate row: "
> +if (logger.isInfoEnabled()) {
> +logger.info(LogUtil.addCustomAnnotations("Adding new
> aggregate row: "
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
