[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-2722:
---
Attachment: PHOENIX-2722_v1_rebased.patch
[~jamestaylor], is it ready for commit now?
> support mysql "limit,offset" clauses
> -
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Minor
> Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch,
> PHOENIX-2722_v1_rebased.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so
> users might need to see that they are not using them as column name or
> something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-2722:
---
Attachment: PHOENIX-2722_formatted.patch
bq. I don't understand the need for this grammar change, as I thought this was
about adding support for OFFSET?
{code}
[ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
{code}
In order to make OFFSET clause compatible with calcite, I need to add ROW|ROWS
to it , and that will not be accurate until we support FETCH syntax for limit
also as per SQL 2008.
bq. Regarding the white space changes.
Sorry I din't know running command+shift+F on empty space results in formatting
of whole file. I have reverted those changes in attached patch.
> support mysql "limit,offset" clauses
> -
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Minor
> Attachments: PHOENIX-2722.patch, PHOENIX-2722_formatted.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so
> users might need to see that they are not using them as column name or
> something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-2722:
---
Description:
For serial query(query with “serial" hint or “limit" without "order by”), we
can limit each scan(using page filter) to “limit+offset” instead of limit
earlier.
And then, for all queries, we can forward the relevant client iterators to the
offset provided and then return the result.
syntax
{code}
[ LIMIT { count } ]
[ OFFSET start [ ROW | ROWS ] ]
[ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
{code}
Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so users
might need to see that they are not using them as column name or something.
WDYT, [~jamestaylor]
was:
For serial query(query with “serial" hint or “limit" without "order by”), we
can limit each scan(using page filter) to “limit+offset” instead of limit
earlier.
And then, for all queries, we can forward the relevant client iterators to the
offset provided and then return the result.
syntax
{code}
[ LIMIT { count } ]
[ OFFSET start [ ROW | ROWS ] ]
[ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
{code}
Some new keywords() are getting introduced so users might need to see that they
are not using them as column name or something.
WDYT, [~jamestaylor]
> support mysql "limit,offset" clauses
> -
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Minor
> Attachments: PHOENIX-2722.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords(OFFSET,FETCH,ROW, ROWS,ONLY) are getting introduced so
> users might need to see that they are not using them as column name or
> something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[
https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-2722:
---
Description:
For serial query(query with “serial" hint or “limit" without "order by”), we
can limit each scan(using page filter) to “limit+offset” instead of limit
earlier.
And then, for all queries, we can forward the relevant client iterators to the
offset provided and then return the result.
syntax
{code}
[ LIMIT { count } ]
[ OFFSET start [ ROW | ROWS ] ]
[ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
{code}
Some new keywords() are getting introduced so users might need to see that they
are not using them as column name or something.
WDYT, [~jamestaylor]
was:
For serial query(query with “serial" hint or “limit" without "order by”), we
can limit each scan(using page filter) to “limit+offset” instead of limit
earlier.
And then, for all queries, we can forward the relevant client iterators to the
offset provided and then return the result.
WDYT, [~jamestaylor]
> support mysql "limit,offset" clauses
> -
>
> Key: PHOENIX-2722
> URL: https://issues.apache.org/jira/browse/PHOENIX-2722
> Project: Phoenix
> Issue Type: New Feature
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Minor
> Attachments: PHOENIX-2722.patch
>
>
> For serial query(query with “serial" hint or “limit" without "order by”), we
> can limit each scan(using page filter) to “limit+offset” instead of limit
> earlier.
> And then, for all queries, we can forward the relevant client iterators to
> the offset provided and then return the result.
> syntax
> {code}
> [ LIMIT { count } ]
> [ OFFSET start [ ROW | ROWS ] ]
> [ FETCH { FIRST | NEXT } [ count ] { ROW | ROWS } ONLY ]
> {code}
> Some new keywords() are getting introduced so users might need to see that
> they are not using them as column name or something.
> WDYT, [~jamestaylor]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[ https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-2722: --- Attachment: PHOENIX-2722.patch thanks [~jamestaylor] for the comments. can you please review the attached patch. Attached patch includes both of your input :- * Pushing offset to server for serial queries(non-order by and non-aggregate) * SQL syntax compatible with calcite. > support mysql "limit,offset" clauses > - > > Key: PHOENIX-2722 > URL: https://issues.apache.org/jira/browse/PHOENIX-2722 > Project: Phoenix > Issue Type: New Feature >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Minor > Attachments: PHOENIX-2722.patch > > > For serial query(query with “serial" hint or “limit" without "order by”), we > can limit each scan(using page filter) to “limit+offset” instead of limit > earlier. > And then, for all queries, we can forward the relevant client iterators to > the offset provided and then return the result. > WDYT, [~jamestaylor] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PHOENIX-2722) support mysql "limit,offset" clauses
[ https://issues.apache.org/jira/browse/PHOENIX-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankit Singhal updated PHOENIX-2722: --- Description: For serial query(query with “serial" hint or “limit" without "order by”), we can limit each scan(using page filter) to “limit+offset” instead of limit earlier. And then, for all queries, we can forward the relevant client iterators to the offset provided and then return the result. WDYT, [~jamestaylor] was: For serial query(query with “serial" hint or “limit" without "order by”), we can limit each scan(using page filter) to “limit+offset” instead of limit earlier. And then, for all queries, we can forward the client iterators to the offset provided and then return the result. WDYT, [~jamestaylor] > support mysql "limit,offset" clauses > - > > Key: PHOENIX-2722 > URL: https://issues.apache.org/jira/browse/PHOENIX-2722 > Project: Phoenix > Issue Type: New Feature >Reporter: Ankit Singhal >Assignee: Ankit Singhal >Priority: Minor > > For serial query(query with “serial" hint or “limit" without "order by”), we > can limit each scan(using page filter) to “limit+offset” instead of limit > earlier. > And then, for all queries, we can forward the relevant client iterators to > the offset provided and then return the result. > WDYT, [~jamestaylor] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
