[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated PHOENIX-6055: -- Fix Version/s: 4.16.0 > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-6055.master.001.patch, > PHOENIX-6055.master.002.patch, PHOENIX-6055.master.003.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Istvan Toth updated PHOENIX-6055: - Fix Version/s: 5.1.0 > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6055.master.001.patch, > PHOENIX-6055.master.002.patch, PHOENIX-6055.master.003.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gokcen Iskender updated PHOENIX-6055: - Attachment: PHOENIX-6055.master.003.patch > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6055.master.001.patch, > PHOENIX-6055.master.002.patch, PHOENIX-6055.master.003.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gokcen Iskender updated PHOENIX-6055: - Attachment: PHOENIX-6055.master.002.patch > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6055.master.001.patch, > PHOENIX-6055.master.002.patch > > Time Spent: 1h > Remaining Estimate: 0h > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gokcen Iskender updated PHOENIX-6055: - Attachment: PHOENIX-6055.master.001.patch > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-6055.master.001.patch > > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geoffrey Jacoby updated PHOENIX-6055: - Comment: was deleted (was: [~giskender] - Some operators may have legal or contractual restrictions on emitting production data into their logs, which this would be likely to do. ) > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (PHOENIX-6055) Improve error reporting for index validation when there are "Not matching index rows"
[ https://issues.apache.org/jira/browse/PHOENIX-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gokcen Iskender updated PHOENIX-6055: - Description: In the IndexRebuildRegionScanner, in the following line we return the timestamp of the latest expected mutation rather than the expected mutation itself. byte[] dataKey = indexMaintainer.buildDataRowKey(new ImmutableBytesWritable(indexRow.getRow()), viewConstants); String errorMsg = "Not matching index row"; logToIndexToolOutputTable(dataKey, indexRow.getRow(), getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, INVALID_ROW); Instead of expectedMutationList.get(0), expected should be used. > Improve error reporting for index validation when there are "Not matching > index rows" > - > > Key: PHOENIX-6055 > URL: https://issues.apache.org/jira/browse/PHOENIX-6055 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > > In the IndexRebuildRegionScanner, in the following line we return the > timestamp of the latest expected mutation rather than the expected mutation > itself. > > byte[] dataKey = indexMaintainer.buildDataRowKey(new > ImmutableBytesWritable(indexRow.getRow()), viewConstants); > String errorMsg = "Not matching index row"; > logToIndexToolOutputTable(dataKey, indexRow.getRow(), > getTimestamp(expectedMutationList.get(0)), 0L, errorMsg, isBeforeRebuild, > INVALID_ROW); > > Instead of expectedMutationList.get(0), expected should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
