Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
-1 As Jacob found this dependency issue PHOENIX-6348, we should have the fix before the next RC. Hi Istvan, thank you for the quick response and jump on this for the fix. On Fri, Jan 29, 2021 at 12:03 PM Istvan Toth wrote: > My bad, I got confused and mixed up bulk loading which uses phoenix-client > and IndexTool, which uses the Hbase classpath, and thus phoenix-server. > > regards > István > > On Fri, Jan 29, 2021 at 8:36 PM Istvan Toth wrote: > > > Jacob, are you sure you were using phoenix-client for the test ? > > The stack trace in PHOENIX-6348 suggests that you tried to use > > phoenix-core or perhaps phoenix-server instead (which indeed doesn't > work). > > > > regards > > Istvan > > > > On Fri, Jan 29, 2021 at 1:49 PM Istvan Toth wrote: > > > >> Copying here from PHOENIX-6348 and PHOENIX-6349 for greater exposure: > >> > >> Let me know if the solution in PHOENIX-6349 is acceptable. > >> If I get the timely +1 for PHOENIX-6349, then I'll put up the > >> phoenix-thirdparty 1.1.0RC0 today, > >> so that we can have a phoenix-thirdparty release on Monday to Wendsday. > >> (Depending on whether we count the weekend into the compulsory 72 hour > >> vote window) > >> > >> I think that PHOENIX-6349 is a worthwhile fix, as it lets us solve the > >> quoting/case sensitivity problems on the tools, > >> even if we decide not to fast track it to get into this release. > >> > >> regards Istvan > >> > >> On Fri, Jan 29, 2021 at 1:40 AM Jacob Isaac > >> wrote: > >> > >>> As I started testing the builds found a dependency issue - > >>> PHOENIX-6348 > >>> > >>> This will need to be addressed as this affects core functionality > related > >>> to running the IndexTool. > >>> > >>> Thanks > >>> Jacob > >>> > >>> > >>> On 2021/01/28 05:09:44, Xinyi Yan wrote: > >>> > Hello Everyone, > >>> > > >>> > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the > >>> next > >>> > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, > 1.5 > >>> > and 1.6. > >>> > > >>> > The VOTE will remain open for at least 72 hours. > >>> > > >>> > [ ] +1 Release this package as Apache phoenix 4.16.0 > >>> > [ ] -1 Do not release this package because ... > >>> > > >>> > The tag to be voted on is 4.16.0RC0 > >>> > https://github.com/apache/phoenix/tree/4.16.0RC0 > >>> > > >>> > The release files, including signatures, digests, as well as > CHANGES.md > >>> > and RELEASENOTES.md included in this RC can be found at: > >>> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > >>> > > >>> > For a complete list of changes, see: > >>> > > >>> > >>> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > >>> > > >>> > Artifacts are signed with my "CODE SIGNING KEY": > >>> > E4882DD3AB711587 > >>> > > >>> > KEYS file available here: > >>> > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > >>> > > >>> > > >>> > Thanks, > >>> > Xinyi > >>> > > >>> > >> >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
My bad, I got confused and mixed up bulk loading which uses phoenix-client and IndexTool, which uses the Hbase classpath, and thus phoenix-server. regards István On Fri, Jan 29, 2021 at 8:36 PM Istvan Toth wrote: > Jacob, are you sure you were using phoenix-client for the test ? > The stack trace in PHOENIX-6348 suggests that you tried to use > phoenix-core or perhaps phoenix-server instead (which indeed doesn't work). > > regards > Istvan > > On Fri, Jan 29, 2021 at 1:49 PM Istvan Toth wrote: > >> Copying here from PHOENIX-6348 and PHOENIX-6349 for greater exposure: >> >> Let me know if the solution in PHOENIX-6349 is acceptable. >> If I get the timely +1 for PHOENIX-6349, then I'll put up the >> phoenix-thirdparty 1.1.0RC0 today, >> so that we can have a phoenix-thirdparty release on Monday to Wendsday. >> (Depending on whether we count the weekend into the compulsory 72 hour >> vote window) >> >> I think that PHOENIX-6349 is a worthwhile fix, as it lets us solve the >> quoting/case sensitivity problems on the tools, >> even if we decide not to fast track it to get into this release. >> >> regards Istvan >> >> On Fri, Jan 29, 2021 at 1:40 AM Jacob Isaac >> wrote: >> >>> As I started testing the builds found a dependency issue - >>> PHOENIX-6348 >>> >>> This will need to be addressed as this affects core functionality related >>> to running the IndexTool. >>> >>> Thanks >>> Jacob >>> >>> >>> On 2021/01/28 05:09:44, Xinyi Yan wrote: >>> > Hello Everyone, >>> > >>> > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the >>> next >>> > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 >>> > and 1.6. >>> > >>> > The VOTE will remain open for at least 72 hours. >>> > >>> > [ ] +1 Release this package as Apache phoenix 4.16.0 >>> > [ ] -1 Do not release this package because ... >>> > >>> > The tag to be voted on is 4.16.0RC0 >>> > https://github.com/apache/phoenix/tree/4.16.0RC0 >>> > >>> > The release files, including signatures, digests, as well as CHANGES.md >>> > and RELEASENOTES.md included in this RC can be found at: >>> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ >>> > >>> > For a complete list of changes, see: >>> > >>> >>> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md >>> > >>> > Artifacts are signed with my "CODE SIGNING KEY": >>> > E4882DD3AB711587 >>> > >>> > KEYS file available here: >>> > https://dist.apache.org/repos/dist/dev/phoenix/KEYS >>> > >>> > >>> > Thanks, >>> > Xinyi >>> > >>> >>
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
Jacob, are you sure you were using phoenix-client for the test ? The stack trace in PHOENIX-6348 suggests that you tried to use phoenix-core or perhaps phoenix-server instead (which indeed doesn't work). regards Istvan On Fri, Jan 29, 2021 at 1:49 PM Istvan Toth wrote: > Copying here from PHOENIX-6348 and PHOENIX-6349 for greater exposure: > > Let me know if the solution in PHOENIX-6349 is acceptable. > If I get the timely +1 for PHOENIX-6349, then I'll put up the > phoenix-thirdparty 1.1.0RC0 today, > so that we can have a phoenix-thirdparty release on Monday to Wendsday. > (Depending on whether we count the weekend into the compulsory 72 hour > vote window) > > I think that PHOENIX-6349 is a worthwhile fix, as it lets us solve the > quoting/case sensitivity problems on the tools, > even if we decide not to fast track it to get into this release. > > regards Istvan > > On Fri, Jan 29, 2021 at 1:40 AM Jacob Isaac > wrote: > >> As I started testing the builds found a dependency issue - >> PHOENIX-6348 >> >> This will need to be addressed as this affects core functionality related >> to running the IndexTool. >> >> Thanks >> Jacob >> >> >> On 2021/01/28 05:09:44, Xinyi Yan wrote: >> > Hello Everyone, >> > >> > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next >> > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 >> > and 1.6. >> > >> > The VOTE will remain open for at least 72 hours. >> > >> > [ ] +1 Release this package as Apache phoenix 4.16.0 >> > [ ] -1 Do not release this package because ... >> > >> > The tag to be voted on is 4.16.0RC0 >> > https://github.com/apache/phoenix/tree/4.16.0RC0 >> > >> > The release files, including signatures, digests, as well as CHANGES.md >> > and RELEASENOTES.md included in this RC can be found at: >> > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ >> > >> > For a complete list of changes, see: >> > >> >> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md >> > >> > Artifacts are signed with my "CODE SIGNING KEY": >> > E4882DD3AB711587 >> > >> > KEYS file available here: >> > https://dist.apache.org/repos/dist/dev/phoenix/KEYS >> > >> > >> > Thanks, >> > Xinyi >> > >> >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
Copying here from PHOENIX-6348 and PHOENIX-6349 for greater exposure: Let me know if the solution in PHOENIX-6349 is acceptable. If I get the timely +1 for PHOENIX-6349, then I'll put up the phoenix-thirdparty 1.1.0RC0 today, so that we can have a phoenix-thirdparty release on Monday to Wendsday. (Depending on whether we count the weekend into the compulsory 72 hour vote window) I think that PHOENIX-6349 is a worthwhile fix, as it lets us solve the quoting/case sensitivity problems on the tools, even if we decide not to fast track it to get into this release. regards Istvan On Fri, Jan 29, 2021 at 1:40 AM Jacob Isaac wrote: > As I started testing the builds found a dependency issue - > PHOENIX-6348 > > This will need to be addressed as this affects core functionality related > to running the IndexTool. > > Thanks > Jacob > > > On 2021/01/28 05:09:44, Xinyi Yan wrote: > > Hello Everyone, > > > > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next > > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 > > and 1.6. > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache phoenix 4.16.0 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 4.16.0RC0 > > https://github.com/apache/phoenix/tree/4.16.0RC0 > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > > > > For a complete list of changes, see: > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > > > > Artifacts are signed with my "CODE SIGNING KEY": > > E4882DD3AB711587 > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > Thanks, > > Xinyi > > >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
Xinyi, i have updated fixVersion for relevant cases and mentioned you on Jiras where i am not sure about the conclusion. create-release scripts should update change log correctly this time. On Fri, 29 Jan 2021 at 4:04 PM, Viraj Jasani wrote: > Apart from latest Jiras mentioned by Istvan for fixVersion discrepancies, > when I used this script [1], I could see more such discrepancies, meaning > CHANGES.md is out of sync from git commits landed on branch 4.16. > > As of now, I can see: > > 37 Jiras missing fixVersion 4.16 > 4 git commits without Jira number > 2 Jiras not resolved yet but corresponding commits are present > 6 reverted commits (need to verify Jira status) > 4 Jiras marked resolved but have no relevant commits present > (false positive case for svn checkins though) > > Xinyi, let me spend some time today to fix some of these > discrepancies. If the completion status is unknown for some > Jira, i will ping you on it. > This might not be strong point to sink the RC, but if we have some > way to re-generate and update CHANGES.md after fixing Jira status, > we should consider it (if not sink the RC) but it might be bit of a > manual task I believe. > > > 1. https://github.com/apache/phoenix/tree/master/dev/misc_utils > > On 2021/01/28 05:09:44, Xinyi Yan wrote: > > Hello Everyone, > > > > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next > > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 > > and 1.6. > > > > The VOTE will remain open for at least 72 hours. > > > > [ ] +1 Release this package as Apache phoenix 4.16.0 > > [ ] -1 Do not release this package because ... > > > > The tag to be voted on is 4.16.0RC0 > > https://github.com/apache/phoenix/tree/4.16.0RC0 > > > > The release files, including signatures, digests, as well as CHANGES.md > > and RELEASENOTES.md included in this RC can be found at: > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > > > > For a complete list of changes, see: > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > > > > Artifacts are signed with my "CODE SIGNING KEY": > > E4882DD3AB711587 > > > > KEYS file available here: > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > Thanks, > > Xinyi > > >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
Apart from latest Jiras mentioned by Istvan for fixVersion discrepancies, when I used this script [1], I could see more such discrepancies, meaning CHANGES.md is out of sync from git commits landed on branch 4.16. As of now, I can see: 37 Jiras missing fixVersion 4.16 4 git commits without Jira number 2 Jiras not resolved yet but corresponding commits are present 6 reverted commits (need to verify Jira status) 4 Jiras marked resolved but have no relevant commits present (false positive case for svn checkins though) Xinyi, let me spend some time today to fix some of these discrepancies. If the completion status is unknown for some Jira, i will ping you on it. This might not be strong point to sink the RC, but if we have some way to re-generate and update CHANGES.md after fixing Jira status, we should consider it (if not sink the RC) but it might be bit of a manual task I believe. 1. https://github.com/apache/phoenix/tree/master/dev/misc_utils On 2021/01/28 05:09:44, Xinyi Yan wrote: > Hello Everyone, > > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 > and 1.6. > > The VOTE will remain open for at least 72 hours. > > [ ] +1 Release this package as Apache phoenix 4.16.0 > [ ] -1 Do not release this package because ... > > The tag to be voted on is 4.16.0RC0 > https://github.com/apache/phoenix/tree/4.16.0RC0 > > The release files, including signatures, digests, as well as CHANGES.md > and RELEASENOTES.md included in this RC can be found at: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > > For a complete list of changes, see: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > > Artifacts are signed with my "CODE SIGNING KEY": > E4882DD3AB711587 > > KEYS file available here: > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > Thanks, > Xinyi >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
As I started testing the builds found a dependency issue - PHOENIX-6348 This will need to be addressed as this affects core functionality related to running the IndexTool. Thanks Jacob On 2021/01/28 05:09:44, Xinyi Yan wrote: > Hello Everyone, > > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 > and 1.6. > > The VOTE will remain open for at least 72 hours. > > [ ] +1 Release this package as Apache phoenix 4.16.0 > [ ] -1 Do not release this package because ... > > The tag to be voted on is 4.16.0RC0 > https://github.com/apache/phoenix/tree/4.16.0RC0 > > The release files, including signatures, digests, as well as CHANGES.md > and RELEASENOTES.md included in this RC can be found at: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > > For a complete list of changes, see: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > > Artifacts are signed with my "CODE SIGNING KEY": > E4882DD3AB711587 > > KEYS file available here: > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > Thanks, > Xinyi >
Re: [VOTE] Release of Apache Phoenix 4.16.0 RC0
I haven't had a chance to test the release yet, but I'd like to point out that (at least) the following JIRAs didn't have the 4.16.0 fix version set. (Some of that is probably my fault) PHOENIX-6342 PHOENIX-5296 PHOENIX-6327 PHOENIX-6329 PHOENIX-6330 Missing some commits from the generated CHANGES file is probably not serious enough to warrant a new RC, though. regards Istvan On Thu, Jan 28, 2021 at 6:09 AM Xinyi Yan wrote: > Hello Everyone, > > This is a call for a vote on Apache Phoenix 4.16.0 RC0. This is the next > minor release of Phoenix 4, compatible with Apache HBase 1.3, 1.4, 1.5 > and 1.6. > > The VOTE will remain open for at least 72 hours. > > [ ] +1 Release this package as Apache phoenix 4.16.0 > [ ] -1 Do not release this package because ... > > The tag to be voted on is 4.16.0RC0 > https://github.com/apache/phoenix/tree/4.16.0RC0 > > The release files, including signatures, digests, as well as CHANGES.md > and RELEASENOTES.md included in this RC can be found at: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/ > > For a complete list of changes, see: > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-4.16.0RC0/CHANGES.md > > Artifacts are signed with my "CODE SIGNING KEY": > E4882DD3AB711587 > > KEYS file available here: > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > Thanks, > Xinyi >
