Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Istvan Toth]

Hi!

Thanks for calling this out, Geoffrey.
This was an oversight, I ignored that some of the +1s were non-binding.
I'll keep this in mind for next time.

regards
Istvan

On Mon, Feb 1, 2021 at 11:23 PM Geoffrey Jacoby  wrote:

> Thanks for everyone's hard work at getting phoenix-thirdparty done and
> tested so quickly.
>
> However, I'm a bit confused -- I see the public announcement for
> phoenix-thirdparty-1.1.0's release went out when the vote was by my
> count +2 binding (Istvan and Ankit), +2 non-binding (Xinyi and Viraj), and
> no 0s or -1s. By Apache rules doesn't a release need at least 3 binding
> (from PMC members) +1s and more positives than negatives? [1] If so,
> Chinmay's binding +1 a few minutes later fixes the problem, so _now_ we
> have enough to release at +3 binding, +2 non-binding.
>
> Was there a third binding +1 that I missed by announce time, was this an
> oversight, or have I misunderstood the rules?
>
> Thanks,
>
> Geoffrey
>
> [1]
>
> http://www.apache.org/legal/release-policy.html#:~:text=For%20a%20release%20vote%20to,by%20PMC%20members%20are%20binding
> .
>
> On Mon, Feb 1, 2021 at 3:57 PM Chinmay Kulkarni <
> chinmayskulka...@gmail.com>
> wrote:
>
> > +1 (Belated)
> >
> > Build: OK
> > Build Phoenix master branch with latest thirdparty: OK
> > Build Phoenix 4.x branch with PR
> >  and latest thirdparty: OK
> > Release Notes: OK
> > Staging Repo and tests: OK
> >
> >
> > On Sun, Jan 31, 2021 at 10:42 PM Ankit Singhal  >
> > wrote:
> >
> > > +1
> > >
> > >  * Build phoenix-thirdparty - OK
> > >  * Build Phoenix master with phoenix-thirdparty - Ok
> > >  * apache-rat:check check failed for following files (it's better we
> > remove
> > > them):-
> > >
> > >
> > >
> >
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
> > >
> > >
> > >
> >
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
> > >  *  Distribution link for the vote has a typo, the correct link seems
> to
> > be
> > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
> > >  * RELEASE notes and changes.md seems to be not updated from the last
> > > release.
> > >  * Signature and checksum - Ok
> > >  * Licence and Notice(nit: Copyright 2021) - Ok
> > >
> > > Regards,
> > > Ankit Singhal
> > >
> > > On Fri, Jan 29, 2021 at 11:05 PM Viraj Jasani 
> > wrote:
> > >
> > > > +1 (non-binding)
> > > >
> > > > Build: ok
> > > > Compilation against master and 4.x branch: ok
> > > > ChangeLog/Release notes: ok
> > > >
> > > > Staging repository looks good:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/staging/org/apache/phoenix/thirdparty/phoenix-thirdparty/1.1.0/
> > > >
> > > > IT results look good on PRs #1122 and #1123.
> > > >
> > > >
> > > > On 2021/01/29 21:32:39, Istvan Toth  wrote:
> > > > > Please vote on this Apache phoenix thirdparty release candidate,
> > > > > phoenix-thirdparty-1.1.0RC0
> > > > >
> > > > > The VOTE will remain open for at least 72 hours.
> > > > >
> > > > > [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> > > > > [ ] -1 Do not release this package because ...
> > > > >
> > > > > The tag to be voted on is 1.1.0RC0:
> > > > >
> > > > >   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
> > > > >
> > > > > The release files, including signatures, digests, as well as
> > CHANGES.md
> > > > > and RELEASENOTES.md included in this RC can be found at:
> > > > >
> > > > >   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
> > > > >
> > > > > Maven artifacts are available in a staging repository at:
> > > > >
> > > > >   https://repository.apache.org/content/repositories//
> > > > >
> > > > > Artifacts were signed with the 0x794433C7 key which can be found
> in:
> > > > >
> > > > >   https://dist.apache.org/repos/dist/release/phoenix/KEYS
> > > > >
> > > > > To learn more about Apache phoenix thirdparty, please see
> > > > >
> > > > >   http://phoenix.apache.org/
> > > > >
> > > > > Thanks,
> > > > > Istvan
> > > > >
> > > >
> > >
> >
> >
> > --
> > Chinmay Kulkarni
> >
>

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Geoffrey Jacoby]

Thanks for everyone's hard work at getting phoenix-thirdparty done and
tested so quickly.

However, I'm a bit confused -- I see the public announcement for
phoenix-thirdparty-1.1.0's release went out when the vote was by my
count +2 binding (Istvan and Ankit), +2 non-binding (Xinyi and Viraj), and
no 0s or -1s. By Apache rules doesn't a release need at least 3 binding
(from PMC members) +1s and more positives than negatives? [1] If so,
Chinmay's binding +1 a few minutes later fixes the problem, so _now_ we
have enough to release at +3 binding, +2 non-binding.

Was there a third binding +1 that I missed by announce time, was this an
oversight, or have I misunderstood the rules?

Thanks,

Geoffrey

[1]
http://www.apache.org/legal/release-policy.html#:~:text=For%20a%20release%20vote%20to,by%20PMC%20members%20are%20binding
.

On Mon, Feb 1, 2021 at 3:57 PM Chinmay Kulkarni 
wrote:

> +1 (Belated)
>
> Build: OK
> Build Phoenix master branch with latest thirdparty: OK
> Build Phoenix 4.x branch with PR
>  and latest thirdparty: OK
> Release Notes: OK
> Staging Repo and tests: OK
>
>
> On Sun, Jan 31, 2021 at 10:42 PM Ankit Singhal 
> wrote:
>
> > +1
> >
> >  * Build phoenix-thirdparty - OK
> >  * Build Phoenix master with phoenix-thirdparty - Ok
> >  * apache-rat:check check failed for following files (it's better we
> remove
> > them):-
> >
> >
> >
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
> >
> >
> >
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
> >  *  Distribution link for the vote has a typo, the correct link seems to
> be
> >
> >
> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
> >  * RELEASE notes and changes.md seems to be not updated from the last
> > release.
> >  * Signature and checksum - Ok
> >  * Licence and Notice(nit: Copyright 2021) - Ok
> >
> > Regards,
> > Ankit Singhal
> >
> > On Fri, Jan 29, 2021 at 11:05 PM Viraj Jasani 
> wrote:
> >
> > > +1 (non-binding)
> > >
> > > Build: ok
> > > Compilation against master and 4.x branch: ok
> > > ChangeLog/Release notes: ok
> > >
> > > Staging repository looks good:
> > >
> >
> https://repository.apache.org/content/repositories/staging/org/apache/phoenix/thirdparty/phoenix-thirdparty/1.1.0/
> > >
> > > IT results look good on PRs #1122 and #1123.
> > >
> > >
> > > On 2021/01/29 21:32:39, Istvan Toth  wrote:
> > > > Please vote on this Apache phoenix thirdparty release candidate,
> > > > phoenix-thirdparty-1.1.0RC0
> > > >
> > > > The VOTE will remain open for at least 72 hours.
> > > >
> > > > [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> > > > [ ] -1 Do not release this package because ...
> > > >
> > > > The tag to be voted on is 1.1.0RC0:
> > > >
> > > >   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
> > > >
> > > > The release files, including signatures, digests, as well as
> CHANGES.md
> > > > and RELEASENOTES.md included in this RC can be found at:
> > > >
> > > >   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
> > > >
> > > > Maven artifacts are available in a staging repository at:
> > > >
> > > >   https://repository.apache.org/content/repositories//
> > > >
> > > > Artifacts were signed with the 0x794433C7 key which can be found in:
> > > >
> > > >   https://dist.apache.org/repos/dist/release/phoenix/KEYS
> > > >
> > > > To learn more about Apache phoenix thirdparty, please see
> > > >
> > > >   http://phoenix.apache.org/
> > > >
> > > > Thanks,
> > > > Istvan
> > > >
> > >
> >
>
>
> --
> Chinmay Kulkarni
>

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Chinmay Kulkarni]

+1 (Belated)

Build: OK
Build Phoenix master branch with latest thirdparty: OK
Build Phoenix 4.x branch with PR
 and latest thirdparty: OK
Release Notes: OK
Staging Repo and tests: OK


On Sun, Jan 31, 2021 at 10:42 PM Ankit Singhal 
wrote:

> +1
>
>  * Build phoenix-thirdparty - OK
>  * Build Phoenix master with phoenix-thirdparty - Ok
>  * apache-rat:check check failed for following files (it's better we remove
> them):-
>
>
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
>
>
> phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
>  *  Distribution link for the vote has a typo, the correct link seems to be
>
> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
>  * RELEASE notes and changes.md seems to be not updated from the last
> release.
>  * Signature and checksum - Ok
>  * Licence and Notice(nit: Copyright 2021) - Ok
>
> Regards,
> Ankit Singhal
>
> On Fri, Jan 29, 2021 at 11:05 PM Viraj Jasani  wrote:
>
> > +1 (non-binding)
> >
> > Build: ok
> > Compilation against master and 4.x branch: ok
> > ChangeLog/Release notes: ok
> >
> > Staging repository looks good:
> >
> https://repository.apache.org/content/repositories/staging/org/apache/phoenix/thirdparty/phoenix-thirdparty/1.1.0/
> >
> > IT results look good on PRs #1122 and #1123.
> >
> >
> > On 2021/01/29 21:32:39, Istvan Toth  wrote:
> > > Please vote on this Apache phoenix thirdparty release candidate,
> > > phoenix-thirdparty-1.1.0RC0
> > >
> > > The VOTE will remain open for at least 72 hours.
> > >
> > > [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> > > [ ] -1 Do not release this package because ...
> > >
> > > The tag to be voted on is 1.1.0RC0:
> > >
> > >   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
> > >
> > > The release files, including signatures, digests, as well as CHANGES.md
> > > and RELEASENOTES.md included in this RC can be found at:
> > >
> > >   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
> > >
> > > Maven artifacts are available in a staging repository at:
> > >
> > >   https://repository.apache.org/content/repositories//
> > >
> > > Artifacts were signed with the 0x794433C7 key which can be found in:
> > >
> > >   https://dist.apache.org/repos/dist/release/phoenix/KEYS
> > >
> > > To learn more about Apache phoenix thirdparty, please see
> > >
> > >   http://phoenix.apache.org/
> > >
> > > Thanks,
> > > Istvan
> > >
> >
>


-- 
Chinmay Kulkarni

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Ankit Singhal]

+1

 * Build phoenix-thirdparty - OK
 * Build Phoenix master with phoenix-thirdparty - Ok
 * apache-rat:check check failed for following files (it's better we remove
them):-

phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch

phoenix-thirdparty/phoenix-shaded-commons-cli/src/main/java/META-INF/MANIFEST.MF
 *  Distribution link for the vote has a typo, the correct link seems to be
 https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
 * RELEASE notes and changes.md seems to be not updated from the last
release.
 * Signature and checksum - Ok
 * Licence and Notice(nit: Copyright 2021) - Ok

Regards,
Ankit Singhal

On Fri, Jan 29, 2021 at 11:05 PM Viraj Jasani  wrote:

> +1 (non-binding)
>
> Build: ok
> Compilation against master and 4.x branch: ok
> ChangeLog/Release notes: ok
>
> Staging repository looks good:
> https://repository.apache.org/content/repositories/staging/org/apache/phoenix/thirdparty/phoenix-thirdparty/1.1.0/
>
> IT results look good on PRs #1122 and #1123.
>
>
> On 2021/01/29 21:32:39, Istvan Toth  wrote:
> > Please vote on this Apache phoenix thirdparty release candidate,
> > phoenix-thirdparty-1.1.0RC0
> >
> > The VOTE will remain open for at least 72 hours.
> >
> > [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> > [ ] -1 Do not release this package because ...
> >
> > The tag to be voted on is 1.1.0RC0:
> >
> >   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
> >
> > The release files, including signatures, digests, as well as CHANGES.md
> > and RELEASENOTES.md included in this RC can be found at:
> >
> >   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
> >
> > Maven artifacts are available in a staging repository at:
> >
> >   https://repository.apache.org/content/repositories//
> >
> > Artifacts were signed with the 0x794433C7 key which can be found in:
> >
> >   https://dist.apache.org/repos/dist/release/phoenix/KEYS
> >
> > To learn more about Apache phoenix thirdparty, please see
> >
> >   http://phoenix.apache.org/
> >
> > Thanks,
> > Istvan
> >
>

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Viraj Jasani]

+1 (non-binding)

Build: ok
Compilation against master and 4.x branch: ok
ChangeLog/Release notes: ok

Staging repository looks good: 
https://repository.apache.org/content/repositories/staging/org/apache/phoenix/thirdparty/phoenix-thirdparty/1.1.0/

IT results look good on PRs #1122 and #1123.


On 2021/01/29 21:32:39, Istvan Toth  wrote: 
> Please vote on this Apache phoenix thirdparty release candidate,
> phoenix-thirdparty-1.1.0RC0
> 
> The VOTE will remain open for at least 72 hours.
> 
> [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> [ ] -1 Do not release this package because ...
> 
> The tag to be voted on is 1.1.0RC0:
> 
>   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
> 
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
> 
>   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
> 
> Maven artifacts are available in a staging repository at:
> 
>   https://repository.apache.org/content/repositories//
> 
> Artifacts were signed with the 0x794433C7 key which can be found in:
> 
>   https://dist.apache.org/repos/dist/release/phoenix/KEYS
> 
> To learn more about Apache phoenix thirdparty, please see
> 
>   http://phoenix.apache.org/
> 
> Thanks,
> Istvan
> 

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Xinyi Yan]

+1 (non-binding)

I modified thirdparty version at the pom.xml on the master branch and ran
the local HBase IndexTool job from commandline as an example(using the
phoenix server jar instead of the client jar).


Thanks,
Xinyi

On Fri, Jan 29, 2021 at 3:17 PM Xinyi Yan  wrote:

> Just a small correction, the release files, including signatures, digests,
> as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/
>
> On Fri, Jan 29, 2021 at 1:33 PM Istvan Toth  wrote:
>
>> Please vote on this Apache phoenix thirdparty release candidate,
>> phoenix-thirdparty-1.1.0RC0
>>
>> The VOTE will remain open for at least 72 hours.
>>
>> [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
>> [ ] -1 Do not release this package because ...
>>
>> The tag to be voted on is 1.1.0RC0:
>>
>>   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
>>
>> The release files, including signatures, digests, as well as CHANGES.md
>> and RELEASENOTES.md included in this RC can be found at:
>>
>>   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
>>
>> Maven artifacts are available in a staging repository at:
>>
>>   https://repository.apache.org/content/repositories//
>>
>> Artifacts were signed with the 0x794433C7 key which can be found in:
>>
>>   https://dist.apache.org/repos/dist/release/phoenix/KEYS
>>
>> To learn more about Apache phoenix thirdparty, please see
>>
>>   http://phoenix.apache.org/
>>
>> Thanks,
>> Istvan
>>
>

Re: [VOTE] Release of Apache Phoenix Thirdparty 1.1.0 RC0

[Xinyi Yan]

Just a small correction, the release files, including signatures, digests,
as well as CHANGES.md
and RELEASENOTES.md included in this RC can be found at:
https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-1.1.0RC0/

On Fri, Jan 29, 2021 at 1:33 PM Istvan Toth  wrote:

> Please vote on this Apache phoenix thirdparty release candidate,
> phoenix-thirdparty-1.1.0RC0
>
> The VOTE will remain open for at least 72 hours.
>
> [ ] +1 Release this package as Apache phoenix thirdparty 1.1.0
> [ ] -1 Do not release this package because ...
>
> The tag to be voted on is 1.1.0RC0:
>
>   https://github.com/apache/phoenix-thirdparty/tree/1.1.0RC0
>
> The release files, including signatures, digests, as well as CHANGES.md
> and RELEASENOTES.md included in this RC can be found at:
>
>   https://dist.apache.org/repos/dist/dev/phoenix/1.1.0RC0/
>
> Maven artifacts are available in a staging repository at:
>
>   https://repository.apache.org/content/repositories//
>
> Artifacts were signed with the 0x794433C7 key which can be found in:
>
>   https://dist.apache.org/repos/dist/release/phoenix/KEYS
>
> To learn more about Apache phoenix thirdparty, please see
>
>   http://phoenix.apache.org/
>
> Thanks,
> Istvan
>