Re:Re: Master branch does not compile

2020-06-17 Thread cheng...@apache.org 



Should we only support HBase 2.2 , which is a stable 2.x release ?  














At 2020-06-17 16:04:58, "Istvan Toth"  wrote:
>The 4.x branch has historically deprecated unsupported branches.
>
>I'd be fine with removing support for EOL 2.x branches in master,
>https://issues.apache.org/jira/browse/PHOENIX-5716 is open for this very
>issue,
>but would welcome some community input before working on it.
>
>I also like Josh's idea, https://issues.apache.org/jira/browse/PHOENIX-5828 is
>quite similar to it.
>
>
>On Wed, Jun 17, 2020 at 2:49 AM Guanghao Zhang  wrote:
>
>> HBase 2.0 and 2.1 has been EOL now. Does phoenix need to support them?
>>
>> swaroopa kadam  于2020年6月17日周三 上午12:32写道：
>>
>> > yes, that’s a good idea.
>> >
>> > On Tue, Jun 16, 2020 at 9:29 AM Josh Elser  wrote:
>> >
>> > > Sounds like we should try to update precommit to at least compile
>> > > against _a version_ in each line 2.1/2.2/2.3 for master. Thoughts?
>> > >
>> > > On 6/16/20 11:57 AM, swaroopa kadam wrote:
>> > > > Thank you for the replies everyone!
>> > > >
>> > > > It puts me at ease by knowing the issue has been identified and being
>> > > > fixed.
>> > > >
>> > > > Thanks!
>> > > >
>> > > > On Tue, Jun 16, 2020 at 4:11 AM rajeshb...@apache.org <
>> > > > chrajeshbab...@gmail.com> wrote:
>> > > >
>> > > >> I am on the PHOENIX-5905 compilation issue and will fix it today.
>> > > >>
>> > > >> On Tue, Jun 16, 2020 at 3:07 PM cheng...@apache.org <
>> > > cheng...@apache.org>
>> > > >> wrote:
>> > > >>
>> > > >>>
>> > > >>>
>> > > >>>
>> > > >>> PHOENIX-5905 caused the master branch compile broken, because
>> > > >>> org.apache.hadoop.hbase.security.access.GetUserPermissionsRequest
>> is
>> > > only
>> > > >>> available in hbase 2.2.x,
>> > > >>> so when the hbase.profile=2.0 or  hbase.profile=2.1, the compiler
>> > > boken,
>> > > >>> Should we revert PHOENIX-5905 for the moment?
>> > > >>>
>> > > >>>
>> > > >>> The error messages are :
>> > > >>>
>> > > >>>
>> > > >>> [ERROR] COMPILATION ERROR :
>> > > >>> [INFO]
>> -
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[39,47]
>> > > >>> cannot find symbol
>> > > >>>symbol:   class GetUserPermissionsRequest
>> > > >>>location: package org.apache.hadoop.hbase.security.access
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[1452,48]
>> > > >>> cannot find symbol
>> > > >>>symbol:   method hasUserName()
>> > > >>>location: variable request of type
>> > > >>>
>> > > >>
>> > >
>> >
>> org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[1452,72]
>> > > >>> cannot find symbol
>> > > >>>symbol:   method getUserName()
>> > > >>>location: variable request of type
>> > > >>>
>> > > >>
>> > >
>> >
>> org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[1458,32]
>> > > >>> cannot find symbol
>> > > >>>symbol:   method hasColumnFamily()
>> > > >>>location: variable request of type
>> > > >>>
>> > > >>
>> > >
>> >
>> org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[1458,60]
>> > > >>> cannot find symbol
>> > > >>>symbol:   method getColumnFamily()
>> > > >>>location: variable request of type
>> > > >>>
>> > > >>
>> > >
>> >
>> org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/ws/phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
>> > > >>> :[1460,32]
>> > > >>> cannot find symbol
>> > > >>>symbol:   method hasColumnQualifier()
>> > > >>>location: variable request of type
>> > > >>>
>> > > >>
>> > >
>> >
>> org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
>> > > >>> [ERROR] <
>> > > >>>
>> > > >>
>> > >
>> >
>> https://builds.apache.org/job/Phoenix-master-matrix/HBASE_PROFILE=2.1/

Re:Re: Master branch does not compile

2020-06-16 Thread cheng...@apache.org 



PHOENIX-5905 caused the master branch compile broken, because 
org.apache.hadoop.hbase.security.access.GetUserPermissionsRequest is only 
available in hbase 2.2.x, 
so when the hbase.profile=2.0 or  hbase.profile=2.1, the compiler boken,
Should we revert PHOENIX-5905 for the moment?


The error messages are :


[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
:[39,47]
 cannot find symbol
  symbol:   class GetUserPermissionsRequest
  location: package org.apache.hadoop.hbase.security.access
[ERROR] 
:[1452,48]
 cannot find symbol
  symbol:   method hasUserName()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1452,72]
 cannot find symbol
  symbol:   method getUserName()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1458,32]
 cannot find symbol
  symbol:   method hasColumnFamily()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1458,60]
 cannot find symbol
  symbol:   method getColumnFamily()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1460,32]
 cannot find symbol
  symbol:   method hasColumnQualifier()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1460,63]
 cannot find symbol
  symbol:   method getColumnQualifier()
  location: variable request of type 
org.apache.hadoop.hbase.protobuf.generated.AccessControlProtos.GetUserPermissionsRequest
[ERROR] 
:[1461,17]
 cannot find symbol
  symbol:   class GetUserPermissionsRequest
  location: class 
org.apache.phoenix.end2end.BasePermissionsIT.CustomAccessController
[ERROR] 
:[1463,49]
 cannot find symbol
  symbol:   variable GetUserPermissionsRequest
  location: class 
org.apache.phoenix.end2end.BasePermissionsIT.CustomAccessController
[ERROR] 
:[1467,29]
 cannot find symbol
  symbol:   variable GetUserPermissionsRequest
  location: class org.apache.phoenix.end2end.BasePermissionsIT.Custo


















At 2020-06-16 14:26:23, "Istvan Toth"  wrote:
>Hi!
>
>In some cases specifying non-default HBase and Hadoop versions can cause
>this.
>Please report your full maven command line, and I'll look into it.
>In the meantime you can disable the dependency check with -D
>mdep.analyze.skip=true
>
>Istvan
>
>On Mon, Jun 15, 2020 at 7:57 PM swaroopa kadam 
>wrote:
>
>> Thank you for the response, Andrew and Geoffrey. Below is the error message
>> I see:
>>
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-dependency-plugin:3.1.1:analyze-only
>> (enforce-dependencies) on project phoenix-core: Dependency problems found
>> -> [Help 1]
>> [ERROR]
>> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
>> switch.
>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>> [ERROR]
>> [ERROR] For more information about the errors and possible solutions,
>> please read the following articles:
>> [ERROR] [Help 1]
>> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>> [ERROR]
>> [ERROR] After correcting the problems, you can resume the build with the
>> command
>> [ERROR]   mvn  -rf :phoenix-core
>>
>>
>> On Mon, Jun 15, 2020 at 10:4