[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Attachment: PIG-4554-3.patch Made changes as suggested by [~rohini] > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Sandeep Samdaria > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554-2.patch, PIG-4554-3.patch, PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIG-4641) Print the instance of Object without using toString()
[
https://issues.apache.org/jira/browse/PIG-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Samdaria updated PIG-4641:
--
Attachment: PIG-4641.patch
Attaching the patch.
Used {{toString}} to print the value.
> Print the instance of Object without using toString()
> -
>
> Key: PIG-4641
> URL: https://issues.apache.org/jira/browse/PIG-4641
> Project: Pig
> Issue Type: Bug
>Affects Versions: 0.13.0, 0.14.0, 0.15.0
>Reporter: songwanging
>Assignee: Sandeep Samdaria
>Priority: Minor
> Attachments: PIG-4641.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In Class: pig-0.15.0\src\org\apache\pig\scripting\js\JsFunction.java
> when printing the instance of Object "value", should use "toString()" to
> convert it to a String instance
> private void debugConvertPigToJS(int depth, String pigType, Object value,
> Schema schema) {
> if (LOG.isDebugEnabled()) {
> LOG.debug(indent(depth)+"converting from Pig " + pigType + " " +
> value + " using " + stringify(schema));
> }
> }
> In the same Class, all others use toString(value) to print the instance of
> Object "value".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PIG-4641) Print the instance of Object without using toString()
[
https://issues.apache.org/jira/browse/PIG-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Samdaria updated PIG-4641:
--
Assignee: Sandeep Samdaria
Status: Patch Available (was: Open)
> Print the instance of Object without using toString()
> -
>
> Key: PIG-4641
> URL: https://issues.apache.org/jira/browse/PIG-4641
> Project: Pig
> Issue Type: Bug
>Affects Versions: 0.15.0, 0.14.0, 0.13.0
>Reporter: songwanging
>Assignee: Sandeep Samdaria
>Priority: Minor
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In Class: pig-0.15.0\src\org\apache\pig\scripting\js\JsFunction.java
> when printing the instance of Object "value", should use "toString()" to
> convert it to a String instance
> private void debugConvertPigToJS(int depth, String pigType, Object value,
> Schema schema) {
> if (LOG.isDebugEnabled()) {
> LOG.debug(indent(depth)+"converting from Pig " + pigType + " " +
> value + " using " + stringify(schema));
> }
> }
> In the same Class, all others use toString(value) to print the instance of
> Object "value".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Attachment: PIG-4554-2.patch Made changes as suggested by Rohini. > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Sandeep Samdaria > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554-2.patch, PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Status: Patch Available (was: Open) > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Sandeep Samdaria > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4554) Compress pig.script before encoding
[
https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876305#comment-14876305
]
Sandeep Samdaria commented on PIG-4554:
---
I have added a new variable called {{truncatedScript}} and storing the
truncated script in that variable.
I have one question. How can I test and verify that the Tez DAG UI is showing
the truncated script?
I will upload the patch, once I am able to verify the above.
> Compress pig.script before encoding
> ---
>
> Key: PIG-4554
> URL: https://issues.apache.org/jira/browse/PIG-4554
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.14.0
>Reporter: Rohini Palaniswamy
> Labels: newbie
> Fix For: 0.16.0
>
> Attachments: PIG-4554.patch
>
>
> Currently we truncate the pig script (maxScriptSize = 10240) and base64
> encode it and store in config. We should remove the truncation and store the
> full script by compressing and then doing base64 encoding. We already do that
> for udfcontext, etc. It will save space as it will compress really well and
> will also give the full pig script while debugging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Status: Open (was: Patch Available) Misunderstood "Submit Patch" as the workflow to submit the patch. Reverting it back to open. > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Attachment: PIG-4554.patch Attaching the patch. > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PIG-4554) Compress pig.script before encoding
[ https://issues.apache.org/jira/browse/PIG-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandeep Samdaria updated PIG-4554: -- Status: Patch Available (was: Open) > Compress pig.script before encoding > --- > > Key: PIG-4554 > URL: https://issues.apache.org/jira/browse/PIG-4554 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy > Labels: newbie > Fix For: 0.16.0 > > Attachments: PIG-4554.patch > > > Currently we truncate the pig script (maxScriptSize = 10240) and base64 > encode it and store in config. We should remove the truncation and store the > full script by compressing and then doing base64 encoding. We already do that > for udfcontext, etc. It will save space as it will compress really well and > will also give the full pig script while debugging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
