[jira] [Commented] (PIG-2035) Macro expansion doesn't handle multiple expansions of same macro inside another macro
[
https://issues.apache.org/jira/browse/PIG-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031483#comment-13031483
]
Daniel Dai commented on PIG-2035:
-
+1
> Macro expansion doesn't handle multiple expansions of same macro inside
> another macro
> -
>
> Key: PIG-2035
> URL: https://issues.apache.org/jira/browse/PIG-2035
> Project: Pig
> Issue Type: Bug
> Components: impl
>Affects Versions: 0.9.0
>Reporter: Richard Ding
>Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2035_1.patch
>
>
> Here is the use case:
> {code}
> define test ( in, out, x ) returns c {
> a = load '$in' as (name, age, gpa);
> b = group a by gpa;
> $c = foreach b generate group, COUNT(a.$x);
> store $c into '$out';
> };
> define test2( in, out ) returns x {
> $x = test( '$in', '$out', 'name' );
> $x = test( '$in', '$out.1', 'age' );
> $x = test( '$in', '$out.2', 'gpa' );
> };
> x = test2('studenttab10k', 'myoutput');
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2035) Macro expansion doesn't handle multiple expansions of same macro inside another macro
[
https://issues.apache.org/jira/browse/PIG-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030019#comment-13030019
]
Richard Ding commented on PIG-2035:
---
Unit tests pass.
> Macro expansion doesn't handle multiple expansions of same macro inside
> another macro
> -
>
> Key: PIG-2035
> URL: https://issues.apache.org/jira/browse/PIG-2035
> Project: Pig
> Issue Type: Bug
> Components: impl
>Affects Versions: 0.9.0
>Reporter: Richard Ding
>Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2035_1.patch
>
>
> Here is the use case:
> {code}
> define test ( in, out, x ) returns c {
> a = load '$in' as (name, age, gpa);
> b = group a by gpa;
> $c = foreach b generate group, COUNT(a.$x);
> store $c into '$out';
> };
> define test2( in, out ) returns x {
> $x = test( '$in', '$out', 'name' );
> $x = test( '$in', '$out.1', 'age' );
> $x = test( '$in', '$out.2', 'gpa' );
> };
> x = test2('studenttab10k', 'myoutput');
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2035) Macro expansion doesn't handle multiple expansions of same macro inside another macro
[
https://issues.apache.org/jira/browse/PIG-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029045#comment-13029045
]
Richard Ding commented on PIG-2035:
---
test-patch result:
{code}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 585 release
audit warnings (more than the trunk's current 584 warnings).
{code}
> Macro expansion doesn't handle multiple expansions of same macro inside
> another macro
> -
>
> Key: PIG-2035
> URL: https://issues.apache.org/jira/browse/PIG-2035
> Project: Pig
> Issue Type: Bug
> Components: impl
>Affects Versions: 0.9.0
>Reporter: Richard Ding
>Assignee: Richard Ding
> Fix For: 0.9.0
>
> Attachments: PIG-2035_1.patch
>
>
> Here is the use case:
> {code}
> define test ( in, out, x ) returns c {
> a = load '$in' as (name, age, gpa);
> b = group a by gpa;
> $c = foreach b generate group, COUNT(a.$x);
> store $c into '$out';
> };
> define test2( in, out ) returns x {
> $x = test( '$in', '$out', 'name' );
> $x = test( '$in', '$out.1', 'age' );
> $x = test( '$in', '$out.2', 'gpa' );
> };
> x = test2('studenttab10k', 'myoutput');
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
