[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535355#comment-13535355 ] Julien Le Dem commented on PIG-2583: [~xalan] I'm closing this ticket as it has been committed. Please open a new ticket to further improve your contribution. Thanks again > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory1.patch, gruntHistory2.patch, > gruntHistory3.patch, gruntHistory4.patch, gruntHistory.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13500589#comment-13500589 ] Julien Le Dem commented on PIG-2583: Please open a new ticket for this and resolve this one > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory1.patch, gruntHistory2.patch, > gruntHistory3.patch, gruntHistory4.patch, gruntHistory.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272949#comment-13272949 ] Prashant Kommireddi commented on PIG-2583: -- Thanks Allan for the contribution! > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch, > gruntHistory2.patch, gruntHistory3.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272158#comment-13272158 ] Allan Avendaño commented on PIG-2583: - Last patch shows by default an enumerated history, this can be omitted with "-n" > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch, > gruntHistory2.patch, gruntHistory3.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272066#comment-13272066 ] Daniel Dai commented on PIG-2583: - Yes, that's better, and let's make show line number the default option. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch, > gruntHistory2.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[
https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271965#comment-13271965
]
Prashant Kommireddi commented on PIG-2583:
--
Not a huge deal, but again replicating Unix 'history' behavior (no parenthesis)
would be ideal in my opinion.
{code}
pkommireddi@pkommireddi-wsl:~$ pwd
/home/pkommireddi
pkommireddi@pkommireddi-wsl:~$ date
Wed May 9 17:01:37 PDT 2012
pkommireddi@pkommireddi-wsl:~$ pwd
/home/pkommireddi
pkommireddi@pkommireddi-wsl:~$ whoami
pkommireddi
pkommireddi@pkommireddi-wsl:~$ history
2989 pwd
2990 date
2991 pwd
2992 whoami
{code}
> Add Grunt command to list the statements in cache
> -
>
> Key: PIG-2583
> URL: https://issues.apache.org/jira/browse/PIG-2583
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.10.0
>Reporter: Daniel Dai
>Assignee: Allan Avendaño
>Priority: Minor
> Labels: newbie
> Fix For: 0.11
>
> Attachments: gruntHistory.patch, gruntHistory1.patch,
> gruntHistory2.patch
>
>
> It is convenient to list statements in cache:
> grunt> a = load '1.txt';
> grunt> b = foreach a generate $0, $1;
> grunt> list
> a = load '1.txt';
> b = foreach a generate $0, $1;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271959#comment-13271959 ] Daniel Dai commented on PIG-2583: - Fine for me. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch, > gruntHistory2.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[
https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271937#comment-13271937
]
Allan Avendaño commented on PIG-2583:
-
Something like this?
grunt> history -n
(1) A = load 'data/abs' using PigStorage('|') as (name:chararray, id1:int,
id2:int, id3:int);
(2) B = group A by id1;
(3) C = order A by id2;
grunt> history
A = load 'data/abs' using PigStorage('|') as (name:chararray, id1:int, id2:int,
id3:int);
B = rank A by id1;
C = order A by id2;
> Add Grunt command to list the statements in cache
> -
>
> Key: PIG-2583
> URL: https://issues.apache.org/jira/browse/PIG-2583
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.10.0
>Reporter: Daniel Dai
>Assignee: Allan Avendaño
>Priority: Minor
> Labels: newbie
> Fix For: 0.11
>
> Attachments: gruntHistory.patch, gruntHistory1.patch,
> gruntHistory2.patch
>
>
> It is convenient to list statements in cache:
> grunt> a = load '1.txt';
> grunt> b = foreach a generate $0, $1;
> grunt> list
> a = load '1.txt';
> b = foreach a generate $0, $1;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271822#comment-13271822 ] Daniel Dai commented on PIG-2583: - Looks good. Another request however, we shall print line number, but we can optionally turn it off (history -n sounds good?) > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch, > gruntHistory2.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270977#comment-13270977 ] Daniel Dai commented on PIG-2583: - I take back the "last definition" part. If people keep reusing the same alias, we shall keep the complete history: A = load ... A = foreach A ... A = filter A by ... It is possible to detect complete dead statement, but I don't want to complicate the implementation. However, we shall reuse scriptCache instead of introducing a new data structure. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[
https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270899#comment-13270899
]
Prashant Kommireddi commented on PIG-2583:
--
Should we let the behavior be similar to standard "history" command on UNIX
shell?
{code}
localhost:~ pkommireddi$ pwd
/Users/pkommireddi
localhost:~ pkommireddi$ date
Tue May 8 15:26:26 PDT 2012
localhost:~ pkommireddi$ whoami
pkommireddi
localhost:~ pkommireddi$ pwd
/Users/pkommireddi
localhost:~ pkommireddi$ history
541 pwd
542 date
543 whoami
544 pwd
545 history
{code}
It might be useful for users while developing/debugging to be able to look at
all declarations of an alias.
> Add Grunt command to list the statements in cache
> -
>
> Key: PIG-2583
> URL: https://issues.apache.org/jira/browse/PIG-2583
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.10.0
>Reporter: Daniel Dai
>Assignee: Allan Avendaño
>Priority: Minor
> Labels: newbie
> Fix For: 0.11
>
> Attachments: gruntHistory.patch, gruntHistory1.patch
>
>
> It is convenient to list statements in cache:
> grunt> a = load '1.txt';
> grunt> b = foreach a generate $0, $1;
> grunt> list
> a = load '1.txt';
> b = foreach a generate $0, $1;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270888#comment-13270888 ] Gianmarco De Francisci Morales commented on PIG-2583: - Probably it is fine anyway. The order in which they are defined (and printed) will tell you that D got defined before A. One use case I see for this history command is to build a Pig script interactively step by step. The output of the history can be then copy-pasted to a file to save the script. In this case you would need to repeat the D = ... statement anyway to get the correct order. To do this for more than one statement you could simply use the output of history, and copy-paste it in grunt up to (excluding) the last A = ... statement. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch, gruntHistory1.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[
https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270879#comment-13270879
]
Allan Avendaño commented on PIG-2583:
-
I was working on this, but I found something particular if we show the last
definition for the alias, for example on this sequence:
A = load 'data/abs' using PigStorage('|') as (name:chararray, id1:int, id2:int,
id3:int);
D = group A by id1;
A = load 'data/abs' using PigStorage('|') as (name:chararray, x:int, y:int,
z:int);
With modifications on the patch that I attach, the following history is shown
(according to historical modifications on aliases):
D = group A by id1;
A = load 'data/abs' using PigStorage('|') as (name:chararray, x:int, y:int,
z:int);
But, D will work on previous schema of A, and not with the last definition. And
maybe, we are missing this other historical point of view.
> Add Grunt command to list the statements in cache
> -
>
> Key: PIG-2583
> URL: https://issues.apache.org/jira/browse/PIG-2583
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.10.0
>Reporter: Daniel Dai
>Assignee: Allan Avendaño
>Priority: Minor
> Labels: newbie
> Fix For: 0.11
>
> Attachments: gruntHistory.patch, gruntHistory1.txt
>
>
> It is convenient to list statements in cache:
> grunt> a = load '1.txt';
> grunt> b = foreach a generate $0, $1;
> grunt> list
> a = load '1.txt';
> b = foreach a generate $0, $1;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269877#comment-13269877 ] Daniel Dai commented on PIG-2583: - It is right to put in command cache only if it is a Pig statement not a command. However, if an alias is get reused, we should show the last definition, not all. I think we should make use of Graph.scriptCache to do it. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Assignee: Allan Avendaño >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265551#comment-13265551 ] Daniel Dai commented on PIG-2583: - Thanks, I will take a look. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0 >Reporter: Daniel Dai >Priority: Minor > Labels: newbie > Fix For: 0.11 > > Attachments: gruntHistory.patch > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[ https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228963#comment-13228963 ] Daniel Dai commented on PIG-2583: - Sounds good. > Add Grunt command to list the statements in cache > - > > Key: PIG-2583 > URL: https://issues.apache.org/jira/browse/PIG-2583 > Project: Pig > Issue Type: Improvement >Reporter: Daniel Dai >Priority: Minor > Labels: newbie > Fix For: 0.11 > > > It is convenient to list statements in cache: > grunt> a = load '1.txt'; > grunt> b = foreach a generate $0, $1; > grunt> list > a = load '1.txt'; > b = foreach a generate $0, $1; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2583) Add Grunt command to list the statements in cache
[
https://issues.apache.org/jira/browse/PIG-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228925#comment-13228925
]
Bill Graham commented on PIG-2583:
--
Great idea. What about {{history}} instead of {{list}}? It's similar to bash
and groovy shell. I couldn't find an irb equivalent.
> Add Grunt command to list the statements in cache
> -
>
> Key: PIG-2583
> URL: https://issues.apache.org/jira/browse/PIG-2583
> Project: Pig
> Issue Type: Improvement
>Reporter: Daniel Dai
>Priority: Minor
> Labels: newbie
> Fix For: 0.11
>
>
> It is convenient to list statements in cache:
> grunt> a = load '1.txt';
> grunt> b = foreach a generate $0, $1;
> grunt> list
> a = load '1.txt';
> b = foreach a generate $0, $1;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
