[jira] [Commented] (PIG-3044) Trigger POPartialAgg compaction under GC pressure
[ https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528310#comment-13528310 ] Jonathan Coveney commented on PIG-3044: --- Thanks for the review. Committed to trunk and to 0.11 > Trigger POPartialAgg compaction under GC pressure > - > > Key: PIG-3044 > URL: https://issues.apache.org/jira/browse/PIG-3044 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0, 0.11, 0.10.1 >Reporter: Dmitriy V. Ryaboy >Assignee: Dmitriy V. Ryaboy > Fix For: 0.11, 0.12 > > Attachments: PIG-3044.2.diff, PIG-3044-hotfix.patch, PIG-3404.diff > > > If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the > available heap can be consumed by the POPartialAgg operator. This can cause > memory issues for jobs that use all, or nearly all, of the heap already. > If we make POPartialAgg "spillable" (trigger compaction when memory reduction > is required), we would be much nicer to high-memory jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3044) Trigger POPartialAgg compaction under GC pressure
[ https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528296#comment-13528296 ] Cheolsoo Park commented on PIG-3044: +1 for the hotfix patch. I also verified test-commit passes. Thanks Jonathan! > Trigger POPartialAgg compaction under GC pressure > - > > Key: PIG-3044 > URL: https://issues.apache.org/jira/browse/PIG-3044 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0, 0.11, 0.10.1 >Reporter: Dmitriy V. Ryaboy >Assignee: Dmitriy V. Ryaboy > Fix For: 0.11, 0.12 > > Attachments: PIG-3044.2.diff, PIG-3044-hotfix.patch, PIG-3404.diff > > > If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the > available heap can be consumed by the POPartialAgg operator. This can cause > memory issues for jobs that use all, or nearly all, of the heap already. > If we make POPartialAgg "spillable" (trigger compaction when memory reduction > is required), we would be much nicer to high-memory jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3044) Trigger POPartialAgg compaction under GC pressure
[ https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526600#comment-13526600 ] Thejas M Nair commented on PIG-3044: bq. I would even say we remove the % memory budget as the Spillable mechanism is more reliable and much simpler. The reason why % memory budget was introduced for SelfSpillBag, was because the spillable mechanism didn't always work well. The cleanup often was getting triggered too late. So I think it is better use the Spillable mechanism here to spill earlier if necessary, as the patch is doing. > Trigger POPartialAgg compaction under GC pressure > - > > Key: PIG-3044 > URL: https://issues.apache.org/jira/browse/PIG-3044 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0, 0.11, 0.10.1 >Reporter: Dmitriy V. Ryaboy >Assignee: Dmitriy V. Ryaboy > Fix For: 0.11, 0.12 > > Attachments: PIG-3044.2.diff, PIG-3404.diff > > > If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the > available heap can be consumed by the POPartialAgg operator. This can cause > memory issues for jobs that use all, or nearly all, of the heap already. > If we make POPartialAgg "spillable" (trigger compaction when memory reduction > is required), we would be much nicer to high-memory jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3044) Trigger POPartialAgg compaction under GC pressure
[
https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506647#comment-13506647
]
Julien Le Dem commented on PIG-3044:
in DefaultAbstractBag.getMemorySize():
* You use avgTupleSize first to sum the aggregated tuple size and then you
divide it to get the average. Could you use different names for clarity?
something like:
{noformat}
for (j = 0; i.hasNext() && j < 100; j++) {
totalTupleSize += i.next().getMemorySize()
}
averageTupleSize = totalTupleSize / j;
{noformat}
* Here we take the floor() of the average estimate. Do you want to make it a
ceil() by adding + 1 ?
That way we would slightly overestimate instead of slightly underestimate.
otherwise it looks all good to me.
I would even say we remove the % memory budget as the Spillable mechanism is
more reliable and much simpler.
+1
> Trigger POPartialAgg compaction under GC pressure
> -
>
> Key: PIG-3044
> URL: https://issues.apache.org/jira/browse/PIG-3044
> Project: Pig
> Issue Type: Improvement
>Affects Versions: 0.10.0, 0.11, 0.10.1
>Reporter: Dmitriy V. Ryaboy
>Assignee: Dmitriy V. Ryaboy
> Fix For: 0.12
>
> Attachments: PIG-3404.diff
>
>
> If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the
> available heap can be consumed by the POPartialAgg operator. This can cause
> memory issues for jobs that use all, or nearly all, of the heap already.
> If we make POPartialAgg "spillable" (trigger compaction when memory reduction
> is required), we would be much nicer to high-memory jobs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-3044) Trigger POPartialAgg compaction under GC pressure
[ https://issues.apache.org/jira/browse/PIG-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494382#comment-13494382 ] Dmitriy V. Ryaboy commented on PIG-3044: Since this is preventing some jobs from migrating from Pig 9 to Pig 11 in our environment, I would like to add it to 11, but an argument can be made that this is not a critical bug and should therefore not be applied to the 0.11 branch. Committers, please weigh in if you have an opinion on this. > Trigger POPartialAgg compaction under GC pressure > - > > Key: PIG-3044 > URL: https://issues.apache.org/jira/browse/PIG-3044 > Project: Pig > Issue Type: Improvement >Affects Versions: 0.10.0, 0.11, 0.10.1 >Reporter: Dmitriy V. Ryaboy >Assignee: Dmitriy V. Ryaboy > Fix For: 0.12 > > > If partial aggregation is turned on in pig 10 and 11, 20% (by default) of the > available heap can be consumed by the POPartialAgg operator. This can cause > memory issues for jobs that use all, or nearly all, of the heap already. > If we make POPartialAgg "spillable" (trigger compaction when memory reduction > is required), we would be much nicer to high-memory jobs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
