[jira] [Commented] (PIG-3801) Auto local mode does not call storeSchema

2014-03-22 Thread Aniket Mokashi (JIRA) 

[ 
https://issues.apache.org/jira/browse/PIG-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944356#comment-13944356
 ] 

Aniket Mokashi commented on PIG-3801:
-

Committed to trunk. Thanks [~julienledem] for the review.

> Auto local mode does not call storeSchema
> -
>
> Key: PIG-3801
> URL: https://issues.apache.org/jira/browse/PIG-3801
> Project: Pig
>  Issue Type: Bug
>Reporter: Aniket Mokashi
>Assignee: Aniket Mokashi
> Fix For: 0.13.0
>
> Attachments: PIG-3801.patch
>
>
> https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java#L481
> Pig code explicitly runs PigOutputCommitter.storeCleanup for local jobs. We 
> also need to add this for auto-local jobs.
> To repro this problem, run-
> >  a = load '2.txt' as (a0:chararray, a1:int);
> >  store a into 'a' using PigStorage(',','-schema');
> This creates .pig_schema file in pig -x local mode, but does not create 
> .pig_schema file in auto-local mode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PIG-3801) Auto local mode does not call storeSchema

2014-03-10 Thread Julien Le Dem (JIRA) 

[ 
https://issues.apache.org/jira/browse/PIG-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926350#comment-13926350
 ] 

Julien Le Dem commented on PIG-3801:


I would use properties.getProperty(MAPREDUCE_FRAMEWORK_NAME).equals(LOCAL) to 
decide if it's running locally, but otherwise this looks good to me.

> Auto local mode does not call storeSchema
> -
>
> Key: PIG-3801
> URL: https://issues.apache.org/jira/browse/PIG-3801
> Project: Pig
>  Issue Type: Bug
>Reporter: Aniket Mokashi
>Assignee: Aniket Mokashi
> Attachments: PIG-3801.patch
>
>
> https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java#L481
> Pig code explicitly runs PigOutputCommitter.storeCleanup for local jobs. We 
> also need to add this for auto-local jobs.
> To repro this problem, run-
> >  a = load '2.txt' as (a0:chararray, a1:int);
> >  store a into 'a' using PigStorage(',','-schema');
> This creates .pig_schema file in pig -x local mode, but does not create 
> .pig_schema file in auto-local mode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (PIG-3801) Auto local mode does not call storeSchema

2014-03-10 Thread Julien Le Dem (JIRA) 

[ 
https://issues.apache.org/jira/browse/PIG-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926351#comment-13926351
 ] 

Julien Le Dem commented on PIG-3801:


+1

> Auto local mode does not call storeSchema
> -
>
> Key: PIG-3801
> URL: https://issues.apache.org/jira/browse/PIG-3801
> Project: Pig
>  Issue Type: Bug
>Reporter: Aniket Mokashi
>Assignee: Aniket Mokashi
> Attachments: PIG-3801.patch
>
>
> https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java#L481
> Pig code explicitly runs PigOutputCommitter.storeCleanup for local jobs. We 
> also need to add this for auto-local jobs.
> To repro this problem, run-
> >  a = load '2.txt' as (a0:chararray, a1:int);
> >  store a into 'a' using PigStorage(',','-schema');
> This creates .pig_schema file in pig -x local mode, but does not create 
> .pig_schema file in auto-local mode.



--
This message was sent by Atlassian JIRA
(v6.2#6252)