[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498819#comment-14498819 ] Rohini Palaniswamy commented on PIG-4509: - Committed to trunk. Thanks for reporting this and the review [~thejas]. > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch, PIG-4509-FixCompileError.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498812#comment-14498812 ] Thejas M Nair commented on PIG-4509: +1 The change looks good to me. Thanks Rohini! > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch, PIG-4509-FixCompileError.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498787#comment-14498787 ] Thejas M Nair commented on PIG-4509: It builds fine on my mac as well with jdk 7. However, it is failing with jdk7 in our internal build environment as well (probably linux). The fact that it passes in some setups is certainly very strange. I think we should still go ahead and fix this, as far as i know this should result in a syntax error. > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498377#comment-14498377 ] Rohini Palaniswamy commented on PIG-4509: - [~knoguchi] tried and it compiles fine for him too. I have jdk8 in eclipse and jdk7 for ant. But it failed for me when I compiled with jdk6 on a Linux box. [~thejas], what is the jdk version you are using and Mac or Linux? > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498357#comment-14498357 ] Rohini Palaniswamy commented on PIG-4509: - I see the problem with the code. But it is odd that it builds fine for me with ant clean jar -Dhadoopversion=23 and eclipse also does not show any errors. Let me put up a patch to fix that. > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[
https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498325#comment-14498325
]
Thejas M Nair commented on PIG-4509:
[~rohini] This results in a compilation failure.
{code}
src/org/apache/pig/backend/hadoop/executionengine/tez/TezSessionManager.java:105:
error: unreported exception Throwable; must be caught or declared to be thrown
[javac] throw e;
[javac] ^
{code}
> [Pig on Tez] Unassigned applications not killed on shutdown
> ---
>
> Key: PIG-4509
> URL: https://issues.apache.org/jira/browse/PIG-4509
> Project: Pig
> Issue Type: Bug
>Affects Versions: 0.14.0
>Reporter: Rohini Palaniswamy
>Assignee: Rohini Palaniswamy
> Fix For: 0.15.0
>
> Attachments: PIG-4509-1.patch
>
>
> tezclient.stop() should be called when tezClient.waitTillReady() is
> interrupted on shutdown.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4509) [Pig on Tez] Unassigned applications not killed on shutdown
[ https://issues.apache.org/jira/browse/PIG-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497675#comment-14497675 ] Daniel Dai commented on PIG-4509: - +1 > [Pig on Tez] Unassigned applications not killed on shutdown > --- > > Key: PIG-4509 > URL: https://issues.apache.org/jira/browse/PIG-4509 > Project: Pig > Issue Type: Bug >Affects Versions: 0.14.0 >Reporter: Rohini Palaniswamy >Assignee: Rohini Palaniswamy > Fix For: 0.15.0 > > Attachments: PIG-4509-1.patch > > > tezclient.stop() should be called when tezClient.waitTillReady() is > interrupted on shutdown. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
