[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032186#comment-15032186
]
Rohini Palaniswamy commented on PIG-4673:
-
Created PIG-4750 to fix this UDF to compile Pattern once and reuse.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: 0.16.0
>
> Attachments: PIG-4673-1.patch, PIG-4673-fix-test-failure.patch,
> replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14950250#comment-14950250
]
Rohini Palaniswamy commented on PIG-4673:
-
Yes. Committed
https://issues.apache.org/jira/secure/attachment/12765682/PIG-4673-fix-test-failure.patch
after
svn mv
contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/evaluation/string/TestBuiltinReplaceMulti.java
contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/evaluation/string/TestReplaceMulti.java
Thanks for the review Daniel.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: 0.16.0
>
> Attachments: PIG-4673-1.patch, PIG-4673-fix-test-failure.patch,
> replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949663#comment-14949663
]
Daniel Dai commented on PIG-4673:
-
+1. Patch does not apply now, assume you will need to move the file first then
apply the patch.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: 0.16.0
>
> Attachments: PIG-4673-1.patch, PIG-4673-fix-test-failure.patch,
> replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876190#comment-14876190
]
Rohini Palaniswamy commented on PIG-4673:
-
Good feature [~murali.k.h@gmail.com]. Would you be interested in enhancing
this UDF for better performance in a new jira?
http://stackoverflow.com/questions/7661460/replace-multiple-substrings-at-once/7661573#7661573
- You can basically compile the Pattern once and cache it (Have a limit on the
cache if the search strings are variable and not constant) and do the multiple
replace in one go. Have seen a lot of jobs suffer in performance because of
UDFs with regex match and not reusing compiled Pattern.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: 0.16.0
>
> Attachments: PIG-4673-1.patch, replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876840#comment-14876840
]
Murali Rao commented on PIG-4673:
-
[~rohini] : Thanks for your inputs, will check on the performance and will take
necessary actions.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: 0.16.0
>
> Attachments: PIG-4673-1.patch, replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790701#comment-14790701
]
Daniel Dai commented on PIG-4673:
-
I cannot see the patch, can you attach to the Jira?
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: site
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791312#comment-14791312
]
Murali Rao commented on PIG-4673:
-
[~daijy] : Thanks for the review. While committing the code to SVN, getting
error as
below. Plz. let me know how to get write access to repo.
org.apache.subversion.javahl.ClientException: svn: E170001: Commit failed
(details follow):
svn: E170001: MKACTIVITY of
'/repos/asf/!svn/act/0fb982d8-4f01-0010-a887-1302968552fb': 403 Forbidden (
http://svn.apache.org)
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: site
>
> Attachments: PIG-4673-1.patch, replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790765#comment-14790765
]
Murali Rao commented on PIG-4673:
-
[~daijy] : Attached patch, plz check and let me know your inputs.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Affects Versions: site
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
> Labels: None
> Fix For: site
>
> Attachments: replace_multi_udf.patch
>
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('A1B2C3D4','A','1'),'B','2'),'C','3'),'D','4')
>
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'A1B2C3D4', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PIG-4673) Built In UDF - REPLACE_MULTI : For a given string, search and replace all occurrences of search keys with replacement values.
[
https://issues.apache.org/jira/browse/PIG-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739882#comment-14739882
]
Daniel Dai commented on PIG-4673:
-
Sounds useful to have it in piggybank. I can review it once you put a patch.
> Built In UDF - REPLACE_MULTI : For a given string, search and replace all
> occurrences of search keys with replacement values.
> --
>
> Key: PIG-4673
> URL: https://issues.apache.org/jira/browse/PIG-4673
> Project: Pig
> Issue Type: New Feature
> Components: piggybank
>Reporter: Murali Rao
>Assignee: Murali Rao
>Priority: Minor
>
> Lets say we have a string = 'A1B2C3D4'. Our objective is to replace A with 1,
> B with 2, C with 3 and D with 4 to derive 11223344 string.
> Using existing REPLACE method
> REPLACE(REPLACE(REPLACE(REPLACE('ABCD','A','1'),'B','2'),'C','3'),'D','4')
> With proposed UDF : REPLACE_MULTI method
> General Syntax :
> REPLACE_MULTI ( sourceString, [ search1#replacement1, ... ] )
> REPLACE_MULTI ( 'abcd', [ 'A'#'1','B'#'2', 'C'#'3', 'D'#'4' ] )
> Advantage :
> 1. Function calls are reduced.
> 2. Ease to code and better readable.
>
> Let me know your thoughts/ inputs on having this UDF in Piggy Bank. Will take
> this up based on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
