[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650021#comment-16650021 ] Nandor Kollar commented on PIG-5317: Thanks Rohini, Koji and Satish! I mark this Jira as resolved, and in case there are still test failures due to this one, feel free to reopen it. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch, > PIG-5317_without_new_dep_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646952#comment-16646952 ] Koji Noguchi commented on PIG-5317: --- Thanks Nandor, Satish, Rohini! > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch, > PIG-5317_without_new_dep_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16645320#comment-16645320 ] Rohini Palaniswamy commented on PIG-5317: - +1. Committed PIG-5317_without_new_dep_2.patch. Thanks Nandor for the fix. Current patch should take care of the broken tez e2e tests. Sorry about continuously missing this one and delaying looking into this for long. I did really test Koji's patience on this one !/jira/images/icons/emoticons/smile.png! . I still think there might be an issue if the pig installation refers to libraries from hadoop and tez instead of shipping it on its own as hadoop and tez only seem to have commons-lang-2.6.jar and not commons-lang3. Will investigate that later. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch, > PIG-5317_without_new_dep_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637635#comment-16637635 ] Satish Subhashrao Saley commented on PIG-5317: -- I tested PIG-5317_without_new_dep_2.patch, it looks good. +1 (non-binding) > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch, > PIG-5317_without_new_dep_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621847#comment-16621847 ] Nandor Kollar commented on PIG-5317: Thanks [~satishsaley], I think the one line change in the build.xml in PIG-5317_without_new_dep_2.patch should fix this problem. Since I can't easily create a cluster with Tez installed, could you please test on your end and tell if it indeed fixes this failure? > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch, > PIG-5317_without_new_dep_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[
https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621188#comment-16621188
]
Satish Subhashrao Saley commented on PIG-5317:
--
You can try {{CastScalar}} e2e test in tez mode. It will fail.
{code:java}
ERROR TestDriver::runTestGroup at : 729 Failed to run test CastScalar_11
_Failed running ./CastScalar_11.pig
Dumping logfile <>/CastScalar_11.log ===
Pig Stack Trace
---
ERROR 2998: Unhandled internal error. org/apache/commons/lang3/ArrayUtils
java.lang.NoClassDefFoundError: org/apache/commons/lang3/ArrayUtils
at
org.apache.pig.backend.hadoop.executionengine.tez.util.TezCompilerUtil.replaceOutput(TezCompilerUtil.java:192)
at
org.apache.pig.backend.hadoop.executionengine.tez.util.TezCompilerUtil.connectTezOpToNewSuccesor(TezCompilerUtil.java:182)
at
org.apache.pig.backend.hadoop.executionengine.tez.plan.optimizer.MultiQueryOptimizerTez.removeSplittee(MultiQueryOptimizerTez.java:324)
at
org.apache.pig.backend.hadoop.executionengine.tez.plan.optimizer.MultiQueryOptimizerTez.visitTezOp(MultiQueryOptimizerTez.java:289)
at
org.apache.pig.backend.hadoop.executionengine.tez.plan.TezOperator.visit(TezOperator.java:265)
at
org.apache.pig.backend.hadoop.executionengine.tez.plan.TezOperator.visit(TezOperator.java:56)
at
org.apache.pig.impl.plan.ReverseDependencyOrderWalker.walk(ReverseDependencyOrderWalker.java:71)
at org.apache.pig.impl.plan.PlanVisitor.visit(PlanVisitor.java:46)
at
org.apache.pig.backend.hadoop.executionengine.tez.TezLauncher.optimize(TezLauncher.java:482)
at
org.apache.pig.backend.hadoop.executionengine.tez.TezLauncher.compile(TezLauncher.java:431)
at
org.apache.pig.backend.hadoop.executionengine.tez.TezLauncher.launchPig(TezLauncher.java:172)
at
org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.launchPig(HExecutionEngine.java:290)
at org.apache.pig.PigServer.launchPlan(PigServer.java:1479)
at org.apache.pig.PigServer.executeCompiledLogicalPlan(PigServer.java:1464)
at org.apache.pig.PigServer.execute(PigServer.java:1453)
at org.apache.pig.PigServer.executeBatch(PigServer.java:489)
at org.apache.pig.PigServer.executeBatch(PigServer.java:472)
at org.apache.pig.tools.grunt.GruntParser.executeBatch(GruntParser.java:172)
at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:235)
at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:206)
at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
at org.apache.pig.Main.run(Main.java:630)
at org.apache.pig.Main.main(Main.java:175)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.hadoop.util.RunJar.run(RunJar.java:239)
at org.apache.hadoop.util.RunJar.main(RunJar.java:153)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang3.ArrayUtils
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 29 more
{code}
> Upgrade old dependencies: commons-lang, hsqldb, commons-logging
> ---
>
> Key: PIG-5317
> URL: https://issues.apache.org/jira/browse/PIG-5317
> Project: Pig
> Issue Type: Improvement
>Reporter: Nandor Kollar
>Assignee: Nandor Kollar
>Priority: Minor
> Fix For: 0.18.0
>
> Attachments: PIG-5317_1.patch, PIG-5317_2.patch,
> PIG-5317_amend.patch, PIG-5317_without_new_dep.patch
>
>
> Pig depends on old version of commons-lang, hsqldb and commons-logging. It
> would be nice to upgrade the version of these dependencies, for commons-lang
> Pig should depend on commons-lang3 instead (which is already present in the
> ivy.xml)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542125#comment-16542125 ] Rohini Palaniswamy commented on PIG-5317: - bq. The new numbers are empirically deduced, not sure if they are "correct", not really familiar with ORC predicate pushdown. It think it should still be ok. TezCompilerUtil java.lang.NoClassDefFoundError: org/apache/commons/lang3/ArrayUtils still needs to be fixed. [~satishsaley] found that just reverting it back to ArrayUtils worked as commons-lang was being pulled by some other package. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538189#comment-16538189 ] Nandor Kollar commented on PIG-5317: [~rohini] could you please have a look at PIG-5317_without_new_dep.patch? Hope it fixes the failing test cases, and would be nice to make all green again. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515720#comment-16515720 ] Koji Noguchi commented on PIG-5317: --- [~rohini], appreciate your help in reviewing this jira. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432439#comment-16432439 ] Koji Noguchi commented on PIG-5317: --- [~rohini], can you take a look at this? Love to get our tests into clean state. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313277#comment-16313277 ] Nandor Kollar commented on PIG-5317: Attached PIG-5317_without_new_dep.patch, without new dependencies, but changed thresholds for the failing cases. [~rohini] could you please help with a review? The new numbers are empirically deduced, not sure if they are "correct", not really familiar with ORC predicate pushdown. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, > PIG-5317_amend.patch, PIG-5317_without_new_dep.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16311379#comment-16311379 ] Nandor Kollar commented on PIG-5317: I took a look at the changes in RandomStringUtils, and I think this change is related to LANG-1286. Looks like with this overflow fix changed RandomStringUtils' API too, though I don't know why does this affect us. > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, PIG-5317_amend.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309881#comment-16309881 ] Rohini Palaniswamy commented on PIG-5317: - bq. the documentation says that RandomStringUtils is deprecated, and RandomStringGenerator should be used instead Can we find some other alternative that does not add a new dependency? > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, PIG-5317_amend.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[
https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309874#comment-16309874
]
Rohini Palaniswamy commented on PIG-5317:
-
I am also seeing this error
{code}
java.lang.NoClassDefFoundError: org/apache/commons/lang3/ArrayUtils
at
org.apache.pig.backend.hadoop.executionengine.tez.util.TezCompilerUtil.replaceOutput(TezCompilerUtil.java:192)
{code}
> Upgrade old dependencies: commons-lang, hsqldb, commons-logging
> ---
>
> Key: PIG-5317
> URL: https://issues.apache.org/jira/browse/PIG-5317
> Project: Pig
> Issue Type: Improvement
>Reporter: Nandor Kollar
>Assignee: Nandor Kollar
>Priority: Minor
> Fix For: 0.18.0
>
> Attachments: PIG-5317_1.patch, PIG-5317_2.patch, PIG-5317_amend.patch
>
>
> Pig depends on old version of commons-lang, hsqldb and commons-logging. It
> would be nice to upgrade the version of these dependencies, for commons-lang
> Pig should depend on commons-lang3 instead (which is already present in the
> ivy.xml)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309873#comment-16309873 ] Nandor Kollar commented on PIG-5317: Ouch, it looks TestOrcStoragePushdown fails because of this patch. Attached PIG-5317_amend.patch, the documentation says that RandomStringUtils is deprecated, and RandomStringGenerator should be used instead. Looks like in commons-lang3 the behavior of this deprecated class changed? [~rohini] could you please have a look at PIG-5317_amend.patch? > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, PIG-5317_amend.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309869#comment-16309869 ] Rohini Palaniswamy commented on PIG-5317: - Can we avoid adding a new dependency? > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Fix For: 0.18.0 > > Attachments: PIG-5317_1.patch, PIG-5317_2.patch, PIG-5317_amend.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[ https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308353#comment-16308353 ] Nandor Kollar commented on PIG-5317: [~rohini] what do you think about PIG-5317_2.patch? Do you see any issue that could be caused by upgrading these dependencies? > Upgrade old dependencies: commons-lang, hsqldb, commons-logging > --- > > Key: PIG-5317 > URL: https://issues.apache.org/jira/browse/PIG-5317 > Project: Pig > Issue Type: Improvement >Reporter: Nandor Kollar >Assignee: Nandor Kollar >Priority: Minor > Attachments: PIG-5317_1.patch, PIG-5317_2.patch > > > Pig depends on old version of commons-lang, hsqldb and commons-logging. It > would be nice to upgrade the version of these dependencies, for commons-lang > Pig should depend on commons-lang3 instead (which is already present in the > ivy.xml) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[
https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285800#comment-16285800
]
Nandor Kollar commented on PIG-5317:
[~rohini] the database path is the same, didn't change:
{code}
dbServer.setDatabasePath(0,
"file:" + TMP_DIR + "batchtest;"+
"hsqldb.default_table_type=cached;hsqldb.cache_rows=100;sql.enforce_strict_size=true");
{code}
I added the caching to this path now in PIG-5317_2.patch.
> Upgrade old dependencies: commons-lang, hsqldb, commons-logging
> ---
>
> Key: PIG-5317
> URL: https://issues.apache.org/jira/browse/PIG-5317
> Project: Pig
> Issue Type: Improvement
>Reporter: Nandor Kollar
>Assignee: Nandor Kollar
>Priority: Minor
> Attachments: PIG-5317_1.patch, PIG-5317_2.patch
>
>
> Pig depends on old version of commons-lang, hsqldb and commons-logging. It
> would be nice to upgrade the version of these dependencies, for commons-lang
> Pig should depend on commons-lang3 instead (which is already present in the
> ivy.xml)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PIG-5317) Upgrade old dependencies: commons-lang, hsqldb, commons-logging
[
https://issues.apache.org/jira/browse/PIG-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285014#comment-16285014
]
Rohini Palaniswamy commented on PIG-5317:
-
{code}
dblocation = TMP_DIR + "batchtest";
78 url = "jdbc:hsqldb:file:" + dblocation
79 +
";hsqldb.default_table_type=cached;hsqldb.cache_rows=100";
{code}
Above dblocation which wrote to build/test is not used anymore and dbUrl is
used. Where is the database now created? Need to ensure that it does not get
created in the same directory as pig source and also it gets cleaned up at the
end of the test or at least when ant clean is run like before. You might also
want to keep the cached settings to make the test faster.
> Upgrade old dependencies: commons-lang, hsqldb, commons-logging
> ---
>
> Key: PIG-5317
> URL: https://issues.apache.org/jira/browse/PIG-5317
> Project: Pig
> Issue Type: Improvement
>Reporter: Nandor Kollar
>Assignee: Nandor Kollar
>Priority: Minor
> Attachments: PIG-5317_1.patch
>
>
> Pig depends on old version of commons-lang, hsqldb and commons-logging. It
> would be nice to upgrade the version of these dependencies, for commons-lang
> Pig should depend on commons-lang3 instead (which is already present in the
> ivy.xml)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
