[jira] Commented: (PIVOT-713) Consider making some inner classes non-final
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008436#comment-13008436 ] Greg Brown commented on PIVOT-713: -- No, the first patch is wrong too. The only classes that should be made non-final are GridPane.Row and TableView.Column. Consider making some inner classes non-final Key: PIVOT-713 URL: https://issues.apache.org/jira/browse/PIVOT-713 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Reporter: xiefei Assignee: Sandro Martini Priority: Minor Fix For: 2.0.1 Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes non-final
[
https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008443#comment-13008443
]
Sandro Martini commented on PIVOT-713:
--
Ok, I'll change only those definitions.
But what do you think on this comment by Chris ?
If GridPane.Row will be made non-final, should it's private 'cells' field also
be changed to protected or a protected getter added? (And then also for
TablePane.Row to be consistent?)
So my previous addition even of a protected getCells() method in GridPane and
TablePane.
Tell me if this is needed.
And last:
wtk\src\org\apache\pivot\wtk\GridPane.java
00260: public static class Filler extends Component {
wtk\src\org\apache\pivot\wtk\TablePane.java
00622: public static final class Filler extends Component {
I think it would be better to put GridPane.Filler final, ok ? Tell me.
Bye,
Sandro
Consider making some inner classes non-final
Key: PIVOT-713
URL: https://issues.apache.org/jira/browse/PIVOT-713
Project: Pivot
Issue Type: Improvement
Components: wtk
Affects Versions: 2.0
Reporter: xiefei
Assignee: Sandro Martini
Priority: Minor
Fix For: 2.0.1
Attachments: patch.patch,
patch_remove_final_from_all_public_static_final_class.patch,
pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt
I am implementing a groovy-builder-like DSL for pivot using scala. In the
DSL, I need subclass of each component/container that retains original
component/container behavior but is aware of the DSL context as well. All
goes well except GridPane.Row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIVOT-713) Consider making some inner classes non-final
[ https://issues.apache.org/jira/browse/PIVOT-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008451#comment-13008451 ] Sandro Martini commented on PIVOT-713: -- Ok, now all is clear (I hope :-) ). Thank you very much Consider making some inner classes non-final Key: PIVOT-713 URL: https://issues.apache.org/jira/browse/PIVOT-713 Project: Pivot Issue Type: Improvement Components: wtk Affects Versions: 2.0 Reporter: xiefei Assignee: Sandro Martini Priority: Minor Fix For: 2.0.1 Attachments: patch.patch, patch_remove_final_from_all_public_static_final_class.patch, pivot_final_class_grep.txt, pivot_public_static_final_class_grep.txt I am implementing a groovy-builder-like DSL for pivot using scala. In the DSL, I need subclass of each component/container that retains original component/container behavior but is aware of the DSL context as well. All goes well except GridPane.Row. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (PIVOT-718) TreeViewSelectionListener not invoked
TreeViewSelectionListener not invoked - Key: PIVOT-718 URL: https://issues.apache.org/jira/browse/PIVOT-718 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: jkd1.6,linux Reporter: laurent Gebus Fix For: 2.0.1 I have a TreeView with a TreeViewSelectionListener, but the listener doesn't get invoked when a item is removed from the tree. I do : tree.getTreeData().remove( tree.getSelectedNode()); tree is refreshed : the removed node is no longer shown, no node is selected but the listener is not invoked. Looked at the code : in TreeView#itemsRemoved(), clearAndDecrementPaths() is invoked and returns 0. But Listeners are only invoked when 0 is returned. see attached example comparing a TreeView to a ListView -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-718) TreeViewSelectionListener not invoked
[ https://issues.apache.org/jira/browse/PIVOT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] laurent Gebus updated PIVOT-718: Attachment: TreeSelect.bxml TreeSelect.java TreeViewSelectionListener not invoked - Key: PIVOT-718 URL: https://issues.apache.org/jira/browse/PIVOT-718 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: jkd1.6,linux Reporter: laurent Gebus Fix For: 2.0.1 Attachments: TreeSelect.bxml, TreeSelect.java I have a TreeView with a TreeViewSelectionListener, but the listener doesn't get invoked when a item is removed from the tree. I do : tree.getTreeData().remove( tree.getSelectedNode()); tree is refreshed : the removed node is no longer shown, no node is selected but the listener is not invoked. Looked at the code : in TreeView#itemsRemoved(), clearAndDecrementPaths() is invoked and returns 0. But Listeners are only invoked when 0 is returned. see attached example comparing a TreeView to a ListView -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
GridPane.Filler should still be final.
On Mar 18, 2011, at 5:32 PM, smart...@apache.org wrote:
Author: smartini
Date: Fri Mar 18 21:32:23 2011
New Revision: 1083076
URL: http://svn.apache.org/viewvc?rev=1083076view=rev
Log:
PIVOT-713
Modified:
pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java?rev=1083076r1=1083075r2=1083076view=diff
==
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java Fri Mar 18
21:32:23 2011
@@ -32,7 +32,7 @@ public class GridPane extends Container
/**
* Represents a grid pane row.
*/
-public static final class Row implements SequenceComponent,
IterableComponent {
+public static class Row implements SequenceComponent,
IterableComponent {
private ArrayListComponent cells = new ArrayListComponent();
private GridPane gridPane = null;
@@ -257,7 +257,7 @@ public class GridPane extends Container
/**
* Component that can be used as filler for empty cells.
*/
-public static class Filler extends Component {
+public static final class Filler extends Component {
public Filler() {
installSkin(Filler.class);
}
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java?rev=1083076r1=1083075r2=1083076view=diff
==
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java Fri Mar 18
21:32:23 2011
@@ -49,7 +49,7 @@ public class TableView extends Component
/**
* Contains information about a table column.
*/
-public static final class Column {
+public static class Column {
private TableView tableView = null;
private String name = null;
[jira] Created: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: windows-normal-usage-1.jpg Example of normal Windows usage Ctrl+Alt+F Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
Hi Greg,
GridPane.Filler should still be final.
that's how it is now (before only Filler in TablePane was final), so
they are aligned now.
I hope this little change will be Ok ... if not, tell me.
Bye
On Mar 18, 2011, at 5:32 PM, smart...@apache.org wrote:
Author: smartini
Date: Fri Mar 18 21:32:23 2011
New Revision: 1083076
URL: http://svn.apache.org/viewvc?rev=1083076view=rev
Log:
PIVOT-713
Modified:
pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java?rev=1083076r1=1083075r2=1083076view=diff
==
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java Fri Mar 18
21:32:23 2011
@@ -32,7 +32,7 @@ public class GridPane extends Container
/**
* Represents a grid pane row.
*/
- public static final class Row implements SequenceComponent,
IterableComponent {
+ public static class Row implements SequenceComponent,
IterableComponent {
private ArrayListComponent cells = new ArrayListComponent();
private GridPane gridPane = null;
@@ -257,7 +257,7 @@ public class GridPane extends Container
/**
* Component that can be used as filler for empty cells.
*/
- public static class Filler extends Component {
+ public static final class Filler extends Component {
public Filler() {
installSkin(Filler.class);
}
Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
URL:
http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java?rev=1083076r1=1083075r2=1083076view=diff
==
--- pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java (original)
+++ pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java Fri Mar 18
21:32:23 2011
@@ -49,7 +49,7 @@ public class TableView extends Component
/**
* Contains information about a table column.
*/
- public static final class Column {
+ public static class Column {
private TableView tableView = null;
private String name = null;
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: windows-normal-usage-2.jpg Here is an example with just F5. Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg, windows-normal-usage-2.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-719) Keyboard shortcut display is not correct on Windows XP platform
[ https://issues.apache.org/jira/browse/PIVOT-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-719: - Attachment: keyboard.patch Here is a patch to fix both problems. Keyboard shortcut display is not correct on Windows XP platform --- Key: PIVOT-719 URL: https://issues.apache.org/jira/browse/PIVOT-719 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: Windows XP SP3, Java SE JDK/JRE 1.6 Reporter: Roger Whitcomb Priority: Minor Fix For: 2.0.1 Attachments: keyboard.patch, windows-keyboard-shortcut-problem.jpg, windows-normal-usage-1.jpg, windows-normal-usage-2.jpg Original Estimate: 1h Remaining Estimate: 1h All other Windows programs I have seen use Alt+Shift+F (using + as the final separator) for keyboard shortcuts. Pivot would render this Alt+Shift-F (using - as the final separator). In addition, if the key has no modifiers given (such as F5) Pivot will render it as -F5 (with leading separator). Bugs are in org.apache.pivot.wtk.Keyboard and org.apache.pivot.wtk.Platform -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
Don't worry, the important is to fix things :-) ... and you know that in many parts of Pivot I still need your help to find the right direction ... thank you again for your patience. Bye
[jira] Commented: (PIVOT-718) TreeViewSelectionListener not invoked
[ https://issues.apache.org/jira/browse/PIVOT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13008667#comment-13008667 ] Sandro Martini commented on PIVOT-718: -- Hi Laurent, thank you very much for the test case, but I'm sorry I have to ask you another small thing: can you re-attach both files granting the usage in ASF work (or by Apache constraints we aren't able to use them) ? I have already started to look at it, and seems a simple thing to fix :-) . I wait your re-attach of files (and probably should be better to delete currently attached files, to avoid confusion). Thank you again, Sandro TreeViewSelectionListener not invoked - Key: PIVOT-718 URL: https://issues.apache.org/jira/browse/PIVOT-718 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: jkd1.6,linux Reporter: laurent Gebus Fix For: 2.0.1 Attachments: TreeSelect.bxml, TreeSelect.java I have a TreeView with a TreeViewSelectionListener, but the listener doesn't get invoked when a item is removed from the tree. I do : tree.getTreeData().remove( tree.getSelectedNode()); tree is refreshed : the removed node is no longer shown, no node is selected but the listener is not invoked. Looked at the code : in TreeView#itemsRemoved(), clearAndDecrementPaths() is invoked and returns 0. But Listeners are only invoked when 0 is returned. see attached example comparing a TreeView to a ListView -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (PIVOT-718) TreeViewSelectionListener not invoked
[ https://issues.apache.org/jira/browse/PIVOT-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sandro Martini updated PIVOT-718: - Assignee: Sandro Martini Priority: Minor (was: Major) TreeViewSelectionListener not invoked - Key: PIVOT-718 URL: https://issues.apache.org/jira/browse/PIVOT-718 Project: Pivot Issue Type: Bug Components: wtk Affects Versions: 2.0 Environment: jkd1.6,linux Reporter: laurent Gebus Assignee: Sandro Martini Priority: Minor Fix For: 2.0.1 Attachments: TreeSelect.bxml, TreeSelect.java I have a TreeView with a TreeViewSelectionListener, but the listener doesn't get invoked when a item is removed from the tree. I do : tree.getTreeData().remove( tree.getSelectedNode()); tree is refreshed : the removed node is no longer shown, no node is selected but the listener is not invoked. Looked at the code : in TreeView#itemsRemoved(), clearAndDecrementPaths() is invoked and returns 0. But Listeners are only invoked when 0 is returned. see attached example comparing a TreeView to a ListView -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
