[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

2011-05-19 Thread Edvin Syse (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036046#comment-13036046
 ] 

Edvin Syse commented on PIVOT-744:
--

My patch is NOT changing the behavior you describe, my patch will only change 
what happens when ALL elements are already selected. I also agree that the 
current behavior is weird, and not as expected, so a rewrite to the way Windows 
works for example would probably be wise.

 ListView with SelectMode.Multi does not allow deselection when all elements 
 are selected
 

 Key: PIVOT-744
 URL: https://issues.apache.org/jira/browse/PIVOT-744
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Edvin Syse
Assignee: Sandro Martini
Priority: Minor
 Fix For: 2.0.1

 Attachments: TerraListViewSkinDeselect.patch, pivot744_patch2.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 If you select all items in a ListView that allows multiple selection, there 
 is not way to deselect using the keyboard. One would expect that releasing 
 shift and moving the arrows would revert to selecting a single element, but 
 this is not the case. The supplied patch allows deselection in the following 
 manner:
 1. If you select all elements with the keyboard downwards, release shift 
 and then press Keyboard.KeyCode.UP, the next last element in the list is 
 selected.
 2. If you select all elements with the keyboard upwards, release shift and 
 then press Keyboard.KeyCode.DOWN, the next first element in the list is 
 selected.
 I tried to take enabled state into account when finding the approproate 
 element to select, so the patch may be more involved than nessecary.
 I tested against ScriptApplication 
 --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons

2011-05-19 Thread Raffaele Borrelli (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036079#comment-13036079
 ] 

Raffaele Borrelli commented on PIVOT-737:
-

Thanks Sandro and Greg, I was having the problem with multiple selection in my 
application but I couldn't figure out where it was coming from. Now everything 
works fine.

 TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
 -

 Key: PIVOT-737
 URL: https://issues.apache.org/jira/browse/PIVOT-737
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Raffaele Borrelli
Assignee: Sandro Martini
 Fix For: 2.0.1


 The default TerraTableViewSkin initiates a TableViewRowEditor without regard 
 for which mouse button is pressed.
 The problem is in the functions mouseClick() and mouseDown() which should be 
 fixed to distinguish between left and right mouse click.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

2011-05-19 Thread Greg Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036120#comment-13036120
 ] 

Greg Brown commented on PIVOT-744:
--

Was this patch actually applied? It doesn't look like it - just want to confirm.


 ListView with SelectMode.Multi does not allow deselection when all elements 
 are selected
 

 Key: PIVOT-744
 URL: https://issues.apache.org/jira/browse/PIVOT-744
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Edvin Syse
Assignee: Sandro Martini
Priority: Minor
 Fix For: 2.0.1

 Attachments: TerraListViewSkinDeselect.patch, pivot744_patch2.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 If you select all items in a ListView that allows multiple selection, there 
 is not way to deselect using the keyboard. One would expect that releasing 
 shift and moving the arrows would revert to selecting a single element, but 
 this is not the case. The supplied patch allows deselection in the following 
 manner:
 1. If you select all elements with the keyboard downwards, release shift 
 and then press Keyboard.KeyCode.UP, the next last element in the list is 
 selected.
 2. If you select all elements with the keyboard upwards, release shift and 
 then press Keyboard.KeyCode.DOWN, the next first element in the list is 
 selected.
 I tried to take enabled state into account when finding the approproate 
 element to select, so the patch may be more involved than nessecary.
 I tested against ScriptApplication 
 --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

2011-05-19 Thread Sandro Martini (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036146#comment-13036146
 ] 

Sandro Martini commented on PIVOT-744:
--

No, to avoid side effects (before yesterday's patch on the same classes), but 
it's here in attach (the newer file).
If you have time, try to apply and make some test.
If possible this evening I'll do other tests and commit but for what I've seen 
all seems to work good with this patch.

But for changes in behavior (on the current selection, etc via keys) we can see 
what to do for the 2.1 (should already exist an issue for this).


 ListView with SelectMode.Multi does not allow deselection when all elements 
 are selected
 

 Key: PIVOT-744
 URL: https://issues.apache.org/jira/browse/PIVOT-744
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Edvin Syse
Assignee: Sandro Martini
Priority: Minor
 Fix For: 2.0.1

 Attachments: TerraListViewSkinDeselect.patch, pivot744_patch2.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 If you select all items in a ListView that allows multiple selection, there 
 is not way to deselect using the keyboard. One would expect that releasing 
 shift and moving the arrows would revert to selecting a single element, but 
 this is not the case. The supplied patch allows deselection in the following 
 manner:
 1. If you select all elements with the keyboard downwards, release shift 
 and then press Keyboard.KeyCode.UP, the next last element in the list is 
 selected.
 2. If you select all elements with the keyboard upwards, release shift and 
 then press Keyboard.KeyCode.DOWN, the next first element in the list is 
 selected.
 I tried to take enabled state into account when finding the approproate 
 element to select, so the patch may be more involved than nessecary.
 I tested against ScriptApplication 
 --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

2011-05-19 Thread Greg Brown (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036155#comment-13036155
 ] 

Greg Brown commented on PIVOT-744:
--

OK. If you do apply this patch and it works correctly, you should be sure to 
make similar changes to TableView and TreeView.


 ListView with SelectMode.Multi does not allow deselection when all elements 
 are selected
 

 Key: PIVOT-744
 URL: https://issues.apache.org/jira/browse/PIVOT-744
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Edvin Syse
Assignee: Sandro Martini
Priority: Minor
 Fix For: 2.0.1

 Attachments: TerraListViewSkinDeselect.patch, pivot744_patch2.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 If you select all items in a ListView that allows multiple selection, there 
 is not way to deselect using the keyboard. One would expect that releasing 
 shift and moving the arrows would revert to selecting a single element, but 
 this is not the case. The supplied patch allows deselection in the following 
 manner:
 1. If you select all elements with the keyboard downwards, release shift 
 and then press Keyboard.KeyCode.UP, the next last element in the list is 
 selected.
 2. If you select all elements with the keyboard upwards, release shift and 
 then press Keyboard.KeyCode.DOWN, the next first element in the list is 
 selected.
 I tried to take enabled state into account when finding the approproate 
 element to select, so the patch may be more involved than nessecary.
 I tested against ScriptApplication 
 --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PIVOT-744) ListView with SelectMode.Multi does not allow deselection when all elements are selected

2011-05-19 Thread Sandro Martini (JIRA)

[ 
https://issues.apache.org/jira/browse/PIVOT-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036160#comment-13036160
 ] 

Sandro Martini commented on PIVOT-744:
--

Ok, today I'll make some other tests and today/in a few days I'll commit 
changes in ListView class and only after in related classes (I wasn't sure 
before this discussion that the current behavior was right).


 ListView with SelectMode.Multi does not allow deselection when all elements 
 are selected
 

 Key: PIVOT-744
 URL: https://issues.apache.org/jira/browse/PIVOT-744
 Project: Pivot
  Issue Type: Bug
  Components: wtk-terra
Affects Versions: 2.0
Reporter: Edvin Syse
Assignee: Sandro Martini
Priority: Minor
 Fix For: 2.0.1

 Attachments: TerraListViewSkinDeselect.patch, pivot744_patch2.patch

   Original Estimate: 0.25h
  Remaining Estimate: 0.25h

 If you select all items in a ListView that allows multiple selection, there 
 is not way to deselect using the keyboard. One would expect that releasing 
 shift and moving the arrows would revert to selecting a single element, but 
 this is not the case. The supplied patch allows deselection in the following 
 manner:
 1. If you select all elements with the keyboard downwards, release shift 
 and then press Keyboard.KeyCode.UP, the next last element in the list is 
 selected.
 2. If you select all elements with the keyboard upwards, release shift and 
 then press Keyboard.KeyCode.DOWN, the next first element in the list is 
 selected.
 I tried to take enabled state into account when finding the approproate 
 element to select, so the patch may be more involved than nessecary.
 I tested against ScriptApplication 
 --src=--src=/org/apache/pivot/demos/lists/multi_select.bxml.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Pivot version available programmatically?

2011-05-19 Thread Roger L. Whitcomb
In ApplicationContext there is a getJVMVersion() that returns a
Version structure.  I'm looking for something that gives me the Pivot
version number (Version object) in a similar fashion and I can't find
it.  Is there such a method?  If not, do you think it would be useful?
Could it be set somehow from the static build.properties version
number?

 

Thanks.

 

Roger Whitcomb

Architect, Engineering

Ingres Corporation

roger.whitc...@ingres.com mailto:roger.whitc...@ingres.com 

 

PHONE +1 650.587.5596

FAX +1 650.587.5550

 

www.ingres.com http://www.ingres.com/  

 

This transmission is confidential and intended solely for the use of the
recipient named above. It may contain confidential, proprietary, or
legally privileged information. If you are not the intended recipient,
you are hereby notified that any unauthorized review, use, disclosure or
distribution is strictly prohibited. If you have received this
transmission in error, please contact the sender by reply e-mail and
delete the original transmission and all copies from your system.

 



Re: Pivot version available programmatically?

2011-05-19 Thread Greg Brown
You can get this information from the JAR manifests but it is pretty ugly. Best 
thing to do would probably be to add build.properties or something like it to 
the generated JARs so it would be available on the classpath.

On May 19, 2011, at 3:42 PM, Roger L. Whitcomb wrote:

 In ApplicationContext there is a getJVMVersion() that returns a
 Version structure.  I'm looking for something that gives me the Pivot
 version number (Version object) in a similar fashion and I can't find
 it.  Is there such a method?  If not, do you think it would be useful?
 Could it be set somehow from the static build.properties version
 number?
 
 
 
 Thanks.
 
 
 
 Roger Whitcomb
 
 Architect, Engineering
 
 Ingres Corporation
 
 roger.whitc...@ingres.com mailto:roger.whitc...@ingres.com 
 
 
 
 PHONE +1 650.587.5596
 
 FAX +1 650.587.5550
 
 
 
 www.ingres.com http://www.ingres.com/  
 
 
 
 This transmission is confidential and intended solely for the use of the
 recipient named above. It may contain confidential, proprietary, or
 legally privileged information. If you are not the intended recipient,
 you are hereby notified that any unauthorized review, use, disclosure or
 distribution is strictly prohibited. If you have received this
 transmission in error, please contact the sender by reply e-mail and
 delete the original transmission and all copies from your system.
 
 
 



RE: Pivot version available programmatically?

2011-05-19 Thread Roger L. Whitcomb
Would it be worth adding this to the build?  Would it then also be worth
adding an API to load and parse this as a Version structure?

Roger Whitcomb | Architect, Engineering | roger.whitc...@ingres.com |
Ingres | 500 Arguello Street | Suite 200 | Redwood City | CA | 94063 |
USA  +1 650-587-5596 | fax: +1 650-587-5550

-Original Message-
From: Greg Brown [mailto:gk_br...@verizon.net] 
Sent: Thursday, May 19, 2011 1:04 PM
To: dev@pivot.apache.org
Subject: Re: Pivot version available programmatically?

You can get this information from the JAR manifests but it is pretty
ugly. Best thing to do would probably be to add build.properties or
something like it to the generated JARs so it would be available on the
classpath.

On May 19, 2011, at 3:42 PM, Roger L. Whitcomb wrote:

 In ApplicationContext there is a getJVMVersion() that returns a
 Version structure.  I'm looking for something that gives me the Pivot
 version number (Version object) in a similar fashion and I can't find
 it.  Is there such a method?  If not, do you think it would be useful?
 Could it be set somehow from the static build.properties version
 number?
 
 
 
 Thanks.
 
 
 
 Roger Whitcomb
 
 Architect, Engineering
 
 Ingres Corporation
 
 roger.whitc...@ingres.com mailto:roger.whitc...@ingres.com 
 
 
 
 PHONE +1 650.587.5596
 
 FAX +1 650.587.5550
 
 
 
 www.ingres.com http://www.ingres.com/  
 
 
 
 This transmission is confidential and intended solely for the use of
the
 recipient named above. It may contain confidential, proprietary, or
 legally privileged information. If you are not the intended recipient,
 you are hereby notified that any unauthorized review, use, disclosure
or
 distribution is strictly prohibited. If you have received this
 transmission in error, please contact the sender by reply e-mail and
 delete the original transmission and all copies from your system.
 
 
 



Re: Pivot version available programmatically?

2011-05-19 Thread Greg Brown
 Would it be worth adding this to the build?  Would it then also be worth
 adding an API to load and parse this as a Version structure?

Yes, I think so.



[jira] [Created] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties

2011-05-19 Thread Roger Whitcomb (JIRA)
Add API to return Version of Pivot retrieved from build.properties


 Key: PIVOT-746
 URL: https://issues.apache.org/jira/browse/PIVOT-746
 Project: Pivot
  Issue Type: New Feature
  Components: wtk
Affects Versions: 2.0.1
 Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Priority: Trivial
 Fix For: 2.0.1
 Attachments: version.patch

Would be helpful to be able to determine programmatically what the version of 
Pivot is.  The simplest method is to include build.properties which is the 
original source of this information in the packaged .jar files and then to 
provide an API to read and parse this value into a Version structure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties

2011-05-19 Thread Roger Whitcomb (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roger Whitcomb updated PIVOT-746:
-

Attachment: version.patch

Here is a patch that implements this feature.

 Add API to return Version of Pivot retrieved from build.properties
 

 Key: PIVOT-746
 URL: https://issues.apache.org/jira/browse/PIVOT-746
 Project: Pivot
  Issue Type: New Feature
  Components: wtk
Affects Versions: 2.0.1
 Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Priority: Trivial
 Fix For: 2.0.1

 Attachments: version.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Would be helpful to be able to determine programmatically what the version of 
 Pivot is.  The simplest method is to include build.properties which is the 
 original source of this information in the packaged .jar files and then to 
 provide an API to read and parse this value into a Version structure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Resolved] (PIVOT-746) Add API to return Version of Pivot retrieved from build.properties

2011-05-19 Thread Greg Brown (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIVOT-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Brown resolved PIVOT-746.
--

Resolution: Fixed

Patch applied. Thanks!


 Add API to return Version of Pivot retrieved from build.properties
 

 Key: PIVOT-746
 URL: https://issues.apache.org/jira/browse/PIVOT-746
 Project: Pivot
  Issue Type: New Feature
  Components: wtk
Affects Versions: 2.0.1
 Environment: Windows XP SP3, JDK 1.6.0_16
Reporter: Roger Whitcomb
Priority: Trivial
 Fix For: 2.0.1

 Attachments: version.patch

   Original Estimate: 1h
  Remaining Estimate: 1h

 Would be helpful to be able to determine programmatically what the version of 
 Pivot is.  The simplest method is to include build.properties which is the 
 original source of this information in the packaged .jar files and then to 
 provide an API to read and parse this value into a Version structure.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira