[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583027#comment-13583027 ] Sandro Martini commented on PIVOT-893: -- Hi Roger, yes you have reason ... currently the default constructor of Label calls setText(null), but in many other Pivot classes (like TextInput, TextArea, etc) we set not null default, from to not null objects. So now I'll do the change. Note that this could give some problem on user code, but I think could be good the same to have this in 2.0.3 . For objections, tell me. Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-861) Memory leak: Window icon ImageListenerList retains reference to closed windows, preventing garbage collection
[ https://issues.apache.org/jira/browse/PIVOT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583032#comment-13583032 ] Sandro Martini commented on PIVOT-861: -- ok, I like this new implementation of ListenerList even better (reuse standard collections where possible/makes sense). Today I'll put a toString method there to further simplify debugging. Then we can safely mark this issue as resolved, and see the remaining part (moved) in the other, related issue. Memory leak: Window icon ImageListenerList retains reference to closed windows, preventing garbage collection - Key: PIVOT-861 URL: https://issues.apache.org/jira/browse/PIVOT-861 Project: Pivot Issue Type: Bug Components: wtk, wtk-media Affects Versions: 2.0.2 Environment: Windows XP, Java 1.7.0_05 Reporter: David Keen Assignee: Sandro Martini Labels: cache, image, leak, listener, memory Fix For: 2.0.3 Attachments: leaktest.zip, Pivot861.launch, PivotSample.zip When a window or dialog is opened which has an icon, after it is closed it cannot be garbage collected because a reference is retained to it through the icon. Removing the icon resolves the issue. As far as I've investigated, the issue appears to the in the ImageListenerList which each Image contains. I've done a heapdump of my application and used the IBM HeapAnalyzer which shows this list containing a reference to the window/dialog through the ImageViewSkin, but I don't know the Pivot internals well enough to see where or how it should be released. I'll attach a simple test application to show the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-861) Memory leak: Window icon ImageListenerList retains reference to closed windows, preventing garbage collection
[ https://issues.apache.org/jira/browse/PIVOT-861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583290#comment-13583290 ] Roger Whitcomb commented on PIVOT-861: -- Hi Sandro, Last night while working on a totally unrelated issue in our code, there was thrown a ConcurrentModificationException from ArrayList$Itr from the ComponentKeyListenerList So, this issue isn't totally done yet. I could not reproduce the problem, but I think it was from the Tooltip skin adding itself to the key listener list while we were iterating through calling the keyPressed listeners. If that is the case, it would be a rare event (getting the keyPressed event at just the tooltip delay time) but I need to figure out a way not to have this happen. And I'm not completely sure this was the cause either. Memory leak: Window icon ImageListenerList retains reference to closed windows, preventing garbage collection - Key: PIVOT-861 URL: https://issues.apache.org/jira/browse/PIVOT-861 Project: Pivot Issue Type: Bug Components: wtk, wtk-media Affects Versions: 2.0.2 Environment: Windows XP, Java 1.7.0_05 Reporter: David Keen Assignee: Sandro Martini Labels: cache, image, leak, listener, memory Fix For: 2.0.3 Attachments: leaktest.zip, Pivot861.launch, PivotSample.zip When a window or dialog is opened which has an icon, after it is closed it cannot be garbage collected because a reference is retained to it through the icon. Removing the icon resolves the issue. As far as I've investigated, the issue appears to the in the ImageListenerList which each Image contains. I've done a heapdump of my application and used the IBM HeapAnalyzer which shows this list containing a reference to the window/dialog through the ImageViewSkin, but I don't know the Pivot internals well enough to see where or how it should be released. I'll attach a simple test application to show the issue. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
