[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584189#comment-13584189 ] Sandro Martini commented on PIVOT-893: -- To have more knowledge of the little change in Label setText(String text) , I created a dedicated issue for that, and linked here. Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583027#comment-13583027 ] Sandro Martini commented on PIVOT-893: -- Hi Roger, yes you have reason ... currently the default constructor of Label calls setText(null), but in many other Pivot classes (like TextInput, TextArea, etc) we set not null default, from to not null objects. So now I'll do the change. Note that this could give some problem on user code, but I think could be good the same to have this in 2.0.3 . For objections, tell me. Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582129#comment-13582129 ] Sandro Martini commented on PIVOT-893: -- maximumLength property added to Label, and run some examples to ensure all is good, even with ComponentExplorer. Now I guess if (in Label) enable the check that text (to set) must be not null, like in many other classes ... but I can wait for 2.1. Comments ? Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582391#comment-13582391 ] Roger Whitcomb commented on PIVOT-893: -- I don't know what good allowing a null text would do, so why not enable the check now? Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-893) Set lower default value for maximumLength in TextInput and TextArea
[ https://issues.apache.org/jira/browse/PIVOT-893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13579625#comment-13579625 ] Sandro Martini commented on PIVOT-893: -- For 2.0.x branch, set new values for TextInput and TextArea: Committed revision 1446823. Merge in trunk soon. For Label, in next days (unless problems with it). Set lower default value for maximumLength in TextInput and TextArea --- Key: PIVOT-893 URL: https://issues.apache.org/jira/browse/PIVOT-893 Project: Pivot Issue Type: Improvement Reporter: Sandro Martini Assignee: Sandro Martini Priority: Minor Fix For: 2.0.3 To avoid flood memory in input fields, the default value for maximumLength (or maximum number of chars) has to be put to a lower value (up to now is was Integer.MAX_VALUE), that could be: 32768 - 1 for TextInput (like in other GUI frameworks), and 1048576 - 1 for TextArea (where many times it's used to display even long multi-line text). Note that if/when needed, it's always possible to set maximumLength to any positive value up to Integer.MAX_VALUE, using the related setter method. Verify if implement maximumLength even for Labels (could be useful too) with the same default value of TextInput, or maybe even lower. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
