Re: Missing board report

2018-09-30 Thread Julian Feinauer 
Hey Chris,

I wanted to give you the precedence here but please let me know if I can help 
you with anything.

Julian

Am 30.09.18, 21:52 schrieb "Christofer Dutz" :

Yup ... I'm on it ...

Just wanted to have the first release out the door and other things done 
first.
Will take care of this in the next one or two days.

Chris

Am 30.09.18, 15:36 schrieb "Justin Mclean" :

Hi,

The incubator PMC would appreciated if you could complete the podling 
report on time. It takes time to prepare the incubator report, have your 
mentors sign off the report and for the board to review it, in order for all 
that to happen the report is due on Wednesday.

Thanks,
Justin

Missing board report

2018-09-30 Thread Justin Mclean 
Hi,

The incubator PMC would appreciated if you could complete the podling report on 
time. It takes time to prepare the incubator report, have your mentors sign off 
the report and for the board to review it, in order for all that to happen the 
report is due on Wednesday.

Thanks,
Justin

Podling Report Reminder - October 2018

2018-09-30 Thread jmclean 
Dear podling,

This email was sent by an automated system on behalf of the Apache
Incubator PMC. It is an initial reminder to give you plenty of time to
prepare your quarterly board report.

The board meeting is scheduled for Wed, 17 October 2018, 10:30 am PDT.
The report for your podling will form a part of the Incubator PMC
report. The Incubator PMC requires your report to be submitted 2 weeks
before the board meeting, to allow sufficient time for review and
submission (Wed, October 03).

Please submit your report with sufficient time to allow the Incubator
PMC, and subsequently board members to review and digest. Again, the
very latest you should submit your report is 2 weeks prior to the board
meeting.

Candidate names should not be made public before people are actually
elected, so please do not include the names of potential committers or
PPMC members in your report.

Thanks,

The Apache Incubator PMC

Submitting your Report

--

Your report should contain the following:

*   Your project name
*   A brief description of your project, which assumes no knowledge of
the project or necessarily of its field
*   A list of the three most important issues to address in the move
towards graduation.
*   Any issues that the Incubator PMC or ASF Board might wish/need to be
aware of
*   How has the community developed since the last report
*   How has the project developed since the last report.
*   How does the podling rate their own maturity.

This should be appended to the Incubator Wiki page at:

https://wiki.apache.org/incubator/October2018

Note: This is manually populated. You may need to wait a little before
this page is created from a template.

Mentors
---

Mentors should review reports for their project(s) and sign them off on
the Incubator wiki page. Signing off reports shows that you are
following the project - projects that are not signed may raise alarms
for the Incubator PMC.

Incubator PMC

[GitHub] JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked.

2018-09-30 Thread GitBox 
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java 
checked.
URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-425737626
 
 
   Hey @chrisdutz and @sruehl just wanted to bump that up. I think we should 
decide here on something and either merge or decline the PR. What do you hink 
about the checked exceptions for wrong user inputs?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JulianFeinauer commented on a change in pull request #26: connection manager for connection pool initial version

2018-09-30 Thread GitBox 
JulianFeinauer commented on a change in pull request #26: connection manager 
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221466969
 
 

 ##
 File path: 
plc4j/core/src/main/java/org/apache/plc4x/java/connectionpool/ConnectionProxy.java
 ##
 @@ -0,0 +1,24 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package org.apache.plc4x.java.connectionpool;
+
+import org.apache.plc4x.java.api.connection.PlcConnection;
+
+public interface ConnectionProxy extends PlcConnection {
 
 Review comment:
   Do we need this? I guess not?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JulianFeinauer commented on a change in pull request #26: connection manager for connection pool initial version

2018-09-30 Thread GitBox 
JulianFeinauer commented on a change in pull request #26: connection manager 
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221467015
 
 

 ##
 File path: 
plc4j/core/src/main/java/org/apache/plc4x/java/connectionpool/PlcConnectionManager.java
 ##
 @@ -0,0 +1,154 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package org.apache.plc4x.java.connectionpool;
+
+import org.apache.plc4x.java.PlcDriverManager;
+import org.apache.plc4x.java.PlcDriverManagerInterface;
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.connection.PlcConnection;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.exceptions.NoConnectionAvailableException;
+import org.apache.plc4x.java.exceptions.NotConnectedException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.PreDestroy;
+import java.util.HashMap;
+import java.util.Map;
+
+
+/**
+ * Plc Connection Manager to act as a controller to give threads access to a 
connection in the pool only if it is not
+ * used by a different thread
+ */
+public class PlcConnectionManager implements PlcDriverManagerInterface {
+private static final Logger logger = 
LoggerFactory.getLogger(PlcConnectionManager.class);
+//TODO: implement connection Pool with more than one connection
+private Map connections = new HashMap<>();
 
 Review comment:
   I think we have to use a ConcurrentMap or to use locks to avoid 
ConcurrentModificationExceptions, as multiple threads could modify the list 
concurrently.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JulianFeinauer commented on a change in pull request #26: connection manager for connection pool initial version

2018-09-30 Thread GitBox 
JulianFeinauer commented on a change in pull request #26: connection manager 
for connection pool initial version
URL: https://github.com/apache/incubator-plc4x/pull/26#discussion_r221466988
 
 

 ##
 File path: 
plc4j/core/src/main/java/org/apache/plc4x/java/connectionpool/PlcConnectionManager.java
 ##
 @@ -0,0 +1,154 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+package org.apache.plc4x.java.connectionpool;
+
+import org.apache.plc4x.java.PlcDriverManager;
+import org.apache.plc4x.java.PlcDriverManagerInterface;
+import org.apache.plc4x.java.api.authentication.PlcAuthentication;
+import org.apache.plc4x.java.api.connection.PlcConnection;
+import org.apache.plc4x.java.api.exceptions.PlcConnectionException;
+import org.apache.plc4x.java.exceptions.NoConnectionAvailableException;
+import org.apache.plc4x.java.exceptions.NotConnectedException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.PreDestroy;
+import java.util.HashMap;
+import java.util.Map;
+
+
+/**
+ * Plc Connection Manager to act as a controller to give threads access to a 
connection in the pool only if it is not
+ * used by a different thread
+ */
+public class PlcConnectionManager implements PlcDriverManagerInterface {
 
 Review comment:
   Perhaps it is more intuitive to name the Thing PlcConnectionPool or 
something.
   And it should (as stated above) implement PlcDriverManager directly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Compater opened a new pull request #26: connection manager for connection pool initial version

2018-09-30 Thread GitBox 
Compater opened a new pull request #26: connection manager for connection pool 
initial version
URL: https://github.com/apache/incubator-plc4x/pull/26
 
 
   As discussed at the meet up this is the first implementation of our 
connection manager acting as a connection pool.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services