[GitHub] [plc4x] glcj commented on pull request #169: Subscription Support for S7 Driver in 0.6.1
glcj commented on pull request #169: URL: https://github.com/apache/plc4x/pull/169#issuecomment-653082111 Thanks, Julian, All the information and the links to the test codes and the pcap captures are in the open points of Jira (I imagine that if the PR proceeds they will be closed). What is not pointed out is the modification of the Modbus driver (sorry for the mess) to be able to read the scalar types directly. This modification allows the drivers to be exchanged transparently. I will be attentive to any questions, Thank you, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [ApacheCon] Anyone planning on submitting something?
Thanks Julian, I did not know the project, I will check it looks fine. Best regards, El jue., 2 jul. 2020 a las 2:51, Julian Feinauer (< j.feina...@pragmaticminds.de>) escribió: > Hi, > > finally have to jump in (too much Beer Content in the morning). > > We already had the Idea of doing "Beer Punkt Null" with a local brewery > here (its a play of words as the 4.0 in german speaks pretty similar, 4 = > vier which is roughly pronounced like "fear"). > > Do you know the https://web.craftbeerpi.com/? > > Julian > > > Am 01.07.20, 19:59 schrieb "Cesar Garcia" : > > Someday Chris, why not > > I remember training in Mannheim where I had the opportunity to taste > very > good German beers (Many beers!) ... > > In the important thing. Why not have a solution for small breweries > based > on open technologies, aka, Karaf + PLC4X + Graphana + CSS. > > And so on ... > > Best regards, > > > https://assets.new.siemens.com/siemens/assets/api/uuid:1d50c8bc9667e38e180a0ba36a3efa54f80e6d39/version:1529694435/us-cg-fb-tallgrass-brewery-and-custom-metalcraft-case-study.pdf > > El mié., 1 jul. 2020 a las 12:57, Christofer Dutz (< > christofer.d...@c-ware.de>) escribió: > > > Oh yeah ... > > > > But better not talk about it, better get together and drink it ;) > > > > Chris > > > > > > Am 01.07.20, 18:30 schrieb "Cesar Garcia" >: > > > > Hi, > > > > It would be interesting to talk about automation of "CraftBeer". > > > > We are working in that direction, > > > > Best regards, > > > > El mié., 1 jul. 2020 a las 11:47, Christofer Dutz (< > > christofer.d...@c-ware.de>) escribió: > > > > > So would anyone here be interested in doing a pure PLC4X talk? > > > > > > I have been doing that for the past 3-4 years and would be > happy to > > give > > > someone else the chance to do that. > > > > > > Of course, if no one wants to I could probably do it. > > > > > > Chris > > > > > > > > > Am 01.07.20, 16:06 schrieb "Christofer Dutz" < > > christofer.d...@c-ware.de>: > > > > > > Hi all, > > > > > > as you might have gotten 1 or 2 … or 20 emails from Rich > > yesterday > > > regarding the virtual ApacheCon this year. > > > > > > We have 2 weeks to submit talks for the IoT tracks. > > > > > > Perhaps we should coordinate on what we want to submit? > > > > > > > > > * I know the StreamPipes folks already submitted > something > > which > > > involves PLC4X which I would be helping out with. > > > * I was planning on something down the line of > > Home-Automation > > > built with Apache software … using PLC4X, IoTDB and perhaps > Royale > > to build > > > some sort of POC > > > > > > Any other ideas? > > > > > > Chris > > > > > > > > > > > > > > > > -- > > *CEOS Automatización, C.A.* > > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > > *Ing. César García* > > > > *Cel: +58 414-760.98.95* > > > > *Hotline Técnica SIEMENS: 0800 1005080* > > > > *Email: support.aan.automat...@siemens.com > > * > > > > > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > *Ing. César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: support.aan.automat...@siemens.com > * > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com *
Re: S7 write test doubt
Hi Iñigo,
happy you made quite some progress.
If you were asking yourself why for BYTE, WORD and DWORD the driver is
returning a List ... these are considered Bit-Strings. If you want to
read/write a single byte as an integer value, please use SINT instead.
So regarding one of your questions ... could you instead of doing:
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127);
Please try:
builderWriter.addItem("mivariable", "%DB20:DBB06:SINT", 127);
And if you're getting an INTERNAL_ERROR that's probably our fault. As I
mentioned, we haven't done too much writing as no one ever uses that ;-)
Chris
Am 02.07.20, 15:56 schrieb "Iñigo Angulo" :
Hi,
I have been doing further tests with the S7 driver. I would like to ask you
some doubts, which i am not sure if relate to the PLC4X driver or the actual
hardware (Siemens S7-300) i am using (pretty novice in PLC data access im
afraid...)
The "Read value" tests I have done work correctly for different datatypes,
for example:
builderReader.addItem("mivariable", "%DB20:DBX5.0:BOOL"); //Single
boolean value
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns a
PlcList (Array of 8 boolean values)
builderReader.addItem("mivariable", "%DB20:DBW06:WORD"); //returns a
PlcList (Array of 16 boolean values)
builderReader.addItem("mivariable", "%DB20:DBD06:DWORD"); //returns a
PlcList (Array of 32 boolean values)
builderReader.addItem("mivariable", "%DB20:DBW06:INT"); //returns a
PlcInteger (16 bit integer (signed))
builderReader.addItem("mivariable", "%DB20:DBD06:DINT"); //returns a
PlcInteger (32 bit integer (signed))
builderReader.addItem("mivariable", "%DB20:DBD06:REAL"); //returns a
PlcFloat (32 bit IEEE 754 full precision floating point value (signed))
In the "Write value" tests, write request for all datatype seem to work
fine:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBW06:WORD", 7); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBD06:DWORD", 1); //write
response code "OK"
Except for the 'INT' and 'DINT' datatypes, which return an INTERNAL_ERROR
response code
builderWriter.addItem("mivariable", "%DB20:DBW06:INT", 1); //write
response code "INTERNAL_ERROR"
builderWriter.addItem("mivariable", "%DB20:DBD06:DINT", 1); //write
response code "INTERNAL_ERROR"
Is the INTERNAL_ERROR code a hardware issue? (Maybe a device configuration
problem?)
---
Also, the other thing I found in the test:
When I write a value different than BOOL, and then read the same memory
address, I dont get the actual value but a 'false' filled array. TO give some
examples,
with BOOL values:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true);
builderReader.addItem("mivariable", "%DB20:DBX6.1:BOOL"); //return true
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", false);
builderReader.addItem("mivariable", "%DB20:DBX6.1:BOOL"); //return false
The written value is "correctly updated" and read fine.
with other datatypes:
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 1);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, false, false]
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, false, false]
I have tried to combine write single bits and read other datatypes, which
seem to work fine:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, true, false]
builderReader.addItem("mivariable", "%DB20:DBW06:INT"); //return 512
And the other way around, write a byte and read single bits
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127);
builderReader.addItem("mivariable-0", "%DB20:DBX6.0:BOOL"); //returns
false
builderReader.addItem("mivariable-1", "%DB20:DBX6.1:BOOL"); //returns
false
builderReader.addItem("mivariable-2", "%DB20:DBX6.2:BOOL"); //returns
false
builderReader.addItem("mivariable-3", "%DB20:DBX6.3:BOOL"); //returns
false
builderReader.addItem("mivariable-4", "%DB20:DBX6.4:BOOL"); //returns
false
builderReader.addItem("mivariable-5", "%DB20:DBX6.5:BOOL"); //returns
false
builderReader.addItem("mivariable-6", "%DB20:DBX6.6:BOOL"); //returns
false
builderReader.addItem("mivariable-7", "%DB20:DBX6.7:BOOL"); //returns
false
Which
Re: S7 write test doubt
Hi,
I have been doing further tests with the S7 driver. I would like to ask you
some doubts, which i am not sure if relate to the PLC4X driver or the actual
hardware (Siemens S7-300) i am using (pretty novice in PLC data access im
afraid...)
The "Read value" tests I have done work correctly for different datatypes, for
example:
builderReader.addItem("mivariable", "%DB20:DBX5.0:BOOL"); //Single
boolean value
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns a
PlcList (Array of 8 boolean values)
builderReader.addItem("mivariable", "%DB20:DBW06:WORD"); //returns a
PlcList (Array of 16 boolean values)
builderReader.addItem("mivariable", "%DB20:DBD06:DWORD"); //returns a
PlcList (Array of 32 boolean values)
builderReader.addItem("mivariable", "%DB20:DBW06:INT"); //returns a
PlcInteger (16 bit integer (signed))
builderReader.addItem("mivariable", "%DB20:DBD06:DINT"); //returns a
PlcInteger (32 bit integer (signed))
builderReader.addItem("mivariable", "%DB20:DBD06:REAL"); //returns a
PlcFloat (32 bit IEEE 754 full precision floating point value (signed))
In the "Write value" tests, write request for all datatype seem to work fine:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBW06:WORD", 7); //write
response code "OK"
builderWriter.addItem("mivariable", "%DB20:DBD06:DWORD", 1); //write
response code "OK"
Except for the 'INT' and 'DINT' datatypes, which return an INTERNAL_ERROR
response code
builderWriter.addItem("mivariable", "%DB20:DBW06:INT", 1); //write
response code "INTERNAL_ERROR"
builderWriter.addItem("mivariable", "%DB20:DBD06:DINT", 1); //write
response code "INTERNAL_ERROR"
Is the INTERNAL_ERROR code a hardware issue? (Maybe a device configuration
problem?)
---
Also, the other thing I found in the test:
When I write a value different than BOOL, and then read the same memory
address, I dont get the actual value but a 'false' filled array. TO give some
examples,
with BOOL values:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true);
builderReader.addItem("mivariable", "%DB20:DBX6.1:BOOL"); //return true
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", false);
builderReader.addItem("mivariable", "%DB20:DBX6.1:BOOL"); //return false
The written value is "correctly updated" and read fine.
with other datatypes:
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 1);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, false, false]
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, false, false]
I have tried to combine write single bits and read other datatypes, which seem
to work fine:
builderWriter.addItem("mivariable", "%DB20:DBX6.1:BOOL", true);
builderReader.addItem("mivariable", "%DB20:DBB06:BYTE"); //returns
[false, false, false, false, false, false, true, false]
builderReader.addItem("mivariable", "%DB20:DBW06:INT"); //return 512
And the other way around, write a byte and read single bits
builderWriter.addItem("mivariable", "%DB20:DBB06:BYTE", 127);
builderReader.addItem("mivariable-0", "%DB20:DBX6.0:BOOL"); //returns
false
builderReader.addItem("mivariable-1", "%DB20:DBX6.1:BOOL"); //returns
false
builderReader.addItem("mivariable-2", "%DB20:DBX6.2:BOOL"); //returns
false
builderReader.addItem("mivariable-3", "%DB20:DBX6.3:BOOL"); //returns
false
builderReader.addItem("mivariable-4", "%DB20:DBX6.4:BOOL"); //returns
false
builderReader.addItem("mivariable-5", "%DB20:DBX6.5:BOOL"); //returns
false
builderReader.addItem("mivariable-6", "%DB20:DBX6.6:BOOL"); //returns
false
builderReader.addItem("mivariable-7", "%DB20:DBX6.7:BOOL"); //returns
false
Which leads me to think that could be a write issue, right?
Again I understand that these issues could be an actual hardware configuration
problem.. but any help or advice would be much appreciated
Thank you in advance!
iñigo
P.S. I attached the test classes if anyone wants to take a look.
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Iñigo Angulo Otegui"
Para: "dev"
Enviados: Jueves, 2 de Julio 2020 12:45:49
Asunto: Re: S7 write test doubt
Hi Julian,
Yes, we saw the adopters page and were
Courses / Trainings for Open Source Projects
Hi folks, following up on Chris post here you know that we are starting something together (and also with other Partners from the community!). Our next idea was to provide trainings and courses for the open source projects we list on the site (or even more) but we are not yet clear about the interest and demand. And, as we are community driven this explicity INCLUDES free content and NOT only paid services. Thus I think ist reasonable to share the little survey we prepared on this list also. The survey should help us to see if there is a demand or what exactly the community / communities may need and expect. So we would be happy if you take the time to fill it out : ) Link to the survey: https://www.surveymonkey.de/r/CKZMTDL Thanks already! Julian
Re: S7 write test doubt
Hi Julian, Yes, we saw the adopters page and were thinking to contribute there. We will prepare a short text describing the work we are doing with the project and send it to you soon. Thanks iñigo - Iñigo Angulo ZYLK.net :: consultoría.openSource Ribera de Axpe, 11 Edificio A, modulo 201-203 48950 Erandio (Bizkaia) +34 944272119 - - Mensaje original - De: "Julian Feinauer" Para: "dev" Enviados: Jueves, 2 de Julio 2020 12:00:53 Asunto: Re: S7 write test doubt And, as i shortly checked your company profile which looks pretty cool... if you like it, or use it, dont forget to enter your company on the adopters page : ) https://plc4x.apache.org/users/adopters.html Julian Am 02.07.20, 10:31 schrieb "Iñigo Angulo" : Hi Chris, Yes, using the 0.8.0-SNAPSHOT with the update you did the problem is solved now. Thank you for the help and the fast solution! Iñigo - Iñigo Angulo ZYLK.net :: consultoría.openSource Ribera de Axpe, 11 Edificio A, modulo 201-203 48950 Erandio (Bizkaia) +34 944272119 - - Mensaje original - De: "Christofer Dutz" Para: "dev" Enviados: Miércoles, 1 de Julio 2020 13:18:34 Asunto: Re: S7 write test doubt Hi all, build passed locall, pushed the changes, build on ci passed so you should be ready to give things a new try. However keep in mind, if you built with 0.8.0-SNAPSHOT once today, please be sure to do a "mvn -U install" build or you won't get the update today. Would be cool if you could reply if this helped. Chris Am 01.07.20, 12:30 schrieb "Julian Feinauer" : Thanks both of you! As I just wrote in Slack we can only grow and improve if we get feedback, Bug reports and usage scenarios. And of course thanks Chris for that fast reply and fix <3 Julian Am 01.07.20, 12:24 schrieb "Iñigo Angulo" : Hi Chris, No problem. I will keep track of the issue in Jira, and use the 0.8.0-SNAPSHOT version. Thank you for your help iñigo - Iñigo Angulo ZYLK.net :: consultoría.openSource Ribera de Axpe, 11 Edificio A, modulo 201-203 48950 Erandio (Bizkaia) +34 944272119 - - Mensaje original - De: "Christofer Dutz" Para: "dev" Enviados: Miércoles, 1 de Julio 2020 12:06:28 Asunto: Re: S7 write test doubt Hi Iñigo, I will have to ask you to wait for a little while as you stumbled over a problem which goes a little deeper and is related to a major refactoring we did just before Christmas. I am pretty puzzled that no one ever noticed this, but I'll immediately start working on fixing this. I'm tracking progress here: https://issues.apache.org/jira/browse/PLC4X-206 If that's done I would like to ask you to use the 0.8.0-SNAPSHOT till we've released the next version of PLC4X. Chris Am 01.07.20, 12:00 schrieb "Iñigo Angulo" : Hi Chris, Thanks for the fast answer! I will keep your advice about not adding the cast to the values, and letting the driver do its work. If you want me to try to reproduce any other test just let me know. Iñigo - Iñigo Angulo ZYLK.net :: consultoría.openSource Ribera de Axpe, 11 Edificio A, modulo 201-203 48950 Erandio (Bizkaia) +34 944272119 - - Mensaje original - De: "Christofer Dutz" Para: "dev" Enviados: Miércoles, 1 de Julio 2020 11:48:48 Asunto: Re: S7 write test doubt And let me give you a little more context ... with the INT type in S7 you happen to know that there an INT is a 16 Bit signed integer. We wanted to abstract from that. Cause another PLC could define INT as 32 bit integer ... So you can generally just work with any numeric type and pass that in. The driver will inspect the value ranges for that particular protocol and give some sensible error messages (At least it should ;-) ). But ... I just noticed that indeed I am seeing the same problems you are seeing and that my suggestion just causes a different error ... I'll get working on fixing this right away.
Re: S7 write test doubt
And, as i shortly checked your company profile which looks pretty cool... if
you like it, or use it, dont forget to enter your company on the adopters page
: )
https://plc4x.apache.org/users/adopters.html
Julian
Am 02.07.20, 10:31 schrieb "Iñigo Angulo" :
Hi Chris,
Yes, using the 0.8.0-SNAPSHOT with the update you did the problem is solved
now.
Thank you for the help and the fast solution!
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 13:18:34
Asunto: Re: S7 write test doubt
Hi all,
build passed locall, pushed the changes, build on ci passed so you
should be ready to give things a new try.
However keep in mind, if you built with 0.8.0-SNAPSHOT once today, please
be sure to do a "mvn -U install" build or you won't get the update today.
Would be cool if you could reply if this helped.
Chris
Am 01.07.20, 12:30 schrieb "Julian Feinauer" :
Thanks both of you!
As I just wrote in Slack we can only grow and improve if we get
feedback, Bug reports and usage scenarios.
And of course thanks Chris for that fast reply and fix <3
Julian
Am 01.07.20, 12:24 schrieb "Iñigo Angulo" :
Hi Chris,
No problem. I will keep track of the issue in Jira, and use the
0.8.0-SNAPSHOT version.
Thank you for your help
iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 12:06:28
Asunto: Re: S7 write test doubt
Hi Iñigo,
I will have to ask you to wait for a little while as you stumbled
over a problem which goes a little deeper and is related to a major refactoring
we did just before Christmas. I am pretty puzzled that no one ever noticed
this, but I'll immediately start working on fixing this.
I'm tracking progress here:
https://issues.apache.org/jira/browse/PLC4X-206
If that's done I would like to ask you to use the 0.8.0-SNAPSHOT
till we've released the next version of PLC4X.
Chris
Am 01.07.20, 12:00 schrieb "Iñigo Angulo" :
Hi Chris,
Thanks for the fast answer!
I will keep your advice about not adding the cast to the
values, and letting the driver do its work.
If you want me to try to reproduce any other test just let me
know.
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 11:48:48
Asunto: Re: S7 write test doubt
And let me give you a little more context ... with the INT type
in S7 you happen to know that there an INT is a 16 Bit signed integer.
We wanted to abstract from that. Cause another PLC could define
INT as 32 bit integer ... So you can generally just work with any numeric type
and pass that in. The driver will inspect the value ranges for that particular
protocol and give some sensible error messages (At least it should ;-) ).
But ... I just noticed that indeed I am seeing the same
problems you are seeing and that my suggestion just causes a different error
... I'll get working on fixing this right away.
I'm really a bit confused about this ... but it does prove that
most people just care about reading ;-)
Will keep you and the others posted on any progress.
Chris
Am 01.07.20, 11:33 schrieb "Christofer Dutz"
:
Hi Iñigo,
welcome to the party ... I really hope we'll be able to get
you started asap ...
I just had a look at the code and PlcInteger does have the
constructor ...
public PlcInteger(Short value) {
Re: S7 write test doubt
Thanks for reporting.
As Julian mentioned, this is highly valuable input for us :-)
Glad we could help.
Chris
Am 02.07.20, 10:31 schrieb "Iñigo Angulo" :
Hi Chris,
Yes, using the 0.8.0-SNAPSHOT with the update you did the problem is solved
now.
Thank you for the help and the fast solution!
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 13:18:34
Asunto: Re: S7 write test doubt
Hi all,
build passed locall, pushed the changes, build on ci passed so you
should be ready to give things a new try.
However keep in mind, if you built with 0.8.0-SNAPSHOT once today, please
be sure to do a "mvn -U install" build or you won't get the update today.
Would be cool if you could reply if this helped.
Chris
Am 01.07.20, 12:30 schrieb "Julian Feinauer" :
Thanks both of you!
As I just wrote in Slack we can only grow and improve if we get
feedback, Bug reports and usage scenarios.
And of course thanks Chris for that fast reply and fix <3
Julian
Am 01.07.20, 12:24 schrieb "Iñigo Angulo" :
Hi Chris,
No problem. I will keep track of the issue in Jira, and use the
0.8.0-SNAPSHOT version.
Thank you for your help
iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 12:06:28
Asunto: Re: S7 write test doubt
Hi Iñigo,
I will have to ask you to wait for a little while as you stumbled
over a problem which goes a little deeper and is related to a major refactoring
we did just before Christmas. I am pretty puzzled that no one ever noticed
this, but I'll immediately start working on fixing this.
I'm tracking progress here:
https://issues.apache.org/jira/browse/PLC4X-206
If that's done I would like to ask you to use the 0.8.0-SNAPSHOT
till we've released the next version of PLC4X.
Chris
Am 01.07.20, 12:00 schrieb "Iñigo Angulo" :
Hi Chris,
Thanks for the fast answer!
I will keep your advice about not adding the cast to the
values, and letting the driver do its work.
If you want me to try to reproduce any other test just let me
know.
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 11:48:48
Asunto: Re: S7 write test doubt
And let me give you a little more context ... with the INT type
in S7 you happen to know that there an INT is a 16 Bit signed integer.
We wanted to abstract from that. Cause another PLC could define
INT as 32 bit integer ... So you can generally just work with any numeric type
and pass that in. The driver will inspect the value ranges for that particular
protocol and give some sensible error messages (At least it should ;-) ).
But ... I just noticed that indeed I am seeing the same
problems you are seeing and that my suggestion just causes a different error
... I'll get working on fixing this right away.
I'm really a bit confused about this ... but it does prove that
most people just care about reading ;-)
Will keep you and the others posted on any progress.
Chris
Am 01.07.20, 11:33 schrieb "Christofer Dutz"
:
Hi Iñigo,
welcome to the party ... I really hope we'll be able to get
you started asap ...
I just had a look at the code and PlcInteger does have the
constructor ...
public PlcInteger(Short value) {
super(value.intValue(), true);
}
So I'll try
Re: S7 write test doubt
Hi Chris,
Yes, using the 0.8.0-SNAPSHOT with the update you did the problem is solved
now.
Thank you for the help and the fast solution!
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 13:18:34
Asunto: Re: S7 write test doubt
Hi all,
build passed locall, pushed the changes, build on ci passed so you should
be ready to give things a new try.
However keep in mind, if you built with 0.8.0-SNAPSHOT once today, please be
sure to do a "mvn -U install" build or you won't get the update today.
Would be cool if you could reply if this helped.
Chris
Am 01.07.20, 12:30 schrieb "Julian Feinauer" :
Thanks both of you!
As I just wrote in Slack we can only grow and improve if we get feedback,
Bug reports and usage scenarios.
And of course thanks Chris for that fast reply and fix <3
Julian
Am 01.07.20, 12:24 schrieb "Iñigo Angulo" :
Hi Chris,
No problem. I will keep track of the issue in Jira, and use the
0.8.0-SNAPSHOT version.
Thank you for your help
iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 12:06:28
Asunto: Re: S7 write test doubt
Hi Iñigo,
I will have to ask you to wait for a little while as you stumbled over
a problem which goes a little deeper and is related to a major refactoring we
did just before Christmas. I am pretty puzzled that no one ever noticed this,
but I'll immediately start working on fixing this.
I'm tracking progress here:
https://issues.apache.org/jira/browse/PLC4X-206
If that's done I would like to ask you to use the 0.8.0-SNAPSHOT till
we've released the next version of PLC4X.
Chris
Am 01.07.20, 12:00 schrieb "Iñigo Angulo" :
Hi Chris,
Thanks for the fast answer!
I will keep your advice about not adding the cast to the values,
and letting the driver do its work.
If you want me to try to reproduce any other test just let me know.
Iñigo
-
Iñigo Angulo
ZYLK.net :: consultoría.openSource
Ribera de Axpe, 11
Edificio A, modulo 201-203
48950 Erandio (Bizkaia)
+34 944272119
-
- Mensaje original -
De: "Christofer Dutz"
Para: "dev"
Enviados: Miércoles, 1 de Julio 2020 11:48:48
Asunto: Re: S7 write test doubt
And let me give you a little more context ... with the INT type in
S7 you happen to know that there an INT is a 16 Bit signed integer.
We wanted to abstract from that. Cause another PLC could define INT
as 32 bit integer ... So you can generally just work with any numeric type and
pass that in. The driver will inspect the value ranges for that particular
protocol and give some sensible error messages (At least it should ;-) ).
But ... I just noticed that indeed I am seeing the same problems
you are seeing and that my suggestion just causes a different error ... I'll
get working on fixing this right away.
I'm really a bit confused about this ... but it does prove that
most people just care about reading ;-)
Will keep you and the others posted on any progress.
Chris
Am 01.07.20, 11:33 schrieb "Christofer Dutz"
:
Hi Iñigo,
welcome to the party ... I really hope we'll be able to get you
started asap ...
I just had a look at the code and PlcInteger does have the
constructor ...
public PlcInteger(Short value) {
super(value.intValue(), true);
}
So I'll try to reproduce the problem ... but for now ... could
you just remove the cast from your items?
builderWriter.addItem("mivariable-1", "%DB20:DBX6.7:BOOL",
true);
builderWriter.addItem("mivariable-4", "%DB20:DBW06.0:INT",
2);
builderWriter.addItem("mivariable-2", "%DB20:DBB06:BYTE",
0);
Cause PLC4X internally already ensures everything fits into the
bounds and internally PLC4X handles the "(short) 2" as an "(int)
Re: [ApacheCon] Anyone planning on submitting something?
Wanted to say: till next week ;-) Am 02.07.20, 10:29 schrieb "Christofer Dutz" : Hi all, Well If I don't hear anyone raising an arm for a core-plc4x talk, I'll submit one. Chris Am 02.07.20, 08:51 schrieb "Julian Feinauer" : Hi, finally have to jump in (too much Beer Content in the morning). We already had the Idea of doing "Beer Punkt Null" with a local brewery here (its a play of words as the 4.0 in german speaks pretty similar, 4 = vier which is roughly pronounced like "fear"). Do you know the https://web.craftbeerpi.com/? Julian Am 01.07.20, 19:59 schrieb "Cesar Garcia" : Someday Chris, why not I remember training in Mannheim where I had the opportunity to taste very good German beers (Many beers!) ... In the important thing. Why not have a solution for small breweries based on open technologies, aka, Karaf + PLC4X + Graphana + CSS. And so on ... Best regards, https://assets.new.siemens.com/siemens/assets/api/uuid:1d50c8bc9667e38e180a0ba36a3efa54f80e6d39/version:1529694435/us-cg-fb-tallgrass-brewery-and-custom-metalcraft-case-study.pdf El mié., 1 jul. 2020 a las 12:57, Christofer Dutz (< christofer.d...@c-ware.de>) escribió: > Oh yeah ... > > But better not talk about it, better get together and drink it ;) > > Chris > > > Am 01.07.20, 18:30 schrieb "Cesar Garcia" : > > Hi, > > It would be interesting to talk about automation of "CraftBeer". > > We are working in that direction, > > Best regards, > > El mié., 1 jul. 2020 a las 11:47, Christofer Dutz (< > christofer.d...@c-ware.de>) escribió: > > > So would anyone here be interested in doing a pure PLC4X talk? > > > > I have been doing that for the past 3-4 years and would be happy to > give > > someone else the chance to do that. > > > > Of course, if no one wants to I could probably do it. > > > > Chris > > > > > > Am 01.07.20, 16:06 schrieb "Christofer Dutz" < > christofer.d...@c-ware.de>: > > > > Hi all, > > > > as you might have gotten 1 or 2 … or 20 emails from Rich > yesterday > > regarding the virtual ApacheCon this year. > > > > We have 2 weeks to submit talks for the IoT tracks. > > > > Perhaps we should coordinate on what we want to submit? > > > > > > * I know the StreamPipes folks already submitted something > which > > involves PLC4X which I would be helping out with. > > * I was planning on something down the line of > Home-Automation > > built with Apache software … using PLC4X, IoTDB and perhaps Royale > to build > > some sort of POC > > > > Any other ideas? > > > > Chris > > > > > > > > > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > *Ing. César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: support.aan.automat...@siemens.com > * > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com *
Re: [ApacheCon] Anyone planning on submitting something?
Hi all, Well If I don't hear anyone raising an arm for a core-plc4x talk, I'll submit one. Chris Am 02.07.20, 08:51 schrieb "Julian Feinauer" : Hi, finally have to jump in (too much Beer Content in the morning). We already had the Idea of doing "Beer Punkt Null" with a local brewery here (its a play of words as the 4.0 in german speaks pretty similar, 4 = vier which is roughly pronounced like "fear"). Do you know the https://web.craftbeerpi.com/? Julian Am 01.07.20, 19:59 schrieb "Cesar Garcia" : Someday Chris, why not I remember training in Mannheim where I had the opportunity to taste very good German beers (Many beers!) ... In the important thing. Why not have a solution for small breweries based on open technologies, aka, Karaf + PLC4X + Graphana + CSS. And so on ... Best regards, https://assets.new.siemens.com/siemens/assets/api/uuid:1d50c8bc9667e38e180a0ba36a3efa54f80e6d39/version:1529694435/us-cg-fb-tallgrass-brewery-and-custom-metalcraft-case-study.pdf El mié., 1 jul. 2020 a las 12:57, Christofer Dutz (< christofer.d...@c-ware.de>) escribió: > Oh yeah ... > > But better not talk about it, better get together and drink it ;) > > Chris > > > Am 01.07.20, 18:30 schrieb "Cesar Garcia" : > > Hi, > > It would be interesting to talk about automation of "CraftBeer". > > We are working in that direction, > > Best regards, > > El mié., 1 jul. 2020 a las 11:47, Christofer Dutz (< > christofer.d...@c-ware.de>) escribió: > > > So would anyone here be interested in doing a pure PLC4X talk? > > > > I have been doing that for the past 3-4 years and would be happy to > give > > someone else the chance to do that. > > > > Of course, if no one wants to I could probably do it. > > > > Chris > > > > > > Am 01.07.20, 16:06 schrieb "Christofer Dutz" < > christofer.d...@c-ware.de>: > > > > Hi all, > > > > as you might have gotten 1 or 2 … or 20 emails from Rich > yesterday > > regarding the virtual ApacheCon this year. > > > > We have 2 weeks to submit talks for the IoT tracks. > > > > Perhaps we should coordinate on what we want to submit? > > > > > > * I know the StreamPipes folks already submitted something > which > > involves PLC4X which I would be helping out with. > > * I was planning on something down the line of > Home-Automation > > built with Apache software … using PLC4X, IoTDB and perhaps Royale > to build > > some sort of POC > > > > Any other ideas? > > > > Chris > > > > > > > > > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > *Ing. César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: support.aan.automat...@siemens.com > * > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com *
[GitHub] [plc4x] JulianFeinauer opened a new pull request #169: Subscription Support for S7 Driver in 0.6.1
JulianFeinauer opened a new pull request #169: URL: https://github.com/apache/plc4x/pull/169 @glcj: I Started a PR for it, to have a place to discuss and Test stuff. I hope that is okay for you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [ApacheCon] Anyone planning on submitting something?
Hi, finally have to jump in (too much Beer Content in the morning). We already had the Idea of doing "Beer Punkt Null" with a local brewery here (its a play of words as the 4.0 in german speaks pretty similar, 4 = vier which is roughly pronounced like "fear"). Do you know the https://web.craftbeerpi.com/? Julian Am 01.07.20, 19:59 schrieb "Cesar Garcia" : Someday Chris, why not I remember training in Mannheim where I had the opportunity to taste very good German beers (Many beers!) ... In the important thing. Why not have a solution for small breweries based on open technologies, aka, Karaf + PLC4X + Graphana + CSS. And so on ... Best regards, https://assets.new.siemens.com/siemens/assets/api/uuid:1d50c8bc9667e38e180a0ba36a3efa54f80e6d39/version:1529694435/us-cg-fb-tallgrass-brewery-and-custom-metalcraft-case-study.pdf El mié., 1 jul. 2020 a las 12:57, Christofer Dutz (< christofer.d...@c-ware.de>) escribió: > Oh yeah ... > > But better not talk about it, better get together and drink it ;) > > Chris > > > Am 01.07.20, 18:30 schrieb "Cesar Garcia" : > > Hi, > > It would be interesting to talk about automation of "CraftBeer". > > We are working in that direction, > > Best regards, > > El mié., 1 jul. 2020 a las 11:47, Christofer Dutz (< > christofer.d...@c-ware.de>) escribió: > > > So would anyone here be interested in doing a pure PLC4X talk? > > > > I have been doing that for the past 3-4 years and would be happy to > give > > someone else the chance to do that. > > > > Of course, if no one wants to I could probably do it. > > > > Chris > > > > > > Am 01.07.20, 16:06 schrieb "Christofer Dutz" < > christofer.d...@c-ware.de>: > > > > Hi all, > > > > as you might have gotten 1 or 2 … or 20 emails from Rich > yesterday > > regarding the virtual ApacheCon this year. > > > > We have 2 weeks to submit talks for the IoT tracks. > > > > Perhaps we should coordinate on what we want to submit? > > > > > > * I know the StreamPipes folks already submitted something > which > > involves PLC4X which I would be helping out with. > > * I was planning on something down the line of > Home-Automation > > built with Apache software … using PLC4X, IoTDB and perhaps Royale > to build > > some sort of POC > > > > Any other ideas? > > > > Chris > > > > > > > > > > -- > *CEOS Automatización, C.A.* > *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* > *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* > > *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* > *Ing. César García* > > *Cel: +58 414-760.98.95* > > *Hotline Técnica SIEMENS: 0800 1005080* > > *Email: support.aan.automat...@siemens.com > * > > -- *CEOS Automatización, C.A.* *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,* *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,* *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI* *Ing. César García* *Cel: +58 414-760.98.95* *Hotline Técnica SIEMENS: 0800 1005080* *Email: support.aan.automat...@siemens.com *
