[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #62: chore(deps): bump maven-plugin-plugin from 3.7.1 to 3.8.1
dependabot[bot] opened a new pull request, #62: URL: https://github.com/apache/plc4x-build-tools/pull/62 Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.7.1 to 3.8.1. Commits https://github.com/apache/maven-plugin-tools/commit/b242658bf0b3abbc9758cfe61e669d0e77037946;>b242658 [maven-release-plugin] prepare release maven-plugin-tools-3.8.1 https://github.com/apache/maven-plugin-tools/commit/2721944828592167a714bec304e8f368f6c87daf;>2721944 Revert Bump plexus-velocity from 1.2 to 2.0 and velocity from 1.7 to 2.3 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/1;>#1... https://github.com/apache/maven-plugin-tools/commit/d99a455f772c1728efb732795fe06e5d2d34ecc1;>d99a455 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-plugin-tools/commit/9ca8a18dbb47c9f7e7450a85353316c6c51882e4;>9ca8a18 [maven-release-plugin] prepare release maven-plugin-tools-3.8.0 https://github.com/apache/maven-plugin-tools/commit/84f9a2e7b23aae884c5214564adb8c4759b0776f;>84f9a2e [MPLUGIN-455] Bump plexus-archiver from 4.5.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/189;>#189) https://github.com/apache/maven-plugin-tools/commit/df4b8fdaf719daed8b060ee161cd60f49761783c;>df4b8fd Bump plexus-velocity from 1.2 to 2.0 and velocity from 1.7 to 2.3 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/195;>#195) https://github.com/apache/maven-plugin-tools/commit/25837eede059b63a2c249b139c6b6340a0d7ac89;>25837ee [MPLUGIN-441] Upgrade to maven alpha-4 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/191;>#191) https://github.com/apache/maven-plugin-tools/commit/4cd8c032197587292470978235df5b4c9d07602a;>4cd8c03 [MPLUGIN-454] Bump junit-bom from 5.9.1 to 5.9.2 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/193;>#193) https://github.com/apache/maven-plugin-tools/commit/52be8fafda3abee7404548f17fca6e1b7877fe41;>52be8fa [MPLUGIN-453] Fix Temporary File Information Disclosure (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/176;>#176) https://github.com/apache/maven-plugin-tools/commit/ce498163247c9059fba390397d59dda7494274da;>ce49816 [MPLUGIN-447] Ignore reformat commit rev in blame Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.7.1...maven-plugin-tools-3.8.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #61: chore(deps): bump maven-plugin-annotations from 3.7.1 to 3.8.1
dependabot[bot] opened a new pull request, #61: URL: https://github.com/apache/plc4x-build-tools/pull/61 Bumps [maven-plugin-annotations](https://github.com/apache/maven-plugin-tools) from 3.7.1 to 3.8.1. Commits https://github.com/apache/maven-plugin-tools/commit/b242658bf0b3abbc9758cfe61e669d0e77037946;>b242658 [maven-release-plugin] prepare release maven-plugin-tools-3.8.1 https://github.com/apache/maven-plugin-tools/commit/2721944828592167a714bec304e8f368f6c87daf;>2721944 Revert Bump plexus-velocity from 1.2 to 2.0 and velocity from 1.7 to 2.3 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/1;>#1... https://github.com/apache/maven-plugin-tools/commit/d99a455f772c1728efb732795fe06e5d2d34ecc1;>d99a455 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-plugin-tools/commit/9ca8a18dbb47c9f7e7450a85353316c6c51882e4;>9ca8a18 [maven-release-plugin] prepare release maven-plugin-tools-3.8.0 https://github.com/apache/maven-plugin-tools/commit/84f9a2e7b23aae884c5214564adb8c4759b0776f;>84f9a2e [MPLUGIN-455] Bump plexus-archiver from 4.5.0 to 4.6.1 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/189;>#189) https://github.com/apache/maven-plugin-tools/commit/df4b8fdaf719daed8b060ee161cd60f49761783c;>df4b8fd Bump plexus-velocity from 1.2 to 2.0 and velocity from 1.7 to 2.3 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/195;>#195) https://github.com/apache/maven-plugin-tools/commit/25837eede059b63a2c249b139c6b6340a0d7ac89;>25837ee [MPLUGIN-441] Upgrade to maven alpha-4 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/191;>#191) https://github.com/apache/maven-plugin-tools/commit/4cd8c032197587292470978235df5b4c9d07602a;>4cd8c03 [MPLUGIN-454] Bump junit-bom from 5.9.1 to 5.9.2 (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/193;>#193) https://github.com/apache/maven-plugin-tools/commit/52be8fafda3abee7404548f17fca6e1b7877fe41;>52be8fa [MPLUGIN-453] Fix Temporary File Information Disclosure (https://github-redirect.dependabot.com/apache/maven-plugin-tools/issues/176;>#176) https://github.com/apache/maven-plugin-tools/commit/ce498163247c9059fba390397d59dda7494274da;>ce49816 [MPLUGIN-447] Ignore reformat commit rev in blame Additional commits viewable in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.7.1...maven-plugin-tools-3.8.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] dependabot[bot] opened a new pull request, #60: chore(deps): bump maven-compiler-plugin from 3.10.1 to 3.11.0
dependabot[bot] opened a new pull request, #60: URL: https://github.com/apache/plc4x-build-tools/pull/60 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.10.1 to 3.11.0. Commits https://github.com/apache/maven-compiler-plugin/commit/eeda628b832bf3cc27571e2073f62d582a6d9527;>eeda628 [maven-release-plugin] prepare release maven-compiler-plugin-3.11.0 https://github.com/apache/maven-compiler-plugin/commit/82b799f3501d0dc3ef868859245816c563c46f04;>82b799f [MCOMPILER-527] Upgrade plexus-java to 1.1.2 (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/177;>#177) https://github.com/apache/maven-compiler-plugin/commit/f9c2350c885a96638db66fbab4d9180729a31d5a;>f9c2350 [MCOMPILER-526] Fix IT (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/178;>#178) https://github.com/apache/maven-compiler-plugin/commit/4022bd0f37626124dad394b2e4583fd6768fa74a;>4022bd0 [MCOMPILER-494] - Add a useModulePath switch to the testCompile mojo (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/119;>#119) https://github.com/apache/maven-compiler-plugin/commit/f4a8a54e116b07e888ac7b6371fa24b7a81517b3;>f4a8a54 [MCOMPILER-525] Incorrect detection of dependency change (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/172;>#172) https://github.com/apache/maven-compiler-plugin/commit/86b9f5972bcb005305f8abb8fb1f3c0d89df2726;>86b9f59 [MCOMPILER-395] Allow dependency exclusions for 'annotationProcessorPaths' (#... https://github.com/apache/maven-compiler-plugin/commit/e304ceb91cb625399638f95be41e6c23ca0970d0;>e304ceb [MCOMPILER-526] Ignore reformat commit for git blame https://github.com/apache/maven-compiler-plugin/commit/f7a4613eaa2364dcaf10f96f04a6b1afb2feb7ed;>f7a4613 [MCOMPILER-526] Reformat https://github.com/apache/maven-compiler-plugin/commit/cc78aee657a684af721b3efafd0e1525272d4201;>cc78aee [MCOMPILER-526] Upgrade to parent 39 https://github.com/apache/maven-compiler-plugin/commit/3dca82f4bf91e747c81ff3fe43e670f7cd7c08e1;>3dca82f [MCOMPILER-526] Add packages to please the formatter Additional commits viewable in https://github.com/apache/maven-compiler-plugin/compare/maven-compiler-plugin-3.10.1...maven-compiler-plugin-3.11.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [1264]'
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [1264]': Is back to normal.
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
spnettec commented on PR #822: URL: https://github.com/apache/plc4x/pull/822#issuecomment-1446566389 > Thanks for initial review, were you able to test this PR against your environment? What's you changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
spnettec commented on code in PR #822:
URL: https://github.com/apache/plc4x/pull/822#discussion_r1118926053
##
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
##
@@ -200,85 +198,60 @@ public void userEventTriggered(ChannelHandlerContext ctx,
Object evt) throws Exc
// by sending a connection request to the plc.
logger.debug("User Event triggered {}", evt);
if (evt instanceof ConnectEvent) {
-this.protocolBase.onConnect(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.onConnect(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof DisconnectEvent) {
-this.protocolBase.onDisconnect(new
DefaultConversationContext<>(ctx, authentication, passive));
+this.protocolBase.onDisconnect(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof DiscoverEvent) {
-this.protocolBase.onDiscover(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.onDiscover(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof CloseConnectionEvent) {
-this.protocolBase.close(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.close(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
Review Comment:
Fresh pipeline finnaly always invoke `PlcConnectionManager.getConnection` it
will create fesh pipeline. If you don't stop the TimeManager it will caouse
memory leak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
Hi,
This is quite an interesting problem, as they point out, the state machine
of the driver (plc4x) and the state of the Netty pipe must be handled,
For the S7 driver, I have the S7HA version (high availability) in which I
solve part of that problem and it may help you. You can see it in [1].
I hope to be able to place this version this week in the plc4x repo since
it will be the one I will use for my tests, but I see the solution that you
propose as interesting and on track.
My grain of sand,
Kind regards,
1. https://github.com/glcj/plc4x/tree/develop/plc4j/drivers/s7
El lun, 27 feb 2023 a las 11:11, splatch (via GitHub) ()
escribió:
>
> splatch commented on code in PR #822:
> URL: https://github.com/apache/plc4x/pull/822#discussion_r1118881055
>
>
> ##
> plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
> ##
> @@ -200,85 +198,60 @@ public void userEventTriggered(ChannelHandlerContext
> ctx, Object evt) throws Exc
> // by sending a connection request to the plc.
> logger.debug("User Event triggered {}", evt);
> if (evt instanceof ConnectEvent) {
> -this.protocolBase.onConnect(new
> DefaultConversationContext<>(ctx, authentication, passive));
> +this.protocolBase.onConnect(new
> DefaultConversationContext<>(this::registerHandler, ctx, authentication,
> passive));
> } else if (evt instanceof DisconnectEvent) {
> -this.protocolBase.onDisconnect(new
> DefaultConversationContext<>(ctx, authentication, passive));
> +this.protocolBase.onDisconnect(new
> DefaultConversationContext<>(this::registerHandler, ctx, authentication,
> passive));
> } else if (evt instanceof DiscoverEvent) {
> -this.protocolBase.onDiscover(new
> DefaultConversationContext<>(ctx, authentication, passive));
> +this.protocolBase.onDiscover(new
> DefaultConversationContext<>(this::registerHandler, ctx, authentication,
> passive));
> } else if (evt instanceof CloseConnectionEvent) {
> -this.protocolBase.close(new DefaultConversationContext<>(ctx,
> authentication, passive));
> +this.protocolBase.close(new
> DefaultConversationContext<>(this::registerHandler, ctx, authentication,
> passive));
>
> Review Comment:
>You're right, however I am not entirely sure of netty vs plc4x
> lifecycle. Namely can we reestablish connection once we reached that
> point? At high level plc4x drivers support `connect` call, we would need to
> assure that it always configure fresh pipeline and uses new timeout
> manager forcing netty to fire bootstrap procedure again.
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
>
> For queries about this service, please contact Infrastructure at:
> us...@infra.apache.org
>
>
--
*CEOS Automatización, C.A.*
*GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
*PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*
*FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
*Ing. César García*
*Cel: +58 414-760.98.95*
*Hotline Técnica SIEMENS: 0800 1005080*
*Email: support.aan.automat...@siemens.com
*
Re: [PR] feat(plc4j) Better handling of timeouts in plc4j (#821). (plc4x)
splatch commented on code in PR #822:
URL: https://github.com/apache/plc4x/pull/822#discussion_r1118881055
##
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
##
@@ -200,85 +198,60 @@ public void userEventTriggered(ChannelHandlerContext ctx,
Object evt) throws Exc
// by sending a connection request to the plc.
logger.debug("User Event triggered {}", evt);
if (evt instanceof ConnectEvent) {
-this.protocolBase.onConnect(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.onConnect(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof DisconnectEvent) {
-this.protocolBase.onDisconnect(new
DefaultConversationContext<>(ctx, authentication, passive));
+this.protocolBase.onDisconnect(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof DiscoverEvent) {
-this.protocolBase.onDiscover(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.onDiscover(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
} else if (evt instanceof CloseConnectionEvent) {
-this.protocolBase.close(new DefaultConversationContext<>(ctx,
authentication, passive));
+this.protocolBase.close(new
DefaultConversationContext<>(this::registerHandler, ctx, authentication,
passive));
Review Comment:
You're right, however I am not entirely sure of netty vs plc4x lifecycle.
Namely can we reestablish connection once we reached that point? At high level
plc4x drivers support `connect` call, we would need to assure that it always
configure fresh pipeline and uses new timeout manager forcing netty to fire
bootstrap procedure again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [plc4x-build-tools] sruehl merged pull request #58: chore(deps): bump maven-assembly-plugin from 3.4.2 to 3.5.0
sruehl merged PR #58: URL: https://github.com/apache/plc4x-build-tools/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [plc4x-build-tools] sruehl merged pull request #59: chore(deps): bump maven-clean-plugin from 3.1.0 to 3.2.0
sruehl merged PR #59: URL: https://github.com/apache/plc4x-build-tools/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /plc4go (plc4x)
sruehl merged PR #825: URL: https://github.com/apache/plc4x/pull/825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] build(deps): bump google-java-format from 1.15.0 to 1.16.0 (plc4x)
sruehl merged PR #824: URL: https://github.com/apache/plc4x/pull/824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
