Re: [I] [Bug]: plc4j-driver-opcua - Dead connection objects after session timeout

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1100:
URL: https://github.com/apache/plc4x/issues/1100#issuecomment-1741519313

   Would a periodic keep-allive request help in this case? I know some projects 
usually do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1680]'

2023-09-29 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1680]':

Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1680/;>PLC4X/PLC4X/develop
 [develop] [1680]"

Re: [PR] Nifi integration revision

2023-09-29 Thread via GitHub


QuanticPony commented on PR #1122:
URL: https://github.com/apache/plc4x/pull/1122#issuecomment-1741381407

   I'm done. Tell me if anything else is needed. Will have a look at it over 
the weekend


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Nifi integration revision

2023-09-29 Thread via GitHub


QuanticPony commented on PR #1122:
URL: https://github.com/apache/plc4x/pull/1122#issuecomment-1741354119

   Sorry for the long PR. I would normally split it, but though posting as 
early as possible would be best in this case.
   Duplicated code removed. Unit tests added.
   i added the read tags from a file as I have seen it in some production 
environments with other OPCUA processors. I think it could be easier to migrate 
to PLC4X if we have them. If you don't see it clear i can remove it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1679]'

2023-09-29 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1679]':

Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1679/;>PLC4X/PLC4X/develop
 [develop] [1679]"

Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741242982

   Please give the current 0.11.0-SNAPSHOT version a try and check if the 
problem is gone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741241339

   
![image](https://github.com/apache/plc4x/assets/651105/97ce78d9-a4d1-4574-8d6d-2e5fe0c88d67)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741240593

   YAY ... I found it :-)
   It wasn#t the event loops .. they are correctly closed.
   It was the NettyHashTimerTimeoutManager that we start for every connection 
but never explicitly close it ... by overriding the close() method of 
ChannelDuplexHandler in Plc4xNettyWrapper and explicitly closing it, the leak 
of open threads is gone ... you can see a commons-pool growing at the start, 
but as soon as it's reached it's 11 threads the thread-count stays constant :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1678]'

2023-09-29 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1678]':

Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1678/;>PLC4X/PLC4X/develop
 [develop] [1678]"

Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741191662

   
![image](https://github.com/apache/plc4x/assets/651105/204723f9-8db2-4c74-8fa1-1f6668c4cec5)
Should have been this image


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741190498

   And they all seem to be related to the nio event group: 
   
   
![image](https://github.com/apache/plc4x/assets/651105/afe9f0a5-6dba-4e2a-97f6-79715f6c6400)
   
   Hmpf ... I thought we had addressed that issue and I guess it probably also 
has an effect on all other drivers too ... Usually opening and closing 
connections shouldn't be the default case, as the connection-cache should be 
used, but I think having somethign stuck will also be the reason why some 
applications simply don't stop gracefully.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741187655

   Ok ... just noticed I was running it in the IntelliJ profiler, not JProfiler 
... I split up the application into a server (that just starts milo) and a 
client (with your code) ... when profilling only the client I can see a 
constant increase in sleeping threads ... I should probably figgure out why 
this is happening and fix it before the 0.11.0 release ...
   
![image](https://github.com/apache/plc4x/assets/651105/a90f860e-6bf3-43b3-8172-5e85992fa436)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



AW: Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Christofer Dutz
If you merge it … please update the RELEASE_NOTES file accordingly ;-)

Chris


Von: Cesar Garcia 
Datum: Freitag, 29. September 2023 um 18:25
An: dev@plc4x.apache.org 
Betreff: Re: Last call ... get your changes in ... 0.10.0 is coming ...
Thank you Chris,

Yes, I think it is an interesting contribution for us and the community in
general.

I keep you informed,

Kind regards,

El vie, 29 sept 2023 a las 12:19, Christofer Dutz (<
christofer.d...@c-ware.de>) escribió:

> Hi Cesar,
>
> I guess that’s something you have to decide ;-)
> If you think it’s usable (doesn’t have to be perfect)
> Usually I’d say: “if it’s better than in the 0.10.0 … go for it”.
> As it’s completely new … it’s just “go for it” ;-)
>
> Chris
>
>
> Von: Cesar Garcia 
> Datum: Freitag, 29. September 2023 um 18:14
> An: dev@plc4x.apache.org 
> Betreff: Re: Last call ... get your changes in ... 0.10.0 is coming ...
> Hello Chrish,
>
> Is it possible that the Hop integration is part of this release?
>
> I only need the documentation which I could work on this weekend.
>
> Kind regards,
>
> El vie, 29 sept 2023 a las 11:12, Christofer Dutz (<
> christofer.d...@c-ware.de>) escribió:
>
> > Scrap that … 0.11.0 is coming ;-)
> >
> > And I really could use some help by the community to help get the
> > Release-Notes in shape … I’m starting to compile a list, but it will not
> be
> > complete.
> >
> > Chris
> >
> >
> >
> > Von: Christofer Dutz 
> > Datum: Freitag, 29. September 2023 um 17:09
> > An: dev@plc4x.apache.org 
> > Betreff: Last call ... get your changes in ... 0.10.0 is coming ...
> > Hi all,
> >
> > so for the last few days I have been testing a lot and fixing a number of
> > issues that were reported.
> > This was all in preparation for the next release.
> >
> > In order to have a new release out before CommunityOverCode, I am
> planning
> > on preparing the RC for 0.10.0 on Monday (2nd of October).
> >
> > So if you want to get some stuff in the next release … hurry up, you’ve
> > got this weekend to make it happen.
> >
> > Chris
> >
>
>
> --
> *CEOS Automatización, C.A.*
> *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
> *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*
>
> *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
> *Ing. César García*
>
> *Cel: +58 414-760.98.95*
>
> *Hotline Técnica SIEMENS: 0800 1005080*
>
> *Email: support.aan.automat...@siemens.com
> *
>


--
*CEOS Automatización, C.A.*
*GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
*PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*

*FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
*Ing. César García*

*Cel: +58 414-760.98.95*

*Hotline Técnica SIEMENS: 0800 1005080*

*Email: support.aan.automat...@siemens.com
*


Re: Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Cesar Garcia
Thank you Chris,

Yes, I think it is an interesting contribution for us and the community in
general.

I keep you informed,

Kind regards,

El vie, 29 sept 2023 a las 12:19, Christofer Dutz (<
christofer.d...@c-ware.de>) escribió:

> Hi Cesar,
>
> I guess that’s something you have to decide ;-)
> If you think it’s usable (doesn’t have to be perfect)
> Usually I’d say: “if it’s better than in the 0.10.0 … go for it”.
> As it’s completely new … it’s just “go for it” ;-)
>
> Chris
>
>
> Von: Cesar Garcia 
> Datum: Freitag, 29. September 2023 um 18:14
> An: dev@plc4x.apache.org 
> Betreff: Re: Last call ... get your changes in ... 0.10.0 is coming ...
> Hello Chrish,
>
> Is it possible that the Hop integration is part of this release?
>
> I only need the documentation which I could work on this weekend.
>
> Kind regards,
>
> El vie, 29 sept 2023 a las 11:12, Christofer Dutz (<
> christofer.d...@c-ware.de>) escribió:
>
> > Scrap that … 0.11.0 is coming ;-)
> >
> > And I really could use some help by the community to help get the
> > Release-Notes in shape … I’m starting to compile a list, but it will not
> be
> > complete.
> >
> > Chris
> >
> >
> >
> > Von: Christofer Dutz 
> > Datum: Freitag, 29. September 2023 um 17:09
> > An: dev@plc4x.apache.org 
> > Betreff: Last call ... get your changes in ... 0.10.0 is coming ...
> > Hi all,
> >
> > so for the last few days I have been testing a lot and fixing a number of
> > issues that were reported.
> > This was all in preparation for the next release.
> >
> > In order to have a new release out before CommunityOverCode, I am
> planning
> > on preparing the RC for 0.10.0 on Monday (2nd of October).
> >
> > So if you want to get some stuff in the next release … hurry up, you’ve
> > got this weekend to make it happen.
> >
> > Chris
> >
>
>
> --
> *CEOS Automatización, C.A.*
> *GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
> *PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*
>
> *FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
> *Ing. César García*
>
> *Cel: +58 414-760.98.95*
>
> *Hotline Técnica SIEMENS: 0800 1005080*
>
> *Email: support.aan.automat...@siemens.com
> *
>


-- 
*CEOS Automatización, C.A.*
*GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
*PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*

*FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
*Ing. César García*

*Cel: +58 414-760.98.95*

*Hotline Técnica SIEMENS: 0800 1005080*

*Email: support.aan.automat...@siemens.com
*


Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741164428

   Ok ... after running it for almost two hours ... there's definitely 
something going on ... not sure if it's because I'm also running the server in 
the same VM ... It's consuming quite a bit more Memory and a lot more CPU time.
   
![image](https://github.com/apache/plc4x/assets/651105/48a2b64c-4148-4e16-940e-bbfdc812307f)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



AW: Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Christofer Dutz
Hi Cesar,

I guess that’s something you have to decide ;-)
If you think it’s usable (doesn’t have to be perfect)
Usually I’d say: “if it’s better than in the 0.10.0 … go for it”.
As it’s completely new … it’s just “go for it” ;-)

Chris


Von: Cesar Garcia 
Datum: Freitag, 29. September 2023 um 18:14
An: dev@plc4x.apache.org 
Betreff: Re: Last call ... get your changes in ... 0.10.0 is coming ...
Hello Chrish,

Is it possible that the Hop integration is part of this release?

I only need the documentation which I could work on this weekend.

Kind regards,

El vie, 29 sept 2023 a las 11:12, Christofer Dutz (<
christofer.d...@c-ware.de>) escribió:

> Scrap that … 0.11.0 is coming ;-)
>
> And I really could use some help by the community to help get the
> Release-Notes in shape … I’m starting to compile a list, but it will not be
> complete.
>
> Chris
>
>
>
> Von: Christofer Dutz 
> Datum: Freitag, 29. September 2023 um 17:09
> An: dev@plc4x.apache.org 
> Betreff: Last call ... get your changes in ... 0.10.0 is coming ...
> Hi all,
>
> so for the last few days I have been testing a lot and fixing a number of
> issues that were reported.
> This was all in preparation for the next release.
>
> In order to have a new release out before CommunityOverCode, I am planning
> on preparing the RC for 0.10.0 on Monday (2nd of October).
>
> So if you want to get some stuff in the next release … hurry up, you’ve
> got this weekend to make it happen.
>
> Chris
>


--
*CEOS Automatización, C.A.*
*GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
*PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*

*FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
*Ing. César García*

*Cel: +58 414-760.98.95*

*Hotline Técnica SIEMENS: 0800 1005080*

*Email: support.aan.automat...@siemens.com
*


Re: Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Cesar Garcia
Hello Chrish,

Is it possible that the Hop integration is part of this release?

I only need the documentation which I could work on this weekend.

Kind regards,

El vie, 29 sept 2023 a las 11:12, Christofer Dutz (<
christofer.d...@c-ware.de>) escribió:

> Scrap that … 0.11.0 is coming ;-)
>
> And I really could use some help by the community to help get the
> Release-Notes in shape … I’m starting to compile a list, but it will not be
> complete.
>
> Chris
>
>
>
> Von: Christofer Dutz 
> Datum: Freitag, 29. September 2023 um 17:09
> An: dev@plc4x.apache.org 
> Betreff: Last call ... get your changes in ... 0.10.0 is coming ...
> Hi all,
>
> so for the last few days I have been testing a lot and fixing a number of
> issues that were reported.
> This was all in preparation for the next release.
>
> In order to have a new release out before CommunityOverCode, I am planning
> on preparing the RC for 0.10.0 on Monday (2nd of October).
>
> So if you want to get some stuff in the next release … hurry up, you’ve
> got this weekend to make it happen.
>
> Chris
>


-- 
*CEOS Automatización, C.A.*
*GALPON SERVICIO INDUSTRIALES Y NAVALES FA, C.A.,*
*PISO 1, OFICINA 2, AV. RAUL LEONI, SECTOR GUAMACHITO,*

*FRENTE A LA ASOCIACION DE GANADEROS,BARCELONA,EDO. ANZOATEGUI*
*Ing. César García*

*Cel: +58 414-760.98.95*

*Hotline Técnica SIEMENS: 0800 1005080*

*Email: support.aan.automat...@siemens.com
*


AW: Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Christofer Dutz
Scrap that … 0.11.0 is coming ;-)

And I really could use some help by the community to help get the Release-Notes 
in shape … I’m starting to compile a list, but it will not be complete.

Chris



Von: Christofer Dutz 
Datum: Freitag, 29. September 2023 um 17:09
An: dev@plc4x.apache.org 
Betreff: Last call ... get your changes in ... 0.10.0 is coming ...
Hi all,

so for the last few days I have been testing a lot and fixing a number of 
issues that were reported.
This was all in preparation for the next release.

In order to have a new release out before CommunityOverCode, I am planning on 
preparing the RC for 0.10.0 on Monday (2nd of October).

So if you want to get some stuff in the next release … hurry up, you’ve got 
this weekend to make it happen.

Chris


Last call ... get your changes in ... 0.10.0 is coming ...

2023-09-29 Thread Christofer Dutz
Hi all,

so for the last few days I have been testing a lot and fixing a number of 
issues that were reported.
This was all in preparation for the next release.

In order to have a new release out before CommunityOverCode, I am planning on 
preparing the RC for 0.10.0 on Monday (2nd of October).

So if you want to get some stuff in the next release … hurry up, you’ve got 
this weekend to make it happen.

Chris



Re: [PR] doc(plc4j): Integrating Kafka and PLC4x using Docker.

2023-09-29 Thread via GitHub


chrisdutz commented on PR #892:
URL: https://github.com/apache/plc4x/pull/892#issuecomment-1741035011

   But digging even deeper ... I noticed the "" image and that sounded 
non-Apache and indeed ... this is proprietary Confluent stuff that's under the 
"(Confluent Enterprise License)". So if this is a requirement for this to work, 
we will not be able to accept this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] doc(plc4j): Integrating Kafka and PLC4x using Docker.

2023-09-29 Thread via GitHub


chrisdutz commented on PR #892:
URL: https://github.com/apache/plc4x/pull/892#issuecomment-1741029631

   Please ignore my last comment ... a quick search on DockerHub showed me that 
there is no official Apache Kafka docker image, but only those provided by 
third-parties.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Pg/security policy

2023-09-29 Thread via GitHub


chrisdutz commented on PR #1007:
URL: https://github.com/apache/plc4x/pull/1007#issuecomment-1741016000

   Hi,
   
   do you need any help with your PR? Would also be awesome, if you could sign 
up to our mailinglist and get a bit more in touch with the rest of the 
community dev@plc4x.apache.org (subscribe by sending an empty email to 
dev-subscr...@plc4x.apache.org).
   
   Chris


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741004332

   
![image](https://github.com/apache/plc4x/assets/651105/fd8f2dfd-ddbd-4d42-a421-63aca367fbe1)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1741001121

   Having seen now that you were using the pre 0.10.0 syntax for creating the 
connection, I think you have stumbled over a problem that we have already 
addresses in 0.10.0-SNAPSHOT ... we're planning on releasing that in the next 
few days. Would be cool, if you could have a look if this is fixed for your 
case too. 
   
   I am currently running an updated version of your program in JProfiler and 
am not seeing any increase in memory usage.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua seems to leak memory

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1101:
URL: https://github.com/apache/plc4x/issues/1101#issuecomment-1740983366

   I'll have a look at this as it seems none else is currently planning on 
doing so ... hopefully this doesn't require too much knowledge of the OPC-UA 
protocol.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-driver-opcua - No subscription events are generated for `addCyclicField(...)` tags

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1102:
URL: https://github.com/apache/plc4x/issues/1102#issuecomment-1740980105

   @hutcheb or @sruehl ... I know you two are involved a bit more in this 
protocol ... can you help here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Nifi integration revision

2023-09-29 Thread via GitHub


chrisdutz commented on PR #1122:
URL: https://github.com/apache/plc4x/pull/1122#issuecomment-1740977990

   By the way ... would be cool, if you could sign up to the dev-list and start 
communicating with us there ;-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Nifi integration revision

2023-09-29 Thread via GitHub


chrisdutz commented on PR #1122:
URL: https://github.com/apache/plc4x/pull/1122#issuecomment-1740971695

   Thanks for this ;-) 
   
   Unfortunately I am probably not the one ideal to review NiFi related things, 
but I would trust you and your changes. So if I don't hear any objections till 
Monday, I'll merge this PR into develop before cutting the release branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature Request]: I encountered some configuration issues when using PLC4X for the first time

2023-09-29 Thread via GitHub


chrisdutz closed issue #1054: [Feature Request]: I encountered some 
configuration issues when using PLC4X for the first time
URL: https://github.com/apache/plc4x/issues/1054


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Feature Request]: I encountered some configuration issues when using PLC4X for the first time

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1054:
URL: https://github.com/apache/plc4x/issues/1054#issuecomment-1740890179

   But I'm also seeing that you are using the latest released version, as we 
refactored the API quite a bit. I have tested your usecase and it's returning 
the right information. We are going to release PLC4X 0.10.0 in a few days, so 
please re-try with that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: Once a connection is established using modbus tcp, it cannot be reconnected once disconnected

2023-09-29 Thread via GitHub


chrisdutz closed issue #1068: [Bug]: Once a connection is established using 
modbus tcp, it cannot be reconnected once disconnected
URL: https://github.com/apache/plc4x/issues/1068


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: Once a connection is established using modbus tcp, it cannot be reconnected once disconnected

2023-09-29 Thread via GitHub


chrisdutz commented on issue #1068:
URL: https://github.com/apache/plc4x/issues/1068#issuecomment-1740885327

   So ... for the sake of being right here, I wrote this little program, and it 
worked as it should ... So I guess you were doing it wrong. But at least you 
can use this example for knowing how it was supposed to be used (However I 
wouldn't reccomend this pattern in general ... wir modbus it's ok, but with 
other drivers such as ADS, this approach would be very imperformant).
   
   ```
   public static void main(String[] args) throws Exception {
   try (PlcConnection plcConnection = 
PlcDriverManager.getDefault().getConnectionManager().getConnection("modbus-tcp://127.0.0.1"))
 {
   PlcReadRequest readRequest = 
plcConnection.readRequestBuilder().addTagAddress("Bool", 
"holding-register:1000:BOOL").build();
   PlcReadResponse readResponse = readRequest.execute().get();
   }
   try (PlcConnection plcConnection = 
PlcDriverManager.getDefault().getConnectionManager().getConnection("modbus-tcp://127.0.0.1"))
 {
   PlcReadRequest readRequest = 
plcConnection.readRequestBuilder().addTagAddress("Bool", 
"holding-register:1000:BOOL").build();
   PlcReadResponse readResponse = readRequest.execute().get();
   }
   }
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: Modbus: Write coil wrong

2023-09-29 Thread via GitHub


chrisdutz closed issue #808: [Bug]: Modbus: Write coil wrong
URL: https://github.com/apache/plc4x/issues/808


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[BUILD-STABLE]: Job 'PLC4X/PLC4X/develop [develop] [1676]'

2023-09-29 Thread Apache Jenkins Server
BUILD-STABLE: Job 'PLC4X/PLC4X/develop [develop] [1676]':

Is back to normal.

Re: [I] plc4j-Write a value to the coil, and the result is INVALID_ ADDRESS

2023-09-29 Thread via GitHub


chrisdutz closed issue #663: plc4j-Write a value to the coil, and the result is 
INVALID_ ADDRESS
URL: https://github.com/apache/plc4x/issues/663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] plc4j-Write a value to the coil, and the result is INVALID_ ADDRESS

2023-09-29 Thread via GitHub


chrisdutz commented on issue #663:
URL: https://github.com/apache/plc4x/issues/663#issuecomment-1740840072

   I have tested that generally writing a bool value works  there were 
issues with writing arrays of bool, but there's another issue for that. I'm 
therefore closing this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[BUILD-FAILURE]: Job 'PLC4X/PLC4X/develop [develop] [1675]'

2023-09-29 Thread Apache Jenkins Server
BUILD-FAILURE: Job 'PLC4X/PLC4X/develop [develop] [1675]':

Check console output at "https://ci-builds.apache.org/job/PLC4X/job/PLC4X/job/develop/1675/;>PLC4X/PLC4X/develop
 [develop] [1675]"

Re: [PR] build(deps): bump org.codehaus.gmavenplus:gmavenplus-plugin from 3.0.0 to 3.0.2

2023-09-29 Thread via GitHub


sruehl merged PR #1121:
URL: https://github.com/apache/plc4x/pull/1121


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] build(deps): bump netty.version from 4.1.98.Final to 4.1.99.Final

2023-09-29 Thread via GitHub


sruehl merged PR #1120:
URL: https://github.com/apache/plc4x/pull/1120


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Nifi integration revision

2023-09-29 Thread via GitHub


QuanticPony opened a new pull request, #1122:
URL: https://github.com/apache/plc4x/pull/1122

   # NiFi integration revision
   As we aim for a new release I bring a revision of the NiFi integration with 
a couple of improvements:
   
   * #900: this made the processors be able to auto-reconnect with small 
changes. And allowed to make:
   * #593 : this was already done for the addresses. But the connection 
string had to be constant. Expression Language is now supported on the 
connection string.
   * #629 : this was an old TODO. I have added validation for the 
connection string (if not EL in use) and to the addresses (if not EL in use in 
neither of them as we need the driver).
   
   * Add FilePropertyAccessStrategy: now we can read the addresses from a file 
in JSON format. Same as 'Address Text' property but in a file. Expression 
Language can be used and validation for the tags also works.
   *  Processors code revision: rewrote the onTrigger methods of the processors 
so they look more similar between them. To make them more maintainable.
   * Complete FlowFlile transfer: some FlowFiles did not transfer to failure 
correctly. Now the incoming FlowFile is sent to failure and one attribute is 
added with the localized message in case of any exception.
   * Timestamp field name: It was a fixed `ts` field/attribute we added. I have 
made a property that defines this field's name. 
   * Update Readme to reflect changes.
   
   Closes #593
   Closes #629 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout

2023-09-29 Thread via GitHub


chrisdutz commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1740598025

   well ... we're planning on cutting the RC for 0.10.0 on monday ... 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [I] [Bug]: plc4j-tools-connection-cache: broken connections remaing in the cache on timeout

2023-09-29 Thread via GitHub


QuanticPony commented on issue #900:
URL: https://github.com/apache/plc4x/issues/900#issuecomment-1740578111

   @chrisdutz Implemented already in our fork. Working pretty well. Will be 
posting a PR soon with the changes needed for the NiFi integration to work 
properly again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org