[GitHub] [plc4x] AndyGrebe commented on pull request #384: Updated java CIP write dataSize to match read dataSize

[GitBox]

AndyGrebe commented on PR #384:
URL: https://github.com/apache/plc4x/pull/384#issuecomment-1161085585

   I'll make sure to fill the ICLA.  I have a feeling we will be working
   together quite a bit.
   
   On Mon, Jun 20, 2022, 8:10 AM Christofer Dutz ***@***.***>
   wrote:
   
   > I think the contribution is small enough to be ok to merge without ...
   > however if you plan on actively contributing more (which I really hope),
   > then it would be cool, if you could file an ICLA as Ben pointed out
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [plc4x] AndyGrebe commented on pull request #384: Updated java CIP write dataSize to match read dataSize

[GitBox]

AndyGrebe commented on PR #384:
URL: https://github.com/apache/plc4x/pull/384#issuecomment-1159770043

   Hi,
   
   Sorry for the late reply.  The path size for writing the structure members
   was the wrong size.  It was fixed on the read side, but not the write.
   
   Thanks,
   Andy
   
   On Sun, Jun 19, 2022, 6:20 AM Christofer Dutz ***@***.***>
   wrote:
   
   > So is this in a mergable state? I think you're probably the best to say
   > anything about this. If it is ... please be so kind an merge it.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > , or
   > unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org