[GitHub] JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked.
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked. URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-426191726 Closing as suggested by sebastian. But I definitly like to adress the topic nonetheless as we heavily depend on user input which can always be errorous. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked.
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked. URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-425737626 Hey @chrisdutz and @sruehl just wanted to bump that up. I think we should decide here on something and either merge or decline the PR. What do you hink about the checked exceptions for wrong user inputs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked.
JulianFeinauer commented on issue #21: Made PlcInvalidFieldException.java checked. URL: https://github.com/apache/incubator-plc4x/pull/21#issuecomment-421942602 Hi @sruehl I think I cannot answer to your question directly, I think. I get your point and in these points you point out it's true that I do not know what the appropriate handling is. I opened a dicussion thread on the list to exchange the arguments and find a common understanding :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
