sruehl commented on issue #10: Fixed NPE in S7PlcConnection#close. URL: https://github.com/apache/incubator-plc4x/pull/10#issuecomment-409959876 one note at this point. As far as I understand netty throws this exception to indicate that it dislikes when the thread gets blocked. By using @chrisdutz or @JulianFeinauer code we might just trick the detection of netty. Im not quite sure but I think this is then more a hack/workaround rather then the intended use of netty. What I found what should come close to the intended behavior ist [this](https://netty.io/4.0/api/io/netty/util/concurrent/SingleThreadEventExecutor.html#addShutdownHook-java.lang.Runnable-). Maybe we should ask on the netty list how it is expected to do such things...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
