Re: [VOTE] Apache PLC4X 0.9.0 RC2
-1 (binding) README.md in the project is wrong. We do not build without JDK 11. 84 ### Environment 85 86 Currently, the project is configured to require the following software: 87 88 1. Java 8 JDK: For running Maven in general as well as compiling the Java and Scala modules `JAVA_HOME` configured to 89 point to that. On Sat, Sep 18, 2021 at 12:15 PM Christofer Dutz wrote: > Apache PLC4X 0.9.0 has been staged under [2] and it's time to vote on > accepting it for release. All Maven artifacts are available under [1]. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 are > required to pass. > > > > Release tag: v0.9.0 > > Hash for the release tag: e9e9a58b057d7df827463f1262ded3a34015666a > > > > Per [3] "Before voting +1 PMC members are required to download the signed > source code package, compile it as provided, and test the resulting > executable on their own platform, along with also verifying that the > package meets the requirements of the ASF policy on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM > items in [4]) [ ] -1 reject (explanation required) > > > > > > [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1038 > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.9.0/rc2 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release > >
Re: [VOTE] Apache PLC4X 0.9.0 RC2
+1 [x] Download all staged artifacts under the url specified in the release vote email. [x] Verify the SHA512 hashes. [x] Unzip the archive. [x] Build the project with empty local repo. Best, Łukasz On 20.09.2021 10:39, Sebastian Rühl wrote: +1 (binding) Sebastian Rühl [x] Download all staged artifacts under the url specified in the release vote email. [x] Verify the signature is correct. [x] Check if the signature references an Apache email address. [x] Verify the SHA512 hashes. [x] Unzip the archive. [x] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [x] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [x] Search for SNAPSHOT references: Only found some in the dummy website copy in the integration-tests [x] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. [x] Build the project according to the information in the README.md file. On 2021/09/18 16:15:34, Christofer Dutz wrote: Apache PLC4X 0.9.0 has been staged under [2] and it's time to vote on accepting it for release. All Maven artifacts are available under [1]. Voting will be open for 72hr. A minimum of 3 binding +1 votes and more binding +1 than binding -1 are required to pass. Release tag: v0.9.0 Hash for the release tag: e9e9a58b057d7df827463f1262ded3a34015666a Per [3] "Before voting +1 PMC members are required to download the signed source code package, compile it as provided, and test the resulting executable on their own platform, along with also verifying that the package meets the requirements of the ASF policy on releases." You can achieve the above by following [4]. [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items in [4]) [ ] -1 reject (explanation required) [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1038 [2] https://dist.apache.org/repos/dist/dev/plc4x/0.9.0/rc2 [3] https://www.apache.org/dev/release.html#approving-a-release [4] https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
Re: [VOTE] Apache PLC4X 0.9.0 RC2
+1 (binding) Sebastian Rühl [x] Download all staged artifacts under the url specified in the release vote email. [x] Verify the signature is correct. [x] Check if the signature references an Apache email address. [x] Verify the SHA512 hashes. [x] Unzip the archive. [x] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [x] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [x] Search for SNAPSHOT references: Only found some in the dummy website copy in the integration-tests [x] Search for Copyright references, and if they are in headers, make sure these files containing them are mentioned in the LICENSE file. [x] Build the project according to the information in the README.md file. On 2021/09/18 16:15:34, Christofer Dutz wrote: > Apache PLC4X 0.9.0 has been staged under [2] and it's time to vote on > accepting it for release. All Maven artifacts are available under [1]. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 are > required to pass. > > > > Release tag: v0.9.0 > > Hash for the release tag: e9e9a58b057d7df827463f1262ded3a34015666a > > > > Per [3] "Before voting +1 PMC members are required to download the signed > source code package, compile it as provided, and test the resulting > executable on their own platform, along with also verifying that the package > meets the requirements of the ASF policy on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM items > in [4]) [ ] -1 reject (explanation required) > > > > > > [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1038 > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.9.0/rc2 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release > >
Re: [VOTE] Apache PLC4X 0.9.0 RC2
Hi +1 (binding) I checked; - signatures and hashes are fine - LICENSE and NOTICE are good - No unexpected binary files - Source files have ASF headers - Can compile from source I also checked the download page links and all good. I think the README ned to be updated re versions of java you need to compile the project. Kind Regards, Justin
RE: [VOTE] Apache PLC4X 0.9.0 RC2
Hi, +1 (non-binding) I did: [OK] Download all staged artifacts under the url specified in the release vote email. [OK] Verify the signature is correct. [OK] Check if the signature references an Apache email address. [OK] Verify the SHA512 hashes. [OK] Verify the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Verify the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. [OK] Search for SNAPSHOT references [OK] Build the project according to the information in the README.md file. Successfully built on Windows 10/WSL 2 (Ubuntu 20.04), OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.8+10) mvnw install Probably this is only a minor issue on my setup, but I had to change the file format of the mvnw file with :set fileformat=unix before the Maven wrapper could be started. Dominik -Original Message- From: Lukas Ott Sent: Saturday, September 18, 2021 6:50 PM To: dev@plc4x.apache.org Subject: Re: [VOTE] Apache PLC4X 0.9.0 RC2 +1 binding Actions performed: Downloaded all staged artifacts under the url specified in the release vote email into a directory we’ll now call download-dir. Verified the signature is correct gpg: Korrekte Signatur von "Christofer Dutz (Apache Comitter) < cd...@apache.org>" Verified the SHA512 hashes Verified the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. Verified the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. Run RAT externally with no surprises (log to be expected): 9 Unknown Licenses * Files with unapproved licenses: apache-plc4x-0.9.0/code-generation/protocol-base-mspec/src/main/antlr4/org/apache/plc4x/plugins/codegenerator/language/mspec/expression/Expression.g4 apache-plc4x-0.9.0/code-generation/protocol-base-mspec/src/remote-resources/UNLICENSE apache-plc4x-0.9.0/licenses/UNLICENSE apache-plc4x-0.9.0/plc4go/go.sum apache-plc4x-0.9.0/plc4j/examples/hello-webapp/client/asconfig.json apache-plc4x-0.9.0/plc4j/integrations/apache-calcite/src/test/resources/model.json apache-plc4x-0.9.0/plc4j/tools/scraper/src/test/resources/config.json apache-plc4x-0.9.0/sandbox/code-gen/src/main/resources/example.json apache-plc4x-0.9.0/sandbox/code-gen/src/main/resources/example2.json * Successfully built with Ubuntu 20.04 mvn -P with-go install openjdk 11.0.11 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04) Am Sa., 18. Sept. 2021 um 18:15 Uhr schrieb Christofer Dutz < christofer.d...@c-ware.de>: > Apache PLC4X 0.9.0 has been staged under [2] and it's time to vote on > accepting it for release. All Maven artifacts are available under [1]. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 > are required to pass. > > > > Release tag: v0.9.0 > > Hash for the release tag: e9e9a58b057d7df827463f1262ded3a34015666a > > > > Per [3] "Before voting +1 PMC members are required to download the > signed source code package, compile it as provided, and test the > resulting executable on their own platform, along with also verifying > that the package meets the requirements of the ASF policy on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the > non-RM items in [4]) [ ] -1 reject (explanation required) > > > > > > [1] > https://repository.apache.org/content/repositories/orgapacheplc4x-1038 > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.9.0/rc2 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+ > Release > >
Re: [VOTE] Apache PLC4X 0.9.0 RC2
+1 binding Actions performed: Downloaded all staged artifacts under the url specified in the release vote email into a directory we’ll now call download-dir. Verified the signature is correct gpg: Korrekte Signatur von "Christofer Dutz (Apache Comitter) < cd...@apache.org>" Verified the SHA512 hashes Verified the existence of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. Verified the content of LICENSE, NOTICE, README, RELEASE_NOTES files in the extracted source bundle. Run RAT externally with no surprises (log to be expected): 9 Unknown Licenses * Files with unapproved licenses: apache-plc4x-0.9.0/code-generation/protocol-base-mspec/src/main/antlr4/org/apache/plc4x/plugins/codegenerator/language/mspec/expression/Expression.g4 apache-plc4x-0.9.0/code-generation/protocol-base-mspec/src/remote-resources/UNLICENSE apache-plc4x-0.9.0/licenses/UNLICENSE apache-plc4x-0.9.0/plc4go/go.sum apache-plc4x-0.9.0/plc4j/examples/hello-webapp/client/asconfig.json apache-plc4x-0.9.0/plc4j/integrations/apache-calcite/src/test/resources/model.json apache-plc4x-0.9.0/plc4j/tools/scraper/src/test/resources/config.json apache-plc4x-0.9.0/sandbox/code-gen/src/main/resources/example.json apache-plc4x-0.9.0/sandbox/code-gen/src/main/resources/example2.json * Successfully built with Ubuntu 20.04 mvn -P with-go install openjdk 11.0.11 2021-04-20 OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04) Am Sa., 18. Sept. 2021 um 18:15 Uhr schrieb Christofer Dutz < christofer.d...@c-ware.de>: > Apache PLC4X 0.9.0 has been staged under [2] and it's time to vote on > accepting it for release. All Maven artifacts are available under [1]. > > Voting will be open for 72hr. > > > > A minimum of 3 binding +1 votes and more binding +1 than binding -1 are > required to pass. > > > > Release tag: v0.9.0 > > Hash for the release tag: e9e9a58b057d7df827463f1262ded3a34015666a > > > > Per [3] "Before voting +1 PMC members are required to download the signed > source code package, compile it as provided, and test the resulting > executable on their own platform, along with also verifying that the > package meets the requirements of the ASF policy on releases." > > > > You can achieve the above by following [4]. > > > > [ ] +1 accept (indicate what you validated - e.g. performed the non-RM > items in [4]) [ ] -1 reject (explanation required) > > > > > > [1] https://repository.apache.org/content/repositories/orgapacheplc4x-1038 > > [2] https://dist.apache.org/repos/dist/dev/plc4x/0.9.0/rc2 > > [3] https://www.apache.org/dev/release.html#approving-a-release > > [4] > https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release > >
