DO NOT REPLY [Bug 46859] New: [Patch] rename org.apache.poi.openxml4j.opc.Package

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46859

   Summary: [Patch] rename org.apache.poi.openxml4j.opc.Package
   Product: POI
   Version: 3.5-dev
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: normal
  Priority: P2
 Component: POI Overall
AssignedTo: dev@poi.apache.org
ReportedBy: j...@gildedtree.com


Since the class java.lang.Package is available without import, failing to
explicitly import org.apache.poi.openxml4j.opc.Package may cause confusing
compiler errors.

As a general rule, POI classes should not have names that clash with any
jdk-public (or other well known) class.

This is a change which would be good to get done before the 3.5-final release.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46859] [Patch] rename org.apache.poi.openxml4j.opc.Package

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46859





--- Comment #1 from Josh Micich j...@gildedtree.com  2009-03-15 23:44:53 PST 
---
Created an attachment (id=23386)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23386)
svn diff

Please consider this patch and give feedback.

In this patch I have created a new base class called OPCPackage.  The
existing Package class has been deprecated and now extends OPCPackage. The rest
of POI code has been changed to use the new non-deprecated class.

The new name 'OPCPackage' is negotiable.  Other names I considered were
'OpenPackage', 'OpenPackageContainer', 'XMLPackage' and 'PackageBase'.

If maintaining binary compatibility with previous poi-ooxml versions is
important, we will need to re-add deprecated versions of many methods which
take OPCPackage as a parameter.  Most of the usage of Package was internal,
however there are some notable public methods/constructors, like
XSSFWorkbook(Package).


An unrelated change was to restrict the class hierarchy of Package to only POI
subclasses (i.e. ZipPackage).  This was done because POI discourages client
classes from inheriting from POI classes.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46859] [Patch] rename org.apache.poi.openxml4j.opc.Package

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46859





--- Comment #2 from Yegor Kozlov ye...@dinom.ru  2009-03-16 04:57:47 PST ---
+1 to this change. 

I agree that name clash with java.lang.* classes is undesirable. However, it's
normal to have collisions with other packages, namely, with java.awt.*.
There are Shape and Polygon objects both in HSLF and AWT and I think that they
can co-exist happily. Even Java itself comes name clashes:
java.awt.Shape vs javax.swing.Shape, java.util.List vs java.awt.List, etc. 

As to binary compatibility, I think it's OK to require users to re-compile
their applications while we are still in a beta phase. I'm very reluctant to
pollute the code with overridden methods for the sake of binary compatibility:
foo(Package pkg) and foo(OPCPackage pkg). 

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46846] After open-save as XLS in MSExcel (2003, 2007) styles are messed up

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46846





--- Comment #4 from Yegor Kozlov ye...@dinom.ru  2009-03-16 08:19:07 PST ---
I confirmed the trouble. For an unknown reason Excel inserts an extra font
record and it shifts the font indexes. I'm not sure if it is a problem of POI
or another weird feature of Excel. Your code looks good and should work just
fine. 

Interestingly, if I create all styles and fonts in advance then everything is
OK and fonts survive across read / write. See a modified version of your
program where copyStyles is called before creating the output. Hope this
workaround helps you.

Regards,
Yegor

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46846] After open-save as XLS in MSExcel (2003, 2007) styles are messed up

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46846





--- Comment #5 from Yegor Kozlov ye...@dinom.ru  2009-03-16 08:20:41 PST ---
Created an attachment (id=23387)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=23387)
a workaround

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46846] After open-save as XLS in MSExcel (2003, 2007) styles are messed up

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46846


Yegor Kozlov ye...@dinom.ru changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||REMIND




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



DO NOT REPLY [Bug 46796] I can not read excel password protected workbook files

2009-03-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46796


Nick Burch n...@torchbox.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Comment #9 from Nick Burch n...@torchbox.com  2009-03-16 10:05:16 PST ---
(In reply to comment #8)
 I just have a reflexive question, no offense, but... Won't Apache POI have 
 this
 feature?

The bulk of the office encryption stuff isn't standard, and isn't documented,
so support it very unlikely to be forthcoming, unless someone volunteers to do
a massive amount of reverse engineering

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[g...@vmgump]: Project poi (in module poi) failed

2009-03-16 Thread Gump [HEAD] :-(
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project poi has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Timed Out'.
For reference only, the following projects are affected by this:
- poi :  POI


Full details are available at:
http://vmgump.apache.org/gump/public/poi/poi/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Output [poi-ooxml-gump-16032009.jar] identifier set to output 
basename: [poi-ooxml-gump]
 -DEBUG- Output [poi-contrib-gump-16032009.jar] identifier set to output 
basename: [poi-contrib-gump]
 -DEBUG- Output [poi-scratchpad-gump-16032009.jar] identifier set to output 
basename: [poi-scratchpad-gump]
 -DEBUG- Output [poi-gump-16032009.jar] identifier set to output basename: 
[poi-gump]
 -INFO- Failed with reason build timed out
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/poi/poi/gump_work/build_poi_poi.html
Work Name: build_poi_poi (Type: Build)
Work ended in a state of : Failed
Elapsed: 60 mins
Command Line: /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true 
-Xbootclasspath/p:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-xalan/build/serializer.jar:/srv/gump/public/workspace/xml-xalan/build/xalan-unbundled.jar
 org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbuild.sysclasspath=only -Dversion.id=gump -DDSTAMP=16032009 -f build.xml gump 
[Working Directory: /srv/gump/public/workspace/poi]
CLASSPATH: 
/usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/poi/ooxml-lib/xmlbeans-2.3.0.jar:/srv/gump/public/workspace/poi/ooxml-lib/jsr173_1.0_api.jar:/srv/gump/public/workspace/poi/ooxml-lib/ooxml-schemas-1.0.jar:/srv/gump/public/workspace/poi/ooxml-lib/openxml4j-1.0-beta.jar:/srv/gump/public/workspace/poi/build/classes:/srv/gump/public/workspace/poi/build/contrib-classes:/srv/gump/public/workspace/poi/build/scratchpad-classes:/srv/gump/public/workspace/poi/build/ooxml-classes:/srv/gump/public/workspace/poi/build/test-classes:/srv/gump/public/workspace/poi/build/scratchpad-test-classes:/srv/gump/public/workspace/poi/build/ooxml-test-classes:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/l
 
ib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/logging-log4j-12/dist/lib/log4j-16032009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-16032009.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-16032009.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-16032009.jar:/srv/gump/public/workspace/apache-commons/collections/build/commons-collections-16032009.jar:/srv/gump/public/workspace/apache-commons/lang/target/commons-lang-3.0-SNAPSHOT.jar:/srv/gump/public/workspace/junit/dist/junit-16032009.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/dom4j/build/dom4j.jar
-
Buildfile: /srv/gump/public/workspace/poi/build.xml

check-jars:

fetch-jars:

testexist:

downloadfile:
  [get] Getting: 
http://www.ibiblio.org/maven/commons-logging/jars/commons-logging-1.1.jar
  [get] To: /srv/gump/public/workspace/poi/lib/commons-logging-1.1.jar

testexist:

downloadfile:
  [get] Getting: http://www.ibiblio.org/maven/log4j/jars/log4j-1.2.13.jar
  [get] To: /srv/gump/public/workspace/poi/lib/log4j-1.2.13.jar

testexist:

downloadfile:
  [get] Getting: http://www.ibiblio.org/maven/junit/jars/junit-3.8.1.jar
  [get] To: /srv/gump/public/workspace/poi/lib/junit-3.8.1.jar
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump.apache.org/gump/public/poi/poi/rss.xml
- Atom: http://vmgump.apache.org/gump/public/poi/poi/atom.xml

== Gump Tracking Only ===
Produced by Gump version 2.3.
Gump Run 15000816032009, vmgump:vmgump-public:15000816032009
Gump E-mail Identifier (unique within run) #1.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump]