[Bug 54392] HSSFWorkbook initialization fail, with RuntimeException during creation of HSSFSheet, caused by an unknown excel format

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54392

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |LATER

--- Comment #4 from Nick Burch apa...@gagravarr.org ---
I've just tried the attached file with 3.10 Final, and it opens without error

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 54443] ClassCastException in HSSFOptimiser

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54443

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #9 from Nick Burch apa...@gagravarr.org ---
Thanks for the test case and suggested fix, should now be working as of
r1613175.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 54838] StringBuffer could be replaced by StringBuilder for performance

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54838

--- Comment #5 from Nick Burch apa...@gagravarr.org ---
In r1613186, I've updated the Vector uses that are clearly fine to ArrayList

Where a StringBuilder is used within a method, then toString'd at the end and
discarded, I can't see why those can't be quickly and easily updated. Where the
StringBuffer is persisted beyond one method in any way, or passed outside the
method, then someone would need to think a little bit.

Does someone fancy updating the StringBuffer instances where are self contained
(eg used in toString() methods)? We can then review what's left, which'll
hopefully be a much smaller list

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 54954] [FEATURE REQUEST] The 'names' ArrayList in HSSFWorkbook should be public

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54954

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #2 from Nick Burch apa...@gagravarr.org ---
Without a strong use case why, this won't be exposed given that a delete case
would still need to update records / formulas / etc

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 54634] [PATCH] End index for bookmarks are incorrect when bookmarks overlap

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54634

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

   Keywords||PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56132] [PATCH] support ignore missing workbook references in XSSF

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56132

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #3 from Nick Burch apa...@gagravarr.org ---
There is now some XSSF Formula support for external references in trunk

Any chance you could review that, then either make some changes to your patch
if needed, or comment that no further changes are needed if the patch is fine
as-is?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 55562] [PATCH] Patch with example for creating a table

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55562

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 OS||All

--- Comment #1 from Nick Burch apa...@gagravarr.org ---
Thanks for this, example added in r1613191.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56683] SXSSF generated corrupted report in z/OS on applying cell Style

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56683

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nick Burch apa...@gagravarr.org ---
Default of UTF-8 set in r1613193.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56735] [PATCH] Use custom temporary file directory in SXSSF

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56735

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Nick Burch apa...@gagravarr.org ---
Thanks for this, patch applied in r1613246.

If you could review and close the GitHub pull request, that'd be great!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56757] [PATCH] Possible symlink race condition vulnerability when creating temp files

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56757

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 OS||All

--- Comment #1 from Nick Burch apa...@gagravarr.org ---
I believe that the patch for this was rolled into GitHub Pull #10, which was
applied in r1613246, so closing this one too, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56194] [PATCH] Retrieve properly Clipbard format tag for thumbnail

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56194

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nick Burch apa...@gagravarr.org ---
Thanks for the patch and file, applied (with minor tweaks) in r1613256.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[GitHub] poi pull request: Improvements to temporary file handling

2014-07-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/poi/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 56023] [PATCH] Include cell comments in XSSFEventBasedExcelExtractor output

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56023

--- Comment #9 from Nick Burch apa...@gagravarr.org ---
Applied (with some changes) in r1613266.

I'm a little worried about backwards compatibility though - anyone who
currently implements SheetContentsHandler will suddenly find their code won't
compile / run on 3.11

What do you think about us adding a second interface for people who want
comments, to maintain backwards compatibility? 

(We need to decide ASAP, before 3.11 beta 1 gets released)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Jenkins build is back to normal : POI-JDK8 #100

2014-07-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/POI-JDK8/100/changes


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 55906] [PATCH] Correctly evaluate/parse multisheet reference for XLS documents

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55906

Nick Burch apa...@gagravarr.org changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #4 from Nick Burch apa...@gagravarr.org ---
I've done some work on this today, cherrypicking bits out of this patch, and
doing some fairly liberal refactoring of the formula code too. (Now we have
external name / sheet support in the XSSF formula parser, it's much clearer
which bits of the hssf external sheet support can be refactored and which ones
matter). It's quite a lot of work, but without this patch it's more than I'd
have considered even starting!

As of r1613317, POI can now correctly read and render a multi-sheet formula
string from a cell, i.e. cell.getCellFormula() now returns the right thing. If
you ask FormulaParser to parse a multi-sheet reference, it no longer objects,
and returns useful ptgs, but it doesn't yet do enough to support a
round-tripping of a formula

Next step - get the round-tripping working, so that the last part of
TestFormulaParser.testMultiSheetReference() can be enabled

Future step - evaluator support

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Build failed in Jenkins: POI #368

2014-07-24 Thread Apache Jenkins Server
See https://builds.apache.org/job/POI/368/changes

Changes:

[nick] More progress towards #55906 - FormulaParser is able to identify and 
parse multi-sheet references, but not yet fully round-trip them. (No evaluation 
support yet either)

--
[...truncated 1946 lines...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.06 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFGroupShape
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.212 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFHyperlink
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.119 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFPictureShape
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.504 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFShape
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.102 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFShapeContainer
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.048 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFSheet
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.125 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFSimpleShape
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.267 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFSlide
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.726 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFSlideShow
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.425 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTable
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.166 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTableStyles
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.048 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTextBox
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.082 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTextParagraph
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.181 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTextRun
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.043 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTextShape
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.251 sec
[junit] Running org.apache.poi.xslf.usermodel.TestXSLFTheme
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.595 sec
[junit] Running org.apache.poi.xssf.TestSheetProtection
[junit] Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.193 sec
[junit] Running org.apache.poi.xssf.TestWorkbookProtection
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.219 sec
[junit] Running 
org.apache.poi.xssf.eventusermodel.TestReadOnlySharedStringsTable
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.013 sec
[junit] Running org.apache.poi.xssf.eventusermodel.TestXSSFReader
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.124 sec
[junit] Running 
org.apache.poi.xssf.extractor.TestXSSFEventBasedExcelExtractor
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.554 sec
[junit] Running 
org.apache.poi.xssf.extractor.TestXSSFEventBasedExcelExtractorUsingFactory
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.396 sec
[junit] Running org.apache.poi.xssf.extractor.TestXSSFExcelExtractor
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.026 sec
[junit] Running 
org.apache.poi.xssf.extractor.TestXSSFExcelExtractorUsingFactory
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.722 sec
[junit] Running org.apache.poi.xssf.extractor.TestXSSFExportToXML
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.527 sec
[junit] Running org.apache.poi.xssf.extractor.TestXSSFImportFromXML
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.378 sec
[junit] Running org.apache.poi.xssf.io.TestLoadSaveXSSF
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.069 sec
[junit] Running org.apache.poi.xssf.model.TestCalculationChain
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.731 sec
[junit] Running org.apache.poi.xssf.model.TestCommentsTable
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.318 sec
[junit] Running 

[Bug 56702] Get one exception java.lang.IllegalStateException: Cannot get a numeric value from a text cell when calling org.apache.poi.ss.usermodel.DataFormatter.formatCellValue

2014-07-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56702

--- Comment #9 from sangshenghong 278880...@qq.com ---
Hi Nick:
Could you tell me which version I can use?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org