[Bug 60713] SXSSFWorkbook.write(OutputStream) close OutputStream

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

--- Comment #5 from Dominik Stadler  ---
I agree, it sounds like a theoretical issue and changing this very likely would
have bad side-effects for existing users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60047] XSSFDrawing.getShapes() changes Anchor type.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60047

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Javen O'Neal  ---
Would you be willing to write a unit test and patch for this? Seems like you're
fairly familiar with the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60355] SS Formula Parser fails to parse a formula with a free ref function

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60355

Javen O'Neal  changed:

   What|Removed |Added

   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 59919] RuntimeException: Unexpected record type (org.apache.poi.hssf.record.HyperlinkRecord)

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59919

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME
   Severity|blocker |normal

--- Comment #11 from Javen O'Neal  ---
Closing as WORKSFORME. Please reopen if you can show that POI incorrectly
raises an exception on a valid workbook.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 57296] ZipInputStreamZipEntrySource.java:61 should catch IOExceptions on "close" after successfully reading

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57296

--- Comment #11 from Javen O'Neal  ---
(In reply to Javen O'Neal from comment #10)
> Potentially fixed by bug 60128 in POI 3.15.

Torsten, can you verify this (3 years later)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60282] getFontHeightInPoints() has wrong type

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60282

--- Comment #1 from Javen O'Neal  ---
Unfortunately, changing the return type of this method would break backwards
compatibility.

If you need the accuracy of fractional points, perform this computation
yourself using getFontHeight.

We could add a warning in the JavaDoc that fractional values are discarded.
We could also make the 20 constant a public constant in Font.
Otherwise we could try to change the return type through some slow deprecation
process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60355] SS Formula Parser fails to parse a formula with a free ref function

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60355

Javen O'Neal  changed:

   What|Removed |Added

Summary|SS Formula Parser fails to  |SS Formula Parser fails to
   |parse valid formula string  |parse a formula with a free
   ||ref function

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60325] Poor performance in DirectoryNode.createDocument() for NPOIFSFileSystem

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60325

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Javen O'Neal  ---
Do you have any suggestions on how to improve the NPOIFSFileSystem
implementation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60713] SXSSFWorkbook.write(OutputStream) close OutputStream

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #4 from Javen O'Neal  ---
ddchzyj99, what kind of OutputStream are you using that has problems being
closed twice?

I think we may want to err on the side of no change unless someone has a
nonhypothetical scenario where this impacts them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60713] SXSSFWorkbook.write(OutputStream) close OutputStream

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

--- Comment #3 from Javen O'Neal  ---
There should only be a problem if the OutputStream's close method follows the
AutoCloseable interface and is not idempotent, where subsequent calls to close
have visible side effects.

At the creation of these classes and prior to Java 7, OutputStream implemented
the Closeable interface, which requires subsequent calls to close to have no
effect.

We must balance that with users forgetting to close their own input streams and
leaking resources (though that's on them). If we change POI to no longer close
user-opened OutputStreams, we should document this changed behavior in both the
Javadocs and changelog, making sure to update all of our POI example code and
website to close the provided stream (that'd be a good idea anyways).

https://docs.oracle.com/javase/7/docs/api/java/io/OutputStream.html#close()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #6 from Javen O'Neal  ---
(In reply to zakim from comment #4)
> Created attachment 34759 [details]
> patched XSSFEventBasedExcelExtractor
> 
> The missing file patched.
Please submit patches generated by "svn diff", "git-svn diff" or "ant -f
patch.xml" [1]
Entire files are difficult to review and commit because other changes may be
made to that file after you attached it.

Additionally, I am unclear how this contribution will help POI. Adding a method
that does nothing may be a source of confusion for people reading or
maintaining the code. If your intent is to have POI define a method that you
plan on overriding in your own code, how do you plan on using that? Could
someone else override this inner class without modifying POI source code?
If so, perhaps this change is worthy of example code or documentation so that
others know how to override endSheet().

[1] https://poi.apache.org/guidelines.html#Submitting+Patches

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60528] Duplicate PageSettingsBlock Record

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60528

Javen O'Neal  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEEDINFO|RESOLVED

--- Comment #9 from Javen O'Neal  ---
Closing as WORKSFORME. Please reopen with supporting code if you are still
facing this issue with the latest code (trunk).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60528] Duplicate PageSettingsBlock Record

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60528

Javen O'Neal  changed:

   What|Removed |Added

   Severity|blocker |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60518] HSSFCell.Type can not recognize the right type

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60518

Javen O'Neal  changed:

   What|Removed |Added

   Severity|critical|normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60518] HSSFCell.Type can not recognize the right type

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60518

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Javen O'Neal  ---
Closing since no response for several months. Please reopen with necessary
information to reproduce the problem if you are still experiencing an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

zakim  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #5 from zakim  ---
Attached the missing file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

--- Comment #4 from zakim  ---
Created attachment 34759
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34759=edit
patched XSSFEventBasedExcelExtractor

The missing file patched.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60601] Hyperlinks in original worksheet are not removed if there are no more hyperlinks on write.

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60601

--- Comment #8 from Joachim Piketz  ---
We have replaces WF 9 with WF 10 meanwhile and can't reproduce the exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

--- Comment #3 from Javen O'Neal  ---
(In reply to Javen O'Neal from comment #2)
> The title of this bug comment 0
correction: The title of this bug and comment 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Javen O'Neal  changed:

   What|Removed |Added

 OS||All
 Status|NEW |NEEDINFO

--- Comment #2 from Javen O'Neal  ---
src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java
does not compile with the patch from comment 1.
The following error is given:
XSSFEventBasedExcelExtractor.SheetTextExtractor is not abstract and does not
override abstract method endSheet() in SheetContentsHandler

Could you submit a tested patch that hopefully also includes an update to the
documentation, a poi-examples file, or a unit test so that we understand how
endSheet() is used and what it's supposed to do? The title of this bug comment
0 is a bit vague on the need to have this new feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

--- Comment #1 from Javen O'Neal  ---
Created attachment 34758
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34758=edit
The patch described by comment 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org

[Bug 60737] New: XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Bug ID: 60737
   Summary: XSSFSheetXMLHandler class's inside interface
SheetContentsHandler should have an endSheet method
   Product: POI
   Version: 3.15-FINAL
  Hardware: PC
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: XSSF
  Assignee: dev@poi.apache.org
  Reporter: zakim2...@yahoo.com
  Target Milestone: ---

interface SheetContentsHandler inside XSSFSheetXMLHandler class should have an
endSheet method, which should be called from the :

public void endElement(String uri, String localName, String qName)
throws SAXException {

method's "switch" modified as follows:
...
 } else if ("sheetData".equals(localName)) {
// Handle any "missing" cells which had comments attached
   
checkForEmptyCellComments(EmptyCellCommentsCheckType.END_OF_SHEET_DATA);
output.endSheet();
}
...

This is is useful when the sheet finished processing, and you need to do
something with the sheet data yet available.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org