[Bug 60662] Slide import delete unrecognized elements in group shape

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60662

Andreas Beeker  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Andreas Beeker  ---
Patched via r1783486

Thanks for the example files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



RE: [Bug 60741] NPOIFS move from read-only flag to 3-state enum

2017-02-17 Thread Murphy, Mark
+1

-Original Message-
From: bugzi...@apache.org [mailto:bugzi...@apache.org] 
Sent: Friday, February 17, 2017 12:43 PM
To: dev@poi.apache.org
Subject: [Bug 60741] NPOIFS move from read-only flag to 3-state enum

https://bz.apache.org/bugzilla/show_bug.cgi?id=60741

--- Comment #2 from Greg Woolsey  --- (In reply to Nick 
Burch from comment #1)
> Help needed with naming the enum and the enum values...

Perhaps

public enum WriteState {
READ_ONLY,
IN_PLACE,
BUFFERED,
;
}

with appropriate JavaDocs indicating restrictions, performance implications, 
and example use cases.  The Enum and API method JavaDocs would note that this 
only applies to paths that read from files, not streams.

--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org For additional commands, 
e-mail: dev-h...@poi.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60741] NPOIFS move from read-only flag to 3-state enum

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60741

--- Comment #2 from Greg Woolsey  ---
(In reply to Nick Burch from comment #1)
> Help needed with naming the enum and the enum values...

Perhaps

public enum WriteState {
READ_ONLY,
IN_PLACE,
BUFFERED,
;
}

with appropriate JavaDocs indicating restrictions, performance implications,
and example use cases.  The Enum and API method JavaDocs would note that this
only applies to paths that read from files, not streams.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60713] SXSSFWorkbook.write(OutputStream) close OutputStream

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

--- Comment #7 from Greg Woolsey  ---
I'm also in favor of a helper method, to avoid a dramatic change to the API. 
Big breaks in backward compatibility mean longer delays before downstream
projects taken an update, and often I want newer functionality available to my
projects that use those downstream projects sooner rather than later. 
Maintaining backward compatibility speeds that up, or lets me update POI
independent of other libraries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Jenkins build is back to normal : POI-DSL-1.6 #184

2017-02-17 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60742] [PATCH] Build fail on Windows due to Linux-style path in unit test

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60742

Dominik Stadler  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Dominik Stadler  ---
I remove this in r1783428 as it just was leftover local test code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60742] [PATCH] Build fail on Windows due to Linux-style path in unit test

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60742

Javen O'Neal  changed:

   What|Removed |Added

Summary|Build fail on Windows   |[PATCH] Build fail on
   |(resolution patch)  |Windows due to Linux-style
   ||path in unit test

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



tika-eval

2017-02-17 Thread Allison, Timothy B.
All,

  I finally got around to adding tika-eval[1] to Apache Tika.  If you have any 
interest in comparing the output of different tools/versions/parameters on text 
extraction, give it a try.  You don't need to use Tika or format the output in 
a specific format; plain UTF-8 text will work.

  Tilman, I generalized your common word count methodology.  The code now runs 
language id on the text and then counts the common words for that language.

  Lots more work remains.  Thank you, all, for contributing to the 
methodologies!

 Cheers,

  Tim


[1] https://wiki.apache.org/tika/TikaEval


[Bug 60742] Build fail on Windows (resolution patch)

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60742

Javen O'Neal  changed:

   What|Removed |Added

 Depends on||60512
 Status|NEW |NEEDINFO

--- Comment #1 from Javen O'Neal  ---
Thanks! Fixed in r1783426.

I'm wondering if we need to call both writeOutAndReadBack and write. If this
test is testing what happens if the same workbook is written out twice, then we
could accomplish that with two writeOutAndReadBack (to ByteArrayOutputStreams
instead of FileOutputStreams, which are faster) or write out to a
NullOutputStream if we don't care about the output.

Dominik, any ideas?


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60512
[Bug 60512] Missing XSSFRelation.CUSTOM_PROPERTY generates POIXMLException on
cloneSheet() method
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60512] Missing XSSFRelation.CUSTOM_PROPERTY generates POIXMLException on cloneSheet() method

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60512

Javen O'Neal  changed:

   What|Removed |Added

 Blocks||60742


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60742
[Bug 60742] Build fail on Windows (resolution patch)
-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60742] Build fail on Windows (resolution patch)

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60742

Chiara Marcheschi  changed:

   What|Removed |Added

   Keywords||PatchAvailable
 CC||chiaramarches...@tagetik.co
   ||m
 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60742] New: Build fail on Windows (resolution patch)

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60742

Bug ID: 60742
   Summary: Build fail on Windows (resolution patch)
   Product: POI
   Version: 3.16-dev
  Hardware: PC
Status: NEW
  Severity: major
  Priority: P2
 Component: POI Overall
  Assignee: dev@poi.apache.org
  Reporter: chiaramarches...@tagetik.com
  Target Milestone: ---

Created attachment 34763
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34763&action=edit
Patch

The TestXSSFCloneSheet contains a "unix style" path to reference "60512.xlsm".
The ant compilation fails with:
"java.io.FileNotFoundException: \tmp\60512.xlsx (The system cannot find the
path specified)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60741] NPOIFS move from read-only flag to 3-state enum

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60741

--- Comment #1 from Nick Burch  ---
Help needed with naming the enum and the enum values...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60741] New: NPOIFS move from read-only flag to 3-state enum

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60741

Bug ID: 60741
   Summary: NPOIFS move from read-only flag to 3-state enum
   Product: POI
   Version: 3.16-dev
  Hardware: PC
OS: All
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: POIFS
  Assignee: dev@poi.apache.org
  Reporter: apa...@gagravarr.org
  Target Milestone: ---

Currently, in NPOIFS (NPOIFSFileSystem + POIFSFileSystem, but not
OPOIFSFileSystem), you can either load from a File or from a Stream. With a
Stream, everything gets buffered into memory

When loading from a File, you can load read-write or read-only. In
read-write mode, we use NIO to mmap the file so we can quickly + low memory
read + write.

The other case, File + read-only, isn't so ideal. We need to support both
people doing true read-only cases, eg reading or text extraction, plus
people doing read-template + write or read-change-save-as cases. To support
that, we buffer into memory.

Instead, if we changed the read-write state to an enum with 3 states, we could
have:
 * Read/Write - unchanged
 * Read Only - mmap in read-only mode, text extraction etc only
 * Read as Template - mmap in private mode, changes buffered in memory, able to
write out to a new file

That'd mean lower memory use, and more consistent code.

Naming TBC

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 57296] ZipInputStreamZipEntrySource.java:61 should catch IOExceptions on "close" after successfully reading

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57296

--- Comment #12 from Torsten Krah  ---
POI is still closing the InputStream it did not create instead of just reading
from it - so this is still a valid concern if close throws an exception but
data needed could be successfully read.
The original case was fixed later in the JDK and at least my root case - the
javax.crypto.BadPaddingException on close - is not thrown anymore - but the
case itself here to not close the stream it did not create, e.g. like lucene
does not close them and mentions that on the api docs:

https://lucene.apache.org/core/4_9_0/analyzers-common/org/apache/lucene/analysis/hunspell/Dictionary.html

Discussable though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



Build failed in Jenkins: POI-DSL-1.6 #183

2017-02-17 Thread Apache Jenkins Server
See 

Changes:

[nick] Need to use  rather than , and reflow

--
[...truncated 4036 lines...]
[junit] Reading spreadsheet/TwoSheetsNoneHidden.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/TwoSheetsNoneHidden.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/TwoSheetsOneHidden.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/TwoSheetsOneHidden.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/TwoSheetsOneHidden.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/UncalcedRecord.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/UnionPtg.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WORKBOOK_in_capitals.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WeekNumFunctionTestCaseData.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WeekNumFunctionTestCaseData2013.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithChart.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithChart.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithChart.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithChartSheet.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithChartSheet.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithCheckBoxes.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithConditionalFormatting.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithConditionalFormatting.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithConditionalFormatting.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithDrawing.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithDrawing.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithEmbeddedObjects.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithEmbeded.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithEmbeded.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithExtendedStyles.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithFormattedGraphTitle.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithHyperlink.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithMoreVariousData.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithMoreVariousData.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithTable.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithTable.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithTextBox.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithTextBox.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithTextBox2.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithTextBox2.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithThreeCharts.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithThreeCharts.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithThreeCharts.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithTwoCharts.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithTwoCharts.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithTwoCharts.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WithTwoHyperLinks.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/WithVariousData.xlsx with class 
org.apache.poi.stress.XSSFFileHandler
[junit] Reading spreadsheet/WithVariousData.xlsx with class 
org.apache.poi.stress.OPCFileHandler
[junit] Reading spreadsheet/WrongFormulaRecordType.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/XRefCalc.xls with class 
org.apache.poi.stress.HSSFFileHandler
[junit] Reading spreadsheet/XRefCalcData.xls with class 
org.apache.poi.st

[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

zakim  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #9 from zakim  ---
Never mind, forget about it.
It's not the BigGridDemo, I've never seen that demo.

You can simply press the Diff button near the Attachment on the bugzilla site
and you can see the difference. I was referring to the officially relase in the
maven repo.
If you release another version with 3.15.Final name, then you have a big
problem and the diff won't help either, because your versions will be messed
up.
If I knew that a suggestion is so hard to accomplish, I would never start this.
This is a feature request I've asked for, not a bug.
I've encountered this, when I was overwriting the following interface:
XSSFSheetXMLHandler.SheetContentsHandler. I was saving the rows read from the
xlsx file by group(1 save from multiple rows) and needed to save the last group
at the end of the sheet without passing the data outside the overridden
interface.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60713] SXSSFWorkbook.write(OutputStream) close OutputStream

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60713

--- Comment #6 from Nick Burch  ---
We already have a helper method on NPOIFS for people who don't want the
auto-close behaviour when opening from an InputStream -
https://poi.apache.org/apidocs/org/apache/poi/poifs/filesystem/NPOIFSFileSystem.html#createNonClosingInputStream(java.io.InputStream)

Maybe we could add a similar one for OutputStream, to help people wrap their
problematic ones if needed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Javen O'Neal  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

Javen O'Neal  changed:

   What|Removed |Added

  Attachment #34759|0   |1
is obsolete||

--- Comment #8 from Javen O'Neal  ---
Created attachment 34762
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34762&action=edit
The patch corresponding to attachment 34759 against the code from 3.15-final

(In reply to zakim from comment #7)
> The file shows the changes added to the existing file, compared to poi 
> version > 3.15-FINAL as stated in the version field.
The version field is sometimes updated when an unfixed bug is still present in
a later build, so it's better to explicitly state in a comment what the base
rev for a file is. Even better is to submit a patch, which includes the rev if
the patch was generated by Subversion.
It's probably a good idea to check out trunk anyways so that you can open the
project in Eclipse or other IDE, make your changes, and know immediately
whether there are compile-time errors with your changes.

> I haven't checked out the entire project to send only the differences.
You can perform a sparse svn checkout of POI if you don't want to wait the 10
minutes it takes to check out the trunk or one of the release tags. You could
also save the original file and modified file and use any diffing program to
generate a patch file (Linux/Mac: diff, Windows: TortoiseSVN, TortoiseGit)

> It was only a suggestion to make poi more usable which means in my opinion: 
> a more usable framework should be easy to use, with less coding.
> If you need to write ten classes using the poi framework then you better
> write the whole function without using poi.
This is the part that I am confused about. How does the addition of an empty
endSheet() method make it easier for someone to use POI? Did I correctly
receive your patch file? Was there really only an addition of 3 lines?

The only other references I see to endSheet within the POI source code and
website is in BigGridDemo. Is this the inspiration for this bug?

I am genuinely interested in trying to make POI easier for people to use, but
I'm not convinced that the contributions so far accomplish that. Am I missing
some other files that have some useful behavior when the endSheet() event is
reached?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

--- Comment #7 from Javen O'Neal  ---
(unrelated changes) close leaked resources in r1783362

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

Javen O'Neal  changed:

   What|Removed |Added

  Attachment #34760|0   |1
is obsolete||

--- Comment #6 from Javen O'Neal  ---
Created attachment 34761
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34761&action=edit
patch with all of the unrelated code removed

Less than half the size of the original. Hopefully this makes it easier to
review, though it still needs to be rebased to trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 60737] XSSFSheetXMLHandler class's inside interface SheetContentsHandler should have an endSheet method

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60737

zakim  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #7 from zakim  ---
The file shows the changes added to the existing file, compared to poi version
3.15-FINAL as stated in the version field.
I havent checked out the entire project to send only the differences.
It was only a suggestion to make poi more usable which means in my opinion: 
a more usable framework should be easy to use, with less coding.
If you need to write ten classes using the poi framework then you better write
the whole function without using poi.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

--- Comment #5 from Javen O'Neal  ---
r1783356

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

--- Comment #4 from Javen O'Neal  ---
ChunkedCipherInputStream.read needs attention. Changed from checking the return
value of reading from the underlying stream from 1 to -1.

I have temporarily reverted this to restore the original behavior in 1783356.
This should probably have been put back into the patch that excludes the
unrelated stuff, since this behavior is related to the available() changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

Javen O'Neal  changed:

   What|Removed |Added

  Attachment #34068|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org



[Bug 59893] Forbid calls to InputStream.available

2017-02-17 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59893

--- Comment #3 from Javen O'Neal  ---
Created attachment 34760
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34760&action=edit
patch with some of the unrelated code removed

I committed some of Andi's unrelated changes from attachment 34068 in r1783347
and r1783353.

Some of the line numbers may be off since I deleted unrelated changes from the
patch by directly editing the text file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@poi.apache.org
For additional commands, e-mail: dev-h...@poi.apache.org